Re: [PATCH 0/9] Support blending modes of display planes

Matt Roper
2016-01-22T00:31:41Z

On Mon, Jan 18, 2016 at 08:45:34PM +0530, Vandita Kulkarni wrote:
> From: vandita kulkarni <vandita.kulkarni@intel.com>
>
> The below patches support plane and pixel blending
> by adding two properties blend_func and blend_color.
> As per Damien's initial patches, this design based on
> OpenGL's blend equations is suggested by Ville.
> All the below patches are tested on BXT android platform.
>
> The initial kernel patches from damien can be found at
> https://github.com/dlespiau/linux/commits/20150708-alpha-blending
> Damien Lespiau (5):
> drm: Introduce the blend-func property
> drm/i915/skl: Add blend_func to SKL/BXT sprite planes
> drm: Introduce DRM_MODE_COLOR()
> drm: Add an blend_color property
> drm/i915/skl: Add support for blending modes
>
> vandita kulkarni (4):
> drm/i915/skl: Drop alpha in non ARGB formats
> drm/i915: Support blend func on primary
> drm/i915/skl: Support blend color on primary
> drm/i915/skl: Separate out disable plane alpha

This series looks pretty good; I've given some feedback on a few of the
patches, but it's all pretty minor. And some of the feedback I gave
wound up being addressed in later patches in the series anyway; I think
you can probably squash patches 6-9 into the earlier patches to simplify
a bit.

One of the requirements to merge new features upstream is to have an
opensource userspace that makes use of it. It sounds like you're doing
this work for Android purposes, so is the plan to add support for these
properties to hwcomposer?

Matt

>
>
> The initial version of kms_blend, igt by Damien
> can be found at
> https://github.com/dlespiau/intel-gpu-tools/commits/20150613-blend
>
> Documentation/DocBook/gpu.tmpl | 18 +++-
> drivers/gpu/drm/drm_atomic.c | 18 ++++
> drivers/gpu/drm/drm_crtc.c | 10 +++
> drivers/gpu/drm/i915/i915_reg.h | 4 +
> drivers/gpu/drm/i915/intel_display.c | 164 +++++++++++++++++++++++++++++++++--
> drivers/gpu/drm/i915/intel_drv.h | 12 ++-
> drivers/gpu/drm/i915/intel_sprite.c | 17 ++--
> include/drm/drm_crtc.h | 26 ++++++
> include/uapi/drm/drm_mode.h | 34 ++++++++
> 9 files changed, 286 insertions(+), 17 deletions(-)
>
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795