From: Daniel Vetter <daniel@ffwll.ch>
To: Andreas Ziegler <andreas.ziegler@fau.de>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/i915: Remove select to deleted STOP_MACHINE from Kconfig
Date: Mon, 25 Jan 2016 16:38:19 +0100 [thread overview]
Message-ID: <20160125153819.GL11240@phenom.ffwll.local> (raw)
In-Reply-To: <1453722079-2604-1-git-send-email-andreas.ziegler@fau.de>
On Mon, Jan 25, 2016 at 12:41:19PM +0100, Andreas Ziegler wrote:
> Commit 5bab6f60cb4d ("drm/i915: Serialise updates to GGTT with access
> through GGTT on Braswell") depended upon a working stop_machine() and
> so forced the selection of STOP_MACHINE. However, commit 86fffe4a61dd
> ("kernel: remove stop_machine() Kconfig dependency") removed the option
> STOP_MACHINE from init/Kconfig and ensured that stop_machine()
> universally works. Due to the order in which the patches were applied,
> removing the select from DRM_I915 got lost during merging.
>
> Remove the now obsolete select statement.
>
> Signed-off-by: Andreas Ziegler <andreas.ziegler@fau.de>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Applied, thanks.
-Daniel
> ---
> Changes to v1:
> - Tell the story right, suggested by Chris Wilson
>
> drivers/gpu/drm/i915/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
> index fcd77b2..051eab3 100644
> --- a/drivers/gpu/drm/i915/Kconfig
> +++ b/drivers/gpu/drm/i915/Kconfig
> @@ -10,7 +10,6 @@ config DRM_I915
> # the shmem_readpage() which depends upon tmpfs
> select SHMEM
> select TMPFS
> - select STOP_MACHINE
> select DRM_KMS_HELPER
> select DRM_PANEL
> select DRM_MIPI_DSI
> --
> 1.9.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-01-25 15:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 11:14 [PATCH] drm/i915: Remove select to deleted STOP_MACHINE from Kconfig Andreas Ziegler
2016-01-25 11:26 ` Chris Wilson
2016-01-25 11:41 ` [PATCH v2] " Andreas Ziegler
2016-01-25 15:38 ` Daniel Vetter [this message]
2016-01-27 16:01 ` ✓ Fi.CI.BAT: success for drm/i915: Remove select to deleted STOP_MACHINE from Kconfig (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160125153819.GL11240@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=andreas.ziegler@fau.de \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox