Re: [PATCH 14/18] drm/i915: Embed rotation_info under intel_framebuffer

Chris Wilson
2016-01-21T12:10:48Z

On Thu, Jan 21, 2016 at 02:06:27PM +0200, Ville Syrjälä wrote:
> On Wed, Jan 20, 2016 at 09:08:50PM +0000, Chris Wilson wrote:
> > On Wed, Jan 20, 2016 at 09:05:35PM +0200, ville.syrjala@linux.intel.com wrote:
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > Instead of repopulatin the rotation_info struct for the fb every time
> > > we try to use the fb, we can just populate it once when creating the fb,
> > > and later we can just copy the pre-populate struct into the gtt_view.
> >
> > But the rotation state isn't tied to the fb, but to the plane+fb.
> > i.e. I can show the same fb on an unrotated pipe at the same time as
> > showing it rotated, right?
>
> Yep. The rotation info basically just tells us how we need to shuffle
> the pages for this particular fb if we want to scan it out in the
> 90/270 degree orientation.

Ah, gotcha, thanks for the clarification.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre