From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/4] drm/i915: Fix context/engine cleanup order Date: Mon, 25 Jan 2016 19:09:31 +0100 Message-ID: <20160125180931.GP11240@phenom.ffwll.local> References: <1453405067-32890-1-git-send-email-david.s.gordon@intel.com> <1453405067-32890-3-git-send-email-david.s.gordon@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by gabe.freedesktop.org (Postfix) with ESMTPS id 691826E4FC for ; Mon, 25 Jan 2016 10:09:24 -0800 (PST) Received: by mail-wm0-f68.google.com with SMTP id l65so12791176wmf.3 for ; Mon, 25 Jan 2016 10:09:24 -0800 (PST) Content-Disposition: inline In-Reply-To: <1453405067-32890-3-git-send-email-david.s.gordon@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon Cc: intel-gfx@lists.freedesktop.org, Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBKYW4gMjEsIDIwMTYgYXQgMDc6Mzc6NDVQTSArMDAwMCwgRGF2ZSBHb3Jkb24gd3Jv dGU6Cj4gRnJvbTogTmljayBIb2F0aCA8bmljaG9sYXMuaG9hdGhAaW50ZWwuY29tPgo+IAo+IFN3 YXAgdGhlIG9yZGVyIG9mIGNvbnRleHQgJiBlbmdpbmUgY2xlYW51cCwgc28gdGhhdCBjb250ZXh0 cyBhcmUgY2xlYW5lZAo+IHVwIGZpcnN0LCBhbmQgKnRoZW4qIGVuZ2luZXMuIFRoaXMgaXMgYSBt b3JlIHNlbnNpYmxlIG9yZGVyIGFueXdheSwgYnV0Cj4gaW4gcGFydGljdWxhciBoYXMgYmVjb21l IG5lY2Vzc2FyeSBzaW5jZSB0aGUgJ2ludGVsX3JpbmdfaW5pdGlhbGl6ZWQoKQo+IG11c3QgYmUg c2ltcGxlIGFuZCBpbmxpbmUnIHBhdGNoLCB3aGljaCBub3cgdXNlcyByaW5nLT5kZXYgYXMgYW4K PiAnaW5pdGlhbGlzZWQnIGZsYWcsIHNvIGl0IGNhbiBub3cgYmUgTlVMTCBhZnRlciBlbmdpbmUg dGVhcmRvd24uIFRoaXMKPiBpbiB0dXJuIGNhbiBjYXVzZSBhIHByb2JsZW0gaW4gdGhlIGNvbnRl eHQgY29kZSwgd2hpY2ggKHVzZWQgdG8pIGNoZWNrCj4gdGhlIHJpbmctPmRldi0+c3RydWN0X211 dGV4IC0tIGNhdXNpbmcgYSBmYXVsdCBpZiByaW5nLT5kZXYgd2FzIE5VTEwuCj4gCj4gQWxzbyBy ZW5hbWUgdGhlIGNsZWFudXAgZnVuY3Rpb24gdG8gcmVmbGVjdCB3aGF0IGl0IGFjdHVhbGx5IGRv ZXMKPiAoY2xlYW51cCBlbmdpbmVzLCBub3QgYSByaW5nYnVmZmVyKSwgYW5kIGZpeCBhbiBhbm5v eWluZyB3aGl0ZXNwYWNlIGlzc3VlLgo+IAo+IHYyOiBBbHNvIG1ha2UgdGhlIGZpeCBpbiBpOTE1 X2xvYWRfbW9kZXNldF9pbml0LCBub3QganVzdCBpbgo+ICAgICBpOTE1X2RyaXZlcl91bmxvYWQg KENocmlzIFdpbHNvbikKPiB2MzogSGFkIGV4dHJhIHN0dWZmIGluIGl0Lgo+IHY0OiBSZXZlcnRl ZCBleHRyYSBzdHVmZiAoc28gd2UncmUgYmFjayB0byB2MikuCj4gICAgIFJlYmFzZWQgYW5kIHVw ZGF0ZWQgY29tbWVudGFyeSBhYm92ZSAoRGF2ZSBHb3Jkb24pLgo+IAo+IFNpZ25lZC1vZmYtYnk6 IE5pY2sgSG9hdGggPG5pY2hvbGFzLmhvYXRoQGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBE YXZlIEdvcmRvbiA8ZGF2aWQucy5nb3Jkb25AaW50ZWwuY29tPgo+IFJldmlld2VkLWJ5OiBDaHJp cyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4gKHYyKQoKVHJ1c3RpbmcgdGhhdCB2 Mj09djQgYW5kIGFwcGxpZWQgaXQuCi1EYW5pZWwKCj4gCj4gQ2M6IE1pa2EgS3VvcHBhbGEgPG1p a2Eua3VvcHBhbGFAbGludXguaW50ZWwuY29tPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwu dmV0dGVyQGZmd2xsLmNoPgo+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5j by51az4KPiAKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kbWEuYyB8ICA0ICsr LS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCB8ICAyICstCj4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgfCAyMyArKysrKysrKysrKystLS0tLS0tLS0tLQo+ICAz IGZpbGVzIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9ucygtKQo+IAo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RtYS5jIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9kbWEuYwo+IGluZGV4IGQ3MGQ5NmYuLjQ3MjVlOGQgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kbWEuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZG1hLmMKPiBAQCAtNDUxLDggKzQ1MSw4IEBAIHN0YXRpYyBpbnQgaTkxNV9s b2FkX21vZGVzZXRfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAKPiAgY2xlYW51cF9n ZW06Cj4gIAltdXRleF9sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4gLQlpOTE1X2dlbV9jbGVh bnVwX3JpbmdidWZmZXIoZGV2KTsKPiAgCWk5MTVfZ2VtX2NvbnRleHRfZmluaShkZXYpOwo+ICsJ aTkxNV9nZW1fY2xlYW51cF9lbmdpbmVzKGRldik7Cj4gIAltdXRleF91bmxvY2soJmRldi0+c3Ry dWN0X211dGV4KTsKPiAgY2xlYW51cF9pcnE6Cj4gIAlpbnRlbF9ndWNfdWNvZGVfZmluaShkZXYp Owo+IEBAIC0xMTk2LDggKzExOTYsOCBAQCBpbnQgaTkxNV9kcml2ZXJfdW5sb2FkKHN0cnVjdCBk cm1fZGV2aWNlICpkZXYpCj4gIAo+ICAJaW50ZWxfZ3VjX3Vjb2RlX2ZpbmkoZGV2KTsKPiAgCW11 dGV4X2xvY2soJmRldi0+c3RydWN0X211dGV4KTsKPiAtCWk5MTVfZ2VtX2NsZWFudXBfcmluZ2J1 ZmZlcihkZXYpOwo+ICAJaTkxNV9nZW1fY29udGV4dF9maW5pKGRldik7Cj4gKwlpOTE1X2dlbV9j bGVhbnVwX2VuZ2luZXMoZGV2KTsKPiAgCW11dGV4X3VubG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgp Owo+ICAJaW50ZWxfZmJjX2NsZWFudXBfY2ZiKGRldl9wcml2KTsKPiAgCWk5MTVfZ2VtX2NsZWFu dXBfc3RvbGVuKGRldik7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf ZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gaW5kZXggMjA0NjYxZi4u MDIxZTg4YSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+IEBAIC0zMDEyLDcgKzMwMTIs NyBAQCBpbnQgaTkxNV9nZW1faW5pdF9yaW5ncyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsKPiAg aW50IF9fbXVzdF9jaGVjayBpOTE1X2dlbV9pbml0X2h3KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYp Owo+ICBpbnQgaTkxNV9nZW1fbDNfcmVtYXAoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpy ZXEsIGludCBzbGljZSk7Cj4gIHZvaWQgaTkxNV9nZW1faW5pdF9zd2l6emxpbmcoc3RydWN0IGRy bV9kZXZpY2UgKmRldik7Cj4gLXZvaWQgaTkxNV9nZW1fY2xlYW51cF9yaW5nYnVmZmVyKHN0cnVj dCBkcm1fZGV2aWNlICpkZXYpOwo+ICt2b2lkIGk5MTVfZ2VtX2NsZWFudXBfZW5naW5lcyhzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2KTsKPiAgaW50IF9fbXVzdF9jaGVjayBpOTE1X2dwdV9pZGxlKHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+ICBpbnQgX19tdXN0X2NoZWNrIGk5MTVfZ2VtX3N1c3Bl bmQoc3RydWN0IGRybV9kZXZpY2UgKmRldik7Cj4gIHZvaWQgX19pOTE1X2FkZF9yZXF1ZXN0KHN0 cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxLAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+ IGluZGV4IDM3MWJiYjIuLjc5OWE1M2EgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9nZW0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiBA QCAtNDkxMiw3ICs0OTEyLDcgQEAgaW50IGk5MTVfZ2VtX2luaXRfcmluZ3Moc3RydWN0IGRybV9k ZXZpY2UgKmRldikKPiAgCQlyZXEgPSBpOTE1X2dlbV9yZXF1ZXN0X2FsbG9jKHJpbmcsIE5VTEwp Owo+ICAJCWlmIChJU19FUlIocmVxKSkgewo+ICAJCQlyZXQgPSBQVFJfRVJSKHJlcSk7Cj4gLQkJ CWk5MTVfZ2VtX2NsZWFudXBfcmluZ2J1ZmZlcihkZXYpOwo+ICsJCQlpOTE1X2dlbV9jbGVhbnVw X2VuZ2luZXMoZGV2KTsKPiAgCQkJZ290byBvdXQ7Cj4gIAkJfQo+ICAKPiBAQCAtNDkyNSw3ICs0 OTI1LDcgQEAgaW50IGk5MTVfZ2VtX2luaXRfcmluZ3Moc3RydWN0IGRybV9kZXZpY2UgKmRldikK PiAgCQlpZiAocmV0ICYmIHJldCAhPSAtRUlPKSB7Cj4gIAkJCURSTV9FUlJPUigiUFBHVFQgZW5h YmxlIHJpbmcgIyVkIGZhaWxlZCAlZFxuIiwgaSwgcmV0KTsKPiAgCQkJaTkxNV9nZW1fcmVxdWVz dF9jYW5jZWwocmVxKTsKPiAtCQkJaTkxNV9nZW1fY2xlYW51cF9yaW5nYnVmZmVyKGRldik7Cj4g KwkJCWk5MTVfZ2VtX2NsZWFudXBfZW5naW5lcyhkZXYpOwo+ICAJCQlnb3RvIG91dDsKPiAgCQl9 Cj4gIAo+IEBAIC00OTMzLDcgKzQ5MzMsNyBAQCBpbnQgaTkxNV9nZW1faW5pdF9yaW5ncyhzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAJCWlmIChyZXQgJiYgcmV0ICE9IC1FSU8pIHsKPiAgCQkJ RFJNX0VSUk9SKCJDb250ZXh0IGVuYWJsZSByaW5nICMlZCBmYWlsZWQgJWRcbiIsIGksIHJldCk7 Cj4gIAkJCWk5MTVfZ2VtX3JlcXVlc3RfY2FuY2VsKHJlcSk7Cj4gLQkJCWk5MTVfZ2VtX2NsZWFu dXBfcmluZ2J1ZmZlcihkZXYpOwo+ICsJCQlpOTE1X2dlbV9jbGVhbnVwX2VuZ2luZXMoZGV2KTsK PiAgCQkJZ290byBvdXQ7Cj4gIAkJfQo+ICAKPiBAQCAtNTAwOCw3ICs1MDA4LDcgQEAgaW50IGk5 MTVfZ2VtX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgfQo+ICAKPiAgdm9pZAo+IC1p OTE1X2dlbV9jbGVhbnVwX3JpbmdidWZmZXIoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAraTkx NV9nZW1fY2xlYW51cF9lbmdpbmVzKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gIHsKPiAgCXN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gIAlz dHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5nOwo+IEBAIC01MDE3LDEzICs1MDE3LDE0IEBAIGlu dCBpOTE1X2dlbV9pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gIAlmb3JfZWFjaF9yaW5n KHJpbmcsIGRldl9wcml2LCBpKQo+ICAJCWRldl9wcml2LT5ndC5jbGVhbnVwX3JpbmcocmluZyk7 Cj4gIAo+IC0gICAgaWYgKGk5MTUuZW5hYmxlX2V4ZWNsaXN0cykKPiAtICAgICAgICAgICAgLyoK PiAtICAgICAgICAgICAgICogTmVpdGhlciB0aGUgQklPUywgb3Vyc2VsdmVzIG9yIGFueSBvdGhl ciBrZXJuZWwKPiAtICAgICAgICAgICAgICogZXhwZWN0cyB0aGUgc3lzdGVtIHRvIGJlIGluIGV4 ZWNsaXN0cyBtb2RlIG9uIHN0YXJ0dXAsCj4gLSAgICAgICAgICAgICAqIHNvIHdlIG5lZWQgdG8g cmVzZXQgdGhlIEdQVSBiYWNrIHRvIGxlZ2FjeSBtb2RlLgo+IC0gICAgICAgICAgICAgKi8KPiAt ICAgICAgICAgICAgaW50ZWxfZ3B1X3Jlc2V0KGRldik7Cj4gKwlpZiAoaTkxNS5lbmFibGVfZXhl Y2xpc3RzKSB7Cj4gKwkJLyoKPiArCQkgKiBOZWl0aGVyIHRoZSBCSU9TLCBvdXJzZWx2ZXMgb3Ig YW55IG90aGVyIGtlcm5lbAo+ICsJCSAqIGV4cGVjdHMgdGhlIHN5c3RlbSB0byBiZSBpbiBleGVj bGlzdHMgbW9kZSBvbiBzdGFydHVwLAo+ICsJCSAqIHNvIHdlIG5lZWQgdG8gcmVzZXQgdGhlIEdQ VSBiYWNrIHRvIGxlZ2FjeSBtb2RlLgo+ICsJCSAqLwo+ICsJCWludGVsX2dwdV9yZXNldChkZXYp Owo+ICsJfQo+ICB9Cj4gIAo+ICBzdGF0aWMgdm9pZAo+IC0tIAo+IDEuOS4xCj4gCgotLSAKRGFu aWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Js b2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK