From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH] drm/i915: Make wa_tail_dwords flexible for future platforms. Date: Mon, 25 Jan 2016 11:36:34 -0800 Message-ID: <20160125193633.GA31755@intel.com> References: <1453750159-26475-1-git-send-email-rodrigo.vivi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 065236E533 for ; Mon, 25 Jan 2016 11:36:34 -0800 (PST) Content-Disposition: inline In-Reply-To: <1453750159-26475-1-git-send-email-rodrigo.vivi@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBKYW4gMjUsIDIwMTYgYXQgMTE6Mjk6MTlBTSAtMDgwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+IENvbW1pdCA3YzE3ZDM3NzMgKGRybS9pOTE1OiBVc2Ugb3JkZXJlZCBzZXFubyB3cml0 ZSBpbnRlcnJ1cHQgZ2VuZXJhdGlvbgo+IG9uIGdlbjgrIGV4ZWNsaXN0cykgbW92ZWQgdHdvIE1J X05PT1BzIHRvIHRoZSBhZHZhbmNlX2FuZF9zdWJtaXQgZnVuY3Rpb25zCj4gYW5kIGhhcmRjb2Rl ZCB0aGUgV0FfVEFJTF9EV09SRFMuIFdpdGggdGhpcyB3ZSBkb24ndCBoYXZlIGEgY2xlYW4gd2F5 IHRvCj4gaW1wbGVtZW50IG9yIHJlbW92ZSBXYUlkbGVMaXRlUmVzdG9yZSBmb3IgZGlmZmVyZW50 IHBsYXRmb3Jtcy4KPiAKPiBUaGlzIHBhdGNoIGFpbXMgdG8gbGV0IGl0IG1vcmUgZmxleGlibGUu IFNvIHdlIGp1c3QgZW1pdCB0aGUgTk9PUHMKPiBlcXVpdmFsZW50IG9mIHdoYXQgd2FzIGluaXRp YWxpemVkLgo+IAo+IEFsc28gbGV0J3MganVzdCBpbmNsdWRlIHRoZSBwbGF0Zm9ybXMgd2Uga25v dyB0aGF0IG5lZWRzIHRoaXMgV2EsCj4gaS5lIGdlbjggYW5kIGdlbjkgcGxhdGZvcm1zLgo+IAo+ IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogQmVuIFdp ZGF3c2t5IDxiZW5qYW1pbi53aWRhd3NreUBpbnRlbC5jb20+Cj4gCj4gU2lnbmVkLW9mZi1ieTog Um9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgoKSSBkb24ndCBjbGFpbSB0byB1 bmRlcnN0YW5kIHRoZSByZWFzb24gdGhpcyBwYXRjaCBlbmRzIHVwIGJlaW5nIHJlcXVpcmVkLCBi dXQgaXQKbG9va3MgZmluZSB0byBtZS4gSSB3b3VsZCBoYXZlIGdvbmUgd2l0aCBhIGJvb2wgZm9y IHRoZSB3b3JrYXJvdW5kIGluc3RlYWQgb2YgYQpjb3VudCBvZiBkd29yZHMgLSBidXQgaXQncyB1 cCB0byB5b3UuIFNpbmNlIHlvdSBhbGx1ZGUgdG8gYWxyZWFkeSBrbm93aW5nIHdoYXQKZnV0dXJl IGhhcmR3YXJlIGRvZXMsIHdlIGtub3cgd2UgZG9uJ3QgbmVlZCBhIHZhcmlhYmxlIGxlbmd0aCBo ZXJlLgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgICAgICAgIHwg MzEgKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9yaW5nYnVmZmVyLmggfCAgMiArKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDE5IGluc2Vy dGlvbnMoKyksIDE0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9scmMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4g aW5kZXggZGE5N2JjNS4uZDBiMjUzZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9scmMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4g QEAgLTc2NCwxOCArNzY0LDE4IEBAIGludGVsX2xvZ2ljYWxfcmluZ19hZHZhbmNlX2FuZF9zdWJt aXQoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0KQo+ICB7Cj4gIAlzdHJ1Y3Qg aW50ZWxfcmluZ2J1ZmZlciAqcmluZ2J1ZiA9IHJlcXVlc3QtPnJpbmdidWY7Cj4gIAlzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSByZXF1ZXN0LT5pOTE1Owo+ICsJaW50IGk7Cj4g IAo+ICAJaW50ZWxfbG9naWNhbF9yaW5nX2FkdmFuY2UocmluZ2J1Zik7Cj4gIAlyZXF1ZXN0LT50 YWlsID0gcmluZ2J1Zi0+dGFpbDsKPiAgCj4gIAkvKgo+IC0JICogSGVyZSB3ZSBhZGQgdHdvIGV4 dHJhIE5PT1BzIGFzIHBhZGRpbmcgdG8gYXZvaWQKPiArCSAqIEhlcmUgd2UgYWRkIGV4dHJhIE5P T1BzIGFzIHBhZGRpbmcgdG8gYXZvaWQKPiAgCSAqIGxpdGUgcmVzdG9yZSBvZiBhIGNvbnRleHQg d2l0aCBIRUFEPT1UQUlMLgo+IC0JICoKPiAtCSAqIENhbGxlciBtdXN0IHJlc2VydmUgV0FfVEFJ TF9EV09SRFMgZm9yIHVzIQo+ICAJICovCj4gLQlpbnRlbF9sb2dpY2FsX3JpbmdfZW1pdChyaW5n YnVmLCBNSV9OT09QKTsKPiAtCWludGVsX2xvZ2ljYWxfcmluZ19lbWl0KHJpbmdidWYsIE1JX05P T1ApOwo+ICsJZm9yIChpID0gMDsgaSA8IHJpbmdidWYtPndhX3RhaWxfZHdvcmRzOyBpKyspCj4g KwkJaW50ZWxfbG9naWNhbF9yaW5nX2VtaXQocmluZ2J1ZiwgTUlfTk9PUCk7Cj4gKwo+ICAJaW50 ZWxfbG9naWNhbF9yaW5nX2FkdmFuY2UocmluZ2J1Zik7Cj4gIAo+ICAJaWYgKGludGVsX3Jpbmdf c3RvcHBlZChyZXF1ZXN0LT5yaW5nKSkKPiBAQCAtODc2LDYgKzg3NiwxNiBAQCBpbnQgaW50ZWxf bG9naWNhbF9yaW5nX2JlZ2luKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxLCBpbnQg bnVtX2R3b3JkcykKPiAgCWlmIChyZXQpCj4gIAkJcmV0dXJuIHJldDsKPiAgCj4gKwlpZiAoSVNf R0VOOChyZXEtPnJpbmctPmRldikgfHwgSVNfR0VOOShyZXEtPnJpbmctPmRldikpCj4gKwkJLyoK PiArCQkgKiBSZXNlcnZlIHNwYWNlIGZvciAyIE5PT1BzIGF0IHRoZSBlbmQgb2YgZWFjaCByZXF1 ZXN0IHRvIGJlCj4gKwkJICogdXNlZCBhcyBhIHdvcmthcm91bmQgZm9yIG5vdCBiZWluZyBhbGxv d2VkIHRvIGRvIGxpdGUKPiArCQkgKiByZXN0b3JlIHdpdGggSEVBRD09VEFJTCAoV2FJZGxlTGl0 ZVJlc3RvcmUpLgo+ICsJCSAqLwo+ICsJCXJlcS0+cmluZ2J1Zi0+d2FfdGFpbF9kd29yZHMgPSAy OwoKVGhpcyBzaG91bGQgYmUgc2V0IGF0IHJpbmdfaW5pdCwgbm90IGhlcmUuCgo+ICsKPiArCW51 bV9kd29yZHMgKz0gcmVxLT5yaW5nYnVmLT53YV90YWlsX2R3b3JkczsKPiArCj4gIAlyZXQgPSBs b2dpY2FsX3JpbmdfcHJlcGFyZShyZXEsIG51bV9kd29yZHMgKiBzaXplb2YodWludDMyX3QpKTsK PiAgCWlmIChyZXQpCj4gIAkJcmV0dXJuIHJldDsKPiBAQCAtMTg1OCwxMyArMTg2OCw2IEBAIHN0 YXRpYyB2b2lkIGJ4dF9hX3NldF9zZXFubyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5nLCB1 MzIgc2Vxbm8pCj4gIAlpbnRlbF9mbHVzaF9zdGF0dXNfcGFnZShyaW5nLCBJOTE1X0dFTV9IV1Nf SU5ERVgpOwo+ICB9Cj4gIAo+IC0vKgo+IC0gKiBSZXNlcnZlIHNwYWNlIGZvciAyIE5PT1BzIGF0 IHRoZSBlbmQgb2YgZWFjaCByZXF1ZXN0IHRvIGJlCj4gLSAqIHVzZWQgYXMgYSB3b3JrYXJvdW5k IGZvciBub3QgYmVpbmcgYWxsb3dlZCB0byBkbyBsaXRlCj4gLSAqIHJlc3RvcmUgd2l0aCBIRUFE PT1UQUlMIChXYUlkbGVMaXRlUmVzdG9yZSkuCj4gLSAqLwo+IC0jZGVmaW5lIFdBX1RBSUxfRFdP UkRTIDIKPiAtCj4gIHN0YXRpYyBpbmxpbmUgdTMyIGh3c19zZXFub19hZGRyZXNzKHN0cnVjdCBp bnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgewo+ICAJcmV0dXJuIGVuZ2luZS0+c3RhdHVzX3Bh Z2UuZ2Z4X2FkZHIgKyBJOTE1X0dFTV9IV1NfSU5ERVhfQUREUjsKPiBAQCAtMTg3NSw3ICsxODc4 LDcgQEAgc3RhdGljIGludCBnZW44X2VtaXRfcmVxdWVzdChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3Jl cXVlc3QgKnJlcXVlc3QpCj4gIAlzdHJ1Y3QgaW50ZWxfcmluZ2J1ZmZlciAqcmluZ2J1ZiA9IHJl cXVlc3QtPnJpbmdidWY7Cj4gIAlpbnQgcmV0Owo+ICAKPiAtCXJldCA9IGludGVsX2xvZ2ljYWxf cmluZ19iZWdpbihyZXF1ZXN0LCA2ICsgV0FfVEFJTF9EV09SRFMpOwo+ICsJcmV0ID0gaW50ZWxf bG9naWNhbF9yaW5nX2JlZ2luKHJlcXVlc3QsIDYpOwo+ICAJaWYgKHJldCkKPiAgCQlyZXR1cm4g cmV0Owo+ICAKPiBAQCAtMTg5OSw3ICsxOTAyLDcgQEAgc3RhdGljIGludCBnZW44X2VtaXRfcmVx dWVzdF9yZW5kZXIoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0KQo+ICAJc3Ry dWN0IGludGVsX3JpbmdidWZmZXIgKnJpbmdidWYgPSByZXF1ZXN0LT5yaW5nYnVmOwo+ICAJaW50 IHJldDsKPiAgCj4gLQlyZXQgPSBpbnRlbF9sb2dpY2FsX3JpbmdfYmVnaW4ocmVxdWVzdCwgNiAr IFdBX1RBSUxfRFdPUkRTKTsKPiArCXJldCA9IGludGVsX2xvZ2ljYWxfcmluZ19iZWdpbihyZXF1 ZXN0LCA2KTsKPiAgCWlmIChyZXQpCj4gIAkJcmV0dXJuIHJldDsKPiAgCgpJIHRoaW5rIGl0J3Mg YSBsb3QgbW9yZSBzdHJhaWdodGZvcndhcmQgdG8gZG8gdGhlICsgcmluZ2J1Zi0+d2FfdGFpbF9k d29yZHMKaGVyZSwgc28gdGhhdCByaW5nX2JlaW5nIGNhbiBiZSBhcyBkdW1iIGFzIHBvc3NpYmxl LgoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5o IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4gaW5kZXggNTY2YjBh ZS4uNjJiNGUxYiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5n YnVmZmVyLmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgK PiBAQCAtMTIyLDYgKzEyMiw4IEBAIHN0cnVjdCBpbnRlbF9yaW5nYnVmZmVyIHsKPiAgCSAqIHdl IGNhbiBkZXRlY3QgbmV3IHJldGlyZW1lbnRzLgo+ICAJICovCj4gIAl1MzIgbGFzdF9yZXRpcmVk X2hlYWQ7Cj4gKwo+ICsJaW50IHdhX3RhaWxfZHdvcmRzOwo+ICB9Owo+ICAKPiAgc3RydWN0CWlu dGVsX2NvbnRleHQ7Cj4gLS0gCj4gMi40LjMKPiAKCi0tIApCZW4gV2lkYXdza3ksIEludGVsIE9w ZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==