From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [RFC 2/3] drm/i915: do not disable handler after underrun Date: Tue, 26 Jan 2016 21:49:00 +0100 Message-ID: <20160126204900.GF11240@phenom.ffwll.local> References: <1453837017-23209-1-git-send-email-joe.konno@linux.intel.com> <1453837017-23209-3-git-send-email-joe.konno@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by gabe.freedesktop.org (Postfix) with ESMTPS id 44E396E2C9 for ; Tue, 26 Jan 2016 12:48:52 -0800 (PST) Received: by mail-wm0-f50.google.com with SMTP id p63so5073189wmp.1 for ; Tue, 26 Jan 2016 12:48:52 -0800 (PST) Content-Disposition: inline In-Reply-To: <1453837017-23209-3-git-send-email-joe.konno@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Joe Konno Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBKYW4gMjYsIDIwMTYgYXQgMTE6MzY6NTZBTSAtMDgwMCwgSm9lIEtvbm5vIHdyb3Rl Ogo+IEZyb206IEpvZSBLb25ubyA8am9lLmtvbm5vQGludGVsLmNvbT4KPiAKPiBQcmV2aW91c2x5 LCBjcHUgYW5kIHBjaCB1bmRlcnJ1biByZXBvcnRpbmcgd2FzIGRvbmUgb24gYSAicmVwb3J0IG9u Y2UKPiBhbmQgZGlzYWJsZSIgYmFzaXMgdG8gcHJldmVudCBpbnRlcnJ1cHQvZG1lc2cgZmxvb2Rz Lgo+IAo+IFdpdGggdGhpcyBjaGFuZ2UsIGRvIG5vdCBkaXNhYmxlIHRoZSB1bmRlcnJ1biBpbnRl cnJ1cHQgaGFuZGxlcnMuCj4gSW5zdGVhZCwgdXNlIHRocm90dGxlZCAoRFJNX0VSUk9SX1JBVEVM SU1JVEVEKSBkbWVzZyBvdXRwdXQgaWYgZG1lc2cKPiB1bmRlcnJ1biByZXBvcnRpbmcgZW5hYmxl ZC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBKb2UgS29ubm8gPGpvZS5rb25ub0BpbnRlbC5jb20+CgpU aGlzIGlzIHRvbyBzaW1wbGUgdW5mb3J0dW5hdGVseS4gSW4gbWFueSBjYXNlcyB0aGUgdW5kZXJy dW4gaXMgYSBvbmUtb2ZmCnJpZ2h0IHdoZW4gc2Nhbi1vdXQgc3RhcnRzIGFuZCB0aGVuIHN0b3Bz IGFnYWluLCB1bnRpbCBzb21ldGhpbmcgY2hhbmdlcwphZ2Fpbi4gVGhpcyBpcyB0aGUgdHlwaWNh bCBmYWlsdXJlIG1vZGUgZm9yIG5vbi1hdG9taWMgd20gdXBkYXRlIGFuZApzaW1pbGFyIHN0dWZm LgoKQnV0IGl0J3MgYWxzbyBwb3NzaWJsZSB0aGF0IHRoZSBwaXBlIHdlZGdlcyBlbnRpcmVseSBh bmQgdGhlIHVuZGVycnVuIGlzCnN0dWNrLiBUaGVuIHlvdSdsbCBlbmQgdXAgZG9pbmcgbm90aGlu ZyBlbHNlIHRoYW4gc2VydmluZyBmaWZvIHVuZGVycnVucywKd2l0aCBubyBjcHUgdGltZSBsZWZ0 IGZvciBhbnl0aGluZyBlbHNlLiBUaGlzIGtpbGxzIHlvdXIgYm94LgoKU28gaWYgeW91IHdhbnQg dG8ga2VlcCB0cmFjayBvZiBhIGNvdW50IG9mIHVuZGVycnVucyB0aGUgcmlnaHQgd2F5IGlzIHRv CmRpc2FibGUgaXQgd2hlbiBpdCBoYXBwZW5zLCBidXQgdGhlbiBzY2hlZHVsZSByZS1lbmFibGlu ZyBmb3IgdGhlIG5leHQKdmJsYW5rLiBBbHNvIEkgdGhpbmsgd2Ugc2hvdWxkbid0IHNwYW0gZG1l c2cgbW9yZSB0aGFuIHdlIGRvIGFscmVhZHksIHNvCmluc3RlYWQgb2YgcmF0ZWxpbWl0aW5nIEkn ZCBqdXN0IGtlZXAgYSBjb3VudGVyIGFmdGVyIHRoZSBmaXJzdCBvbmUKaGFwcGVuZWQsIGJlZm9y ZSB0aGUgbmV4dCBtb2Rlc2V0LgoKQW5vdGhlciByZWFsbHkgYW5ub3lpbmcgdGhpbmcgd2l0aCB1 bmRlcnJ1bnM6IE9uIHNvbWUgcGxhdGZvcm1zIHRoZSBpcnEKY29udHJvbCBiaXRzIGFyZSBzaGFy ZWQgYmV0d2VlbiB0aGVtIGFsbCwgd2hpY2ggbWVhbnMgeW91IGNhbid0IGRpc2FibGUKdGhlbSBp bmRpdmlkdWFsbHkuIElmIHlvdSB1bmRlcnJ1biBvbiBvbmUgcGlwZSB5b3UgYWxzbyBoYXZlIHRv IGRpc2FibGUgaXQKZm9yIGFsbCB0aGUgb3RoZXJzLgoKSW4gc2hvcnQ6IFRoaXMgaXMgYWxsIGEg cHJldHR5IGJpZyBtZXNzIDooCi1EYW5pZWwKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2ZpZm9fdW5kZXJydW4uYyB8IDI5ICsrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0t Cj4gIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkKPiAK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmlmb191bmRlcnJ1bi5j IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmlmb191bmRlcnJ1bi5jCj4gaW5kZXggOTUx NmJkNDE2MjI2Li40YTFhMjc4MWZjNWUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZmlmb191bmRlcnJ1bi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZmlmb191bmRlcnJ1bi5jCj4gQEAgLTM5MywyNiArMzkzLDIzIEBAIGJvb2wgaW50ZWxfZ2V0 X3BjaF9maWZvX3VuZGVycnVuX3JlcG9ydGluZyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYsCj4gICAqIEBwaXBlOiAoQ1BVKSBwaXBlIHRvIHNldCBzdGF0ZSBmb3IKPiAgICoKPiAg ICogVGhpcyBoYW5kbGVzIGEgQ1BVIGZpZm8gdW5kZXJydW4gaW50ZXJydXB0LCBnZW5lcmF0aW5n IGFuIHVuZGVycnVuIHdhcm5pbmcKPiAtICogaW50byBkbWVzZyBpZiB1bmRlcnJ1biByZXBvcnRp bmcgaXMgZW5hYmxlZCBhbmQgdGhlbiBkaXNhYmxlcyB0aGUgdW5kZXJydW4KPiAtICogaW50ZXJy dXB0IHRvIGF2b2lkIGFuIGlycSBzdG9ybS4KPiArICogaW50byBkbWVzZyBpZiB1bmRlcnJ1biBy ZXBvcnRpbmcgaXMgZW5hYmxlZC4KPiAgICovCj4gIHZvaWQgaW50ZWxfY3B1X2ZpZm9fdW5kZXJy dW5faXJxX2hhbmRsZXIoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJCQkJ CSBlbnVtIHBpcGUgcGlwZSkKPiAgewo+ICAJc3RydWN0IGRybV9jcnRjICpjcnRjID0gZGV2X3By aXYtPnBpcGVfdG9fY3J0Y19tYXBwaW5nW3BpcGVdOwo+ICsJYm9vbCByZXBvcnQ7Cj4gIAo+ICAJ LyogV2UgbWF5IGJlIGNhbGxlZCB0b28gZWFybHkgaW4gaW5pdCwgdGhhbmtzIEJJT1MhICovCj4g IAlpZiAoY3J0YyA9PSBOVUxMKQo+ICAJCXJldHVybjsKPiAgCj4gLQkvKiBHTUNIIGNhbid0IGRp c2FibGUgZmlmbyB1bmRlcnJ1bnMsIGZpbHRlciB0aGVtLiAqLwo+IC0JaWYgKEhBU19HTUNIX0RJ U1BMQVkoZGV2X3ByaXYtPmRldikgJiYKPiAtCSAgICB0b19pbnRlbF9jcnRjKGNydGMpLT5jcHVf Zmlmb191bmRlcnJ1bl9kaXNhYmxlZCkKPiAtCQlyZXR1cm47Cj4gKwlyZXBvcnQgPSBpbnRlbF9n ZXRfY3B1X2ZpZm9fdW5kZXJydW5fcmVwb3J0aW5nKGRldl9wcml2LCBwaXBlKTsKPiAgCj4gLQlp ZiAoaW50ZWxfc2V0X2NwdV9maWZvX3VuZGVycnVuX3JlcG9ydGluZyhkZXZfcHJpdiwgcGlwZSwg ZmFsc2UpKQo+IC0JCURSTV9FUlJPUigiQ1BVIHBpcGUgJWMgRklGTyB1bmRlcnJ1blxuIiwKPiAt CQkJICBwaXBlX25hbWUocGlwZSkpOwo+ICsJaWYgKHJlcG9ydCkKPiArCQlEUk1fRVJST1JfUkFU RUxJTUlURUQoIkNQVSBwaXBlICVjIEZJRk8gdW5kZXJydW5cbiIsCj4gKwkJCQkgICAgICBwaXBl X25hbWUocGlwZSkpOwo+ICB9Cj4gIAo+ICAvKioKPiBAQCAtNDIxLDE2ICs0MTgsMTggQEAgdm9p ZCBpbnRlbF9jcHVfZmlmb191bmRlcnJ1bl9pcnFfaGFuZGxlcihzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYsCj4gICAqIEBwY2hfdHJhbnNjb2RlcjogdGhlIFBDSCB0cmFuc2NvZGVy IChzYW1lIGFzIHBpcGUgb24gSVZCIGFuZCBvbGRlcikKPiAgICoKPiAgICogVGhpcyBoYW5kbGVz IGEgUENIIGZpZm8gdW5kZXJydW4gaW50ZXJydXB0LCBnZW5lcmF0aW5nIGFuIHVuZGVycnVuIHdh cm5pbmcKPiAtICogaW50byBkbWVzZyBpZiB1bmRlcnJ1biByZXBvcnRpbmcgaXMgZW5hYmxlZCBh bmQgdGhlbiBkaXNhYmxlcyB0aGUgdW5kZXJydW4KPiAtICogaW50ZXJydXB0IHRvIGF2b2lkIGFu IGlycSBzdG9ybS4KPiArICogaW50byBkbWVzZyBpZiB1bmRlcnJ1biByZXBvcnRpbmcgaXMgZW5h YmxlZC4KPiAgICovCj4gIHZvaWQgaW50ZWxfcGNoX2ZpZm9fdW5kZXJydW5faXJxX2hhbmRsZXIo c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJCQkJCSBlbnVtIHRyYW5zY29k ZXIgcGNoX3RyYW5zY29kZXIpCj4gIHsKPiAtCWlmIChpbnRlbF9zZXRfcGNoX2ZpZm9fdW5kZXJy dW5fcmVwb3J0aW5nKGRldl9wcml2LCBwY2hfdHJhbnNjb2RlciwKPiAtCQkJCQkJICBmYWxzZSkp Cj4gLQkJRFJNX0VSUk9SKCJQQ0ggdHJhbnNjb2RlciAlYyBGSUZPIHVuZGVycnVuXG4iLAo+IC0J CQkgIHRyYW5zY29kZXJfbmFtZShwY2hfdHJhbnNjb2RlcikpOwo+ICsJc3RydWN0IGRybV9jcnRj ICpjcnRjID0gZGV2X3ByaXYtPnBpcGVfdG9fY3J0Y19tYXBwaW5nW3BjaF90cmFuc2NvZGVyXTsK PiArCWJvb2wgcmVwb3J0ID0gaW50ZWxfZ2V0X3BjaF9maWZvX3VuZGVycnVuX3JlcG9ydGluZyhk ZXZfcHJpdiwKPiArCQkJCQkJCSAgICBwY2hfdHJhbnNjb2Rlcik7Cj4gKwo+ICsJaWYgKHJlcG9y dCkKPiArCQlEUk1fRVJST1JfUkFURUxJTUlURUQoIlBDSCB0cmFuc2NvZGVyICVjIEZJRk8gdW5k ZXJydW5cbiIsCj4gKwkJCQkgICAgICB0cmFuc2NvZGVyX25hbWUocGNoX3RyYW5zY29kZXIpKTsK PiAgfQo+ICAKPiAgLyoqCj4gLS0gCj4gMi42LjQKPiAKPiBfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUg RW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5n IGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==