From: Matt Roper <matthew.d.roper@intel.com>
To: Daniel Stone <daniel@fooishbar.org>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 2/6] drm: introduce color correction properties
Date: Wed, 27 Jan 2016 01:02:44 -0800 [thread overview]
Message-ID: <20160127090244.GB13107@intel.com> (raw)
In-Reply-To: <CAPj87rOkMTW-oO4Sp+PXsycqA=zYKMvXE-dGwm_BMPn5Et8vow@mail.gmail.com>
On Mon, Jan 25, 2016 at 10:57:51AM +0000, Daniel Stone wrote:
> Hi,
>
> On 22 January 2016 at 21:20, Matt Roper <matthew.d.roper@intel.com> wrote:
> > Probably should have noticed/commented on this on your previous
> > iteration, but should we also restrict these new properties to be
> > atomic-only? I thought there was a consensus a while back that new
> > functionality would only be exposed for atomic-ready userspace. That
> > would mean also adding DRM_MODE_PROP_ATOMIC to your flags at creation.
> > Sorry for not noticing this when I commented before!
>
> I don't really see a reason to mandate atomic for these. They'll still
> work with normal prop sets, every bit as well/badly as pre-atomic has
> always worked.
>
Yeah, I agree that these could still work for legacy. But I thought the
goal was to make new common properties atomic-only to help push atomic
as the API of the future and also to reduce the possibility of new
kernel properties confusing any poorly-written existing userspace.
I thought danvet had written something about that a while back, but I
could be completely misremembering. If the consensus is that exposing
these for non-atomic is okay, then I don't have any serious objections
to that.
Thanks.
Matt
> Cheers,
> Daniel
--
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-01-27 9:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 12:12 [PATCH 0/6] Pipe level color management V2 Lionel Landwerlin
2016-01-22 12:12 ` [PATCH 1/6] drm/i915: Extract out gamma table and CSC to their own file Lionel Landwerlin
2016-01-22 12:12 ` [PATCH 2/6] drm: introduce color correction properties Lionel Landwerlin
2016-01-22 21:20 ` Matt Roper
2016-01-25 10:57 ` Daniel Stone
2016-01-27 9:02 ` Matt Roper [this message]
2016-01-22 12:12 ` [PATCH 3/6] drm/i915: enable CSC for pipe C Lionel Landwerlin
2016-01-22 12:12 ` [PATCH 4/6] drm/i915: enable legacy palette " Lionel Landwerlin
2016-01-22 12:12 ` [PATCH 5/6] drm/i915: Implement color management on bdw/skl/bxt/kbl Lionel Landwerlin
2016-01-22 12:12 ` [PATCH 6/6] drm/i915: Implement color management on chv Lionel Landwerlin
2016-01-22 13:14 ` ✗ Fi.CI.BAT: failure for Pipe level color management (rev2) Patchwork
-- strict thread matches above, loose matches on Subject: below --
2016-02-09 12:19 [PATCH 0/6] Pipe level color management V4 Lionel Landwerlin
2016-02-09 12:19 ` [PATCH 2/6] drm: introduce color correction properties Lionel Landwerlin
2016-02-18 1:55 ` Matt Roper
2016-02-01 15:18 [PATCH 0/6] Pipe level color management V3 Lionel Landwerlin
2016-02-01 15:18 ` [PATCH 2/6] drm: introduce color correction properties Lionel Landwerlin
2016-01-21 15:03 [PATCH 0/6] Pipe level color management Lionel Landwerlin
2016-01-21 15:03 ` [PATCH 2/6] drm: introduce color correction properties Lionel Landwerlin
2016-01-21 19:20 ` Matt Roper
2016-01-22 10:20 ` Lionel Landwerlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160127090244.GB13107@intel.com \
--to=matthew.d.roper@intel.com \
--cc=daniel@fooishbar.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).