From: Matt Roper <matthew.d.roper@intel.com>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/bxt: update list of PCIIDs
Date: Sun, 31 Jan 2016 16:20:54 -0800 [thread overview]
Message-ID: <20160201002054.GE20935@intel.com> (raw)
In-Reply-To: <1453989852-13569-1-git-send-email-imre.deak@intel.com>
On Thu, Jan 28, 2016 at 04:04:12PM +0200, Imre Deak wrote:
> Add PCIIDs for new versions of the SOC, based on BSpec. Also add the
> name of the versions as code comment where this is available. The new
> versions don't have any changes visible to the kernel driver.
>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
> include/drm/i915_pciids.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index f970209..9b48ac1 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -296,7 +296,9 @@
> #define INTEL_BXT_IDS(info) \
> INTEL_VGA_DEVICE(0x0A84, info), \
> INTEL_VGA_DEVICE(0x1A84, info), \
> - INTEL_VGA_DEVICE(0x5A84, info)
> + INTEL_VGA_DEVICE(0x1A85, info), \
I don't see 0x1A85 in the bspec (at least not in the "Configurations ->
Steppings and Device IDs" section...is there another list elsewhere in
the bspec you got it from?)
Semi-related...the revision ID vs stepping info on that page doesn't
seem to quite match what we have in bxt_stepping_info[] in intel_csr.c
(plus it looks like we have some new revision ID's we could add in
general).
Matt
> + INTEL_VGA_DEVICE(0x5A84, info), /* APL HD Graphics 505 */ \
> + INTEL_VGA_DEVICE(0x5A85, info) /* APL HD Graphics 500 */
>
> #define INTEL_KBL_GT1_IDS(info) \
> INTEL_VGA_DEVICE(0x5913, info), /* ULT GT1.5 */ \
> --
> 2.5.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-02-01 0:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 14:04 [PATCH] drm/i915/bxt: update list of PCIIDs Imre Deak
2016-01-28 16:03 ` Mika Kuoppala
2016-01-29 10:14 ` ✓ Fi.CI.BAT: success for " Patchwork
2016-02-02 16:32 ` Imre Deak
2016-02-01 0:20 ` Matt Roper [this message]
2016-02-01 10:44 ` [PATCH] " Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160201002054.GE20935@intel.com \
--to=matthew.d.roper@intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).