From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 3/8] drm/i915: Adding the parsing logic for
 the i2c element
Date: Thu, 4 Feb 2016 17:28:54 +0200
Message-ID: <20160204152854.GH23290@intel.com>
References: <cover.1454582914.git.jani.nikula@intel.com>
 <f684304ca297fd3dd325c29a541b8960fe468b96.1454582914.git.jani.nikula@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by gabe.freedesktop.org (Postfix) with ESMTP id CE2456E895
 for <intel-gfx@lists.freedesktop.org>; Thu,  4 Feb 2016 07:28:57 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <f684304ca297fd3dd325c29a541b8960fe468b96.1454582914.git.jani.nikula@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCBGZWIgMDQsIDIwMTYgYXQgMTI6NTA6NTFQTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv
dGU6Cj4gRnJvbTogdmtvcmphbmkgPHZpa2FzLmtvcmphbmlAaW50ZWwuY29tPgo+IAo+IE5ldyBz
ZXF1ZW5jZSBlbGVtZW50IGZvciBpMmMgaXMgYmVlbiBhZGRlZCBpbiB0aGUKPiBtaXBpIHNlcXVl
bmNlIGJsb2NrIG9mIHRoZSBWQlQuIFRoaXMgcGF0Y2ggcGFyc2VzCj4gYW5kIGV4ZWN1dGVzIHRo
ZSBpMmMgc2VxdWVuY2UuCj4gCj4gdjI6IEFkZCBpMmNfcHV0X2FkYXB0ZXIgY2FsbChKYW5pKSwg
cmViYXNlCj4gCj4gdjM6IGNvcnJlY3RlZCB0aGUgcmV0cnkgbG9vcChKYW5pKSwgcmViYXNlCj4g
Cj4gdjQgYnkgSmFuaToKPiAgLSBkb24ndCBwdXQgdGhlIGFkYXB0ZXIgaWYgZ2V0IGZhaWxzCj4g
IC0gcHJpbnQgYW4gZXJyb3IgbWVzc2FnZSBpZiBhbGwgcmV0cmllcyBleGhhdXN0ZWQKPiAgLSB1
c2UgYSBmb3IgbG9vcAo+ICAtIGZpeCB3YXJuaW5ncyBmb3IgdW51c2VkIHZhcmlhYmxlcwo+IAo+
IHY1IGJ5IEphbmk6Cj4gIC0gcmViYXNlIG9uIHRoZSBza2lwIGkyYyBlbGVtZW50IHBhdGNoCj4g
Cj4gdjY6IGJ5IEphbmk6Cj4gIC0gaWdub3JlIHRoZSBnbWJ1cyBpMmMgZWxlbWVudHMgKFZpbGxl
KQo+IAo+IFNpZ25lZC1vZmYtYnk6IHZrb3JqYW5pIDx2aWthcy5rb3JqYW5pQGludGVsLmNvbT4K
PiBTaWduZWQtb2ZmLWJ5OiBEZWVwYWsgTSA8bS5kZWVwYWtAaW50ZWwuY29tPgo+IFNpZ25lZC1v
ZmYtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZl
cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RzaV9wYW5lbF92YnQuYyB8IDY0ICsrKysrKysrKysrKysr
KysrKysrKysrKysrKystLQo+ICAxIGZpbGUgY2hhbmdlZCwgNjEgaW5zZXJ0aW9ucygrKSwgMyBk
ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf
ZHNpX3BhbmVsX3ZidC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHNpX3BhbmVsX3Zi
dC5jCj4gaW5kZXggNmYwMTNlZmJhNDViLi5mNGQzMDNlZTUzOGIgMTAwNjQ0Cj4gLS0tIGEvZHJp
dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHNpX3BhbmVsX3ZidC5jCj4gKysrIGIvZHJpdmVycy9n
cHUvZHJtL2k5MTUvaW50ZWxfZHNpX3BhbmVsX3ZidC5jCj4gQEAgLTMxLDYgKzMxLDcgQEAKPiAg
I2luY2x1ZGUgPGRybS9kcm1fcGFuZWwuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L3NsYWIuaD4KPiAg
I2luY2x1ZGUgPHZpZGVvL21pcGlfZGlzcGxheS5oPgo+ICsjaW5jbHVkZSA8bGludXgvaTJjLmg+
Cj4gICNpbmNsdWRlIDxhc20vaW50ZWwtbWlkLmg+Cj4gICNpbmNsdWRlIDx2aWRlby9taXBpX2Rp
c3BsYXkuaD4KPiAgI2luY2x1ZGUgImk5MTVfZHJ2LmgiCj4gQEAgLTIzNSw5ICsyMzYsNjYgQEAg
b3V0Ogo+ICAJcmV0dXJuIGRhdGE7Cj4gIH0KPiAgCj4gLXN0YXRpYyBjb25zdCB1OCAqbWlwaV9l
eGVjX2kyY19za2lwKHN0cnVjdCBpbnRlbF9kc2kgKmludGVsX2RzaSwgY29uc3QgdTggKmRhdGEp
Cj4gK3N0YXRpYyBjb25zdCB1OCAqbWlwaV9leGVjX2kyYyhzdHJ1Y3QgaW50ZWxfZHNpICppbnRl
bF9kc2ksIGNvbnN0IHU4ICpkYXRhKQo+ICB7Cj4gLQlyZXR1cm4gZGF0YSArICooZGF0YSArIDYp
ICsgNzsKPiArCXN0cnVjdCBpMmNfYWRhcHRlciAqYWRhcHRlcjsKPiArCWludCByZXQsIGk7Cj4g
Kwl1OCByZWdfb2Zmc2V0LCBwYXlsb2FkX3NpemU7Cj4gKwlzdHJ1Y3QgaTJjX21zZyBtc2c7Cj4g
Kwl1OCAqdHJhbnNtaXRfYnVmZmVyOwo+ICsJdTggZmxhZywgcmVzb3VyY2VfaWQsIGJ1c19udW1i
ZXI7Cj4gKwl1MTYgc2xhdmVfYWRkOwo+ICsKPiArCWZsYWcgPSAqZGF0YSsrOwo+ICsJcmVzb3Vy
Y2VfaWQgPSAqZGF0YSsrOwo+ICsJYnVzX251bWJlciA9ICpkYXRhKys7Cj4gKwlzbGF2ZV9hZGQg
PSAqKHUxNiAqKShkYXRhKTsKPiArCWRhdGEgKz0gMjsKPiArCXJlZ19vZmZzZXQgPSAqZGF0YSsr
Owo+ICsJcGF5bG9hZF9zaXplID0gKmRhdGErKzsKPiArCj4gKwlpZiAocmVzb3VyY2VfaWQgPT0g
MHhmZiB8fCBidXNfbnVtYmVyID09IDB4ZmYpIHsKPiArCQlEUk1fREVCVUdfS01TKCJpZ25vcmlu
ZyBnbWJ1cyAocmVzb3VyY2UgaWQgJTAyeCwgYnVzICUwMngpXG4iLAo+ICsJCQkgICAgICByZXNv
dXJjZV9pZCwgYnVzX251bWJlcik7Cj4gKwkJZ290byBvdXQ7Cj4gKwl9Cj4gKwoKU3RpbGwgbWlz
c2luZyB0aGUgY2hlY2sgZm9yIF9faTJjX2ZpcnN0X2R5bmFtaWNfYnVzX251bSB3aGljaCBJIHRo
aW5rCndvdWxkIGF0IGxlYXN0IHByb3ZpZGUgc29tZSBraW5kIG9mIGhhbGYgYXJzZWQgcHJvdGVj
dGlvbiBhZ2FpbnN0CnNvbWV0aGluZyBub3QgcmVnaXN0ZXJpbmcgdGhlc2UgbWFnaWMgaTJjIGJ1
c3Nlcy4KCj4gKwlhZGFwdGVyID0gaTJjX2dldF9hZGFwdGVyKGJ1c19udW1iZXIpOwo+ICsJaWYg
KCFhZGFwdGVyKSB7Cj4gKwkJRFJNX0VSUk9SKCJpMmNfZ2V0X2FkYXB0ZXIoJXUpXG4iLCBidXNf
bnVtYmVyKTsKPiArCQlnb3RvIG91dDsKPiArCX0KPiArCj4gKwl0cmFuc21pdF9idWZmZXIgPSBr
bWFsbG9jKDEgKyBwYXlsb2FkX3NpemUsIEdGUF9URU1QT1JBUlkpOwo+ICsJaWYgKCF0cmFuc21p
dF9idWZmZXIpCj4gKwkJZ290byBvdXRfcHV0Owo+ICsKPiArCXRyYW5zbWl0X2J1ZmZlclswXSA9
IHJlZ19vZmZzZXQ7Cj4gKwltZW1jcHkoJnRyYW5zbWl0X2J1ZmZlclsxXSwgZGF0YSwgcGF5bG9h
ZF9zaXplKTsKPiArCj4gKwltc2cuYWRkciA9IHNsYXZlX2FkZDsKPiArCW1zZy5mbGFncyA9IDA7
Cj4gKwltc2cubGVuID0gcGF5bG9hZF9zaXplICsgMTsKPiArCW1zZy5idWYgPSAmdHJhbnNtaXRf
YnVmZmVyWzBdOwo+ICsKPiArCWZvciAoaSA9IDA7IGkgPCA2OyBpKyspIHsKPiArCQlyZXQgPSBp
MmNfdHJhbnNmZXIoYWRhcHRlciwgJm1zZywgMSk7Cj4gKwkJaWYgKHJldCA9PSAxKSB7Cj4gKwkJ
CWdvdG8gb3V0X2ZyZWU7Cj4gKwkJfSBlbHNlIGlmIChyZXQgPT0gLUVBR0FJTikgewo+ICsJCQl1
c2xlZXBfcmFuZ2UoMTAwMCwgMjUwMCk7Cj4gKwkJfSBlbHNlIHsKPiArCQkJYnJlYWs7Cj4gKwkJ
fQo+ICsJfQo+ICsKPiArCURSTV9FUlJPUigiaTJjIHRyYW5zZmVyIGZhaWxlZDogJWRcbiIsIHJl
dCk7Cj4gK291dF9mcmVlOgo+ICsJa2ZyZWUodHJhbnNtaXRfYnVmZmVyKTsKPiArb3V0X3B1dDoK
PiArCWkyY19wdXRfYWRhcHRlcihhZGFwdGVyKTsKPiArb3V0Ogo+ICsJcmV0dXJuIGRhdGEgKyBw
YXlsb2FkX3NpemU7Cj4gIH0KPiAgCj4gIHR5cGVkZWYgY29uc3QgdTggKiAoKmZuX21pcGlfZWxl
bV9leGVjKShzdHJ1Y3QgaW50ZWxfZHNpICppbnRlbF9kc2ksCj4gQEAgLTI0Niw3ICszMDQsNyBA
QCBzdGF0aWMgY29uc3QgZm5fbWlwaV9lbGVtX2V4ZWMgZXhlY19lbGVtW10gPSB7Cj4gIAlbTUlQ
SV9TRVFfRUxFTV9TRU5EX1BLVF0gPSBtaXBpX2V4ZWNfc2VuZF9wYWNrZXQsCj4gIAlbTUlQSV9T
RVFfRUxFTV9ERUxBWV0gPSBtaXBpX2V4ZWNfZGVsYXksCj4gIAlbTUlQSV9TRVFfRUxFTV9HUElP
XSA9IG1pcGlfZXhlY19ncGlvLAo+IC0JW01JUElfU0VRX0VMRU1fSTJDXSA9IG1pcGlfZXhlY19p
MmNfc2tpcCwKPiArCVtNSVBJX1NFUV9FTEVNX0kyQ10gPSBtaXBpX2V4ZWNfaTJjLAo+ICB9Owo+
ICAKPiAgLyoKPiAtLSAKPiAyLjEuNAo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBs
aXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt
YW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp
bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZy
ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=