From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukas Wunner Subject: Re: [PATCH] drm/i915: Protect fbdev across slow or failed initialisation Date: Fri, 5 Feb 2016 01:27:10 +0100 Message-ID: <20160205002710.GA13964@wunner.de> References: <9BD218709B5F2A4F96F08B4A3B98A897372F1356@SHSMSX104.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailout3.hostsharing.net (mailout3.hostsharing.net [176.9.242.54]) by gabe.freedesktop.org (Postfix) with ESMTPS id 172706E078 for ; Thu, 4 Feb 2016 16:27:03 -0800 (PST) Content-Disposition: inline In-Reply-To: <9BD218709B5F2A4F96F08B4A3B98A897372F1356@SHSMSX104.ccr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Li, Weinan Z" Cc: "intel-gfx@lists.freedesktop.org" , "gustav.fagerlind@gmail.com" List-Id: intel-gfx@lists.freedesktop.org SGksCgpPbiBUaHUsIEZlYiAwNCwgMjAxNiBhdCAwOToyMToxN0FNICswMDAwLCBMaSwgV2VpbmFu IFogd3JvdGU6Cj4gV2Ugc3RpbGwgbmVlZCB0aGlzIHBhdGNoLiBTZWVtcyA1NDYzMmFiZThjYTMg KCJkcm0vaTkxNTogRml4IG9vcHMgY2F1c2VkIGJ5IGZiZGV2IGluaXRpYWxpemF0aW9uCj4gZmFp bHVyZSIpIGFzIHdlbGwgYXMgMzY2ZTM5YjRkMmM1ICgiZHJtL2k5MTU6IFRlYXIgZG93biBmYmRl diBpZgo+IGluaXRpYWxpemF0aW9uIGZhaWxzIikgdGhpcyAyIHBhdGNoZXMgY2FuPz8/dCBjb3Zl ciB0aGlzIGNhc2UuIEl0Pz8/cyBhY2Nlc3MgaWZiZGV2LT5mYiBiZWZvcmUgdGhlIGluaXRpYWxp emF0aW9uCj4gZmluaXNoZWQsIGJ1dCBub3QgaW5pdGlhbGl6YXRpb24gZmFpbGVkLiBJZiBkb24/ Pz90IGhhdmUgYW55IG90aGVyIHBhdGNoZXMgb3IgY29kZSB1cGRhdGUgcmVsYXRpdmUsIGl0IG1h eSBzdGlsbCBoYXZlIGluIDQuNS4KCk9rYXksIEkgc2VlLgoKPiAKPiBhZGQgaW5mbyBOVUxMIGNo ZWNrIHNob3VsZCBiZSBiZXR0ZXIsIGl0IGlzIGFsc28gaW5pdGlhbGl6ZWQgaW4gdGhlIGFzeW5j IHF1ZXVlCj4gPiAgICAgICBpbmZvID0gaWZiZGV2LT5oZWxwZXIuZmJkZXY7Cj4gPiArICAgICBp ZiAoaW5mbyA9PSBOVUxMKQo+ID4gKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKPiA+ICAgICAg IGlmICghaW5mby0+c2NyZWVuX2Jhc2UpCgpTbyBpZiB0aGVyZSdzIGluZGVlZCBhIHJhY2UgYmV0 d2VlbiBmYmRldiBpbml0aWFsaXphdGlvbiBhbmQgdGhlIGNhbGwgdG8KaW50ZWxfZmJkZXZfcmVz dG9yZV9tb2RlKCkgKG9uIGxhc3RjbG9zZSksIHRoZXJlJ3MgbW9yZSB0aGF0IGNhbiBnbyBhd3J5 OgotIGludGVsX2ZiZGV2X3Jlc3RvcmVfbW9kZSgpIGRlcmVmZXJlbmNlcyBpZmJkZXYtPmZiLT5v YmoKLSBpdCBjYWxscyBfX2RybV9hdG9taWNfaGVscGVyX3NldF9jb25maWcoKSB3aGljaCBXQVJO cyBpZiBpZmJkZXYtPmZiIGlzIE5VTEwKLSBpdCBjYWxscyBkcm1fZmJfaGVscGVyX3NldF9wYXIo KSB3aGljaCBkZXJlZmVyZW5jZXMgaWZiZGV2LT5oZWxwZXIuZmJkZXYKCkluc3RlYWQgb2YgY2hl Y2tpbmcgYWxsIHRoYXQgaXQncyBwcm9iYWJseSBzaW1wbGVyIHRvIGNhbGwKYXN5bmNfc3luY2hy b25pemVfZnVsbCgpIGF0IHRoZSBiZWdpbm5pbmcgb2YgaW50ZWxfZmJkZXZfcmVzdG9yZV9tb2Rl KCksCmFzIExpIFdlaW5hbiBzdWdnZXN0ZWQuIEknbGwgc3VibWl0IHRoZSBjb3JyZXNwb25kaW5n IG9uZS1saW5lciBwYXRjaAp0b21vcnJvdyBpZiBub29uZSBlbHNlIGRvZXMuCgpDaHJpcycgcGF0 Y2ggYWxzbyBtb2RpZmllZCBpbnRlbF9mYmRldl9zZXRfc3VzcGVuZCgpIGFzIHdlbGwgYXMKaW50 ZWxfZmJkZXZfb3V0cHV0X3BvbGxfY2hhbmdlZCgpLCBub3Qgc3VyZSBpZiB0aGVzZSBhcmUgcmFj eSBhcyB3ZWxsLgpBdCBsZWFzdCB0aGUgc3RhY2sgdHJhY2VzIHBvc3RlZCBieSBMaSBXZWluYW4g YW5kIEd1c3RhdiBGw6RnZXJsaW5kCm9ubHkgaW5kaWNhdGUgdGhhdCBsYXN0Y2xvc2UgaXMgcmFj eS4KCkJlc3QgcmVnYXJkcywKCkx1a2FzCgo+IEZyb206IExpLCBXZWluYW4gWgo+IFNlbnQ6IFRo dXJzZGF5LCBGZWJydWFyeSAwNCwgMjAxNiAxMDozNCBBTQo+IFRvOiAnZ3VzdGF2LmZhZ2VybGlu ZEBnbWFpbC5jb20nOyBMdWthcyBXdW5uZXIKPiBDYzogQ2hyaXMgV2lsc29uOyBpbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnPG1haWx0bzppbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnPgo+IFN1YmplY3Q6IFJFOiBbSW50ZWwtZ2Z4XSBbUEFUQ0hdIGRybS9pOTE1OiBQcm90ZWN0 IGZiZGV2IGFjcm9zcyBzbG93IG9yIGZhaWxlZCBpbml0aWFsaXNhdGlvbgo+IAo+IFRoYW5rcyBm b3IgeW91ciBxdWljayByZXNwb25zZS4KPiBZZXMgaXQgaXMgbm90IGVhc2lseSBiZSByZXByb2R1 Y2VkIGluIG5hdGl2ZS4gSW4gIGlWR1Qgd2Ugc3RhcnR1cCBzZXZlcmFsIFZNcyAgc2ltdWx0YW5l b3VzbHksIGl0IGNhbiBiZSByZXByb2R1Y2VkIGluIHNldmVyYWwgY3ljbGVzLCB1cG9uIDEvMTAg ZmFpbCByYXRlLgo+IE5lZWQgdG8gdXNlIEdVSSBtb2RlIGJ1dCBub3QgdGV4dCBtb2RlIHRvIHJl cHJvZHVjZSB0aGlzIGlzc3VlLgo+IAo+IEJScywKPiBXZWluYW4gTGkKPiAKPiAKPiBGcm9tOiBH dXN0YXYgRsOkZ2VybGluZCBbbWFpbHRvOmd1c3Rhdi5mYWdlcmxpbmRAZ21haWwuY29tXQo+IFNl bnQ6IFRodXJzZGF5LCBGZWJydWFyeSAwNCwgMjAxNiAxOjA4IEFNCj4gVG86IEx1a2FzIFd1bm5l cgo+IENjOiBDaHJpcyBXaWxzb247IGludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmc8bWFp bHRvOmludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmc+OyBMaSwgV2VpbmFuIFoKPiBTdWJq ZWN0OiBSZTogW0ludGVsLWdmeF0gW1BBVENIXSBkcm0vaTkxNTogUHJvdGVjdCBmYmRldiBhY3Jv c3Mgc2xvdyBvciBmYWlsZWQgaW5pdGlhbGlzYXRpb24KPiAKPiBDb29sLCB0aGFuayB5b3UuCj4g SSBkb250IGJlbGlldmUgSSBjYW4gZWFzaWx5IHJlcHJvZHVjZSBpdCwgaXQgaGFzIG9ubHkgaGFw cGVuZCBmZXcgdGltZXMgKGFuZCBpIHJlYm9vdCBteSBsYXBweSA+MiB0aW1lcyBwZXIgZGF5KS4K PiAKPiAvLwo+IEd1c3Rhdgo+IAo+IDIwMTYtMDItMDMgMTQ6MjUgR01UKzAxOjAwIEx1a2FzIFd1 bm5lciA8bHVrYXNAd3VubmVyLmRlPG1haWx0bzpsdWthc0B3dW5uZXIuZGU+PjoKPiBIaSwKPiAK PiBPbiBXZWQsIEZlYiAwMywgMjAxNiBhdCAwOToxNzozN0FNICswMDAwLCBDaHJpcyBXaWxzb24g d3JvdGU6Cj4gPiBJZiB0aGUgaW5pdGlhbGlzYXRpb24gZmFpbHMsIHdlIG1heSBiZSBsZWZ0IHdp dGggYSBkYW5nbGluZyBwb2ludGVyIHdpdGgKPiA+IGFuIGluY29tcGxldGUgZmJkZXYgc3RydWN0 dXJlLgo+IAo+IFRoaXMgc2hvdWxkbid0IGhhcHBlbiB3aXRoIDQuNSwgdGhlIGZiZGV2IGlzIG5v dyBjbG9iYmVyZWQgaWYgaW5pdGlhbGl6YXRpb24KPiBmYWlscywgdGhlIGV4aXN0aW5nICJpZiAo ZGV2X3ByaXYtPmZiZGV2KSIgY2hlY2tzIHNob3VsZCB0aHVzIGJlIHN1ZmZpY2llbnQuCj4gU2Vl IDU0NjMyYWJlOGNhMyAoImRybS9pOTE1OiBGaXggb29wcyBjYXVzZWQgYnkgZmJkZXYgaW5pdGlh bGl6YXRpb24KPiBmYWlsdXJlIikgYXMgd2VsbCBhcyAzNjZlMzliNGQyYzUgKCJkcm0vaTkxNTog VGVhciBkb3duIGZiZGV2IGlmCj4gaW5pdGlhbGl6YXRpb24gZmFpbHMiKS4KPiAKPiBHdXN0YXYg RmFnZXJsaW5kIGFuZCBMaSBXZWluYW4gYm90aCByZXBvcnRlZCB0aGlzIGZvciA0LjMuIEl0IHdv dWxkIGJlCj4gaW50ZXJlc3RpbmcgdG8ga25vdyBpZiBpdCBjYW4gYmUgcmVwcm9kdWNlZCBhdCBh bGwgd2l0aCA0LjUtcmMyLgo+IAo+IEJlc3QgcmVnYXJkcywKPiAKPiBMdWthcwo+IAo+ID4gSGVy ZSB3ZSB3YW50IHRvIGRpc2FibGUgaW50ZXJuYWwgY2FsbHMKPiA+IGludG8gZmJkZXYuIFNpbWls YXJseSwgdGhlIGluaXRpYWxpc2F0aW9uIG1heSBiZSBzbG93IGFuZCB3ZSBoYXZlbid0IHlldAo+ ID4gZW5hYmxlZCB0aGUgZmJkZXYgKGUuZy4gcXVpY2sgc3VzcGVuZCBvciBsYXN0LWNsb3NlIGJl Zm9yZSB0aGUgYXN5bmMgaW5pdAo+ID4gY29tcGxldGVzKS4KPiA+Cj4gPiBCdWd6aWxsYTogaHR0 cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTM1ODAKPiA+IFJlcG9y dGVkLWJ5OiAiTGksIFdlaW5hbiBaIiA8d2VpbmFuLnoubGlAaW50ZWwuY29tPG1haWx0bzp3ZWlu YW4uei5saUBpbnRlbC5jb20+Pgo+ID4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJp c0BjaHJpcy13aWxzb24uY28udWs8bWFpbHRvOmNocmlzQGNocmlzLXdpbHNvbi5jby51az4+Cj4g PiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmRldi5jIHwgNDEgKysrKysr KysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMjYg aW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRpb25zKC0pCj4gPgo+ID4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiZGV2LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9mYmRldi5jCj4gPiBpbmRleCAwOTg0MGY0MzgwZjkuLjYyMThiYzUzNzBhMSAxMDA2NDQKPiA+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiZGV2LmMKPiA+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiZGV2LmMKPiA+IEBAIC0xMTQsNiArMTE0LDIwIEBAIHN0 YXRpYyBzdHJ1Y3QgZmJfb3BzIGludGVsZmJfb3BzID0gewo+ID4gICAgICAgLmZiX2RlYnVnX2xl YXZlID0gZHJtX2ZiX2hlbHBlcl9kZWJ1Z19sZWF2ZSwKPiA+ICB9Owo+ID4KPiA+ICtzdGF0aWMg Ym9vbCBpbnRlbF9mYmRldl9hY3RpdmUoc3RydWN0IGludGVsX2ZiZGV2ICppZmJkZXYpCj4gPiAr ewo+ID4gKyAgICAgc3RydWN0IGZiX2luZm8gKmluZm87Cj4gPiArCj4gPiArICAgICBpZiAoaWZi ZGV2ID09IE5VTEwpCj4gPiArICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKPiA+ICsKPiA+ICsg ICAgIGluZm8gPSBpZmJkZXYtPmhlbHBlci5mYmRldjsKPiA+ICsgICAgIGlmICghaW5mby0+c2Ny ZWVuX2Jhc2UpCj4gPiArICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKPiA+ICsKPiA+ICsgICAg IHJldHVybiBpbmZvLT5zdGF0ZSA9PSBGQklORk9fU1RBVEVfUlVOTklORzsKPiA+ICt9Cj4gPiAr Cj4gPiAgc3RhdGljIGludCBpbnRlbGZiX2FsbG9jKHN0cnVjdCBkcm1fZmJfaGVscGVyICpoZWxw ZXIsCj4gPiAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBkcm1fZmJfaGVscGVyX3N1cmZh Y2Vfc2l6ZSAqc2l6ZXMpCj4gPiAgewo+ID4gQEAgLTc1Myw2ICs3NjcsOCBAQCB2b2lkIGludGVs X2ZiZGV2X3NldF9zdXNwZW5kKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIGludCBzdGF0ZSwgYm9v bCBzeW5jaHJvbm91cwo+ID4gICAgICAgICAgICAgICByZXR1cm47Cj4gPgo+ID4gICAgICAgaW5m byA9IGlmYmRldi0+aGVscGVyLmZiZGV2Owo+ID4gKyAgICAgaWYgKCFpbmZvLT5zY3JlZW5fYmFz ZSkKPiA+ICsgICAgICAgICAgICAgcmV0dXJuOwo+ID4KPiA+ICAgICAgIGlmIChzeW5jaHJvbm91 cykgewo+ID4gICAgICAgICAgICAgICAvKiBGbHVzaCBhbnkgcGVuZGluZyB3b3JrIHRvIHR1cm4g dGhlIGNvbnNvbGUgb24sIGFuZCB0aGVuCj4gPiBAQCAtNzk0LDI5ICs4MTAsMjQgQEAgdm9pZCBp bnRlbF9mYmRldl9zZXRfc3VzcGVuZChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBpbnQgc3RhdGUs IGJvb2wgc3luY2hyb25vdXMKPiA+Cj4gPiAgdm9pZCBpbnRlbF9mYmRldl9vdXRwdXRfcG9sbF9j aGFuZ2VkKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gPiAgewo+ID4gLSAgICAgc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiA+IC0gICAgIGlm IChkZXZfcHJpdi0+ZmJkZXYpCj4gPiArICAgICBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYgPSB0b19pOTE1KGRldik7Cj4gPiArCj4gPiArICAgICBpZiAoaW50ZWxfZmJkZXZfYWN0 aXZlKGRldl9wcml2LT5mYmRldikpCj4gPiAgICAgICAgICAgICAgIGRybV9mYl9oZWxwZXJfaG90 cGx1Z19ldmVudCgmZGV2X3ByaXYtPmZiZGV2LT5oZWxwZXIpOwo+ID4gIH0KPiA+Cj4gPiAgdm9p ZCBpbnRlbF9mYmRldl9yZXN0b3JlX21vZGUoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiA+ICB7 Cj4gPiAtICAgICBpbnQgcmV0Owo+ID4gLSAgICAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiA+IC0gICAgIHN0cnVjdCBpbnRlbF9mYmRldiAq aWZiZGV2ID0gZGV2X3ByaXYtPmZiZGV2Owo+ID4gLSAgICAgc3RydWN0IGRybV9mYl9oZWxwZXIg KmZiX2hlbHBlcjsKPiA+ICsgICAgIHN0cnVjdCBpbnRlbF9mYmRldiAqaWZiZGV2ID0gdG9faTkx NShkZXYpLT5mYmRldjsKPiA+Cj4gPiAtICAgICBpZiAoIWlmYmRldikKPiA+ICsgICAgIGlmICgh aW50ZWxfZmJkZXZfYWN0aXZlKGlmYmRldikpCj4gPiAgICAgICAgICAgICAgIHJldHVybjsKPiA+ Cj4gPiAtICAgICBmYl9oZWxwZXIgPSAmaWZiZGV2LT5oZWxwZXI7Cj4gPiAtCj4gPiAtICAgICBy ZXQgPSBkcm1fZmJfaGVscGVyX3Jlc3RvcmVfZmJkZXZfbW9kZV91bmxvY2tlZChmYl9oZWxwZXIp Owo+ID4gLSAgICAgaWYgKHJldCkgewo+ID4gLSAgICAgICAgICAgICBEUk1fREVCVUcoImZhaWxl ZCB0byByZXN0b3JlIGNydGMgbW9kZVxuIik7Cj4gPiAtICAgICB9IGVsc2Ugewo+ID4gLSAgICAg ICAgICAgICBtdXRleF9sb2NrKCZmYl9oZWxwZXItPmRldi0+c3RydWN0X211dGV4KTsKPiA+ICsg ICAgIGlmIChkcm1fZmJfaGVscGVyX3Jlc3RvcmVfZmJkZXZfbW9kZV91bmxvY2tlZCgmaWZiZGV2 LT5oZWxwZXIpID09IDApIHsKPiA+ICsgICAgICAgICAgICAgbXV0ZXhfbG9jaygmZGV2LT5zdHJ1 Y3RfbXV0ZXgpOwo+ID4gICAgICAgICAgICAgICBpbnRlbF9mYl9vYmpfaW52YWxpZGF0ZShpZmJk ZXYtPmZiLT5vYmosIE9SSUdJTl9HVFQpOwo+ID4gLSAgICAgICAgICAgICBtdXRleF91bmxvY2so JmZiX2hlbHBlci0+ZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ID4gKyAgICAgICAgICAgICBtdXRleF91 bmxvY2soJmRldi0+c3RydWN0X211dGV4KTsKPiA+ICsgICAgIH0gZWxzZSB7Cj4gPiArICAgICAg ICAgICAgIERSTV9ERUJVRygiZmFpbGVkIHRvIHJlc3RvcmUgY3J0YyBtb2RlXG4iKTsKPiA+ICAg ICAgIH0KPiA+ICB9Cj4gPiAtLQo+ID4gMi43LjAKPiA+Cj4gPiBfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+ ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZzxtYWlsdG86SW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZz4KPiA+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngKPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK