From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v4 2/6] drm/i915: tidy up initialisation failure paths (GEM & LRC) Date: Thu, 11 Feb 2016 09:47:15 +0100 Message-ID: <20160211084715.GH11240@phenom.ffwll.local> References: <1454095171-22475-1-git-send-email-david.s.gordon@intel.com> <1454095171-22475-3-git-send-email-david.s.gordon@intel.com> <20160130105627.GQ24534@nuc-i3427.alporthouse.com> <20160130112818.GV24534@nuc-i3427.alporthouse.com> <56AF2935.1040409@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by gabe.freedesktop.org (Postfix) with ESMTPS id CACA46E272 for ; Thu, 11 Feb 2016 00:46:51 -0800 (PST) Received: by mail-wm0-f54.google.com with SMTP id p63so62309678wmp.1 for ; Thu, 11 Feb 2016 00:46:51 -0800 (PST) Content-Disposition: inline In-Reply-To: <56AF2935.1040409@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBGZWIgMDEsIDIwMTYgYXQgMDk6NDU6MjVBTSArMDAwMCwgRGF2ZSBHb3Jkb24gd3Jv dGU6Cj4gT24gMzAvMDEvMTYgMTE6MjgsIENocmlzIFdpbHNvbiB3cm90ZToKPiA+T24gU2F0LCBK YW4gMzAsIDIwMTYgYXQgMTA6NTY6MjdBTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdyb3RlOgo+ID4+ T24gRnJpLCBKYW4gMjksIDIwMTYgYXQgMDc6MTk6MjdQTSArMDAwMCwgRGF2ZSBHb3Jkb24gd3Jv dGU6Cj4gPj4+MS4gYWRkIGNhbGwgdG8gaTkxNV9nZW1fY29udGV4dF9maW5pKCkgdG8gZGVhbGxv Y2F0ZSB0aGUgZGVmYXVsdAo+ID4+PiAgICBjb250ZXh0KHMpIGlmIHRoZSBjYWxsIHRvIGluaXRf cmluZ3MoKSBmYWlscywgc28gdGhhdCB3ZSBkb24ndAo+ID4+PiAgICBsZWFrIHRoZSBjb250ZXh0 IGluIHRoYXQgc2l0dWF0aW9uLgo+ID4+Pgo+ID4+PjIuIHJlbW92ZSB1c2VsZXNzIGNvZGUgaW4g aW50ZWxfbG9naWNhbF9yaW5nX2NsZWFudXAoKSwgcHJlc3VtYWJseQo+ID4+PiAgICBjb3B5cGFz dGVkIGZyb20gbGVnYWN5IHJpbmdidWZmZXIgdmVyc2lvbiBhdCBjcmVhdGlvbi4KPiA+Pj4KCklm IHlvdXIgY29tbWl0IG1lc3NhZ2UgaGFzIGEgbGlzdCBvZiBpbmRlcGVuZGVudCBjaGFuZ2VzIC4u LgoKPiA+Pj5TaWduZWQtb2ZmLWJ5OiBEYXZlIEdvcmRvbiA8ZGF2aWQucy5nb3Jkb25AaW50ZWwu Y29tPgo+ID4+Pi0tLQo+ID4+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyAgfCAg NSArKysrLQo+ID4+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgfCAxMCArKy0t LS0tLS0tCj4gPj4+ICAyIGZpbGVzIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlv bnMoLSkKPiA+Pj4KPiA+Pj5kaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9n ZW0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiA+Pj5pbmRleCBhOTI4ODIz Li41YTRkNDY4IDEwMDY0NAo+ID4+Pi0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2Vt LmMKPiA+Pj4rKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gPj4+QEAgLTQ5 ODYsOCArNDk4NiwxMSBAQCBpbnQgaTkxNV9nZW1faW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 KQo+ID4+PiAgCQlnb3RvIG91dF91bmxvY2s7Cj4gPj4+Cj4gPj4+ICAJcmV0ID0gZGV2X3ByaXYt Pmd0LmluaXRfcmluZ3MoZGV2KTsKPiA+Pj4tCWlmIChyZXQpCj4gPj4+KwlpZiAocmV0KSB7Cj4g Pj4+KwkJaTkxNV9nZW1fY29udGV4dF9maW5pKGRldik7Cj4gPj4+KwkJLyogWFhYOiBhbnl0aGlu ZyBlbHNlIHRvIGJlIHVuZG9uZSBoZXJlPyAqLwo+ID4+Cj4gPj5ZZXMuIE1ha2UgdGhpcyBhIHNl cGFyYXRlIHBhdGNoIGFuZCBiZWdpbiB0aGUgb25pb24gdW53aW5kLgo+ID4KPiA+SG1tLiBBY3R1 YWxseSwgd2UgaGF2ZSB0byBtYWtlIHN1cmUgdGhhdCB3ZSBjYW4gc3RpbGwgbW9kZXNldCBpZiB0 aGlzCj4gPmZ1bmN0aW9uIGZhaWxzIC0gdGhhdCBpcyBhbnl0aGluZyBidXQgdXR0ZXIgY2F0YXN0 cm9waGUgc2hvdWxkIGp1c3QKPiA+cmVzdWx0IGluIGxvc3Mgb2YgZnVuY3Rpb25hbGl0eSAobm8g c3RvbGVuLCBubyBHRU0gZXhlY3V0aW9uIGV0YykgYnV0IHdlCj4gPmNhbiBzdGlsbCBkcml2ZSB0 aGUgZGlzcGxheXMgc28gdGhlIHVzZXIgY2FuIHNlZSBob3cgYmFkIHRoZSBkYW1hZ2UgaXMuCj4g Pi1DaHJpcwo+IAo+IFllcywgTWlrYSBzYWlkIHRoYXQncyB3aHkgKGhlIHRob3VnaHQpIHRoZXJl IHdhc24ndCBhIGNvbXBsZXRlIHJldmVyc2FsIG9mCj4gZXZlcnl0aGluZyB0aGUgZHJpdmVyIGhh cyBkb25lIHVwIHRvIHRoaXMgcG9pbnQuCj4gCj4gVGhlIGFkZGl0aW9uIG9mIHRoZSBjb250ZXh0 X2ZpbmkoKSBzZWVtcyByZWFzb25hYmxlLCB0aGF0J3MgZ29pbmcgdG8gbWFrZSBpdAo+IGxlYWsg YSBiaXQgbGVzcywgd2hpbGUgc3RpbGwgbGVhdmluZyBiYXNpYyBmcmFtZWJ1ZmZlciB3b3JraW5n Lgo+IAo+IENvdWxkIGJlIGEgc2VwYXJhdGUgcGF0Y2ggaWYgeW91IGxpa2UsIGJ1dCBoYXJkbHkg c2VlbXMgd29ydGggc3BsaXR0aW5nIGZyb20KPiB0aGUgb3RoZXIgY2h1bmssIHdoaWNoIGFmdGVy IGFsbCBvbmx5IHJlcGxhY2VzIHVucmVhY2hhYmxlIGNvZGUgd2l0aCBhCj4gV0FSTmluZy4KCi4u LiBpdCBzaG91bGQgYmUgc3BsaXQuIEFzIGEgcnVsZSBvZiB0aHVtYiBhdCBsZWFzdC4gSSBkb24n dCByZWFsbHkgY2FyZQphbGwgdGhhdCBtdWNoIGhlcmUgdGhvdWdoLCBzbyBqdXQgZm9yIHRoZSBm dXR1cmUuCi1EYW5pZWwKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVs IENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=