From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Protect fbdev across slow or failed initialisation Date: Mon, 15 Feb 2016 17:32:51 +0100 Message-ID: <20160215163251.GR11240@phenom.ffwll.local> References: <9BD218709B5F2A4F96F08B4A3B98A897372F1356@SHSMSX104.ccr.corp.intel.com> <20160205002710.GA13964@wunner.de> <20160205110927.GG7134@nuc-i3427.alporthouse.com> <20160205145831.GA14084@wunner.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by gabe.freedesktop.org (Postfix) with ESMTPS id B247E6E1B6 for ; Mon, 15 Feb 2016 16:32:25 +0000 (UTC) Received: by mail-wm0-f48.google.com with SMTP id a4so63478486wme.1 for ; Mon, 15 Feb 2016 08:32:25 -0800 (PST) Content-Disposition: inline In-Reply-To: <20160205145831.GA14084@wunner.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lukas Wunner Cc: "intel-gfx@lists.freedesktop.org" , "Li, Weinan Z" , "gustav.fagerlind@gmail.com" List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBGZWIgMDUsIDIwMTYgYXQgMDM6NTg6MzFQTSArMDEwMCwgTHVrYXMgV3VubmVyIHdy b3RlOgo+IEhpIENocmlzLAo+IAo+IE9uIEZyaSwgRmViIDA1LCAyMDE2IGF0IDExOjA5OjI3QU0g KzAwMDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiA+IE9uIEZyaSwgRmViIDA1LCAyMDE2IGF0IDAx OjI3OjEwQU0gKzAxMDAsIEx1a2FzIFd1bm5lciB3cm90ZToKPiA+ID4gT24gVGh1LCBGZWIgMDQs IDIwMTYgYXQgMDk6MjE6MTdBTSArMDAwMCwgTGksIFdlaW5hbiBaIHdyb3RlOgo+ID4gPiA+IFdl IHN0aWxsIG5lZWQgdGhpcyBwYXRjaC4gU2VlbXMgNTQ2MzJhYmU4Y2EzICgiZHJtL2k5MTU6IEZp eCBvb3BzIGNhdXNlZCBieSBmYmRldiBpbml0aWFsaXphdGlvbgo+ID4gPiA+IGZhaWx1cmUiKSBh cyB3ZWxsIGFzIDM2NmUzOWI0ZDJjNSAoImRybS9pOTE1OiBUZWFyIGRvd24gZmJkZXYgaWYKPiA+ ID4gPiBpbml0aWFsaXphdGlvbiBmYWlscyIpIHRoaXMgMiBwYXRjaGVzIGNhbj8/P3QgY292ZXIg dGhpcyBjYXNlLiBJdD8/P3MgYWNjZXNzIGlmYmRldi0+ZmIgYmVmb3JlIHRoZSBpbml0aWFsaXph dGlvbgo+ID4gPiA+IGZpbmlzaGVkLCBidXQgbm90IGluaXRpYWxpemF0aW9uIGZhaWxlZC4gSWYg ZG9uPz8/dCBoYXZlIGFueSBvdGhlciBwYXRjaGVzIG9yIGNvZGUgdXBkYXRlIHJlbGF0aXZlLCBp dCBtYXkgc3RpbGwgaGF2ZSBpbiA0LjUuCj4gPiA+IAo+ID4gPiBPa2F5LCBJIHNlZS4KPiA+ID4g Cj4gPiA+ID4gCj4gPiA+ID4gYWRkIGluZm8gTlVMTCBjaGVjayBzaG91bGQgYmUgYmV0dGVyLCBp dCBpcyBhbHNvIGluaXRpYWxpemVkIGluIHRoZSBhc3luYyBxdWV1ZQo+ID4gPiA+ID4gICAgICAg aW5mbyA9IGlmYmRldi0+aGVscGVyLmZiZGV2Owo+ID4gPiA+ID4gKyAgICAgaWYgKGluZm8gPT0g TlVMTCkKPiA+ID4gPiA+ICsgICAgICAgICAgICByZXR1cm4gZmFsc2U7Cj4gPiA+ID4gPiAgICAg ICBpZiAoIWluZm8tPnNjcmVlbl9iYXNlKQo+ID4gPiAKPiA+ID4gU28gaWYgdGhlcmUncyBpbmRl ZWQgYSByYWNlIGJldHdlZW4gZmJkZXYgaW5pdGlhbGl6YXRpb24gYW5kIHRoZSBjYWxsIHRvCj4g PiA+IGludGVsX2ZiZGV2X3Jlc3RvcmVfbW9kZSgpIChvbiBsYXN0Y2xvc2UpLCB0aGVyZSdzIG1v cmUgdGhhdCBjYW4gZ28gYXdyeToKPiA+ID4gLSBpbnRlbF9mYmRldl9yZXN0b3JlX21vZGUoKSBk ZXJlZmVyZW5jZXMgaWZiZGV2LT5mYi0+b2JqCj4gPiA+IC0gaXQgY2FsbHMgX19kcm1fYXRvbWlj X2hlbHBlcl9zZXRfY29uZmlnKCkgd2hpY2ggV0FSTnMgaWYgaWZiZGV2LT5mYiBpcyBOVUxMCj4g PiA+IC0gaXQgY2FsbHMgZHJtX2ZiX2hlbHBlcl9zZXRfcGFyKCkgd2hpY2ggZGVyZWZlcmVuY2Vz IGlmYmRldi0+aGVscGVyLmZiZGV2Cj4gPiA+IAo+ID4gPiBJbnN0ZWFkIG9mIGNoZWNraW5nIGFs bCB0aGF0IGl0J3MgcHJvYmFibHkgc2ltcGxlciB0byBjYWxsCj4gPiA+IGFzeW5jX3N5bmNocm9u aXplX2Z1bGwoKSBhdCB0aGUgYmVnaW5uaW5nIG9mIGludGVsX2ZiZGV2X3Jlc3RvcmVfbW9kZSgp LAo+ID4gPiBhcyBMaSBXZWluYW4gc3VnZ2VzdGVkLiBJJ2xsIHN1Ym1pdCB0aGUgY29ycmVzcG9u ZGluZyBvbmUtbGluZXIgcGF0Y2gKPiA+ID4gdG9tb3Jyb3cgaWYgbm9vbmUgZWxzZSBkb2VzLgo+ ID4gPiAKPiA+ID4gQ2hyaXMnIHBhdGNoIGFsc28gbW9kaWZpZWQgaW50ZWxfZmJkZXZfc2V0X3N1 c3BlbmQoKSBhcyB3ZWxsIGFzCj4gPiA+IGludGVsX2ZiZGV2X291dHB1dF9wb2xsX2NoYW5nZWQo KSwgbm90IHN1cmUgaWYgdGhlc2UgYXJlIHJhY3kgYXMgd2VsbC4KPiA+ID4gQXQgbGVhc3QgdGhl IHN0YWNrIHRyYWNlcyBwb3N0ZWQgYnkgTGkgV2VpbmFuIGFuZCBHdXN0YXYgRsOkZ2VybGluZAo+ ID4gPiBvbmx5IGluZGljYXRlIHRoYXQgbGFzdGNsb3NlIGlzIHJhY3kuCj4gPiAKPiA+IFdlIGNh bGxlZCBzZXQtc3VzcGVuZCBpbnRlcm5hbGx5LCBidXQgd2UgZG9uJ3QgZG8gYW55IGNoZWNrcyBi ZWZvcmUKPiA+IGhhbmQuIEkgd2FzIGNvbmNlcm5lZCB3ZSBtYXkgYmUgYWJsZSB0byBnZXQgaW50 byBhIHNpdHVhdGlvbiB3aGVyZQo+ID4gLmZiX3Byb2JlIGZhaWxzIGFuZCBsZWF2ZXMgYSBkYW5n bGluZyBkZXZfcHJpdi0+aWZiZGV2IGZvciB3aGljaCB3ZQo+ID4gd291bGQgdGhlbiB0cmlwIG92 ZXIgdGhlIE5VTEwgaW5mby0+c2NyZWVuX2Jhc2UuIFNvIEkgd2FzIGxvb2tpbmcgZm9yIGEKPiA+ IHN1aXRhYmxlIGd1YXJkLgo+IAo+IFllcywgbG9va2luZyBhdCB0aGlzIHdpdGggYSBmcmVzaCBw YWlyIG9mIGV5ZWJhbGxzIEkgdGhpbmsgeW91IHdlcmUKPiB0b3RhbGx5IHJpZ2h0LCBpOTE1X3Bt X29wcyBpcyBkZWNsYXJlZCBhcyBwYXJ0IG9mIGk5MTVfcGNpX2RyaXZlciBhbmQKPiBpdCBtaWdo dCBpbmRlZWQgaGFwcGVuIHRoYXQgaTkxNV9wbV9zdXNwZW5kKCkgaXMgY2FsbGVkIGJlZm9yZSB0 aGUgZmJkZXYKPiBpcyBmdWxseSBpbml0aWFsaXplZC4KPiAKPiBBcyBmb3IgaW50ZWxfZmJkZXZf b3V0cHV0X3BvbGxfY2hhbmdlZCgpLCB0aGVyZSdzIGV2ZW4gYSBjb21tZW50IGluCj4gaTkxNV9s b2FkX21vZGVzZXRfaW5pdCgpIHN0YXRpbmcgdGhhdCBob3RwbHVnIGV2ZW50cyBtaWdodCBvY2N1 cgo+IGR1cmluZyBmZGJldiBpbml0aWFsIGNvbmZpZy4KPiAKPiBCZWxvdyBwYXRjaCBhZGRzIHRo ZSByZXF1aXNpdGUgYXN5bmNfc3luY2hyb25pemVfZnVsbCgpIHRvIHRoZSB0aHJlZQo+IGZ1bmN0 aW9ucyB0aGF0IHlvdSBhbHNvIG1vZGlmaWVkIGFuZCB1cGRhdGVzIHRoYXQgY29tbWVudC4KPiAK PiBIb3dldmVyIEFGQUlDVCBhIGNvcm5lciBjYXNlIHJlbWFpbnMgd2hlcmUgd2UncmUgc3RpbGwg dnVsbmVyYWJsZSB0byByYWNlczoKPiBhc3luY19zY2hlZHVsZSgpIHJ1bnMgc3luY2hyb25vdXNs eSAiaWYgd2UncmUgb3V0IG9mIG1lbW9yeSBvciBpZiB0aGVyZSdzCj4gdG9vIG11Y2ggd29yayBw ZW5kaW5nIGFscmVhZHkiIChzZWUgX19hc3luY19zY2hlZHVsZSgpIGluIGtlcm5lbC9hc3luYy5j KS4KPiBJbiB0aGlzIGNhc2Ugbm8gZW50cnkgaXMgYWRkZWQgdG8gdGhlIHBlbmRpbmcgbGlzdCBh bmQKPiBhc3luY19zeW5jaHJvbml6ZV9mdWxsKCkgbWlnaHQgdGhlb3JldGljYWxseSByZXR1cm4g YmVmb3JlIHRoZSBzeW5jaHJvbm91c2x5Cj4gZXhlY3V0ZWQgZnVuY3Rpb24gaGFzIGZpbmlzaGVk Lgo+IAo+IFRoZSBleGlzdGluZyBjYWxsIHRvIGFzeW5jX3N5bmNocm9uaXplX2Z1bGwoKSBpbiBp bnRlbF9mYmRldl9maW5pKCkKPiBzZWVtcyB0byBiZSBzdXNjZXB0aWJsZSB0byB0aGUgc2FtZSBy YWNlIGNvbmRpdGlvbiwgYnV0IGl0J3MgcHJvYmFibHkKPiB2ZXJ5IGhhcmQgdG8gdHJpZ2dlciBp dC4gKFVubG9hZCB0aGUgbW9kdWxlIGJlZm9yZSB0aGUgZmJkZXYgaXMgZnVsbHkKPiBpbml0aWFs aXplZC4pCj4gCj4gVG8gbWFrZSBpdCBidWxsZXQgcHJvb2Ygd2UgY291bGQgZGVjbGFyZSBhIGNv bXBsZXRpb24gaW4gaW50ZWxfZmJkZXYuYwo+IGFuZCB3YWl0IGZvciB0aGF0IGluc3RlYWQuIE9w aW5pb25zPwo+IAo+IFRoYW5rcywKPiAKPiBMdWthcwo+IAo+IC0tID44IC0tCj4gCj4gU3ViamVj dDogW1BBVENIXSBkcm0vaTkxNTogRml4IHJhY2VzIG9uIGZiZGV2Cj4gCj4gVGhlIC0+bGFzdGNs b3NlIGNhbGxiYWNrIGludm9rZXMgaW50ZWxfZmJkZXZfcmVzdG9yZV9tb2RlKCkgYW5kIGhhcwo+ IGJlZW4gd2l0bmVzc2VkIHRvIHJ1biBiZWZvcmUgaW50ZWxfZmJkZXZfaW5pdGlhbF9jb25maWdf YXN5bmMoKQo+IGhhcyBmaW5pc2hlZC4KPiAKPiBXZSBtaWdodCBsaWtld2lzZSByZWNlaXZlIGhv dHBsdWcgZXZlbnRzIG9yIGJlIHN1c3BlbmRlZCBiZWZvcmUKPiB3ZSd2ZSBoYWQgYSBjaGFuY2Ug dG8gZnVsbHkgc2V0IHVwIHRoZSBmYmRldi4KPiAKPiBGaXggYnkgd2FpdGluZyBmb3IgdGhlIGFz eW5jaHJvbm91cyB0aHJlYWQgdG8gZmluaXNoLgo+IAo+IEJ1Z3ppbGxhOiBodHRwczovL2J1Z3Mu ZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD05MzU4MAo+IFJlcG9ydGVkLWJ5OiBHdXN0 YXYgRsOD4oKsZ2VybGluZCA8Z3VzdGF2LmZhZ2VybGluZEBnbWFpbC5jb20+Cj4gUmVwb3J0ZWQt Ynk6ICJMaSwgV2VpbmFuIFoiIDx3ZWluYW4uei5saUBpbnRlbC5jb20+Cj4gQ2M6IENocmlzIFdp bHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBzdGFibGVAdmdlci5rZXJuZWwu b3JnCj4gU2lnbmVkLW9mZi1ieTogTHVrYXMgV3VubmVyIDxsdWthc0B3dW5uZXIuZGU+CgpDYW4g eW91IHBscyByZXN1Ym1pdCB0aGlzIHBhdGNoIHN0YW5kLWFsb25lPyBQYXRjaHdvcmsgKGFuZCB0 aGVyZWZvcmUgQ0kpCndvbid0IHBpY2sgdXAgaW5saW5lZCBwYXRjaGVzIGxpa2UgdGhpcyBvbmUg aGVyZSB1bmZvcnR1bmF0ZWx5LgoKVGhhbmtzLCBEYW5pZWwKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZG1hLmMgICAgfCA4ICsrKy0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2ZiZGV2LmMgfCA0ICsrKysKPiAgMiBmaWxlcyBjaGFuZ2VkLCA3IGluc2VydGlv bnMoKyksIDUgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZG1hLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RtYS5jCj4gaW5kZXgg YTBmNTY1OS4uYTc2YjUyOCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2RtYS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kbWEuYwo+IEBAIC00Mzcs MTEgKzQzNyw5IEBAIHN0YXRpYyBpbnQgaTkxNV9sb2FkX21vZGVzZXRfaW5pdChzdHJ1Y3QgZHJt X2RldmljZSAqZGV2KQo+ICAJICogU29tZSBwb3J0cyByZXF1aXJlIGNvcnJlY3RseSBzZXQtdXAg aHBkIHJlZ2lzdGVycyBmb3IgZGV0ZWN0aW9uIHRvCj4gIAkgKiB3b3JrIHByb3Blcmx5IChsZWFk aW5nIHRvIGdob3N0IGNvbm5lY3RlZCBjb25uZWN0b3Igc3RhdHVzKSwgZS5nLiBWR0EKPiAgCSAq IG9uIGdtNDUuICBIZW5jZSB3ZSBjYW4gb25seSBzZXQgdXAgdGhlIGluaXRpYWwgZmJkZXYgY29u ZmlnIGFmdGVyIGhwZAo+IC0JICogaXJxcyBhcmUgZnVsbHkgZW5hYmxlZC4gTm93IHdlIHNob3Vs ZCBzY2FuIGZvciB0aGUgaW5pdGlhbCBjb25maWcKPiAtCSAqIG9ubHkgb25jZSBob3RwbHVnIGhh bmRsaW5nIGlzIGVuYWJsZWQsIGJ1dCBkdWUgdG8gc2NyZXdlZC11cCBsb2NraW5nCj4gLQkgKiBh cm91bmQga21zL2ZiZGV2IGluaXQgd2UgY2FuJ3QgcHJvdGVjdCB0aGUgZmRiZXYgaW5pdGlhbCBj b25maWcKPiAtCSAqIHNjYW5uaW5nIGFnYWluc3QgaG90cGx1ZyBldmVudHMuIEhlbmNlIGRvIHRo aXMgZmlyc3QgYW5kIGlnbm9yZSB0aGUKPiAtCSAqIHRpbnkgd2luZG93IHdoZXJlIHdlIHdpbGwg bG9vc2UgaG90cGx1ZyBub3RpZmFjdGlvbnMuCj4gKwkgKiBpcnFzIGFyZSBmdWxseSBlbmFibGVk LiBXZSBwcm90ZWN0IHRoZSBmYmRldiBpbml0aWFsIGNvbmZpZyBzY2FubmluZwo+ICsJICogYWdh aW5zdCBob3RwbHVnIGV2ZW50cyBieSB3YWl0aW5nIGluIGludGVsX2ZiZGV2X291dHB1dF9wb2xs X2NoYW5nZWQKPiArCSAqIHVudGlsIHRoZSBhc3luY2hyb25vdXMgdGhyZWFkIGhhcyBmaW5pc2hl ZC4KPiAgCSAqLwo+ICAJaW50ZWxfZmJkZXZfaW5pdGlhbF9jb25maWdfYXN5bmMoZGV2KTsKPiAg Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiZGV2LmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmRldi5jCj4gaW5kZXggMDk4NDBmNC4uMjAwMmIxMyAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmRldi5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJkZXYuYwo+IEBAIC03NDksNiArNzQ5LDcgQEAg dm9pZCBpbnRlbF9mYmRldl9zZXRfc3VzcGVuZChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBpbnQg c3RhdGUsIGJvb2wgc3luY2hyb25vdXMKPiAgCXN0cnVjdCBpbnRlbF9mYmRldiAqaWZiZGV2ID0g ZGV2X3ByaXYtPmZiZGV2Owo+ICAJc3RydWN0IGZiX2luZm8gKmluZm87Cj4gIAo+ICsJYXN5bmNf c3luY2hyb25pemVfZnVsbCgpOwo+ICAJaWYgKCFpZmJkZXYpCj4gIAkJcmV0dXJuOwo+ICAKPiBA QCAtNzk1LDYgKzc5Niw4IEBAIHZvaWQgaW50ZWxfZmJkZXZfc2V0X3N1c3BlbmQoc3RydWN0IGRy bV9kZXZpY2UgKmRldiwgaW50IHN0YXRlLCBib29sIHN5bmNocm9ub3VzCj4gIHZvaWQgaW50ZWxf ZmJkZXZfb3V0cHV0X3BvbGxfY2hhbmdlZChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICB7Cj4g IAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2YXRlOwo+ ICsKPiArCWFzeW5jX3N5bmNocm9uaXplX2Z1bGwoKTsKPiAgCWlmIChkZXZfcHJpdi0+ZmJkZXYp Cj4gIAkJZHJtX2ZiX2hlbHBlcl9ob3RwbHVnX2V2ZW50KCZkZXZfcHJpdi0+ZmJkZXYtPmhlbHBl cik7Cj4gIH0KPiBAQCAtODA2LDYgKzgwOSw3IEBAIHZvaWQgaW50ZWxfZmJkZXZfcmVzdG9yZV9t b2RlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gIAlzdHJ1Y3QgaW50ZWxfZmJkZXYgKmlmYmRl diA9IGRldl9wcml2LT5mYmRldjsKPiAgCXN0cnVjdCBkcm1fZmJfaGVscGVyICpmYl9oZWxwZXI7 Cj4gIAo+ICsJYXN5bmNfc3luY2hyb25pemVfZnVsbCgpOwo+ICAJaWYgKCFpZmJkZXYpCj4gIAkJ cmV0dXJuOwo+ICAKPiAtLSAKPiAxLjguNS4yIChBcHBsZSBHaXQtNDgpCj4gCj4gX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGlu ZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApEYW5pZWwgVmV0 dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZnds bC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK