From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v3 04/21] drm/i915: Support for extra alignment for tiled surfaces Date: Tue, 16 Feb 2016 17:26:53 +0100 Message-ID: <20160216162653.GA32705@phenom.ffwll.local> References: <1455569699-27905-1-git-send-email-ville.syrjala@linux.intel.com> <1455569699-27905-5-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4D14A6E7E6 for ; Tue, 16 Feb 2016 16:26:28 +0000 (UTC) Received: by mail-wm0-f50.google.com with SMTP id a4so108180963wme.1 for ; Tue, 16 Feb 2016 08:26:28 -0800 (PST) Content-Disposition: inline In-Reply-To: <1455569699-27905-5-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBGZWIgMTUsIDIwMTYgYXQgMTA6NTQ6NDJQTSArMDIwMCwgdmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20gd3JvdGU6Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJq YWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiBTS0wrIG5lZWRzID40SyBhbGlnbm1lbnQgZm9yIHRp bGVkIHN1cmZhY2VzLCBzbyBtYWtlCj4gaW50ZWxfY29tcHV0ZV9wYWdlX29mZnNldCgpIGhhbmRs ZSBpdC4KPiAKPiBUaGUgd2F5IHdlIGRvIGl0IGlzIGZpcnN0IHdlIGNvbXB1dGUgdGhlIGNsb3Nl c3QgdGlsZSBib3VuZGFyeQo+IGFzIGJlZm9yZSwgYW5kIHRoZW4gZmlndXJlIG91dCBob3cgbWFu eSB0aWxlcyB3ZSBuZWVkIHRvIGdvCj4gdG8gcmVhY2ggdGhlIGRlc2lyZWQgYWxpZ25tZW50LiBU aGUgZGlmZmVyZW5jZSBpbiB0aGUgb2Zmc2V0Cj4gaXMgdGhlbiBhZGRlZCBpbnRvIHRoZSB4L3kg b2Zmc2V0cy4KPiAKPiB2MjogQmUgbGVzcyBjb25mdXNpbmcgd3J0LiB1bml0cyAocGl4ZWxzIHZz LiBieXRlcykgKERhbmllbCkKPiB2MzogVXNlIHUzMiBmb3Igb2Zmc2V0cwo+ICAgICBIYXZlIGlu dGVsX2FkanVzdF90aWxlX29mZnNldCgpIHJldHVybiB0aGUgbmV3IG9mZnNldCAod2lsbCBiZQo+ ICAgICB1c2VmdWwgbGF0ZXIpCj4gICAgIEFkZCBhbiBvZmZzZXRfYWxpZ25lZCB2YXJpYWJsZSAo RGFuaWVsKQo+IAo+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFs YUBsaW51eC5pbnRlbC5jb20+CgpSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZl dHRlckBmZndsbC5jaD4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3Bs YXkuYyB8IDUwICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLQo+ICAxIGZpbGUg Y2hhbmdlZCwgNDUgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggZGNmMzc5YzI5NTIzLi5mZThkNTM0YTMzMzQg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTI0NjEsNiArMjQ2 MSwzNSBAQCBzdGF0aWMgdm9pZCBpbnRlbF91bnBpbl9mYl9vYmooc3RydWN0IGRybV9mcmFtZWJ1 ZmZlciAqZmIsCj4gIH0KPiAgCj4gIC8qCj4gKyAqIEFkanVzdCB0aGUgdGlsZSBvZmZzZXQgYnkg bW92aW5nIHRoZSBkaWZmZXJlbmNlIGludG8KPiArICogdGhlIHgveSBvZmZzZXRzLgo+ICsgKgo+ ICsgKiBJbnB1dCB0aWxlIGRpbWVuc2lvbnMgYW5kIHBpdGNoIG11c3QgYWxyZWFkeSBiZQo+ICsg KiByb3RhdGVkIHRvIG1hdGNoIHggYW5kIHksIGFuZCBpbiBwaXhlbCB1bml0cy4KPiArICovCj4g K3N0YXRpYyB1MzIgaW50ZWxfYWRqdXN0X3RpbGVfb2Zmc2V0KGludCAqeCwgaW50ICp5LAo+ICsJ CQkJICAgIHVuc2lnbmVkIGludCB0aWxlX3dpZHRoLAo+ICsJCQkJICAgIHVuc2lnbmVkIGludCB0 aWxlX2hlaWdodCwKPiArCQkJCSAgICB1bnNpZ25lZCBpbnQgdGlsZV9zaXplLAo+ICsJCQkJICAg IHVuc2lnbmVkIGludCBwaXRjaF90aWxlcywKPiArCQkJCSAgICB1MzIgb2xkX29mZnNldCwKPiAr CQkJCSAgICB1MzIgbmV3X29mZnNldCkKPiArewo+ICsJdW5zaWduZWQgaW50IHRpbGVzOwo+ICsK PiArCVdBUk5fT04ob2xkX29mZnNldCAmICh0aWxlX3NpemUgLSAxKSk7Cj4gKwlXQVJOX09OKG5l d19vZmZzZXQgJiAodGlsZV9zaXplIC0gMSkpOwo+ICsJV0FSTl9PTihuZXdfb2Zmc2V0ID4gb2xk X29mZnNldCk7Cj4gKwo+ICsJdGlsZXMgPSAob2xkX29mZnNldCAtIG5ld19vZmZzZXQpIC8gdGls ZV9zaXplOwo+ICsKPiArCSp5ICs9IHRpbGVzIC8gcGl0Y2hfdGlsZXMgKiB0aWxlX2hlaWdodDsK PiArCSp4ICs9IHRpbGVzICUgcGl0Y2hfdGlsZXMgKiB0aWxlX3dpZHRoOwo+ICsKPiArCXJldHVy biBuZXdfb2Zmc2V0Owo+ICt9Cj4gKwo+ICsvKgo+ICAgKiBDb21wdXRlcyB0aGUgbGluZWFyIG9m ZnNldCB0byB0aGUgYmFzZSB0aWxlIGFuZCBhZGp1c3RzCj4gICAqIHgsIHkuIGJ5dGVzIHBlciBw aXhlbCBpcyBhc3N1bWVkIHRvIGJlIGEgcG93ZXItb2YtdHdvLgo+ICAgKgo+IEBAIC0yNDc1LDYg KzI1MDQsMTIgQEAgdTMyIGludGVsX2NvbXB1dGVfdGlsZV9vZmZzZXQoc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJCQkgICAgICB1bnNpZ25lZCBpbnQgcGl0Y2gsCj4gIAkJ CSAgICAgIHVuc2lnbmVkIGludCByb3RhdGlvbikKPiAgewo+ICsJdTMyIG9mZnNldCwgb2Zmc2V0 X2FsaWduZWQsIGFsaWdubWVudDsKPiArCj4gKwlhbGlnbm1lbnQgPSBpbnRlbF9zdXJmX2FsaWdu bWVudChkZXZfcHJpdiwgZmJfbW9kaWZpZXIpOwo+ICsJaWYgKGFsaWdubWVudCkKPiArCQlhbGln bm1lbnQtLTsKPiArCj4gIAlpZiAoZmJfbW9kaWZpZXIgIT0gRFJNX0ZPUk1BVF9NT0RfTk9ORSkg ewo+ICAJCXVuc2lnbmVkIGludCB0aWxlX3NpemUsIHRpbGVfd2lkdGgsIHRpbGVfaGVpZ2h0Owo+ ICAJCXVuc2lnbmVkIGludCB0aWxlX3Jvd3MsIHRpbGVzLCBwaXRjaF90aWxlczsKPiBAQCAtMjQ5 NiwxNiArMjUzMSwyMSBAQCB1MzIgaW50ZWxfY29tcHV0ZV90aWxlX29mZnNldChzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJdGlsZXMgPSAqeCAvIHRpbGVfd2lkdGg7Cj4g IAkJKnggJT0gdGlsZV93aWR0aDsKPiAgCj4gLQkJcmV0dXJuICh0aWxlX3Jvd3MgKiBwaXRjaF90 aWxlcyArIHRpbGVzKSAqIHRpbGVfc2l6ZTsKPiAtCX0gZWxzZSB7Cj4gLQkJdW5zaWduZWQgaW50 IGFsaWdubWVudCA9IGludGVsX2xpbmVhcl9hbGlnbm1lbnQoZGV2X3ByaXYpIC0gMTsKPiAtCQl1 bnNpZ25lZCBpbnQgb2Zmc2V0Owo+ICsJCW9mZnNldCA9ICh0aWxlX3Jvd3MgKiBwaXRjaF90aWxl cyArIHRpbGVzKSAqIHRpbGVfc2l6ZTsKPiArCQlvZmZzZXRfYWxpZ25lZCA9IG9mZnNldCAmIH5h bGlnbm1lbnQ7Cj4gIAo+ICsJCWludGVsX2FkanVzdF90aWxlX29mZnNldCh4LCB5LCB0aWxlX3dp ZHRoLCB0aWxlX2hlaWdodCwKPiArCQkJCQkgdGlsZV9zaXplLCBwaXRjaF90aWxlcywKPiArCQkJ CQkgb2Zmc2V0LCBvZmZzZXRfYWxpZ25lZCk7Cj4gKwl9IGVsc2Ugewo+ICAJCW9mZnNldCA9ICp5 ICogcGl0Y2ggKyAqeCAqIGNwcDsKPiArCQlvZmZzZXRfYWxpZ25lZCA9IG9mZnNldCAmIH5hbGln bm1lbnQ7Cj4gKwo+ICAJCSp5ID0gKG9mZnNldCAmIGFsaWdubWVudCkgLyBwaXRjaDsKPiAgCQkq eCA9ICgob2Zmc2V0ICYgYWxpZ25tZW50KSAtICp5ICogcGl0Y2gpIC8gY3BwOwo+IC0JCXJldHVy biBvZmZzZXQgJiB+YWxpZ25tZW50Owo+ICAJfQo+ICsKPiArCXJldHVybiBvZmZzZXRfYWxpZ25l ZDsKPiAgfQo+ICAKPiAgc3RhdGljIGludCBpOXh4X2Zvcm1hdF90b19mb3VyY2MoaW50IGZvcm1h dCkKPiAtLSAKPiAyLjQuMTAKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJ bnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK