[PATCH] drm/i915: synchronize_irq() before turning off disp2d power well on VLV/CHV

[PATCH] drm/i915: synchronize_irq() before turning off disp2d power well on VLV/CHV

[ville.syrjala]

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

After we've told the irq code we don't want to handle display irqs
anymore, we must make sure any display irq handling already
kicked off has finished before we actually turn off the power well.

I wouldn't expect PIPESTAT based interrupts to occur anymore since
vblanks/page flips/gmbus/etc should all be quiescent at this point.
But at least hotplug interrupts could still occur. Hotplug
interrupts may also kick off the workqueue based hotplug processing,
but that code should take the required power domain references
itself, so there shouldn't be any need to synchronize with the
hotplug processing from the power well code.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_runtime_pm.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
index a2e367cf99a2..59e9222223c9 100644
--- a/drivers/gpu/drm/i915/intel_runtime_pm.c
+++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
@@ -941,6 +941,9 @@ static void vlv_display_power_well_deinit(struct drm_i915_private *dev_priv)
 	valleyview_disable_display_irqs(dev_priv);
 	spin_unlock_irq(&dev_priv->irq_lock);
 
+	/* make sure we're done processing display irqs */
+	synchronize_irq(dev_priv->dev->irq);
+
 	vlv_power_sequencer_reset(dev_priv);
 }
 
-- 
2.4.10

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.BAT: warning for drm/i915: synchronize_irq() before turning off disp2d power well on VLV/CHV

[Patchwork]

== Summary ==

Series 3636v1 drm/i915: synchronize_irq() before turning off disp2d power well on VLV/CHV
http://patchwork.freedesktop.org/api/1.0/series/3636/revisions/1/mbox/

Test kms_force_connector_basic:
        Subgroup force-load-detect:
                dmesg-fail -> FAIL       (snb-x220t)
                fail       -> DMESG-FAIL (ivb-t430s)
Test pm_rpm:
        Subgroup basic-pci-d3-state:
                pass       -> DMESG-WARN (byt-nuc)

bdw-nuci7        total:165  pass:154  dwarn:0   dfail:0   fail:0   skip:11 
bdw-ultra        total:168  pass:154  dwarn:0   dfail:0   fail:0   skip:14 
bsw-nuc-2        total:168  pass:136  dwarn:1   dfail:0   fail:1   skip:30 
byt-nuc          total:168  pass:142  dwarn:1   dfail:0   fail:0   skip:25 
ivb-t430s        total:168  pass:153  dwarn:0   dfail:1   fail:0   skip:14 
skl-i5k-2        total:168  pass:151  dwarn:1   dfail:0   fail:0   skip:16 
snb-dellxps      total:168  pass:145  dwarn:0   dfail:0   fail:1   skip:22 
snb-x220t        total:168  pass:145  dwarn:0   dfail:0   fail:2   skip:21 

Results at /archive/results/CI_IGT_test/Patchwork_1450/

c278ff791cc73f90079c86f343be16214a0038b7 drm-intel-nightly: 2016y-02m-22d-09h-17m-11s UTC integration manifest
f1765ebb9591b176065d262b6e6a2983ac0d66b6 drm/i915: synchronize_irq() before turning off disp2d power well on VLV/CHV

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: synchronize_irq() before turning off disp2d power well on VLV/CHV

[Imre Deak]

On pe, 2016-02-19 at 18:41 +0200, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> After we've told the irq code we don't want to handle display irqs
> anymore, we must make sure any display irq handling already
> kicked off has finished before we actually turn off the power well.
> 
> I wouldn't expect PIPESTAT based interrupts to occur anymore since
> vblanks/page flips/gmbus/etc should all be quiescent at this point.
> But at least hotplug interrupts could still occur. Hotplug
> interrupts may also kick off the workqueue based hotplug processing,
> but that code should take the required power domain references
> itself, so there shouldn't be any need to synchronize with the
> hotplug processing from the power well code.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Imre Deak <imre.deak@intel.com>

> ---
>  drivers/gpu/drm/i915/intel_runtime_pm.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c
> b/drivers/gpu/drm/i915/intel_runtime_pm.c
> index a2e367cf99a2..59e9222223c9 100644
> --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
> +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
> @@ -941,6 +941,9 @@ static void vlv_display_power_well_deinit(struct
> drm_i915_private *dev_priv)
>  	valleyview_disable_display_irqs(dev_priv);
>  	spin_unlock_irq(&dev_priv->irq_lock);
>  
> +	/* make sure we're done processing display irqs */
> +	synchronize_irq(dev_priv->dev->irq);
> +
>  	vlv_power_sequencer_reset(dev_priv);
>  }
>  
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: ✗ Fi.CI.BAT: warning for drm/i915: synchronize_irq() before turning off disp2d power well on VLV/CHV

[Ville Syrjälä]

On Mon, Feb 22, 2016 at 10:23:30AM -0000, Patchwork wrote:
> == Summary ==
> 
> Series 3636v1 drm/i915: synchronize_irq() before turning off disp2d power well on VLV/CHV
> http://patchwork.freedesktop.org/api/1.0/series/3636/revisions/1/mbox/
> 
> Test kms_force_connector_basic:
>         Subgroup force-load-detect:
>                 dmesg-fail -> FAIL       (snb-x220t)
>                 fail       -> DMESG-FAIL (ivb-t430s)

Something for Maarten to look at.

> Test pm_rpm:
>         Subgroup basic-pci-d3-state:
>                 pass       -> DMESG-WARN (byt-nuc)

[  135.447825] [drm:intel_runtime_suspend [i915]] *ERROR* Unclaimed access detected prior to suspending
https://bugs.freedesktop.org/show_bug.cgi?id=94164

> 
> bdw-nuci7        total:165  pass:154  dwarn:0   dfail:0   fail:0   skip:11 
> bdw-ultra        total:168  pass:154  dwarn:0   dfail:0   fail:0   skip:14 
> bsw-nuc-2        total:168  pass:136  dwarn:1   dfail:0   fail:1   skip:30 
> byt-nuc          total:168  pass:142  dwarn:1   dfail:0   fail:0   skip:25 
> ivb-t430s        total:168  pass:153  dwarn:0   dfail:1   fail:0   skip:14 
> skl-i5k-2        total:168  pass:151  dwarn:1   dfail:0   fail:0   skip:16 
> snb-dellxps      total:168  pass:145  dwarn:0   dfail:0   fail:1   skip:22 
> snb-x220t        total:168  pass:145  dwarn:0   dfail:0   fail:2   skip:21 
> 
> Results at /archive/results/CI_IGT_test/Patchwork_1450/
> 
> c278ff791cc73f90079c86f343be16214a0038b7 drm-intel-nightly: 2016y-02m-22d-09h-17m-11s UTC integration manifest
> f1765ebb9591b176065d262b6e6a2983ac0d66b6 drm/i915: synchronize_irq() before turning off disp2d power well on VLV/CHV

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: synchronize_irq() before turning off disp2d power well on VLV/CHV

[Ville Syrjälä]

On Mon, Feb 22, 2016 at 02:37:25PM +0200, Imre Deak wrote:
> On pe, 2016-02-19 at 18:41 +0200, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > After we've told the irq code we don't want to handle display irqs
> > anymore, we must make sure any display irq handling already
> > kicked off has finished before we actually turn off the power well.
> > 
> > I wouldn't expect PIPESTAT based interrupts to occur anymore since
> > vblanks/page flips/gmbus/etc should all be quiescent at this point.
> > But at least hotplug interrupts could still occur. Hotplug
> > interrupts may also kick off the workqueue based hotplug processing,
> > but that code should take the required power domain references
> > itself, so there shouldn't be any need to synchronize with the
> > hotplug processing from the power well code.
> > 
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Reviewed-by: Imre Deak <imre.deak@intel.com>

Pushed to dinq. Thanks for the review.

> 
> > ---
> >  drivers/gpu/drm/i915/intel_runtime_pm.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c
> > b/drivers/gpu/drm/i915/intel_runtime_pm.c
> > index a2e367cf99a2..59e9222223c9 100644
> > --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
> > @@ -941,6 +941,9 @@ static void vlv_display_power_well_deinit(struct
> > drm_i915_private *dev_priv)
> >  	valleyview_disable_display_irqs(dev_priv);
> >  	spin_unlock_irq(&dev_priv->irq_lock);
> >  
> > +	/* make sure we're done processing display irqs */
> > +	synchronize_irq(dev_priv->dev->irq);
> > +
> >  	vlv_power_sequencer_reset(dev_priv);
> >  }
> >  

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx