From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 5/6] drm/atomic: Handle encoder assignment conflicts in a separate check. Date: Tue, 1 Mar 2016 19:58:47 +0200 Message-ID: <20160301175847.GN15993@intel.com> References: <1456303053-28806-1-git-send-email-maarten.lankhorst@linux.intel.com> <1456303053-28806-6-git-send-email-maarten.lankhorst@linux.intel.com> <20160301172119.GL15993@intel.com> <56D5D551.2000004@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <56D5D551.2000004@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBNYXIgMDEsIDIwMTYgYXQgMDY6NDU6NTNQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMDEtMDMtMTYgb20gMTg6MjEgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6 Cj4gPiBPbiBXZWQsIEZlYiAyNCwgMjAxNiBhdCAwOTozNzozMkFNICswMTAwLCBNYWFydGVuIExh bmtob3JzdCB3cm90ZToKPiA+PiBUaGUgY3VycmVudCBjaGVjayBkb2Vzbid0IGhhbmRsZSB0aGUg Y2FzZSB3aGVyZSB3ZSBkb24ndCBzdGVhbCBhbgo+ID4+IGVuY29kZXIsIGJ1dCBrZWVwIGl0IG9u IHRoZSBjdXJyZW50IGNvbm5lY3Rvci4gSWYgd2UgcmVwdXJwb3NlCj4gPj4gZGlzYWJsZV9jb25m bGljdGluZ19lbmNvZGVycyB0byBkbyB0aGUgY2hlY2tpbmcsIHdlIGp1c3QgaGF2ZQo+ID4+IHRv IHJlamVjdCB0aGUgb25lcyB0aGF0IGNvbmZsaWN0Lgo+ID4+Cj4gPj4gU2lnbmVkLW9mZi1ieTog TWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiA+ PiBUZXN0Y2FzZToga21zX3NldG1vZGUuaW52YWxpZC1jbG9uZS1zaW5nbGUtY3J0Yy1zdGVhbGlu Zwo+ID4+IC0tLQo+ID4+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYyB8IDU4 ICsrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiA+PiAgMSBmaWxlIGNoYW5n ZWQsIDI0IGluc2VydGlvbnMoKyksIDM0IGRlbGV0aW9ucygtKQo+ID4+Cj4gPj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJt L2RybV9hdG9taWNfaGVscGVyLmMKPiA+PiBpbmRleCAzNTQzYzdmY2QwNzIuLjMyYmQ1YmViZWYw YiAxMDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+ ID4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4gPj4gQEAgLTg2 LDcgKzg2LDggQEAgZHJtX2F0b21pY19oZWxwZXJfcGxhbmVfY2hhbmdlZChzdHJ1Y3QgZHJtX2F0 b21pY19zdGF0ZSAqc3RhdGUsCj4gPj4gIAl9Cj4gPj4gIH0KPiA+PiAgCj4gPj4gLXN0YXRpYyBp bnQgZGlzYWJsZV9jb25mbGljdGluZ19jb25uZWN0b3JzKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRl ICpzdGF0ZSkKPiA+PiArc3RhdGljIGludCBoYW5kbGVfY29uZmxpY3RpbmdfZW5jb2RlcnMoc3Ry dWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLAo+ID4+ICsJCQkJICAgICAgIGJvb2wgZGlzYWJs ZV9jb25mbGljdGluZ19lbmNvZGVycykKPiA+PiAgewo+ID4+ICAJc3RydWN0IGRybV9jb25uZWN0 b3Jfc3RhdGUgKmNvbm5fc3RhdGU7Cj4gPj4gIAlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVj dG9yOwo+ID4+IEBAIC0xMDYsOCArMTA3LDE3IEBAIHN0YXRpYyBpbnQgZGlzYWJsZV9jb25mbGlj dGluZ19jb25uZWN0b3JzKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiA+PiAgCQll bHNlCj4gPj4gIAkJCW5ld19lbmNvZGVyID0gZnVuY3MtPmJlc3RfZW5jb2Rlcihjb25uZWN0b3Ip Owo+ID4+ICAKPiA+PiAtCQlpZiAobmV3X2VuY29kZXIpCj4gPj4gKwkJaWYgKG5ld19lbmNvZGVy KSB7Cj4gPj4gKwkJCWlmIChlbmNvZGVyX21hc2sgJiAoMSA8PCBkcm1fZW5jb2Rlcl9pbmRleChu ZXdfZW5jb2RlcikpKSB7Cj4gPj4gKwkJCQlEUk1fREVCVUdfQVRPTUlDKCJbRU5DT0RFUjolZDol c10gb24gW0NPTk5FQ1RPUjolZDolc10gYWxyZWFkeSBhc3NpZ25lZFxuIiwKPiA+PiArCQkJCQlu ZXdfZW5jb2Rlci0+YmFzZS5pZCwgbmV3X2VuY29kZXItPm5hbWUsCj4gPj4gKwkJCQkJY29ubmVj dG9yLT5iYXNlLmlkLCBjb25uZWN0b3ItPm5hbWUpOwo+ID4+ICsKPiA+PiArCQkJCXJldHVybiAt RUlOVkFMOwo+ID4+ICsJCQl9Cj4gPj4gKwo+ID4+ICAJCQllbmNvZGVyX21hc2sgfD0gMSA8PCBk cm1fZW5jb2Rlcl9pbmRleChuZXdfZW5jb2Rlcik7Cj4gPj4gKwkJfQo+ID4+ICAJfQo+ID4+ICAK PiA+PiAgCWRybV9mb3JfZWFjaF9jb25uZWN0b3IoY29ubmVjdG9yLCBzdGF0ZS0+ZGV2KSB7Cj4g Pj4gQEAgLTEyMCw2ICsxMzAsMTUgQEAgc3RhdGljIGludCBkaXNhYmxlX2NvbmZsaWN0aW5nX2Nv bm5lY3RvcnMoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlKQo+ID4+ICAJCWlmICghZW5j b2RlciB8fCAhKGVuY29kZXJfbWFzayAmICgxIDw8IGRybV9lbmNvZGVyX2luZGV4KGVuY29kZXIp KSkpCj4gPj4gIAkJCWNvbnRpbnVlOwo+ID4+ICAKPiA+PiArCQlpZiAoIWRpc2FibGVfY29uZmxp Y3RpbmdfZW5jb2RlcnMpIHsKPiA+PiArCQkJRFJNX0RFQlVHX0FUT01JQygiW0VOQ09ERVI6JWQ6 JXNdIGluIHVzZSBvbiBbQ1JUQzolZDolc10gYnkgW0NPTk5FQ1RPUjolZDolc11cbiIsCj4gPj4g KwkJCQkJIGVuY29kZXItPmJhc2UuaWQsIGVuY29kZXItPm5hbWUsCj4gPj4gKwkJCQkJIGNvbm5l Y3Rvci0+c3RhdGUtPmNydGMtPmJhc2UuaWQsCj4gPj4gKwkJCQkJIGNvbm5lY3Rvci0+c3RhdGUt PmNydGMtPm5hbWUsCj4gPj4gKwkJCQkJIGNvbm5lY3Rvci0+YmFzZS5pZCwgY29ubmVjdG9yLT5u YW1lKTsKPiA+PiArCQkJcmV0dXJuIC1FSU5WQUw7Cj4gPj4gKwkJfQo+ID4+ICsKPiA+IEhtbS4g VGhpcyBjYW4ndCBwb3NzaWJseSB3b3JrIGNhbiBpdD8gSWYgSSdtIHJlZGluZyB0aGluZ3MgY29y cmVjdGx5Cj4gPiB0aGlzIHdvdWxkIGFscmVhZHkgZmFpbCBpZiB3ZSBoYXZlIGNydGMwLT5lbmMw LT5jb25uMCBhbmQgdGhlbiB0cnkgdG8KPiA+IGNoYW5nZSBpdCB0byBjcnRjMS0+ZW5jMC0+Y29u bjAuIEJ1dCBwZXJoYXBzIEknbSBtaXNzaW5nIHNvbWUgc3VidGxlCj4gPiB0aGluZyAodGhlcmUg YXJlIGEgbG90IG9mIHRob3NlIGluIG91ciBhdG9taWMgZnJhbWV3b3JrIGR1ZSB0byB0aGluZwo+ ID4gYXV0b21hZ2ljYWxseSBnZXR0aW5nIGFkZGVkIHRvIHRoZSBzdGF0ZSkuCj4gPgo+IE5vLCBp biB0aGF0IGNhc2UgdGhlIGNvbm5lY3RvciBpcyBwYXJ0IG9mIHRoZSBzdGF0ZS4KCkRvaCwgSSBt aXNyZWFkIHRoZSBjb25kaXRpb24gZm9yIHRoZSBleGlzdGluZyBzdGF0ZSBjaGVjay4KCk9LLCBz byBJIGd1ZXNzIHRoaXMgaXMgbW9yZSBvciBsZXNzIHdoYXQgSSBoYWQgaW4gbWluZCBhcyB3ZWxs LCBleGNlcHQKaXQgdXNlcyB0aGUgdHdvIGxvb3BzIHZlcnNpb24gZm9yIGJvdGggY2FzZXMuIFRo ZSBvbmUgZGlmZmVyZW5jZSBiZXR3ZWVuCm15IGlkZWEgYW5kIHRoaXMgaXMgdGhhdCB5b3UgZG9u J3QgaW5jbHVkZSB0aGUgb2xkIGVuY29kZXJzIGluCmVuY29kZXJfbWFzayBmb3IgdGhlIGF0b21p YyBjYXNlLCBidXQgdGhhdCBzaG91bGQgYmUgcGVyZmVjdGx5IGZpbmUKc2luY2Ugd2UgY2FuIGFz c3VtZSB0aGUgb2xkIHN0YXRlIGl0c2VsZiBoYWQgbm8gY29uZmxpY3RpbmcgZW5jb2Rlcgphc3Np Z25tZW50cy4KCkkgdGhpbmsgaXQgY291bGQgdXNlIGEgZmV3IGhpZ2ggbGV2ZWxpc2ggY29tbWVu dHMgYXJvdW5kIHRoZSBsb29wcyB0bwpleHBsYWluIHdoYXQgdGhleSBhcmUgc3VwcG9zZWQgdG8g ZG8sIHNvbWV3aGF0IGxpa2UgeW91IGhhZCBpbgp1cGRhdGVfb3V0cHV0X3N0YXRlKCkuCgo+IAo+ IFRoaXMgYm9pbHMgZG93biB0bzoKPiAKPiBpZiAoc3RlYWxpbmcgZW5jb2RlciBmcm9tIGV4aXN0 aW5nIGNvbm5lY3RvciBub3QgcGFydCBvZiBzdGF0ZSkKPiBpZiAoYXRvbWljKSByZXR1cm4gLUVJ TlZBTDsKPiBlbHNlCj4gLy8gZGlzYWJsZSBjb25uZWN0b3IgYW5kIHBvc3NpYmx5IGNydGMKPiAK PiB+TWFhcnRlbgoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==