From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matt Roper <matthew.d.roper@intel.com>
Subject: Re: [PATCH] drm/i915: Only write watermark registers if
 a pipe is active
Date: Fri, 4 Mar 2016 15:49:02 -0800
Message-ID: <20160304234902.GB426@intel.com>
References: <1457044041-13978-1-git-send-email-matthew.d.roper@intel.com>
 <20160304105241.GO10446@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by gabe.freedesktop.org (Postfix) with ESMTP id EA9416E86E
 for <intel-gfx@lists.freedesktop.org>; Fri,  4 Mar 2016 23:49:02 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20160304105241.GO10446@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBNYXIgMDQsIDIwMTYgYXQgMTI6NTI6NDFQTSArMDIwMCwgVmlsbGUgU3lyasOkbMOk
IHdyb3RlOgo+IE9uIFRodSwgTWFyIDAzLCAyMDE2IGF0IDAyOjI3OjIxUE0gLTA4MDAsIE1hdHQg
Um9wZXIgd3JvdGU6Cj4gPiBJZiBhbGwgcGlwZXMgYXJlIG9mZiwgdGhlbiB3ZSBtYXkgaGF2ZSBl
bnRlcmVkIHJ1bnRpbWUgc3VzcGVuZCBhbmQKPiA+IHdyaXRpbmcgdGhlc2UgcmVnaXN0ZXJzIHdp
bGwgaGF2ZSBubyBlZmZlY3QgYW55d2F5LiAgV2hlbiBhIHBpcGUgaXMKPiA+IHJlLWVuYWJsZWQs
IGl0J3MgY3J0Y19lbmFibGUgd2lsbCB0YWtlIGNhcmUgb2YgcHJvZ3JhbW1pbmcgYXBwcm9wcmlh
dGUKPiA+IHdhdGVybWFyayB2YWx1ZXMuCj4gPiAKPiA+IENjOiBhcnVuLnNpbHV2ZXJ5QGxpbnV4
LmludGVsLmNvbQo+ID4gQ2M6IHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tCj4gPiBCdWd6
aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQzNDkK
PiA+IEZpeGVzOiBlZDRhNmE3Y2E4NTMgKCJkcm0vaTkxNTogQWRkIHR3by1zdGFnZSBJTEstc3R5
bGUgd2F0ZXJtYXJrIHByb2dyYW1taW5nICh2MTEpIikKPiA+IFNpZ25lZC1vZmYtYnk6IE1hdHQg
Um9wZXIgPG1hdHRoZXcuZC5yb3BlckBpbnRlbC5jb20+Cj4gPiAtLS0KPiA+IEkndmUgc3RpbGwg
YmVlbiB1bmFibGUgdG8gcmVwcm9kdWNlIHRoaXMgZGVmZWN0IG9uIG15IFNOQiBzeXN0ZW07IG5v
bmUgb2YgdGhlCj4gPiBzdWdnZXN0ZWQgdGVzdHMgcGVvcGxlIGhhdmUgbm90ZWQgaW4gQnVnemls
bGEgaGF2ZSB0cmlnZ2VyZWQgaXQgZm9yIG1lLiAgQnV0Cj4gPiBiYXNlZCBvbiB0aGUgc3RhY2sg
dHJhY2UgSSdtIGd1ZXNzaW5nIHRoYXQgdGhlIHByb2JsZW0gaGFwcGVucyBiZWNhdXNlIHdlJ3Zl
Cj4gPiBkaXNhYmxlZCB0aGUgbGFzdCBwaXBlIGFuZCBnb25lIGludG8gcnVudGltZSBzdXNwZW5k
IGJlZm9yZSB3ZSBnZXQgYXJvdW5kIHRvCj4gPiBvcHRpbWl6aW5nIHRoZSB3YXRlcm1hcmtzLgo+
ID4gCj4gPiBJJ20gbm90IHN1cGVyIGZhbWlsaWFyIHdpdGggdGhlIGRldGFpbHMgb2YgcnVudGlt
ZSBQTSwgc28gaWYgdGhlcmUncyBhIGJldHRlcgo+ID4gd2F5IHRoaXMgc2hvdWxkIGJlIGhhbmRs
ZWQsIEknbSBvcGVuIHRvIHN1Z2dlc3Rpb25zLgo+IAo+IFRoaXMgZGVmaW5pdGVseSBmZWVscyBs
aWtlIHBhcGVyaW5nIG92ZXIgdGhlIHByb2JsZW0uIFdoeSBpcyB0aGUgbW9kZXNldAo+IGNvZGUg
c3RpbGwgY2FsbGluZyB3YXRlcm1hcmsgdXBkYXRlcyBhdCB0aGUgd3JvbmcgdGltZT8KPiAKPiBX
aXRoIG15IG9yaWdpbmFsIHR3byBzdGFnZSB3bSBjb2RlIG1vc3Qgd20gdXBkYXRlcyBnb3Qga2lj
a2VkIG9mZiBmcm9tCj4gdGhlIHBsYW5lIGNvbW1pdHMgc3RhZ2UsIGFuZCB0aGUgb25seSBtYW51
YWwgY2FsbHMgd2VyZSBpbiBwbGFmb3JtCj4gc3BlY2lmaWMgY29kZSBqdXN0IGJlZm9yZSBhIG5l
dyBwaXBlIGlzIGVuYWJsZWQsIG9yIGp1c3QgYWZ0ZXIgb25lIGlzCj4gZGlzYWJsZWQuIFZlcnkg
bGl0dGxlIHJvb20gZm9yIHRoZXNlIHNvcnRzIG9mIGVycm9ycyBpbiB0aGF0IHNjaGVtZS4KPiBX
aGF0IHdlIGhhdmUgY3VycmVudGx5IGlzbid0IGRvbmUgbGlrZSB0aGF0IGFuZCBpbnN0ZWFkIGl0
IHNlZW1zIHRvCj4gbWUgd2UndmUgc29tZWhvdyBzcHJpbmtsZWQgc3R1ZmYgYWxsIG92ZXIgc29t
ZSBjb21tb24gY29kZXBhdGhzIHdoaWNoCj4gYXBwYXJlbnRseSBsZWFkcyB0byB0aGVzZSBwcm9i
bGVtcy4KCkkgZG9uJ3QgdGhpbmsgbW92aW5nIHRoZSBzZWNvbmQgc3RhZ2Ugb2Ygd2F0ZXJtYXJr
IHByb2dyYW1taW5nIGludG8KZGV2aWNlLXNwZWNpZmljIGNvZGUgaXMgdGhlIGRpcmVjdGlvbiB3
ZSB3YW50IHRvIGdvLiAgWW91J3JlIHN0aWxsIHVuZGVyCnZibGFuayBldmFzaW9uIGF0IHRoYXQg
cG9pbnQsIHNvIHlvdSBjYW4ndCB3YWl0IGZvciB2YmxhbmtzLCBidXQgZXZlbiBpZgp5b3UgY291
bGQgeW91J2QgYmUgYWRkaW5nIGEgbG90IG9mIHVubmVjZXNzYXJ5L3JlZHVuZGFudCB3YWl0IHRp
bWUuICBUaGUKbW9kZWwgd2UgaGF2ZSBub3cgaXMgdG8gY2FsbCB0aGUgJ29wdGltaXplJyBoZWxw
ZXIgYXMgc29vbiBhcyB3ZSdyZSBkb25lCndpdGggdGhlIHBvc3QtdXBkYXRlIHZibGFuayB3YWl0
aW5nLiAgSW4gc2ltcGxpZmllZCBwc2V1ZG8tY29kZSwgdGhlCmxvZ2ljIGlzOgoKICAgIGZvciBl
YWNoIGNydGMgaW4gc3RhdGUgewogICAgICAgIGRybV9hdG9taWNfaGVscGVyX2NvbW1pdF9wbGFu
ZXNfb25fY3J0YygpICAvLyBkb2VzIHZibCBldmFkZQogICAgfQoKICAgIGlmICghbGVnYWN5IGN1
cnNvciBoYWNrKQogICAgICAgIGludGVsX2F0b21pY193YWl0X2Zvcl92YmxhbmtzKCk7CgogICAg
Zm9yIGVhY2ggY3J0YyBpbiBzdGF0ZSB7CiAgICAgICAgaW50ZWxfcG9zdF9wbGFuZV91cGRhdGUo
KTsKICAgIH0KCiAgICBpZiAobW9kZXNldCkKICAgICAgICBpbnRlbF9kaXNwbGF5X3Bvd2VyX3B1
dCgpCgogICAgZm9yIGVhY2ggY3J0YyBpbiBzdGF0ZQogICAgICAgIG9wdGltaXplIHdhdGVybWFy
a3MKCkZvciBvdXIgY29kZSB0b2RheSwgSSBndWVzcyB0aGUgcHJvcGVyIGZpeCBpcyB0byBtb3Zl
IHRoZSBvcHRpbWl6ZSBzdGVwCnVwIGFib3ZlIHRoZSBkaXNwbGF5IHBvd2VyIHB1dDsgbG9va3Mg
bGlrZSB0aGF0IFBNIGNvZGUgY2hhbmdlZCBhcm91bmQgYQpiaXQgd2hpbGUgdGhpcyBzZXJpZXMg
d2FzIGJlaW5nIHJlYmFzZWQsIHNvIEkgdGhpbmsgdGhlIHBvd2VyIHB1dCB3YXMKbG9jYXRlZCBl
bHNld2hlcmUgYmVmb3JlLiAgSXQgY291bGQgZXZlbiBiZSBtb3ZlZCBpbnRvIHRoZQpwb3N0X3Bs
YW5lX3VwZGF0ZSBmdW5jdGlvbiBpZiB3ZSB3YW50ZWQsIGJ1dCBJIGhhZCBrZXB0IGl0IHNlcGFy
YXRlCnNpbmNlIHVsdGltYXRlbHkgaXQncyBnb2luZyB0byBtb3ZlIG91dCBvZiB0aGUgYXRvbWlj
X2NvbW1pdCBhbHRvZ2V0aGVyLgoKTG9uZ2VyIHRlcm0sIHdlJ2xsIGFjdHVhbGx5IGJlIGRvaW5n
IHRoZSBvcHRpbWl6ZSBhc3luY2hyb25vdXNseSB2aWEgYQp3b3JrcXVldWUgdGFzayBvciBzb21l
dGhpbmcgKHNvIGF0IGFuIGFyYml0cmFyeSBmdXR1cmUgdGltZSBhZnRlciB0aGUKY29tbWl0IGlz
IGNvbXBsZXRlKTsgYXQgdGhhdCBwb2ludCBpdCdzIGV2ZW4gbW9yZSBsaWtlbHkgdGhhdCB0aGlu
Z3MKaGF2ZSBwb3dlcmVkIGRvd24sIHNvIEkgaW1hZ2luZSB3ZSdsbCBlaXRoZXIgbmVlZCB0byBn
cmFiIHRoZSBwb3dlcgpyZWZlcmVuY2UgYmVmb3JlIG9wdGltaXppbmcgd2F0ZXJtYXJrcyBvciBl
bHNlIGp1c3Qgbm90IGJvdGhlcgpwcm9ncmFtbWluZyB0aGVtIGF0IGFsbCBpbiBjYXNlcyB3aGVy
ZSBldmVyeXRoaW5nIGlzIG9mZiAod2hpY2ggaXMgdGhlCmFwcHJvYWNoIHRoaXMgcGF0Y2ggdG9v
aykuCgpBbnl3YXksIEknbGwgcG9zdCBhbm90aGVyIHBhdGNoIHRvIG1vdmUgdGhlIG9wdGltaXpl
IGNhbGwgdXAgYmVmb3JlIHdlCmRyb3AgdGhlIHBvd2VyIHJlZmVyZW5jZTsgdGhhdCBzaG91bGQg
YWxzbyBmaXggdGhlIHByb2JsZW0gYXMgSQp1bmRlcnN0YW5kIGl0LgoKCk1hdHQKCj4gCj4gPiAK
PiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jIHwgNyArKysrLS0tCj4gPiAgMSBm
aWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlm
ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgYi9kcml2ZXJzL2dwdS9k
cm0vaTkxNS9pbnRlbF9wbS5jCj4gPiBpbmRleCBmNjVlODQxLi44YzdmZGRmIDEwMDY0NAo+ID4g
LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ID4gKysrIGIvZHJpdmVycy9n
cHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ID4gQEAgLTI4MDIsOCArMjgwMiw2IEBAIHN0YXRpYyB2
b2lkIGlsa193cml0ZV93bV92YWx1ZXMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2
LAo+ID4gIAkJSTkxNV9XUklURShXTTJfTFBfSUxLLCByZXN1bHRzLT53bV9scFsxXSk7Cj4gPiAg
CWlmIChkaXJ0eSAmIFdNX0RJUlRZX0xQKDMpICYmIHByZXZpb3VzLT53bV9scFsyXSAhPSByZXN1
bHRzLT53bV9scFsyXSkKPiA+ICAJCUk5MTVfV1JJVEUoV00zX0xQX0lMSywgcmVzdWx0cy0+d21f
bHBbMl0pOwo+ID4gLQo+ID4gLQlkZXZfcHJpdi0+d20uaHcgPSAqcmVzdWx0czsKPiA+ICB9Cj4g
PiAgCj4gPiAgYm9vbCBpbGtfZGlzYWJsZV9scF93bShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+
ID4gQEAgLTM3MzEsNyArMzcyOSwxMCBAQCBzdGF0aWMgdm9pZCBpbGtfcHJvZ3JhbV93YXRlcm1h
cmtzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ICAKPiA+ICAJaWxrX2Nv
bXB1dGVfd21fcmVzdWx0cyhkZXYsIGJlc3RfbHBfd20sIHBhcnRpdGlvbmluZywgJnJlc3VsdHMp
Owo+ID4gIAo+ID4gLQlpbGtfd3JpdGVfd21fdmFsdWVzKGRldl9wcml2LCAmcmVzdWx0cyk7Cj4g
PiArCWlmIChjb25maWcubnVtX3BpcGVzX2FjdGl2ZSA+IDApCj4gPiArCQlpbGtfd3JpdGVfd21f
dmFsdWVzKGRldl9wcml2LCAmcmVzdWx0cyk7Cj4gPiArCj4gPiArCWRldl9wcml2LT53bS5odyA9
IHJlc3VsdHM7Cj4gPiAgfQo+ID4gIAo+ID4gIHN0YXRpYyB2b2lkIGlsa19pbml0aWFsX3dhdGVy
bWFya3Moc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNzdGF0ZSkKPiA+IC0tIAo+ID4gMi4xLjQK
PiAKPiAtLSAKPiBWaWxsZSBTeXJqw6Rsw6QKPiBudGVsIE9UQwoKLS0gCk1hdHQgUm9wZXIKR3Jh
cGhpY3MgU29mdHdhcmUgRW5naW5lZXIKSW9URyBQbGF0Zm9ybSBFbmFibGluZyAmIERldmVsb3Bt
ZW50CkludGVsIENvcnBvcmF0aW9uCig5MTYpIDM1Ni0yNzk1Cl9fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwt
Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t
YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=