From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Only write watermark registers if
 a pipe is active
Date: Mon, 7 Mar 2016 16:29:04 +0200
Message-ID: <20160307142904.GB10446@intel.com>
References: <1457044041-13978-1-git-send-email-matthew.d.roper@intel.com>
 <20160304105241.GO10446@intel.com> <20160304234902.GB426@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTP id BED556E390
 for <intel-gfx@lists.freedesktop.org>; Mon,  7 Mar 2016 14:29:08 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20160304234902.GB426@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBNYXIgMDQsIDIwMTYgYXQgMDM6NDk6MDJQTSAtMDgwMCwgTWF0dCBSb3BlciB3cm90
ZToKPiBPbiBGcmksIE1hciAwNCwgMjAxNiBhdCAxMjo1Mjo0MVBNICswMjAwLCBWaWxsZSBTeXJq
w6Rsw6Qgd3JvdGU6Cj4gPiBPbiBUaHUsIE1hciAwMywgMjAxNiBhdCAwMjoyNzoyMVBNIC0wODAw
LCBNYXR0IFJvcGVyIHdyb3RlOgo+ID4gPiBJZiBhbGwgcGlwZXMgYXJlIG9mZiwgdGhlbiB3ZSBt
YXkgaGF2ZSBlbnRlcmVkIHJ1bnRpbWUgc3VzcGVuZCBhbmQKPiA+ID4gd3JpdGluZyB0aGVzZSBy
ZWdpc3RlcnMgd2lsbCBoYXZlIG5vIGVmZmVjdCBhbnl3YXkuICBXaGVuIGEgcGlwZSBpcwo+ID4g
PiByZS1lbmFibGVkLCBpdCdzIGNydGNfZW5hYmxlIHdpbGwgdGFrZSBjYXJlIG9mIHByb2dyYW1t
aW5nIGFwcHJvcHJpYXRlCj4gPiA+IHdhdGVybWFyayB2YWx1ZXMuCj4gPiA+IAo+ID4gPiBDYzog
YXJ1bi5zaWx1dmVyeUBsaW51eC5pbnRlbC5jb20KPiA+ID4gQ2M6IHZpbGxlLnN5cmphbGFAbGlu
dXguaW50ZWwuY29tCj4gPiA+IEJ1Z3ppbGxhOiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3Jn
L3Nob3dfYnVnLmNnaT9pZD05NDM0OQo+ID4gPiBGaXhlczogZWQ0YTZhN2NhODUzICgiZHJtL2k5
MTU6IEFkZCB0d28tc3RhZ2UgSUxLLXN0eWxlIHdhdGVybWFyayBwcm9ncmFtbWluZyAodjExKSIp
Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IE1hdHQgUm9wZXIgPG1hdHRoZXcuZC5yb3BlckBpbnRlbC5j
b20+Cj4gPiA+IC0tLQo+ID4gPiBJJ3ZlIHN0aWxsIGJlZW4gdW5hYmxlIHRvIHJlcHJvZHVjZSB0
aGlzIGRlZmVjdCBvbiBteSBTTkIgc3lzdGVtOyBub25lIG9mIHRoZQo+ID4gPiBzdWdnZXN0ZWQg
dGVzdHMgcGVvcGxlIGhhdmUgbm90ZWQgaW4gQnVnemlsbGEgaGF2ZSB0cmlnZ2VyZWQgaXQgZm9y
IG1lLiAgQnV0Cj4gPiA+IGJhc2VkIG9uIHRoZSBzdGFjayB0cmFjZSBJJ20gZ3Vlc3NpbmcgdGhh
dCB0aGUgcHJvYmxlbSBoYXBwZW5zIGJlY2F1c2Ugd2UndmUKPiA+ID4gZGlzYWJsZWQgdGhlIGxh
c3QgcGlwZSBhbmQgZ29uZSBpbnRvIHJ1bnRpbWUgc3VzcGVuZCBiZWZvcmUgd2UgZ2V0IGFyb3Vu
ZCB0bwo+ID4gPiBvcHRpbWl6aW5nIHRoZSB3YXRlcm1hcmtzLgo+ID4gPiAKPiA+ID4gSSdtIG5v
dCBzdXBlciBmYW1pbGlhciB3aXRoIHRoZSBkZXRhaWxzIG9mIHJ1bnRpbWUgUE0sIHNvIGlmIHRo
ZXJlJ3MgYSBiZXR0ZXIKPiA+ID4gd2F5IHRoaXMgc2hvdWxkIGJlIGhhbmRsZWQsIEknbSBvcGVu
IHRvIHN1Z2dlc3Rpb25zLgo+ID4gCj4gPiBUaGlzIGRlZmluaXRlbHkgZmVlbHMgbGlrZSBwYXBl
cmluZyBvdmVyIHRoZSBwcm9ibGVtLiBXaHkgaXMgdGhlIG1vZGVzZXQKPiA+IGNvZGUgc3RpbGwg
Y2FsbGluZyB3YXRlcm1hcmsgdXBkYXRlcyBhdCB0aGUgd3JvbmcgdGltZT8KPiA+IAo+ID4gV2l0
aCBteSBvcmlnaW5hbCB0d28gc3RhZ2Ugd20gY29kZSBtb3N0IHdtIHVwZGF0ZXMgZ290IGtpY2tl
ZCBvZmYgZnJvbQo+ID4gdGhlIHBsYW5lIGNvbW1pdHMgc3RhZ2UsIGFuZCB0aGUgb25seSBtYW51
YWwgY2FsbHMgd2VyZSBpbiBwbGFmb3JtCj4gPiBzcGVjaWZpYyBjb2RlIGp1c3QgYmVmb3JlIGEg
bmV3IHBpcGUgaXMgZW5hYmxlZCwgb3IganVzdCBhZnRlciBvbmUgaXMKPiA+IGRpc2FibGVkLiBW
ZXJ5IGxpdHRsZSByb29tIGZvciB0aGVzZSBzb3J0cyBvZiBlcnJvcnMgaW4gdGhhdCBzY2hlbWUu
Cj4gPiBXaGF0IHdlIGhhdmUgY3VycmVudGx5IGlzbid0IGRvbmUgbGlrZSB0aGF0IGFuZCBpbnN0
ZWFkIGl0IHNlZW1zIHRvCj4gPiBtZSB3ZSd2ZSBzb21laG93IHNwcmlua2xlZCBzdHVmZiBhbGwg
b3ZlciBzb21lIGNvbW1vbiBjb2RlcGF0aHMgd2hpY2gKPiA+IGFwcGFyZW50bHkgbGVhZHMgdG8g
dGhlc2UgcHJvYmxlbXMuCj4gCj4gSSBkb24ndCB0aGluayBtb3ZpbmcgdGhlIHNlY29uZCBzdGFn
ZSBvZiB3YXRlcm1hcmsgcHJvZ3JhbW1pbmcgaW50bwo+IGRldmljZS1zcGVjaWZpYyBjb2RlIGlz
IHRoZSBkaXJlY3Rpb24gd2Ugd2FudCB0byBnby4KCkluIG15IGJvb2sgdGhlIHNlY29uZCBzdGFn
ZSBzaG91bGRuJ3QgZXZlbiBiZSBwYXJ0IG9mIHRoZSBtb2Rlc2V0CnNlcXVlbmNlLCBhbmQgaW5z
dGVhZCBpZiBzaG91bGQganVzdCBiZSBkb25lIGZyb20gYSB2Ymxhbmsgd29yay9ldGMuCndoaWNo
IGlzIGhvdyBJIGRpZCBpdC4KCkFuZCB0aGUgZmlyc3Qgc3RhZ2Ugc3R1ZmYgaXMgY2xlYXJseSBo
YXJkd2FyZSBzcGVjaWZpYyBzaW5jZSB0aGUKYmVoYXZob2lyIG9mIHRoZSB3bSByZWdpc3RlcnMg
aXMgaGFyZHdhcmUgc3BlY2lmaWMsIHNvIHRyeWluZyB0bwpzaG9laG9ybiBpdCBhbGwgaW50byB0
aGUgY29tbW9uIGNvZGUgaXMgSU1PIGEgbWlzdGFrZS4KCj4gWW91J3JlIHN0aWxsIHVuZGVyCj4g
dmJsYW5rIGV2YXNpb24gYXQgdGhhdCBwb2ludCwgc28geW91IGNhbid0IHdhaXQgZm9yIHZibGFu
a3MsIGJ1dCBldmVuIGlmCj4geW91IGNvdWxkIHlvdSdkIGJlIGFkZGluZyBhIGxvdCBvZiB1bm5l
Y2Vzc2FyeS9yZWR1bmRhbnQgd2FpdCB0aW1lLiAgVGhlCj4gbW9kZWwgd2UgaGF2ZSBub3cgaXMg
dG8gY2FsbCB0aGUgJ29wdGltaXplJyBoZWxwZXIgYXMgc29vbiBhcyB3ZSdyZSBkb25lCj4gd2l0
aCB0aGUgcG9zdC11cGRhdGUgdmJsYW5rIHdhaXRpbmcuICBJbiBzaW1wbGlmaWVkIHBzZXVkby1j
b2RlLCB0aGUKPiBsb2dpYyBpczoKPiAKPiAgICAgZm9yIGVhY2ggY3J0YyBpbiBzdGF0ZSB7Cj4g
ICAgICAgICBkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfcGxhbmVzX29uX2NydGMoKSAgLy8gZG9l
cyB2YmwgZXZhZGUKPiAgICAgfQo+IAo+ICAgICBpZiAoIWxlZ2FjeSBjdXJzb3IgaGFjaykKPiAg
ICAgICAgIGludGVsX2F0b21pY193YWl0X2Zvcl92YmxhbmtzKCk7Cj4gCj4gICAgIGZvciBlYWNo
IGNydGMgaW4gc3RhdGUgewo+ICAgICAgICAgaW50ZWxfcG9zdF9wbGFuZV91cGRhdGUoKTsKPiAg
ICAgfQo+IAo+ICAgICBpZiAobW9kZXNldCkKPiAgICAgICAgIGludGVsX2Rpc3BsYXlfcG93ZXJf
cHV0KCkKPiAKPiAgICAgZm9yIGVhY2ggY3J0YyBpbiBzdGF0ZQo+ICAgICAgICAgb3B0aW1pemUg
d2F0ZXJtYXJrcwo+IAo+IEZvciBvdXIgY29kZSB0b2RheSwgSSBndWVzcyB0aGUgcHJvcGVyIGZp
eCBpcyB0byBtb3ZlIHRoZSBvcHRpbWl6ZSBzdGVwCj4gdXAgYWJvdmUgdGhlIGRpc3BsYXkgcG93
ZXIgcHV0OyBsb29rcyBsaWtlIHRoYXQgUE0gY29kZSBjaGFuZ2VkIGFyb3VuZCBhCj4gYml0IHdo
aWxlIHRoaXMgc2VyaWVzIHdhcyBiZWluZyByZWJhc2VkLCBzbyBJIHRoaW5rIHRoZSBwb3dlciBw
dXQgd2FzCj4gbG9jYXRlZCBlbHNld2hlcmUgYmVmb3JlLiAgSXQgY291bGQgZXZlbiBiZSBtb3Zl
ZCBpbnRvIHRoZQo+IHBvc3RfcGxhbmVfdXBkYXRlIGZ1bmN0aW9uIGlmIHdlIHdhbnRlZCwgYnV0
IEkgaGFkIGtlcHQgaXQgc2VwYXJhdGUKPiBzaW5jZSB1bHRpbWF0ZWx5IGl0J3MgZ29pbmcgdG8g
bW92ZSBvdXQgb2YgdGhlIGF0b21pY19jb21taXQgYWx0b2dldGhlci4KPiAKPiBMb25nZXIgdGVy
bSwgd2UnbGwgYWN0dWFsbHkgYmUgZG9pbmcgdGhlIG9wdGltaXplIGFzeW5jaHJvbm91c2x5IHZp
YSBhCj4gd29ya3F1ZXVlIHRhc2sgb3Igc29tZXRoaW5nIChzbyBhdCBhbiBhcmJpdHJhcnkgZnV0
dXJlIHRpbWUgYWZ0ZXIgdGhlCj4gY29tbWl0IGlzIGNvbXBsZXRlKTsgYXQgdGhhdCBwb2ludCBp
dCdzIGV2ZW4gbW9yZSBsaWtlbHkgdGhhdCB0aGluZ3MKPiBoYXZlIHBvd2VyZWQgZG93biwgc28g
SSBpbWFnaW5lIHdlJ2xsIGVpdGhlciBuZWVkIHRvIGdyYWIgdGhlIHBvd2VyCj4gcmVmZXJlbmNl
IGJlZm9yZSBvcHRpbWl6aW5nIHdhdGVybWFya3Mgb3IgZWxzZSBqdXN0IG5vdCBib3RoZXIKPiBw
cm9ncmFtbWluZyB0aGVtIGF0IGFsbCBpbiBjYXNlcyB3aGVyZSBldmVyeXRoaW5nIGlzIG9mZiAo
d2hpY2ggaXMgdGhlCj4gYXBwcm9hY2ggdGhpcyBwYXRjaCB0b29rKS4KPiAKPiBBbnl3YXksIEkn
bGwgcG9zdCBhbm90aGVyIHBhdGNoIHRvIG1vdmUgdGhlIG9wdGltaXplIGNhbGwgdXAgYmVmb3Jl
IHdlCj4gZHJvcCB0aGUgcG93ZXIgcmVmZXJlbmNlOyB0aGF0IHNob3VsZCBhbHNvIGZpeCB0aGUg
cHJvYmxlbSBhcyBJCj4gdW5kZXJzdGFuZCBpdC4KPiAKPiAKPiBNYXR0Cj4gCj4gPiAKPiA+ID4g
Cj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jIHwgNyArKysrLS0tCj4gPiA+
ICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+ID4gPiAK
PiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgYi9kcml2
ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gPiA+IGluZGV4IGY2NWU4NDEuLjhjN2ZkZGYg
MTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiA+ID4g
KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ID4gPiBAQCAtMjgwMiw4ICsy
ODAyLDYgQEAgc3RhdGljIHZvaWQgaWxrX3dyaXRlX3dtX3ZhbHVlcyhzdHJ1Y3QgZHJtX2k5MTVf
cHJpdmF0ZSAqZGV2X3ByaXYsCj4gPiA+ICAJCUk5MTVfV1JJVEUoV00yX0xQX0lMSywgcmVzdWx0
cy0+d21fbHBbMV0pOwo+ID4gPiAgCWlmIChkaXJ0eSAmIFdNX0RJUlRZX0xQKDMpICYmIHByZXZp
b3VzLT53bV9scFsyXSAhPSByZXN1bHRzLT53bV9scFsyXSkKPiA+ID4gIAkJSTkxNV9XUklURShX
TTNfTFBfSUxLLCByZXN1bHRzLT53bV9scFsyXSk7Cj4gPiA+IC0KPiA+ID4gLQlkZXZfcHJpdi0+
d20uaHcgPSAqcmVzdWx0czsKPiA+ID4gIH0KPiA+ID4gIAo+ID4gPiAgYm9vbCBpbGtfZGlzYWJs
ZV9scF93bShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ID4gPiBAQCAtMzczMSw3ICszNzI5LDEw
IEBAIHN0YXRpYyB2b2lkIGlsa19wcm9ncmFtX3dhdGVybWFya3Moc3RydWN0IGRybV9pOTE1X3By
aXZhdGUgKmRldl9wcml2KQo+ID4gPiAgCj4gPiA+ICAJaWxrX2NvbXB1dGVfd21fcmVzdWx0cyhk
ZXYsIGJlc3RfbHBfd20sIHBhcnRpdGlvbmluZywgJnJlc3VsdHMpOwo+ID4gPiAgCj4gPiA+IC0J
aWxrX3dyaXRlX3dtX3ZhbHVlcyhkZXZfcHJpdiwgJnJlc3VsdHMpOwo+ID4gPiArCWlmIChjb25m
aWcubnVtX3BpcGVzX2FjdGl2ZSA+IDApCj4gPiA+ICsJCWlsa193cml0ZV93bV92YWx1ZXMoZGV2
X3ByaXYsICZyZXN1bHRzKTsKPiA+ID4gKwo+ID4gPiArCWRldl9wcml2LT53bS5odyA9IHJlc3Vs
dHM7Cj4gPiA+ICB9Cj4gPiA+ICAKPiA+ID4gIHN0YXRpYyB2b2lkIGlsa19pbml0aWFsX3dhdGVy
bWFya3Moc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNzdGF0ZSkKPiA+ID4gLS0gCj4gPiA+IDIu
MS40Cj4gPiAKPiA+IC0tIAo+ID4gVmlsbGUgU3lyasOkbMOkCj4gPiBudGVsIE9UQwo+IAo+IC0t
IAo+IE1hdHQgUm9wZXIKPiBHcmFwaGljcyBTb2Z0d2FyZSBFbmdpbmVlcgo+IElvVEcgUGxhdGZv
cm0gRW5hYmxpbmcgJiBEZXZlbG9wbWVudAo+IEludGVsIENvcnBvcmF0aW9uCj4gKDkxNikgMzU2
LTI3OTUKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwt
Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t
YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=