From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matt Roper <matthew.d.roper@intel.com>
Subject: Re: [PATCH] drm/i915: Only write watermark registers if
 a pipe is active
Date: Mon, 7 Mar 2016 11:09:29 -0800
Message-ID: <20160307190929.GC8165@intel.com>
References: <1457044041-13978-1-git-send-email-matthew.d.roper@intel.com>
 <20160304105241.GO10446@intel.com> <20160304234902.GB426@intel.com>
 <20160307142904.GB10446@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTP id BA2E36E3FF
 for <intel-gfx@lists.freedesktop.org>; Mon,  7 Mar 2016 19:09:30 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20160307142904.GB10446@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gTW9uLCBNYXIgMDcsIDIwMTYgYXQgMDQ6Mjk6MDRQTSArMDIwMCwgVmlsbGUgU3lyasOkbMOk
IHdyb3RlOgo+IE9uIEZyaSwgTWFyIDA0LCAyMDE2IGF0IDAzOjQ5OjAyUE0gLTA4MDAsIE1hdHQg
Um9wZXIgd3JvdGU6Cj4gPiBPbiBGcmksIE1hciAwNCwgMjAxNiBhdCAxMjo1Mjo0MVBNICswMjAw
LCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4gPiA+IE9uIFRodSwgTWFyIDAzLCAyMDE2IGF0IDAy
OjI3OjIxUE0gLTA4MDAsIE1hdHQgUm9wZXIgd3JvdGU6Cj4gPiA+ID4gSWYgYWxsIHBpcGVzIGFy
ZSBvZmYsIHRoZW4gd2UgbWF5IGhhdmUgZW50ZXJlZCBydW50aW1lIHN1c3BlbmQgYW5kCj4gPiA+
ID4gd3JpdGluZyB0aGVzZSByZWdpc3RlcnMgd2lsbCBoYXZlIG5vIGVmZmVjdCBhbnl3YXkuICBX
aGVuIGEgcGlwZSBpcwo+ID4gPiA+IHJlLWVuYWJsZWQsIGl0J3MgY3J0Y19lbmFibGUgd2lsbCB0
YWtlIGNhcmUgb2YgcHJvZ3JhbW1pbmcgYXBwcm9wcmlhdGUKPiA+ID4gPiB3YXRlcm1hcmsgdmFs
dWVzLgo+ID4gPiA+IAo+ID4gPiA+IENjOiBhcnVuLnNpbHV2ZXJ5QGxpbnV4LmludGVsLmNvbQo+
ID4gPiA+IENjOiB2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbQo+ID4gPiA+IEJ1Z3ppbGxh
OiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD05NDM0OQo+ID4g
PiA+IEZpeGVzOiBlZDRhNmE3Y2E4NTMgKCJkcm0vaTkxNTogQWRkIHR3by1zdGFnZSBJTEstc3R5
bGUgd2F0ZXJtYXJrIHByb2dyYW1taW5nICh2MTEpIikKPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBN
YXR0IFJvcGVyIDxtYXR0aGV3LmQucm9wZXJAaW50ZWwuY29tPgo+ID4gPiA+IC0tLQo+ID4gPiA+
IEkndmUgc3RpbGwgYmVlbiB1bmFibGUgdG8gcmVwcm9kdWNlIHRoaXMgZGVmZWN0IG9uIG15IFNO
QiBzeXN0ZW07IG5vbmUgb2YgdGhlCj4gPiA+ID4gc3VnZ2VzdGVkIHRlc3RzIHBlb3BsZSBoYXZl
IG5vdGVkIGluIEJ1Z3ppbGxhIGhhdmUgdHJpZ2dlcmVkIGl0IGZvciBtZS4gIEJ1dAo+ID4gPiA+
IGJhc2VkIG9uIHRoZSBzdGFjayB0cmFjZSBJJ20gZ3Vlc3NpbmcgdGhhdCB0aGUgcHJvYmxlbSBo
YXBwZW5zIGJlY2F1c2Ugd2UndmUKPiA+ID4gPiBkaXNhYmxlZCB0aGUgbGFzdCBwaXBlIGFuZCBn
b25lIGludG8gcnVudGltZSBzdXNwZW5kIGJlZm9yZSB3ZSBnZXQgYXJvdW5kIHRvCj4gPiA+ID4g
b3B0aW1pemluZyB0aGUgd2F0ZXJtYXJrcy4KPiA+ID4gPiAKPiA+ID4gPiBJJ20gbm90IHN1cGVy
IGZhbWlsaWFyIHdpdGggdGhlIGRldGFpbHMgb2YgcnVudGltZSBQTSwgc28gaWYgdGhlcmUncyBh
IGJldHRlcgo+ID4gPiA+IHdheSB0aGlzIHNob3VsZCBiZSBoYW5kbGVkLCBJJ20gb3BlbiB0byBz
dWdnZXN0aW9ucy4KPiA+ID4gCj4gPiA+IFRoaXMgZGVmaW5pdGVseSBmZWVscyBsaWtlIHBhcGVy
aW5nIG92ZXIgdGhlIHByb2JsZW0uIFdoeSBpcyB0aGUgbW9kZXNldAo+ID4gPiBjb2RlIHN0aWxs
IGNhbGxpbmcgd2F0ZXJtYXJrIHVwZGF0ZXMgYXQgdGhlIHdyb25nIHRpbWU/Cj4gPiA+IAo+ID4g
PiBXaXRoIG15IG9yaWdpbmFsIHR3byBzdGFnZSB3bSBjb2RlIG1vc3Qgd20gdXBkYXRlcyBnb3Qg
a2lja2VkIG9mZiBmcm9tCj4gPiA+IHRoZSBwbGFuZSBjb21taXRzIHN0YWdlLCBhbmQgdGhlIG9u
bHkgbWFudWFsIGNhbGxzIHdlcmUgaW4gcGxhZm9ybQo+ID4gPiBzcGVjaWZpYyBjb2RlIGp1c3Qg
YmVmb3JlIGEgbmV3IHBpcGUgaXMgZW5hYmxlZCwgb3IganVzdCBhZnRlciBvbmUgaXMKPiA+ID4g
ZGlzYWJsZWQuIFZlcnkgbGl0dGxlIHJvb20gZm9yIHRoZXNlIHNvcnRzIG9mIGVycm9ycyBpbiB0
aGF0IHNjaGVtZS4KPiA+ID4gV2hhdCB3ZSBoYXZlIGN1cnJlbnRseSBpc24ndCBkb25lIGxpa2Ug
dGhhdCBhbmQgaW5zdGVhZCBpdCBzZWVtcyB0bwo+ID4gPiBtZSB3ZSd2ZSBzb21laG93IHNwcmlu
a2xlZCBzdHVmZiBhbGwgb3ZlciBzb21lIGNvbW1vbiBjb2RlcGF0aHMgd2hpY2gKPiA+ID4gYXBw
YXJlbnRseSBsZWFkcyB0byB0aGVzZSBwcm9ibGVtcy4KPiA+IAo+ID4gSSBkb24ndCB0aGluayBt
b3ZpbmcgdGhlIHNlY29uZCBzdGFnZSBvZiB3YXRlcm1hcmsgcHJvZ3JhbW1pbmcgaW50bwo+ID4g
ZGV2aWNlLXNwZWNpZmljIGNvZGUgaXMgdGhlIGRpcmVjdGlvbiB3ZSB3YW50IHRvIGdvLgo+IAo+
IEluIG15IGJvb2sgdGhlIHNlY29uZCBzdGFnZSBzaG91bGRuJ3QgZXZlbiBiZSBwYXJ0IG9mIHRo
ZSBtb2Rlc2V0Cj4gc2VxdWVuY2UsIGFuZCBpbnN0ZWFkIGlmIHNob3VsZCBqdXN0IGJlIGRvbmUg
ZnJvbSBhIHZibGFuayB3b3JrL2V0Yy4KPiB3aGljaCBpcyBob3cgSSBkaWQgaXQuCgpJIGFncmVl
IG9uIHRoaXM7IHRoYXQncyB0aGUgZXZlbnR1YWwgZ29hbC4gIE15IGVhcmxpZXIgaXRlcmF0aW9u
cyBvZgphdG9taWMgd2F0ZXJtYXJrcyB0b29rIHRoaXMgc3RlcCwgYnV0IHdlIGRlY2lkZWQgdG8g
ZGVmZXIgaXQgdW50aWwgbGF0ZXIKc2luY2UgaXQgY2xhc2hlZCB3aXRoIG90aGVyIHdvcmsgTWFh
cnRlbiB3YXMgZG9pbmcgYW5kIGFsc28gYWRkZWQgdG9vCm1hbnkgbW92aW5nIHBpZWNlcyB0byB0
aGUgYWxyZWFkeS1jb21wbGljYXRlZCB3YXRlcm1hcmsgc2VyaWVzLgoKPiBBbmQgdGhlIGZpcnN0
IHN0YWdlIHN0dWZmIGlzIGNsZWFybHkgaGFyZHdhcmUgc3BlY2lmaWMgc2luY2UgdGhlCj4gYmVo
YXZob2lyIG9mIHRoZSB3bSByZWdpc3RlcnMgaXMgaGFyZHdhcmUgc3BlY2lmaWMsIHNvIHRyeWlu
ZyB0bwo+IHNob2Vob3JuIGl0IGFsbCBpbnRvIHRoZSBjb21tb24gY29kZSBpcyBJTU8gYSBtaXN0
YWtlLgoKTm90aGluZyByZWFsbHkgY2hhbmdlZCB3aXRoIHRoZSBmaXJzdCBzdGFnZSBleGNlcHQg
dGhhdCB0aGUgY29tcHV0YXRpb24KcGFydCBoYXMgYmVlbiBkb25lIGVhcmxpZXIgKGR1cmluZyBh
dG9taWMgY2hlY2sgcGhhc2UpIGFuZCB0aGUgdmZ1bmMKdGhhdCBnZXRzIGNhbGxlZCBpcyBuYW1l
ZCBkaWZmZXJlbnRseSAoaW5pdGlhbF93YXRlcm1hcmtzIHZzIHVwZGF0ZV93bQp0byBjbGFyaWZ5
IGhvdyBpdCBmaXRzIGludG8gdGhlIHR3by1zdGVwIG1vZGVsKS4KCgpNYXR0Cgo+IAo+ID4gWW91
J3JlIHN0aWxsIHVuZGVyCj4gPiB2YmxhbmsgZXZhc2lvbiBhdCB0aGF0IHBvaW50LCBzbyB5b3Ug
Y2FuJ3Qgd2FpdCBmb3IgdmJsYW5rcywgYnV0IGV2ZW4gaWYKPiA+IHlvdSBjb3VsZCB5b3UnZCBi
ZSBhZGRpbmcgYSBsb3Qgb2YgdW5uZWNlc3NhcnkvcmVkdW5kYW50IHdhaXQgdGltZS4gIFRoZQo+
ID4gbW9kZWwgd2UgaGF2ZSBub3cgaXMgdG8gY2FsbCB0aGUgJ29wdGltaXplJyBoZWxwZXIgYXMg
c29vbiBhcyB3ZSdyZSBkb25lCj4gPiB3aXRoIHRoZSBwb3N0LXVwZGF0ZSB2Ymxhbmsgd2FpdGlu
Zy4gIEluIHNpbXBsaWZpZWQgcHNldWRvLWNvZGUsIHRoZQo+ID4gbG9naWMgaXM6Cj4gPiAKPiA+
ICAgICBmb3IgZWFjaCBjcnRjIGluIHN0YXRlIHsKPiA+ICAgICAgICAgZHJtX2F0b21pY19oZWxw
ZXJfY29tbWl0X3BsYW5lc19vbl9jcnRjKCkgIC8vIGRvZXMgdmJsIGV2YWRlCj4gPiAgICAgfQo+
ID4gCj4gPiAgICAgaWYgKCFsZWdhY3kgY3Vyc29yIGhhY2spCj4gPiAgICAgICAgIGludGVsX2F0
b21pY193YWl0X2Zvcl92YmxhbmtzKCk7Cj4gPiAKPiA+ICAgICBmb3IgZWFjaCBjcnRjIGluIHN0
YXRlIHsKPiA+ICAgICAgICAgaW50ZWxfcG9zdF9wbGFuZV91cGRhdGUoKTsKPiA+ICAgICB9Cj4g
PiAKPiA+ICAgICBpZiAobW9kZXNldCkKPiA+ICAgICAgICAgaW50ZWxfZGlzcGxheV9wb3dlcl9w
dXQoKQo+ID4gCj4gPiAgICAgZm9yIGVhY2ggY3J0YyBpbiBzdGF0ZQo+ID4gICAgICAgICBvcHRp
bWl6ZSB3YXRlcm1hcmtzCj4gPiAKPiA+IEZvciBvdXIgY29kZSB0b2RheSwgSSBndWVzcyB0aGUg
cHJvcGVyIGZpeCBpcyB0byBtb3ZlIHRoZSBvcHRpbWl6ZSBzdGVwCj4gPiB1cCBhYm92ZSB0aGUg
ZGlzcGxheSBwb3dlciBwdXQ7IGxvb2tzIGxpa2UgdGhhdCBQTSBjb2RlIGNoYW5nZWQgYXJvdW5k
IGEKPiA+IGJpdCB3aGlsZSB0aGlzIHNlcmllcyB3YXMgYmVpbmcgcmViYXNlZCwgc28gSSB0aGlu
ayB0aGUgcG93ZXIgcHV0IHdhcwo+ID4gbG9jYXRlZCBlbHNld2hlcmUgYmVmb3JlLiAgSXQgY291
bGQgZXZlbiBiZSBtb3ZlZCBpbnRvIHRoZQo+ID4gcG9zdF9wbGFuZV91cGRhdGUgZnVuY3Rpb24g
aWYgd2Ugd2FudGVkLCBidXQgSSBoYWQga2VwdCBpdCBzZXBhcmF0ZQo+ID4gc2luY2UgdWx0aW1h
dGVseSBpdCdzIGdvaW5nIHRvIG1vdmUgb3V0IG9mIHRoZSBhdG9taWNfY29tbWl0IGFsdG9nZXRo
ZXIuCj4gPiAKPiA+IExvbmdlciB0ZXJtLCB3ZSdsbCBhY3R1YWxseSBiZSBkb2luZyB0aGUgb3B0
aW1pemUgYXN5bmNocm9ub3VzbHkgdmlhIGEKPiA+IHdvcmtxdWV1ZSB0YXNrIG9yIHNvbWV0aGlu
ZyAoc28gYXQgYW4gYXJiaXRyYXJ5IGZ1dHVyZSB0aW1lIGFmdGVyIHRoZQo+ID4gY29tbWl0IGlz
IGNvbXBsZXRlKTsgYXQgdGhhdCBwb2ludCBpdCdzIGV2ZW4gbW9yZSBsaWtlbHkgdGhhdCB0aGlu
Z3MKPiA+IGhhdmUgcG93ZXJlZCBkb3duLCBzbyBJIGltYWdpbmUgd2UnbGwgZWl0aGVyIG5lZWQg
dG8gZ3JhYiB0aGUgcG93ZXIKPiA+IHJlZmVyZW5jZSBiZWZvcmUgb3B0aW1pemluZyB3YXRlcm1h
cmtzIG9yIGVsc2UganVzdCBub3QgYm90aGVyCj4gPiBwcm9ncmFtbWluZyB0aGVtIGF0IGFsbCBp
biBjYXNlcyB3aGVyZSBldmVyeXRoaW5nIGlzIG9mZiAod2hpY2ggaXMgdGhlCj4gPiBhcHByb2Fj
aCB0aGlzIHBhdGNoIHRvb2spLgo+ID4gCj4gPiBBbnl3YXksIEknbGwgcG9zdCBhbm90aGVyIHBh
dGNoIHRvIG1vdmUgdGhlIG9wdGltaXplIGNhbGwgdXAgYmVmb3JlIHdlCj4gPiBkcm9wIHRoZSBw
b3dlciByZWZlcmVuY2U7IHRoYXQgc2hvdWxkIGFsc28gZml4IHRoZSBwcm9ibGVtIGFzIEkKPiA+
IHVuZGVyc3RhbmQgaXQuCj4gPiAKPiA+IAo+ID4gTWF0dAo+ID4gCj4gPiA+IAo+ID4gPiA+IAo+
ID4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jIHwgNyArKysrLS0tCj4gPiA+
ID4gIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4gPiA+
ID4gCj4gPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMg
Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gPiA+ID4gaW5kZXggZjY1ZTg0MS4u
OGM3ZmRkZiAxMDA2NDQKPiA+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9w
bS5jCj4gPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ID4gPiA+
IEBAIC0yODAyLDggKzI4MDIsNiBAQCBzdGF0aWMgdm9pZCBpbGtfd3JpdGVfd21fdmFsdWVzKHN0
cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ID4gPiAgCQlJOTE1X1dSSVRFKFdN
Ml9MUF9JTEssIHJlc3VsdHMtPndtX2xwWzFdKTsKPiA+ID4gPiAgCWlmIChkaXJ0eSAmIFdNX0RJ
UlRZX0xQKDMpICYmIHByZXZpb3VzLT53bV9scFsyXSAhPSByZXN1bHRzLT53bV9scFsyXSkKPiA+
ID4gPiAgCQlJOTE1X1dSSVRFKFdNM19MUF9JTEssIHJlc3VsdHMtPndtX2xwWzJdKTsKPiA+ID4g
PiAtCj4gPiA+ID4gLQlkZXZfcHJpdi0+d20uaHcgPSAqcmVzdWx0czsKPiA+ID4gPiAgfQo+ID4g
PiA+ICAKPiA+ID4gPiAgYm9vbCBpbGtfZGlzYWJsZV9scF93bShzdHJ1Y3QgZHJtX2RldmljZSAq
ZGV2KQo+ID4gPiA+IEBAIC0zNzMxLDcgKzM3MjksMTAgQEAgc3RhdGljIHZvaWQgaWxrX3Byb2dy
YW1fd2F0ZXJtYXJrcyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiA+ID4g
IAo+ID4gPiA+ICAJaWxrX2NvbXB1dGVfd21fcmVzdWx0cyhkZXYsIGJlc3RfbHBfd20sIHBhcnRp
dGlvbmluZywgJnJlc3VsdHMpOwo+ID4gPiA+ICAKPiA+ID4gPiAtCWlsa193cml0ZV93bV92YWx1
ZXMoZGV2X3ByaXYsICZyZXN1bHRzKTsKPiA+ID4gPiArCWlmIChjb25maWcubnVtX3BpcGVzX2Fj
dGl2ZSA+IDApCj4gPiA+ID4gKwkJaWxrX3dyaXRlX3dtX3ZhbHVlcyhkZXZfcHJpdiwgJnJlc3Vs
dHMpOwo+ID4gPiA+ICsKPiA+ID4gPiArCWRldl9wcml2LT53bS5odyA9IHJlc3VsdHM7Cj4gPiA+
ID4gIH0KPiA+ID4gPiAgCj4gPiA+ID4gIHN0YXRpYyB2b2lkIGlsa19pbml0aWFsX3dhdGVybWFy
a3Moc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNzdGF0ZSkKPiA+ID4gPiAtLSAKPiA+ID4gPiAy
LjEuNAo+ID4gPiAKPiA+ID4gLS0gCj4gPiA+IFZpbGxlIFN5cmrDpGzDpAo+ID4gPiBudGVsIE9U
Qwo+ID4gCj4gPiAtLSAKPiA+IE1hdHQgUm9wZXIKPiA+IEdyYXBoaWNzIFNvZnR3YXJlIEVuZ2lu
ZWVyCj4gPiBJb1RHIFBsYXRmb3JtIEVuYWJsaW5nICYgRGV2ZWxvcG1lbnQKPiA+IEludGVsIENv
cnBvcmF0aW9uCj4gPiAoOTE2KSAzNTYtMjc5NQo+IAo+IC0tIAo+IFZpbGxlIFN5cmrDpGzDpAo+
IEludGVsIE9UQwoKLS0gCk1hdHQgUm9wZXIKR3JhcGhpY3MgU29mdHdhcmUgRW5naW5lZXIKSW9U
RyBQbGF0Zm9ybSBFbmFibGluZyAmIERldmVsb3BtZW50CkludGVsIENvcnBvcmF0aW9uCig5MTYp
IDM1Ni0yNzk1Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo
dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=