From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Only use sanitized values for ILK watermarks Date: Tue, 8 Mar 2016 16:33:22 +0200 Message-ID: <20160308143322.GN10446@intel.com> References: <56DEA1FC.8080703@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTP id E3A0A6E6EC for ; Tue, 8 Mar 2016 14:33:25 +0000 (UTC) Content-Disposition: inline In-Reply-To: <56DEA1FC.8080703@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: Intel Graphics Development , "Zanoni, Paulo R" List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBNYXIgMDgsIDIwMTYgYXQgMTA6NTc6MTZBTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gVGhlIHJhdyB3YXRlcm1hcmsgdmFsdWVzIGFyZSBuZWVkZWQgd2hlbiBwbGFu ZXMgYXJlIG5vdCBwYXJ0IG9mIHRoZSBzdGF0ZSwKPiBidXQgdGhpcyBpbnRyb2R1Y2VkIGEgcmVn cmVzc2lvbiBhbmQgcG9zc2libHkgYW4gb3ZlcmZsb3cgd2hlbiBtZXJnaW5nCj4gdGhlIHdhdGVy bWFya3MgYmVjYXVzZSBpbnZhbGlkIHZhbHVlcyBtYXkgZW5kIHVwIHVzZWQuIFNvbHZlIHRoaXMg YnkgY2FsY3VsYXRpbmcKPiByYXcgd2F0ZXJtYXJrcyBmb3IgYWxsIGxldmVscywgYW5kIG9ubHkg c2V0dGluZyBub24temVybyB2YWx1ZXMgd2hlbiB0aGUgbGV2ZWwKPiBpcyB2YWxpZC4KPiAKPiBG aXhlcyB0aGUgU05CIHdhcm5pbmc6Cj4gICAgV0FSTklORzogQ1BVOiAxIFBJRDogMjU0MDUgYXQg L2hvbWUvbWF0dHJvcGUvd29yay9rZXJuZWwvZ21zL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X3BtLmM6MjU4MCBpbGtfcHJvZ3JhbV93YXRlcm1hcmtzKzB4N2IyLzB4OWQwIFtpOTE1XSgpCj4g ICAgV0FSTl9PTih3bV9scCAhPSAxKQo+ICAgIE1vZHVsZXMgbGlua2VkIGluOiBpOTE1IGRybV9r bXNfaGVscGVyIGRybSBibHVldG9vdGggZnVzZSBpVENPX3dkdCBpVENPX3ZlbmRvcl9zdXBwb3J0 IHN5c2NvcHlhcmVhIHN5c2ZpbGxyZWN0IHN5c2ltZ2JsdCBmYl9zeXNfZm9wcyB0cG1fdGlzIG1l aV9tZSBlMTAwMGUgc25kX2hkYV9jb2RlY19oZG1pIHBjc3BrciB0cG0gbWVpIGkyY19pODAxIGxw Y19pY2ggc25kX2hkYV9jb2RlYyBzbmRfaGRhX2NvcmUKPiAgICBDUFU6IDEgUElEOiAyNTQwNSBD b21tOiBrbXNfdW5pdmVyc2FsX3AgVGFpbnRlZDogRyAgICAgVSAgVyAgICAgICA0LjUuMC1yYzZh cG9sbG9sYWtlKyAjNDYyCj4gICAgSGFyZHdhcmUgbmFtZTogICAgICAgICAgICAgICAgICAvREg2 N0dELCBCSU9TIEJMSDY3MTBILjg2QS4wMTYwLjIwMTIuMTIwNC4xMTU2IDEyLzA0LzIwMTIKPiAg ICAgMDAwMDAwMDAwMDAwMDAwMCBmZmZmODgwMDlkNDJiOTE4IGZmZmZmZmZmODE0M2NmYWIgZmZm Zjg4MDA5ZDQyYjk2MAo+ICAgICBmZmZmZmZmZmEwMzYzNTgwIGZmZmY4ODAwOWQ0MmI5NTAgZmZm ZmZmZmY4MTA4Mjc0NiBmZmZmODgwMGI5YTI0OTI4Cj4gICAgIGZmZmY4ODAwOWQ0MmJhMDAgZmZm Zjg4MDA5ZDRhMDAwMCAwMDAwMDAwMDAwMDAwMDAwIGZmZmY4ODAwOWQ0MmJhNmMKPiAgICBDYWxs IFRyYWNlOgo+ICAgICBbPGZmZmZmZmZmODE0M2NmYWI+XSBkdW1wX3N0YWNrKzB4NGQvMHg3Mgo+ ICAgICBbPGZmZmZmZmZmODEwODI3NDY+XSB3YXJuX3Nsb3dwYXRoX2NvbW1vbisweDg2LzB4YzAK PiAgICAgWzxmZmZmZmZmZjgxMDgyN2NjPl0gd2Fybl9zbG93cGF0aF9mbXQrMHg0Yy8weDUwCj4g ICAgIFs8ZmZmZmZmZmZhMDI5Mjg2Mj5dIGlsa19wcm9ncmFtX3dhdGVybWFya3MrMHg3YjIvMHg5 ZDAgW2k5MTVdCj4gICAgIFs8ZmZmZmZmZmZhMDI5MmNiNz5dIGlsa19pbml0aWFsX3dhdGVybWFy a3MrMHgxMDcvMHgxMjAgW2k5MTVdCj4gICAgIFs8ZmZmZmZmZmZhMDJmZWZmYT5dIGludGVsX3By ZV9wbGFuZV91cGRhdGUrMHgxMmEvMHgxOTAgW2k5MTVdCj4gICAgIFs8ZmZmZmZmZmZhMDJmZmIz Nj5dIGludGVsX2F0b21pY19jb21taXQrMHg1NDYvMHhkNTAgW2k5MTVdCj4gICAgIFs8ZmZmZmZm ZmZhMDEyYzllNz5dIGRybV9hdG9taWNfY29tbWl0KzB4MzcvMHg2MCBbZHJtXQo+ICAgICBbPGZm ZmZmZmZmYTAyMTczNjE+XSBkcm1fYXRvbWljX2hlbHBlcl9kaXNhYmxlX3BsYW5lKzB4YjEvMHhm MCBbZHJtX2ttc19oZWxwZXJdCj4gICAgIFs8ZmZmZmZmZmZhMDExY2RiND5dIF9fc2V0cGxhbmVf aW50ZXJuYWwrMHgxODQvMHgyODAgW2RybV0KPiAgICAgWzxmZmZmZmZmZmEwMTJiNTdhPl0gPyBk cm1fbW9kZXNldF9sb2NrX2FsbF9jdHgrMHg5YS8weGIwIFtkcm1dCj4gICAgIFs8ZmZmZmZmZmZh MDEyMDEwZj5dIGRybV9tb2RlX3NldHBsYW5lKzB4MTNmLzB4MWMwIFtkcm1dCj4gICAgIFs8ZmZm ZmZmZmZhMDExMWI1Mj5dIGRybV9pb2N0bCsweDE0Mi8weDU5MCBbZHJtXQo+ICAgICBbPGZmZmZm ZmZmYTAxMWZmZDA+XSA/IGRybV9wbGFuZV9jaGVja19waXhlbF9mb3JtYXQrMHg1MC8weDUwIFtk cm1dCj4gICAgIFs8ZmZmZmZmZmY4MTFmMjc0ND5dID8gbW50cHV0KzB4MjQvMHg0MAo+ICAgICBb PGZmZmZmZmZmODExZDI4ZDQ+XSA/IF9fZnB1dCsweDE5NC8weDIwMAo+ICAgICBbPGZmZmZmZmZm YTAxMmRlYzM+XSBkcm1fY29tcGF0X2lvY3RsKzB4MzMvMHg0MCBbZHJtXQo+ICAgICBbPGZmZmZm ZmZmYTAyOWUxYzI+XSBpOTE1X2NvbXBhdF9pb2N0bCsweDMyLzB4NDAgW2k5MTVdCj4gICAgIFs8 ZmZmZmZmZmY4MTIyOGQ3Mj5dIGNvbXBhdF9TeVNfaW9jdGwrMHhjMi8weDMzMAo+ICAgICBbPGZm ZmZmZmZmODEwMDIxZDU+XSA/IGV4aXRfdG9fdXNlcm1vZGVfbG9vcCsweDk1LzB4YjAKPiAgICAg WzxmZmZmZmZmZjgxMDAyZDJlPl0gZG9fZmFzdF9zeXNjYWxsXzMyKzB4OWUvMHgyMTAKPiAgICAg WzxmZmZmZmZmZjgxOTdmYWYyPl0gZW50cnlfU1lTRU5URVJfY29tcGF0KzB4NTIvMHg3MAo+IAo+ IENjOiBNYXR0IFJvcGVyIDxtYXR0aGV3LmQucm9wZXJAaW50ZWwuY29tPgo+IENjOiBDaHJpcyBX aWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogUGF1bG8gWmFub25pIDxwYXVs by5yLnphbm9uaUBpbnRlbC5jb20+Cj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFs YUBsaW51eC5pbnRlbC5jb20+Cj4gVGVzdGNhc2U6IGttc191bml2ZXJzYWxfcGxhbmUKPiBGaXhl czogZDgxZjA0YzVlZiAoImRybS9pOTE1OiBBbGxvdyBwcmVzZXJ2YXRpb24gb2Ygd2F0ZXJtYXJr cywgdjIuIikKPiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5r aG9yc3RAbGludXguaW50ZWwuY29tPgo+IC0tLQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4g aW5kZXggY2QwYjRlYWNiZGRmLi4yODMxODQyNTQxM2EgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kcnYuaAo+IEBAIC0zOTAsNiArMzkwLDcgQEAgc3RydWN0IGludGVsX2NydGNfc2NhbGVyX3N0 YXRlIHsKPiAgCj4gIHN0cnVjdCBpbnRlbF9waXBlX3dtIHsKPiAgCXN0cnVjdCBpbnRlbF93bV9s ZXZlbCB3bVs1XTsKPiArCXN0cnVjdCBpbnRlbF93bV9sZXZlbCByYXdfd21bNV07Cj4gIAl1aW50 MzJfdCBsaW5ldGltZTsKPiAgCWJvb2wgZmJjX3dtX2VuYWJsZWQ7Cj4gIAlib29sIHBpcGVfZW5h YmxlZDsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiBpbmRleCBmNjVlODQxMzcwNjAuLmQ3YWVm MTdiZjBmOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+IEBAIC0yMzM1LDcgKzIzMzUs NiBAQCBzdGF0aWMgaW50IGlsa19jb21wdXRlX3BpcGVfd20oc3RydWN0IGludGVsX2NydGNfc3Rh dGUgKmNzdGF0ZSkKPiAgCQkJIGRybV9yZWN0X2hlaWdodCgmc3Byc3RhdGUtPmRzdCkgIT0gZHJt X3JlY3RfaGVpZ2h0KCZzcHJzdGF0ZS0+c3JjKSA+PiAxNik7Cj4gIAl9Cj4gIAo+IC0KPiAgCXVz YWJsZV9sZXZlbCA9IG1heF9sZXZlbDsKPiAgCj4gIAkvKiBJTEsvU05COiBMUDIrIHdhdGVybWFy a3Mgb25seSB3L28gc3ByaXRlcyAqLwo+IEBAIC0yMzQ3LDcgKzIzNDYsMTAgQEAgc3RhdGljIGlu dCBpbGtfY29tcHV0ZV9waXBlX3dtKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjc3RhdGUpCj4g IAkJdXNhYmxlX2xldmVsID0gMDsKPiAgCj4gIAlpbGtfY29tcGJ1dGVfd21fbGV2ZWwoZGV2X3By aXYsIGludGVsX2NydGMsIDAsIGNzdGF0ZSwKPiAtCQkJICAgICBwcmlzdGF0ZSwgc3Byc3RhdGUs IGN1cnN0YXRlLCAmcGlwZV93bS0+d21bMF0pOwo+ICsJCQkgICAgIHByaXN0YXRlLCBzcHJzdGF0 ZSwgY3Vyc3RhdGUsICZwaXBlX3dtLT5yYXdfd21bMF0pOwo+ICsKPiArCW1lbXNldCgmcGlwZV93 bS0+d20sIDAsIHNpemVvZihwaXBlX3dtLT53bSkpOwo+ICsJcGlwZV93bS0+d21bMF0gPSBwaXBl X3dtLT5yYXdfd21bMF07Cj4gIAo+ICAJaWYgKElTX0hBU1dFTEwoZGV2KSB8fCBJU19CUk9BRFdF TEwoZGV2KSkKPiAgCQlwaXBlX3dtLT5saW5ldGltZSA9IGhzd19jb21wdXRlX2xpbmV0aW1lX3dt KGRldiwgY3N0YXRlKTsKPiBAQCAtMjM1OCw3ICsyMzYwLDcgQEAgc3RhdGljIGludCBpbGtfY29t cHV0ZV9waXBlX3dtKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjc3RhdGUpCj4gIAlpbGtfY29t cHV0ZV93bV9yZWdfbWF4aW11bXMoZGV2LCAxLCAmbWF4KTsKPiAgCj4gIAlmb3IgKGxldmVsID0g MTsgbGV2ZWwgPD0gbWF4X2xldmVsOyBsZXZlbCsrKSB7Cj4gLQkJc3RydWN0IGludGVsX3dtX2xl dmVsICp3bSA9ICZwaXBlX3dtLT53bVtsZXZlbF07Cj4gKwkJc3RydWN0IGludGVsX3dtX2xldmVs ICp3bSA9ICZwaXBlX3dtLT5yYXdfd21bbGV2ZWxdOwo+ICAKPiAgCQlpbGtfY29tcHV0ZV93bV9s ZXZlbChkZXZfcHJpdiwgaW50ZWxfY3J0YywgbGV2ZWwsIGNzdGF0ZSwKPiAgCQkJCSAgICAgcHJp c3RhdGUsIHNwcnN0YXRlLCBjdXJzdGF0ZSwgd20pOwo+IEBAIC0yMzY4LDEyICsyMzcwLDEzIEBA IHN0YXRpYyBpbnQgaWxrX2NvbXB1dGVfcGlwZV93bShzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAq Y3N0YXRlKQo+ICAJCSAqIHJlZ2lzdGVyIG1heGltdW1zIHNpbmNlIHN1Y2ggd2F0ZXJtYXJrcyBh cmUKPiAgCQkgKiBhbHdheXMgaW52YWxpZC4KPiAgCQkgKi8KPiAtCQlpZiAobGV2ZWwgPiB1c2Fi bGVfbGV2ZWwpIHsKPiAtCQkJd20tPmVuYWJsZSA9IGZhbHNlOwo+IC0JCX0gZWxzZSBpZiAoIWls a192YWxpZGF0ZV93bV9sZXZlbChsZXZlbCwgJm1heCwgd20pKSB7Cj4gLQkJCXdtLT5lbmFibGUg PSBmYWxzZTsKPiArCQlpZiAobGV2ZWwgPiB1c2FibGVfbGV2ZWwpCj4gKwkJCWNvbnRpbnVlOwo+ ICsKPiArCQlpZiAoaWxrX3ZhbGlkYXRlX3dtX2xldmVsKGxldmVsLCAmbWF4LCB3bSkpCj4gKwkJ CXBpcGVfd20tPndtW2xldmVsXSA9ICp3bTsKPiArCQllbHNlCj4gIAkJCXVzYWJsZV9sZXZlbCA9 IGxldmVsOwo+IC0JCX0KClllYWgsIHRoYXQgbG9va3MgbGlrZSBpdCBvdWdodCB0byB3b3JrLiBy YXdfd20gZ2V0cyBvdmVyd3JpdHRlbiBvbmx5IGZvcgp0aGUgcGxhbmVzIHRoYXQgY2hhbmdlZCwg YW5kIGFsbCBkaXNhYmxlZCBsZXZlbHMgaW4gcGlwZV93bSB3aWxsIGJlCnplcm9lZCBpbiB0aGUg ZW5kLgoKQW5kIHNwcml0ZXNfZW5hYmxlZC9zY2FsZWQgd2lsbCBiZSBwcmVzZXJ2ZWQgaW4gcGlw ZV93bSB1bnRpbCB0aGUgc3ByaXRlCmdldHMgZW5hYmxlZC9kaXNhYmxlZC4KClJldmlld2VkLWJ5 OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgoKVGhlcmUg aXMgYSBiaXQgb2YgdXNlbGVzcyBndW5rIGluIHJhd193bSBub3cuIFNvIG1pZ2h0IG1ha2Ugc2Vu c2UgdG8gbm90CnVzZSBpbnRlbF9waXBlX3dtIGZvciB0aGF0LiBBbHNvIEknbSBub3Qgc3VyZSBp dCB3b3VsZG4ndCBiZSBiZXR0ZXIgdG8KZG8gdGhlIGNhbGMgc3R1ZmYgaW4gYSBtb3JlIHBsYW5l IG9yaWVudGVkIHdheSBpbnN0ZWFkIG9mIHBhc3NzaW5nCmhhdmluZyB0byBwYXNzIGFyb3VuZCBh bGwgdGhlIHBsYW5lIHN0YXRlcy4gQnV0IHRoZXNlIGNvdWxkIGJlIGxlZnQgdG8Kc29tZSBmdXR1 cmUgY2xlYW51cHMuCgo+ICAJfQo+ICAKPiAgCXJldHVybiAwOwoKLS0gClZpbGxlIFN5cmrDpGzD pApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 Cg==