Re: [PATCH 4/4] drm/i915: Make GMBUS timeout message DRM_DEBUG_KMS

Ville Syrjälä
2016-04-11T15:31:27Z

On Mon, Apr 11, 2016 at 09:19:40AM +0100, Chris Wilson wrote:
> On Mon, Apr 11, 2016 at 10:29:29AM +0300, Ville Syrjälä wrote:
> > On Mon, Mar 07, 2016 at 05:57:00PM +0200, ville.syrjala@linux.intel.com wrote:
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > There's no real reason the user should care that we're about to fall
> > > back to bitbanging, so let's change the message from DRM_INFO to
> > > DRM_DEBUG_KMS.
> > >
> > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94890
>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> KMS or DRIVER though? GMBUS is now independent of KMS, so probably worth
> keeping it separate.

All the other debug message in the gmbus code are KMS. Keeping to the
party line seems best to me.

--
Ville Syrjälä
Intel OTC