From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marius Vlad <marius.c.vlad@intel.com>
Subject: Re: [PATCH i-g-t] scripts/run-test.sh: Piglit overwrite
 option.
Date: Mon, 21 Mar 2016 12:53:40 +0200
Message-ID: <20160321105339.GA27576@mcvlad-wk.rb.intel.com>
References: <1458309731-3065-1-git-send-email-rodrigo.vivi@intel.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2074960614=="
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTP id 3B8346E084
 for <intel-gfx@lists.freedesktop.org>; Mon, 21 Mar 2016 10:52:35 +0000 (UTC)
In-Reply-To: <1458309731-3065-1-git-send-email-rodrigo.vivi@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Alexandra Yates <alexandra.yates@intel.com>, intel-gfx@lists.freedesktop.org, Dylan Baker <baker.dylan.c@gmail.com>
List-Id: intel-gfx@lists.freedesktop.org


--===============2074960614==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="ew6BAiZeqk4r7MaW"
Content-Disposition: inline


--ew6BAiZeqk4r7MaW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Isn't this as https://patchwork.freedesktop.org/series/4177/?

On Fri, Mar 18, 2016 at 07:02:11AM -0700, Rodrigo Vivi wrote:
> The following piglit commit adds one option to overwrite files:
>=20
> commit ec317ece07afdf9c8a26de04bdec8a94e5d7b2db
> Author: Dylan Baker <baker.dylan.c@gmail.com>
> Date:   Mon Feb 1 15:08:23 2016 -0800
>=20
>     framework/programs/run.py: Add option for overwriting files
>=20
> So our run-script.sh test that creates the directory before executing
> the tests were failing with:
>=20
> "Fatal Error: Cannot overwrite existing folder w/o the -o /--overwrite op=
tion being sent"
>=20
> I believe it took a while to notice that because many of us never
> upgrade the piglit. But also the risk with this patch is to have an envir=
onment
> with the old piglit so the result will be:
> piglit: error: unrecognized arguments: --overwrite

Maybe we can test against piglit version and use it accordingly.

>=20
> So, let's start the discussion and also provide the patch that allows
> some people with new version to get it running.
>=20
> Cc: Dylan Baker <baker.dylan.c@gmail.com>
> Cc: Alexandra Yates <alexandra.yates@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  scripts/run-tests.sh | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>=20
> diff --git a/scripts/run-tests.sh b/scripts/run-tests.sh
> index 99e6124..b1abeab 100755
> --- a/scripts/run-tests.sh
> +++ b/scripts/run-tests.sh
> @@ -124,8 +124,7 @@ fi
>  if [ "x$RESUME" !=3D "x" ]; then
>  	sudo IGT_TEST_ROOT=3D"$IGT_TEST_ROOT" "$PIGLIT" resume "$RESULTS" $NORE=
TRY
>  else
> -	mkdir -p "$RESULTS"
> -	sudo IGT_TEST_ROOT=3D"$IGT_TEST_ROOT" "$PIGLIT" run igt "$RESULTS" -s $=
VERBOSE $EXCLUDE $FILTER
> +	sudo IGT_TEST_ROOT=3D"$IGT_TEST_ROOT" "$PIGLIT" run --overwrite igt "$R=
ESULTS" -s $VERBOSE $EXCLUDE $FILTER
>  fi
> =20
>  if [ "$SUMMARY" =3D=3D "html" ]; then
> --=20
> 2.4.3
>=20
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

--ew6BAiZeqk4r7MaW
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJW79KzAAoJELmLWIAQzyE+FUMH/0I7KAcDSWiZoJq6mkR/S0zp
OKIJKk/77DOE2ZHHZ0f58my2yJOAPwVcIjRxm7YczRQdHzsaGltbtZst4mnjAO9I
QwKsrCA3nNb5GBtbSrsTwL+7sucBw7KPgLUFGwsw67RYhfxYhS0/wLIn3Q/5DLR5
4h8x8huTEoakCZ2osDUvSk6ToNsEoYgOAy2MwukMRKU86fXYNj6jRW0mgcx7jF7W
rjtKsOjeXm1Ek+NSG6TuhikUPqGRbjTZh+H7rf6X2iVn+4Ihe66xcZ4hICt1Tc8m
K2hkpcpztXWYoqafCuy39ema1qBDpYG2XkS5AI/Bl9zCbt/WustRBUthqCg11sY=
=3FP5
-----END PGP SIGNATURE-----

--ew6BAiZeqk4r7MaW--

--===============2074960614==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4
IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==

--===============2074960614==--