intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH i-g-t] scripts/run-test.sh: Piglit overwrite option.
@ 2016-03-18 14:02 Rodrigo Vivi
  2016-03-21 10:53 ` Marius Vlad
  2016-03-21 11:27 ` Gabriel Feceoru
  0 siblings, 2 replies; 8+ messages in thread
From: Rodrigo Vivi @ 2016-03-18 14:02 UTC (permalink / raw)
  To: intel-gfx; +Cc: Alexandra Yates, Dylan Baker, Rodrigo Vivi

The following piglit commit adds one option to overwrite files:

commit ec317ece07afdf9c8a26de04bdec8a94e5d7b2db
Author: Dylan Baker <baker.dylan.c@gmail.com>
Date:   Mon Feb 1 15:08:23 2016 -0800

    framework/programs/run.py: Add option for overwriting files

So our run-script.sh test that creates the directory before executing
the tests were failing with:

"Fatal Error: Cannot overwrite existing folder w/o the -o /--overwrite option being sent"

I believe it took a while to notice that because many of us never
upgrade the piglit. But also the risk with this patch is to have an environment
with the old piglit so the result will be:
piglit: error: unrecognized arguments: --overwrite

So, let's start the discussion and also provide the patch that allows
some people with new version to get it running.

Cc: Dylan Baker <baker.dylan.c@gmail.com>
Cc: Alexandra Yates <alexandra.yates@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 scripts/run-tests.sh | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/scripts/run-tests.sh b/scripts/run-tests.sh
index 99e6124..b1abeab 100755
--- a/scripts/run-tests.sh
+++ b/scripts/run-tests.sh
@@ -124,8 +124,7 @@ fi
 if [ "x$RESUME" != "x" ]; then
 	sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" resume "$RESULTS" $NORETRY
 else
-	mkdir -p "$RESULTS"
-	sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" run igt "$RESULTS" -s $VERBOSE $EXCLUDE $FILTER
+	sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" run --overwrite igt "$RESULTS" -s $VERBOSE $EXCLUDE $FILTER
 fi
 
 if [ "$SUMMARY" == "html" ]; then
-- 
2.4.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2016-03-24 15:16 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-18 14:02 [PATCH i-g-t] scripts/run-test.sh: Piglit overwrite option Rodrigo Vivi
2016-03-21 10:53 ` Marius Vlad
2016-03-22  2:00   ` Vivi, Rodrigo
2016-03-22 16:34     ` Dylan Baker
2016-03-24  1:52       ` Vivi, Rodrigo
2016-03-24 15:17         ` Dylan Baker
2016-03-21 11:27 ` Gabriel Feceoru
2016-03-22  2:05   ` Vivi, Rodrigo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).