From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 09/15] drm/i915: Pass crtc_state->dpll directly to ->find_dpll() Date: Tue, 22 Mar 2016 12:18:37 +0200 Message-ID: <20160322101837.GD4329@intel.com> References: <1458576016-30348-1-git-send-email-ander.conselvan.de.oliveira@intel.com> <1458576016-30348-10-git-send-email-ander.conselvan.de.oliveira@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 635E86E213 for ; Tue, 22 Mar 2016 10:19:00 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1458576016-30348-10-git-send-email-ander.conselvan.de.oliveira@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ander Conselvan de Oliveira Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBNYXIgMjEsIDIwMTYgYXQgMDY6MDA6MTBQTSArMDIwMCwgQW5kZXIgQ29uc2VsdmFu IGRlIE9saXZlaXJhIHdyb3RlOgo+IFdoZW4gY2FsY3VsYXRpbmcgY2xvY2tzLCBqdXN0IHBhc3Mg YSBwb2ludGVyIHRvIGNydGNfc3RhdGUtPmRwbGwKPiBkaXJlY3RseSB0byB0aGUgZmluZF9kcGxs KCkgaG9vay4gQmFjayB3aGVuIHRoaXMgd2FzIGludHJvZHVjZWQgaW4KPiBjb21taXQgZjQ3NzA5 YTk1MDJmMyAoImRybS9pOTE1OiBjcmVhdGUgcGlwZV9jb25maWctPmRwbGwgZm9yIGNsb2NrCj4g c3RhdGUiKSB0aGVyZSB3YXMgbm8gc3RhZ2VkIGNydGMgY29uZmlnIG9yIGF0b21pYyBjcnRjIHN0 YXRlLCBzbyBpdCB3YXMKPiBwb3NzaWJsZSB0byBvdmVyd3JpdGUgdGhlIGN1cnJlbnQgY29uZmln dXJhdGlvbiBvbiBlcnJvci4gVGhhdCBoYXNuJ3QKPiBiZWVuIHRoZSBjYXNlIGZvciBhIHdoaWxl IG5vdywgc28gZmluYWxseSBtYWtlIGl0ICJkaXNhcHBlYXIiLgo+IAo+IFNpZ25lZC1vZmYtYnk6 IEFuZGVyIENvbnNlbHZhbiBkZSBPbGl2ZWlyYSA8YW5kZXIuY29uc2VsdmFuLmRlLm9saXZlaXJh QGludGVsLmNvbT4KCldlJ2xsIHBvcHVsYXRlIHRoZSBkZXJpdmVkIHZhbGV1cyBpbiB0aGUgY3J0 Y19zdGF0ZS0+ZHBsbCBub3cgdG9vLCBidXQKSUlSQyB0aGUgc2hhcmVkIGRwbGwgY29kZSBhbmQg c3RhdGUgY2hlY2tzIG9ubHkgdXNlIHRoZSBkcGxsX2h3X3N0YXRlCnNvIHRoaXMgc2hvdWxkIHRv dGFsbHkgT0suCgpSZXZpZXdlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3Bs YXkuYyB8IDM0ICsrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNo YW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDI0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRleCAwYWYxZTdkLi4wYjZlYWJmIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC03ODcxLDcgKzc4NzEsNiBAQCBzdGF0 aWMgaW50IGk5eHhfY3J0Y19jb21wdXRlX2Nsb2NrKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGNydGMtPmJhc2UuZGV2Owo+ICAJc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiAgCWludCByZWZj bGs7Cj4gLQlpbnRlbF9jbG9ja190IGNsb2NrOwo+ICAJYm9vbCBvazsKPiAgCWNvbnN0IGludGVs X2xpbWl0X3QgKmxpbWl0Owo+ICAKPiBAQCAtNzg5MywxOCArNzg5MiwxMiBAQCBzdGF0aWMgaW50 IGk5eHhfY3J0Y19jb21wdXRlX2Nsb2NrKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ICAJCWxp bWl0ID0gaW50ZWxfbGltaXQoY3J0Y19zdGF0ZSwgcmVmY2xrKTsKPiAgCQlvayA9IGRldl9wcml2 LT5kaXNwbGF5LmZpbmRfZHBsbChsaW1pdCwgY3J0Y19zdGF0ZSwKPiAgCQkJCQkJIGNydGNfc3Rh dGUtPnBvcnRfY2xvY2ssCj4gLQkJCQkJCSByZWZjbGssIE5VTEwsICZjbG9jayk7Cj4gKwkJCQkJ CSByZWZjbGssIE5VTEwsCj4gKwkJCQkJCSAmY3J0Y19zdGF0ZS0+ZHBsbCk7Cj4gIAkJaWYgKCFv aykgewo+ICAJCQlEUk1fRVJST1IoIkNvdWxkbid0IGZpbmQgUExMIHNldHRpbmdzIGZvciBtb2Rl IVxuIik7Cj4gIAkJCXJldHVybiAtRUlOVkFMOwo+ICAJCX0KPiAtCj4gLQkJLyogQ29tcGF0LWNv ZGUgZm9yIHRyYW5zaXRpb24sIHdpbGwgZGlzYXBwZWFyLiAqLwo+IC0JCWNydGNfc3RhdGUtPmRw bGwubiA9IGNsb2NrLm47Cj4gLQkJY3J0Y19zdGF0ZS0+ZHBsbC5tMSA9IGNsb2NrLm0xOwo+IC0J CWNydGNfc3RhdGUtPmRwbGwubTIgPSBjbG9jay5tMjsKPiAtCQljcnRjX3N0YXRlLT5kcGxsLnAx ID0gY2xvY2sucDE7Cj4gLQkJY3J0Y19zdGF0ZS0+ZHBsbC5wMiA9IGNsb2NrLnAyOwo+ICAJfQo+ ICAKPiAgCWlmIChJU19HRU4yKGRldikpIHsKPiBAQCAtODkyNSw3ICs4OTE4LDcgQEAgc3RhdGlj IHVpbnQzMl90IGlyb25sYWtlX2NvbXB1dGVfZHBsbChzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxf Y3J0YywKPiAgc3RhdGljIGludCBpcm9ubGFrZV9jcnRjX2NvbXB1dGVfY2xvY2soc3RydWN0IGlu dGVsX2NydGMgKmNydGMsCj4gIAkJCQkgICAgICAgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNy dGNfc3RhdGUpCj4gIHsKPiAtCWludGVsX2Nsb2NrX3QgY2xvY2ssIHJlZHVjZWRfY2xvY2s7Cj4g KwlpbnRlbF9jbG9ja190IHJlZHVjZWRfY2xvY2s7Cj4gIAl1MzIgZHBsbCA9IDAsIGZwID0gMCwg ZnAyID0gMDsKPiAgCWJvb2wgaGFzX3JlZHVjZWRfY2xvY2sgPSBmYWxzZTsKPiAgCXN0cnVjdCBp bnRlbF9zaGFyZWRfZHBsbCAqcGxsOwo+IEBAIC04OTM5LDIwICs4OTMyLDEzIEBAIHN0YXRpYyBp bnQgaXJvbmxha2VfY3J0Y19jb21wdXRlX2Nsb2NrKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ ICAJaWYgKCFjcnRjX3N0YXRlLT5oYXNfcGNoX2VuY29kZXIpCj4gIAkJcmV0dXJuIDA7Cj4gIAo+ IC0JaWYgKCFjcnRjX3N0YXRlLT5jbG9ja19zZXQpIHsKPiAtCQlpZiAoIWlyb25sYWtlX2NvbXB1 dGVfY2xvY2tzKCZjcnRjLT5iYXNlLCBjcnRjX3N0YXRlLCAmY2xvY2ssCj4gLQkJCQkJICAgICAm aGFzX3JlZHVjZWRfY2xvY2ssCj4gLQkJCQkJICAgICAmcmVkdWNlZF9jbG9jaykpIHsKPiAtCQkJ RFJNX0VSUk9SKCJDb3VsZG4ndCBmaW5kIFBMTCBzZXR0aW5ncyBmb3IgbW9kZSFcbiIpOwo+IC0J CQlyZXR1cm4gLUVJTlZBTDsKPiAtCQl9Cj4gLQo+IC0JCS8qIENvbXBhdC1jb2RlIGZvciB0cmFu c2l0aW9uLCB3aWxsIGRpc2FwcGVhci4gKi8KPiAtCQljcnRjX3N0YXRlLT5kcGxsLm4gPSBjbG9j ay5uOwo+IC0JCWNydGNfc3RhdGUtPmRwbGwubTEgPSBjbG9jay5tMTsKPiAtCQljcnRjX3N0YXRl LT5kcGxsLm0yID0gY2xvY2subTI7Cj4gLQkJY3J0Y19zdGF0ZS0+ZHBsbC5wMSA9IGNsb2NrLnAx Owo+IC0JCWNydGNfc3RhdGUtPmRwbGwucDIgPSBjbG9jay5wMjsKPiArCWlmICghY3J0Y19zdGF0 ZS0+Y2xvY2tfc2V0ICYmCj4gKwkgICAgIWlyb25sYWtlX2NvbXB1dGVfY2xvY2tzKCZjcnRjLT5i YXNlLCBjcnRjX3N0YXRlLAo+ICsJCQkJICAgICAmY3J0Y19zdGF0ZS0+ZHBsbCwKPiArCQkJCSAg ICAgJmhhc19yZWR1Y2VkX2Nsb2NrLAo+ICsJCQkJICAgICAmcmVkdWNlZF9jbG9jaykpIHsKPiAr CQlEUk1fRVJST1IoIkNvdWxkbid0IGZpbmQgUExMIHNldHRpbmdzIGZvciBtb2RlIVxuIik7Cj4g KwkJcmV0dXJuIC1FSU5WQUw7Cj4gIAl9Cj4gIAo+ICAJZnAgPSBpOXh4X2RwbGxfY29tcHV0ZV9m cCgmY3J0Y19zdGF0ZS0+ZHBsbCk7Cj4gLS0gCj4gMi40LjMKPiAKPiBfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QK PiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApWaWxsZSBTeXJqw6Rsw6QK SW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=