From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 14/15] drm/i915: Split g4x_crtc_compute_clock() Date: Tue, 22 Mar 2016 14:52:36 +0200 Message-ID: <20160322125236.GM4329@intel.com> References: <1458576016-30348-1-git-send-email-ander.conselvan.de.oliveira@intel.com> <1458576016-30348-15-git-send-email-ander.conselvan.de.oliveira@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id AA45F6E172 for ; Tue, 22 Mar 2016 12:53:03 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1458576016-30348-15-git-send-email-ander.conselvan.de.oliveira@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ander Conselvan de Oliveira Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBNYXIgMjEsIDIwMTYgYXQgMDY6MDA6MTVQTSArMDIwMCwgQW5kZXIgQ29uc2VsdmFu IGRlIE9saXZlaXJhIHdyb3RlOgo+IFNwbGl0IGEgRzRYIHNwZWNpZmljIHZlcnNpb24gZnJvbSBp OXh4X2NydGNfY29tcHV0ZV9jbG9jaygpLiBXaXRoIHRoaXMKPiB0aGUgZGlmZmVyZW5jZXMgYmV0 d2VlbiBwbGF0Zm9ybXMgYmVjb21lIG1vcmUgb2J2aW91cy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBB bmRlciBDb25zZWx2YW4gZGUgT2xpdmVpcmEgPGFuZGVyLmNvbnNlbHZhbi5kZS5vbGl2ZWlyYUBp bnRlbC5jb20+CgpSZXZpZXdlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3Bs YXkuYyB8IDgyICsrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUg Y2hhbmdlZCwgNTMgaW5zZXJ0aW9ucygrKSwgMjkgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IDI0NWQ2YzYuLjU1MmZkNGMgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTU2Nyw0MCArNTY3LDE2IEBAIHN0 YXRpYyBib29sIGludGVsX3BpcGVfd2lsbF9oYXZlX3R5cGUoY29uc3Qgc3RydWN0IGludGVsX2Ny dGNfc3RhdGUgKmNydGNfc3RhdGUsCj4gIH0KPiAgCj4gIHN0YXRpYyBjb25zdCBpbnRlbF9saW1p dF90ICoKPiAtaW50ZWxfZzR4X2xpbWl0KHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0 YXRlKQo+IC17Cj4gLQlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gY3J0Y19zdGF0ZS0+YmFzZS5j cnRjLT5kZXY7Cj4gLQljb25zdCBpbnRlbF9saW1pdF90ICpsaW1pdDsKPiAtCj4gLQlpZiAoaW50 ZWxfcGlwZV93aWxsX2hhdmVfdHlwZShjcnRjX3N0YXRlLCBJTlRFTF9PVVRQVVRfTFZEUykpIHsK PiAtCQlpZiAoaW50ZWxfaXNfZHVhbF9saW5rX2x2ZHMoZGV2KSkKPiAtCQkJbGltaXQgPSAmaW50 ZWxfbGltaXRzX2c0eF9kdWFsX2NoYW5uZWxfbHZkczsKPiAtCQllbHNlCj4gLQkJCWxpbWl0ID0g JmludGVsX2xpbWl0c19nNHhfc2luZ2xlX2NoYW5uZWxfbHZkczsKPiAtCX0gZWxzZSBpZiAoaW50 ZWxfcGlwZV93aWxsX2hhdmVfdHlwZShjcnRjX3N0YXRlLCBJTlRFTF9PVVRQVVRfSERNSSkgfHwK PiAtCQkgICBpbnRlbF9waXBlX3dpbGxfaGF2ZV90eXBlKGNydGNfc3RhdGUsIElOVEVMX09VVFBV VF9BTkFMT0cpKSB7Cj4gLQkJbGltaXQgPSAmaW50ZWxfbGltaXRzX2c0eF9oZG1pOwo+IC0JfSBl bHNlIGlmIChpbnRlbF9waXBlX3dpbGxfaGF2ZV90eXBlKGNydGNfc3RhdGUsIElOVEVMX09VVFBV VF9TRFZPKSkgewo+IC0JCWxpbWl0ID0gJmludGVsX2xpbWl0c19nNHhfc2R2bzsKPiAtCX0gZWxz ZSAvKiBUaGUgb3B0aW9uIGlzIGZvciBvdGhlciBvdXRwdXRzICovCj4gLQkJbGltaXQgPSAmaW50 ZWxfbGltaXRzX2k5eHhfc2R2bzsKPiAtCj4gLQlyZXR1cm4gbGltaXQ7Cj4gLX0KPiAtCj4gLXN0 YXRpYyBjb25zdCBpbnRlbF9saW1pdF90ICoKPiAgaW50ZWxfbGltaXQoc3RydWN0IGludGVsX2Ny dGNfc3RhdGUgKmNydGNfc3RhdGUsIGludCByZWZjbGspCj4gIHsKPiAgCXN0cnVjdCBkcm1fZGV2 aWNlICpkZXYgPSBjcnRjX3N0YXRlLT5iYXNlLmNydGMtPmRldjsKPiAgCWNvbnN0IGludGVsX2xp bWl0X3QgKmxpbWl0Owo+ICAKPiAgCWlmIChJU19CUk9YVE9OKGRldikgfHwgSVNfQ0hFUlJZVklF VyhkZXYpIHx8IElTX1ZBTExFWVZJRVcoZGV2KSB8fAo+IC0JICAgIEhBU19QQ0hfU1BMSVQoZGV2 KSB8fCBJU19HRU4yKGRldikpCj4gKwkgICAgSEFTX1BDSF9TUExJVChkZXYpIHx8IElTX0c0WChk ZXYpIHx8IElTX0dFTjIoZGV2KSkKPiAgCQlsaW1pdCA9IE5VTEw7Cj4gIAo+IC0JaWYgKElTX0c0 WChkZXYpKSB7Cj4gLQkJbGltaXQgPSBpbnRlbF9nNHhfbGltaXQoY3J0Y19zdGF0ZSk7Cj4gLQl9 IGVsc2UgaWYgKElTX1BJTkVWSUVXKGRldikpIHsKPiArCWlmIChJU19QSU5FVklFVyhkZXYpKSB7 Cj4gIAkJaWYgKGludGVsX3BpcGVfd2lsbF9oYXZlX3R5cGUoY3J0Y19zdGF0ZSwgSU5URUxfT1VU UFVUX0xWRFMpKQo+ICAJCQlsaW1pdCA9ICZpbnRlbF9saW1pdHNfcGluZXZpZXdfbHZkczsKPiAg CQllbHNlCj4gQEAgLTc4ODUsNiArNzg2MSw0OSBAQCBzdGF0aWMgaW50IGdlbjJfY3J0Y19jb21w dXRlX2Nsb2NrKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAg Cj4gK3N0YXRpYyBpbnQgZzR4X2NydGNfY29tcHV0ZV9jbG9jayhzdHJ1Y3QgaW50ZWxfY3J0YyAq Y3J0YywKPiArCQkJCSAgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4gK3sK PiArCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBjcnRjLT5iYXNlLmRldjsKPiArCXN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gKwljb25zdCBp bnRlbF9saW1pdF90ICpsaW1pdDsKPiArCWludCByZWZjbGsgPSA5NjAwMDsKPiArCj4gKwltZW1z ZXQoJmNydGNfc3RhdGUtPmRwbGxfaHdfc3RhdGUsIDAsCj4gKwkgICAgICAgc2l6ZW9mKGNydGNf c3RhdGUtPmRwbGxfaHdfc3RhdGUpKTsKPiArCj4gKwlpZiAoaW50ZWxfcGlwZV93aWxsX2hhdmVf dHlwZShjcnRjX3N0YXRlLCBJTlRFTF9PVVRQVVRfTFZEUykpIHsKPiArCQlpZiAoaW50ZWxfcGFu ZWxfdXNlX3NzYyhkZXZfcHJpdikpIHsKPiArCQkJcmVmY2xrID0gZGV2X3ByaXYtPnZidC5sdmRz X3NzY19mcmVxOwo+ICsJCQlEUk1fREVCVUdfS01TKCJ1c2luZyBTU0MgcmVmZXJlbmNlIGNsb2Nr IG9mICVkIGtIelxuIiwgcmVmY2xrKTsKPiArCQl9Cj4gKwo+ICsJCWlmIChpbnRlbF9pc19kdWFs X2xpbmtfbHZkcyhkZXYpKQo+ICsJCQlsaW1pdCA9ICZpbnRlbF9saW1pdHNfZzR4X2R1YWxfY2hh bm5lbF9sdmRzOwo+ICsJCWVsc2UKPiArCQkJbGltaXQgPSAmaW50ZWxfbGltaXRzX2c0eF9zaW5n bGVfY2hhbm5lbF9sdmRzOwo+ICsJfSBlbHNlIGlmIChpbnRlbF9waXBlX3dpbGxfaGF2ZV90eXBl KGNydGNfc3RhdGUsIElOVEVMX09VVFBVVF9IRE1JKSB8fAo+ICsJCSAgIGludGVsX3BpcGVfd2ls bF9oYXZlX3R5cGUoY3J0Y19zdGF0ZSwgSU5URUxfT1VUUFVUX0FOQUxPRykpIHsKPiArCQlsaW1p dCA9ICZpbnRlbF9saW1pdHNfZzR4X2hkbWk7Cj4gKwl9IGVsc2UgaWYgKGludGVsX3BpcGVfd2ls bF9oYXZlX3R5cGUoY3J0Y19zdGF0ZSwgSU5URUxfT1VUUFVUX1NEVk8pKSB7Cj4gKwkJbGltaXQg PSAmaW50ZWxfbGltaXRzX2c0eF9zZHZvOwo+ICsJfSBlbHNlIHsKPiArCQkvKiBUaGUgb3B0aW9u IGlzIGZvciBvdGhlciBvdXRwdXRzICovCj4gKwkJbGltaXQgPSAmaW50ZWxfbGltaXRzX2k5eHhf c2R2bzsKPiArCX0KPiArCj4gKwlpZiAoIWNydGNfc3RhdGUtPmNsb2NrX3NldCAmJgo+ICsJICAg ICFnNHhfZmluZF9iZXN0X2RwbGwobGltaXQsIGNydGNfc3RhdGUsIGNydGNfc3RhdGUtPnBvcnRf Y2xvY2ssCj4gKwkJCQlyZWZjbGssIE5VTEwsICZjcnRjX3N0YXRlLT5kcGxsKSkgewo+ICsJCURS TV9FUlJPUigiQ291bGRuJ3QgZmluZCBQTEwgc2V0dGluZ3MgZm9yIG1vZGUhXG4iKTsKPiArCQly ZXR1cm4gLUVJTlZBTDsKPiArCX0KPiArCj4gKwlpOXh4X2NvbXB1dGVfZHBsbChjcnRjLCBjcnRj X3N0YXRlLCBOVUxMKTsKPiArCj4gKwlyZXR1cm4gMDsKPiArfQo+ICsKPiAgc3RhdGljIGludCBp OXh4X2NydGNfY29tcHV0ZV9jbG9jayhzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiAgCQkJCSAg IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ICB7Cj4gQEAgLTE0OTA2LDkg KzE0OTI1LDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fbW9kZV9jb25maWdfZnVuY3MgaW50 ZWxfbW9kZV9mdW5jcyA9IHsKPiAgICovCj4gIHZvaWQgaW50ZWxfaW5pdF9kaXNwbGF5X2hvb2tz KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgewo+IC0JaWYgKEhBU19QQ0hf U1BMSVQoZGV2X3ByaXYpIHx8IElTX0c0WChkZXZfcHJpdikpCj4gLQkJZGV2X3ByaXYtPmRpc3Bs YXkuZmluZF9kcGxsID0gZzR4X2ZpbmRfYmVzdF9kcGxsOwo+IC0JZWxzZSBpZiAoSVNfUElORVZJ RVcoZGV2X3ByaXYpKQo+ICsJaWYgKElTX1BJTkVWSUVXKGRldl9wcml2KSkKPiAgCQlkZXZfcHJp di0+ZGlzcGxheS5maW5kX2RwbGwgPSBwbnZfZmluZF9iZXN0X2RwbGw7Cj4gIAllbHNlCj4gIAkJ ZGV2X3ByaXYtPmRpc3BsYXkuZmluZF9kcGxsID0gaTl4eF9maW5kX2Jlc3RfZHBsbDsKPiBAQCAt MTQ5NTEsNiArMTQ5NjgsMTMgQEAgdm9pZCBpbnRlbF9pbml0X2Rpc3BsYXlfaG9va3Moc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJCWRldl9wcml2LT5kaXNwbGF5LmNydGNf Y29tcHV0ZV9jbG9jayA9IHZsdl9jcnRjX2NvbXB1dGVfY2xvY2s7Cj4gIAkJZGV2X3ByaXYtPmRp c3BsYXkuY3J0Y19lbmFibGUgPSB2YWxsZXl2aWV3X2NydGNfZW5hYmxlOwo+ICAJCWRldl9wcml2 LT5kaXNwbGF5LmNydGNfZGlzYWJsZSA9IGk5eHhfY3J0Y19kaXNhYmxlOwo+ICsJfSBlbHNlIGlm IChJU19HNFgoZGV2X3ByaXYpKSB7Cj4gKwkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X3BpcGVfY29u ZmlnID0gaTl4eF9nZXRfcGlwZV9jb25maWc7Cj4gKwkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2lu aXRpYWxfcGxhbmVfY29uZmlnID0KPiArCQkJaTl4eF9nZXRfaW5pdGlhbF9wbGFuZV9jb25maWc7 Cj4gKwkJZGV2X3ByaXYtPmRpc3BsYXkuY3J0Y19jb21wdXRlX2Nsb2NrID0gZzR4X2NydGNfY29t cHV0ZV9jbG9jazsKPiArCQlkZXZfcHJpdi0+ZGlzcGxheS5jcnRjX2VuYWJsZSA9IGk5eHhfY3J0 Y19lbmFibGU7Cj4gKwkJZGV2X3ByaXYtPmRpc3BsYXkuY3J0Y19kaXNhYmxlID0gaTl4eF9jcnRj X2Rpc2FibGU7Cj4gIAl9IGVsc2UgaWYgKCFJU19HRU4yKGRldl9wcml2KSkgewo+ICAJCWRldl9w cml2LT5kaXNwbGF5LmdldF9waXBlX2NvbmZpZyA9IGk5eHhfZ2V0X3BpcGVfY29uZmlnOwo+ICAJ CWRldl9wcml2LT5kaXNwbGF5LmdldF9pbml0aWFsX3BsYW5lX2NvbmZpZyA9Cj4gLS0gCj4gMi40 LjMKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=