From: Matt Roper <matthew.d.roper@intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 0/2] drm/i915: Split up modeset state checker.
Date: Fri, 25 Mar 2016 09:59:30 -0700 [thread overview]
Message-ID: <20160325165930.GL20526@intel.com> (raw)
In-Reply-To: <1458741487-23801-1-git-send-email-maarten.lankhorst@linux.intel.com>
On Wed, Mar 23, 2016 at 02:58:05PM +0100, Maarten Lankhorst wrote:
> Right now the state checker assumes that the global state is fixed,
> with support for the atomic ioctl not all state will be locked any more,
> so the state checker has to check only what's part of the state.
>
> This is done by first splitting up the state checker in one part that
> checks all disabled connectors/encoders and global state, and then
> split again to run for each crtc separately.
While you're touching these functions, maybe it would be a good time to
rename them as well? The 'check' in their names can mislead people into
thinking that they're somehow related to the atomic 'check' phase, even
though they're actually something we do after the commit is complete.
Renaming these with s/check/confirm/ or s/check/verify/ might make it a
little bit easier to understand what their purpose is and avoid
confusion.
Matt
>
> Maarten Lankhorst (2):
> drm/i915: Make modeset state checker take crtc as argument.
> drm/i915: Move modeset state checker calls.
>
> drivers/gpu/drm/i915/intel_display.c | 310 +++++++++++++++++++----------------
> 1 file changed, 173 insertions(+), 137 deletions(-)
>
> --
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-03-25 16:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 13:58 [PATCH 0/2] drm/i915: Split up modeset state checker Maarten Lankhorst
2016-03-23 13:58 ` [PATCH 1/2] drm/i915: Make modeset state checker take crtc as argument Maarten Lankhorst
2016-04-07 23:22 ` Matt Roper
2016-03-23 13:58 ` [PATCH 2/2] drm/i915: Move modeset state checker calls Maarten Lankhorst
2016-04-07 23:23 ` Matt Roper
2016-04-08 9:38 ` Maarten Lankhorst
2016-03-25 16:59 ` Matt Roper [this message]
2016-03-29 7:33 ` [PATCH 0/2] drm/i915: Split up modeset state checker Maarten Lankhorst
2016-03-30 8:00 ` [PATCH 3/2] drm/i915: Rename hw state checker to hw state verifier Maarten Lankhorst
2016-03-30 11:26 ` Daniel Vetter
2016-04-07 23:24 ` Matt Roper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160325165930.GL20526@intel.com \
--to=matthew.d.roper@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).