From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: BUG_ON when ggtt_view is NULL
Date: Tue, 29 Mar 2016 13:46:03 +0200
Message-ID: <20160329114603.GT2510@phenom.ffwll.local>
References: <1458834860-7898-1-git-send-email-matthew.auld@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wm0-x231.google.com (mail-wm0-x231.google.com
 [IPv6:2a00:1450:400c:c09::231])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 80D3C6E5F3
 for <intel-gfx@lists.freedesktop.org>; Tue, 29 Mar 2016 11:46:02 +0000 (UTC)
Received: by mail-wm0-x231.google.com with SMTP id 127so55288551wmu.1
 for <intel-gfx@lists.freedesktop.org>; Tue, 29 Mar 2016 04:46:02 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1458834860-7898-1-git-send-email-matthew.auld@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Matthew Auld <matthew.auld@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCBNYXIgMjQsIDIwMTYgYXQgMDM6NTQ6MjBQTSArMDAwMCwgTWF0dGhldyBBdWxkIHdy
b3RlOgo+IExldHMgQlVHX09OIGFuZCBkb24ndCBib3RoZXIgd2l0aCBhIFdBUk4gYW5kIHJldHVy
bmluZyBhbiBlcnJvciwgc28gd2UgY2FuCj4gcmVtb3ZlIHRoZSBuZWVkIHRvIHBvbGx1dGUgdGhl
IGNvZGUgd2l0aCBlcnJvciBoYW5kbGluZywgYWZ0ZXIgYWxsIGl0IGlzCj4gYSBwcm9ncmFtbWVy
IGVycm9yIHRvIHByb3ZpZGUgTlVMTCB2aWV3LiBBbHNvIHdoaWxlIHdlJ3JlIGhlcmUgcmVtb3Zl
Cj4gcmVkdW5kYW50IE5VTEwgZ2d0dF92aWV3IGNoZWNrLgo+IAo+IENjOiBKb29uYXMgTGFodGlu
ZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IFR2cnRrbyBVcnN1bGlu
IDx0dnJ0a28udXJzdWxpbkBsaW51eC5pbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogTWF0dGhl
dyBBdWxkIDxtYXR0aGV3LmF1bGRAaW50ZWwuY29tPgoKWWVhaCwgc2VlbXMgdG8gaGF2ZSBzcHJh
d2xlZCB0b28gbXVjaCBmb3Igbm90IG11Y2ggZ2Fpbi4gQlVHX09OIGFwcHJvdmVkCjstKQoKQWNr
ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gLS0tCj4gIGRy
aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgICAgIHwgIDkgKystLS0tLS0tCj4gIGRyaXZl
cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jIHwgMTAgKy0tLS0tLS0tLQo+ICAyIGZpbGVz
IGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp
dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx
NS9pOTE1X2dlbS5jCj4gaW5kZXggYzdhOTk3YS4uY2JmNjE2YSAxMDA2NDQKPiAtLS0gYS9kcml2
ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv
aTkxNV9nZW0uYwo+IEBAIC00MjM1LDkgKzQyMzUsNiBAQCBpOTE1X2dlbV9vYmplY3RfZG9fcGlu
KHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmosCj4gIAl2bWEgPSBnZ3R0X3ZpZXcgPyBp
OTE1X2dlbV9vYmpfdG9fZ2d0dF92aWV3KG9iaiwgZ2d0dF92aWV3KSA6Cj4gIAkJCSAgaTkxNV9n
ZW1fb2JqX3RvX3ZtYShvYmosIHZtKTsKPiAgCj4gLQlpZiAoSVNfRVJSKHZtYSkpCj4gLQkJcmV0
dXJuIFBUUl9FUlIodm1hKTsKPiAtCj4gIAlpZiAodm1hKSB7Cj4gIAkJaWYgKFdBUk5fT04odm1h
LT5waW5fY291bnQgPT0gRFJNX0k5MTVfR0VNX09CSkVDVF9NQVhfUElOX0NPVU5UKSkKPiAgCQkJ
cmV0dXJuIC1FQlVTWTsKPiBAQCAtNDMwMCw4ICs0Mjk3LDcgQEAgaTkxNV9nZW1fb2JqZWN0X2dn
dHRfcGluKHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmosCj4gIAkJCSB1aW50MzJfdCBh
bGlnbm1lbnQsCj4gIAkJCSB1aW50NjRfdCBmbGFncykKPiAgewo+IC0JaWYgKFdBUk5fT05DRSgh
dmlldywgIm5vIHZpZXcgc3BlY2lmaWVkIikpCj4gLQkJcmV0dXJuIC1FSU5WQUw7Cj4gKwlCVUdf
T04oIXZpZXcpOwo+ICAKPiAgCXJldHVybiBpOTE1X2dlbV9vYmplY3RfZG9fcGluKG9iaiwgaTkx
NV9vYmpfdG9fZ2d0dChvYmopLCB2aWV3LAo+ICAJCQkJICAgICAgYWxpZ25tZW50LCBmbGFncyB8
IFBJTl9HTE9CQUwpOwo+IEBAIC00NjE4LDggKzQ2MTQsNyBAQCBzdHJ1Y3QgaTkxNV92bWEgKmk5
MTVfZ2VtX29ial90b19nZ3R0X3ZpZXcoc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwK
PiAgCXN0cnVjdCBpOTE1X2FkZHJlc3Nfc3BhY2UgKmdndHQgPSBpOTE1X29ial90b19nZ3R0KG9i
aik7Cj4gIAlzdHJ1Y3QgaTkxNV92bWEgKnZtYTsKPiAgCj4gLQlpZiAoV0FSTl9PTkNFKCF2aWV3
LCAibm8gdmlldyBzcGVjaWZpZWQiKSkKPiAtCQlyZXR1cm4gRVJSX1BUUigtRUlOVkFMKTsKPiAr
CUJVR19PTighdmlldyk7Cj4gIAo+ICAJbGlzdF9mb3JfZWFjaF9lbnRyeSh2bWEsICZvYmotPnZt
YV9saXN0LCBvYmpfbGluaykKPiAgCQlpZiAodm1hLT52bSA9PSBnZ3R0ICYmCj4gZGlmZiAtLWdp
dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jIGIvZHJpdmVycy9ncHUvZHJt
L2k5MTUvaTkxNV9nZW1fZ3R0LmMKPiBpbmRleCA3Y2ZhZmRjLi4wNzNjNmJiIDEwMDY0NAo+IC0t
LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jCj4gKysrIGIvZHJpdmVycy9n
cHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMKPiBAQCAtMzM0MSwxNSArMzM0MSw3IEBAIGk5MTVf
Z2VtX29ial9sb29rdXBfb3JfY3JlYXRlX2dndHRfdm1hKHN0cnVjdCBkcm1faTkxNV9nZW1fb2Jq
ZWN0ICpvYmosCj4gIAkJCQkgICAgICAgY29uc3Qgc3RydWN0IGk5MTVfZ2d0dF92aWV3ICp2aWV3
KQo+ICB7Cj4gIAlzdHJ1Y3QgaTkxNV9hZGRyZXNzX3NwYWNlICpnZ3R0ID0gaTkxNV9vYmpfdG9f
Z2d0dChvYmopOwo+IC0Jc3RydWN0IGk5MTVfdm1hICp2bWE7Cj4gLQo+IC0JaWYgKFdBUk5fT04o
IXZpZXcpKQo+IC0JCXJldHVybiBFUlJfUFRSKC1FSU5WQUwpOwo+IC0KPiAtCXZtYSA9IGk5MTVf
Z2VtX29ial90b19nZ3R0X3ZpZXcob2JqLCB2aWV3KTsKPiAtCj4gLQlpZiAoSVNfRVJSKHZtYSkp
Cj4gLQkJcmV0dXJuIHZtYTsKPiArCXN0cnVjdCBpOTE1X3ZtYSAqdm1hID0gaTkxNV9nZW1fb2Jq
X3RvX2dndHRfdmlldyhvYmosIHZpZXcpOwo+ICAKPiAgCWlmICghdm1hKQo+ICAJCXZtYSA9IF9f
aTkxNV9nZW1fdm1hX2NyZWF0ZShvYmosIGdndHQsIHZpZXcpOwo+IC0tIAo+IDIuNC4zCj4gCj4g
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1n
ZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBz
Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAK
RGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDov
L2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au
b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt
Z2Z4Cg==