From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH v3 2/2] drm/i915/guc: always reset GuC
 before loading firmware
Date: Tue, 29 Mar 2016 13:48:16 +0200
Message-ID: <20160329114816.GU2510@phenom.ffwll.local>
References: <1458844815-25925-1-git-send-email-david.s.gordon@intel.com>
 <1458844815-25925-2-git-send-email-david.s.gordon@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com
 [IPv6:2a00:1450:400c:c09::243])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 837806E5F6
 for <intel-gfx@lists.freedesktop.org>; Tue, 29 Mar 2016 11:48:15 +0000 (UTC)
Received: by mail-wm0-x243.google.com with SMTP id p65so4449970wmp.1
 for <intel-gfx@lists.freedesktop.org>; Tue, 29 Mar 2016 04:48:15 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1458844815-25925-2-git-send-email-david.s.gordon@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Dave Gordon <david.s.gordon@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCBNYXIgMjQsIDIwMTYgYXQgMDY6NDA6MTVQTSArMDAwMCwgRGF2ZSBHb3Jkb24gd3Jv
dGU6Cj4gQWZ0ZXIgYSBzdXNwZW5kLXJlc3VtZSBjeWNsZSwgdGhlIHJlc3VtZWQga2VybmVsIGhh
cyBubyBpZGVhIHdoYXQgdGhlCj4gYm9vdGVkIGtlcm5lbCBtYXkgaGF2ZSBkb25lIHRvIHRoZSBH
dUMgYmVmb3JlIHJlcGxhY2luZyBpdHNlbGYgd2l0aCB0aGUKPiByZXN1bWVkIGltYWdlLiBJbiBw
YXJ0aWN1bGFyLCBpdCBtYXkgaGF2ZSBhbHJlYWR5IGxvYWRlZCB0aGUgR3VDIHdpdGgKPiBmaXJt
d2FyZSwgd2hpY2ggd2lsbCB0aGVuIGNhdXNlIHRoaXMga2VybmVsJ3MgYXR0ZW1wdCB0byAocmUp
bG9hZCB0aGUKPiBmaXJtd2FyZSB0byBmYWlsIChHdUMgcHJvZ3JhbSBtZW1vcnkgaXMgd3JpdGUt
b25jZSEpLiBUaGUgc3ltcHRvbXMKPiAoR3VDIGZpcm13YXJlIHJlbG9hZCBmYWlscyBhZnRlciBo
aWJlcm5hdGlvbikgYXJlIGZ1cnRoZXIgZGVzY3JpYmVkCj4gaW4gdGhlIEJ1Z3ppbGxhIHJlZmVy
ZW5jZSBiZWxvdy4KPiAKPiBTbyBsZXQncyAqYWx3YXlzKiByZXNldCB0aGUgR3VDIGp1c3QgYmVm
b3JlIChyZSlsb2FkaW5nIHRoZSBmaXJtd2FyZTsKPiB0aGVuIHRoZSBoYXJkd2FyZSBzaG91bGQg
dGhlbiBiZSBpbiBhIHdlbGwta25vd24gc3RhdGUsIGFuZCB3ZSBtYXkgZXZlbgo+IGF2b2lkIHNv
bWUgb2YgdGhlIGlzc3VlcyBhcmlzaW5nIGZyb20gdW5wcmVkaWN0YWJsZSB0aW1pbmcuCj4gCj4g
QWxzbyBhZGRlZCBzb21lIG1vcmUgZmllbGRzICYgdmFsdWVzIHRvIHRoZSBkZWZpbml0aW9uIG9m
IHRoZSBHVUNfU1RBVFVTCj4gcmVnaXN0ZXIsIHdoaWNoIGlzIHRoZSBrZXkgZGlhZ25vc3RpYyBp
bmRpY2F0b3IgaWYgdGhlIEd1QyBsb2FkIGZhaWxzLgo+IAo+IFNpZ25lZC1vZmYtYnk6IERhdmUg
R29yZG9uIDxkYXZpZC5zLmdvcmRvbkBpbnRlbC5jb20+Cj4gUmV2aWV3ZWQtYnk6IEFydW4gU2ls
dXZlcnkgPGFydW4uc2lsdXZlcnlAbGludXguaW50ZWwuY29tPgo+IENjOiBBbGV4IERhaSA8eXUu
ZGFpQGludGVsLmNvbT4KPiBCdWd6aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9OTQzOTAKCkkgZ3Vlc3MgYm90aCBvZiB0aGVzZSBzaG91bGQgYmUgbGFi
ZWxsZWQgQ2M6IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmcgd2hlbgptZXJnaW5nLgotRGFuaWVsCgo+
IAo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19yZWcuaCAgICAgfCAxMiAr
KysrKysrKy0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYyB8IDQw
ICsrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDI5
IGluc2VydGlvbnMoKyksIDIzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJz
L2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19yZWcuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf
Z3VjX3JlZy5oCj4gaW5kZXggOTRjZWVlNS4uODA3ODZkOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz
L2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19yZWcuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L2k5MTVfZ3VjX3JlZy5oCj4gQEAgLTI3LDEwICsyNywxMiBAQAo+ICAvKiBEZWZpbml0aW9ucyBv
ZiBHdUMgSC9XIHJlZ2lzdGVycywgYml0cywgZXRjICovCj4gIAo+ICAjZGVmaW5lIEdVQ19TVEFU
VVMJCQlfTU1JTygweGMwMDApCj4gLSNkZWZpbmUgICBHU19NSUFfSU5fUkVTRVQJCSgxIDw8IDAp
Cj4gKyNkZWZpbmUgICBHU19SRVNFVF9TSElGVAkJMAo+ICsjZGVmaW5lICAgR1NfTUlBX0lOX1JF
U0VUCQkgICgweDAxIDw8IEdTX1JFU0VUX1NISUZUKQo+ICAjZGVmaW5lICAgR1NfQk9PVFJPTV9T
SElGVAkJMQo+ICAjZGVmaW5lICAgR1NfQk9PVFJPTV9NQVNLCQkgICgweDdGIDw8IEdTX0JPT1RS
T01fU0hJRlQpCj4gICNkZWZpbmUgICBHU19CT09UUk9NX1JTQV9GQUlMRUQJCSAgKDB4NTAgPDwg
R1NfQk9PVFJPTV9TSElGVCkKPiArI2RlZmluZSAgIEdTX0JPT1RST01fSlVNUF9QQVNTRUQJICAo
MHg3NiA8PCBHU19CT09UUk9NX1NISUZUKQo+ICAjZGVmaW5lICAgR1NfVUtFUk5FTF9TSElGVAkJ
OAo+ICAjZGVmaW5lICAgR1NfVUtFUk5FTF9NQVNLCQkgICgweEZGIDw8IEdTX1VLRVJORUxfU0hJ
RlQpCj4gICNkZWZpbmUgICBHU19VS0VSTkVMX0xBUElDX0RPTkUJCSAgKDB4MzAgPDwgR1NfVUtF
Uk5FTF9TSElGVCkKPiBAQCAtMzgsNyArNDAsMTMgQEAKPiAgI2RlZmluZSAgIEdTX1VLRVJORUxf
UkVBRFkJCSAgKDB4RjAgPDwgR1NfVUtFUk5FTF9TSElGVCkKPiAgI2RlZmluZSAgIEdTX01JQV9T
SElGVAkJCTE2Cj4gICNkZWZpbmUgICBHU19NSUFfTUFTSwkJCSAgKDB4MDcgPDwgR1NfTUlBX1NI
SUZUKQo+IC0jZGVmaW5lICAgR1NfTUlBX0NPUkVfU1RBVEUJCSAgKDEgPDwgR1NfTUlBX1NISUZU
KQo+ICsjZGVmaW5lICAgR1NfTUlBX0NPUkVfU1RBVEUJCSAgKDB4MDEgPDwgR1NfTUlBX1NISUZU
KQo+ICsjZGVmaW5lICAgR1NfTUlBX0hBTFRfUkVRVUVTVEVECQkgICgweDAyIDw8IEdTX01JQV9T
SElGVCkKPiArI2RlZmluZSAgIEdTX01JQV9JU1JfRU5UUlkJCSAgKDB4MDQgPDwgR1NfTUlBX1NI
SUZUKQo+ICsjZGVmaW5lICAgR1NfQVVUSF9TVEFUVVNfU0hJRlQJCTMwCj4gKyNkZWZpbmUgICBH
U19BVVRIX1NUQVRVU19NQVNLCQkgICgweDAzIDw8IEdTX0FVVEhfU1RBVFVTX1NISUZUKQo+ICsj
ZGVmaW5lICAgR1NfQVVUSF9TVEFUVVNfQkFECQkgICgweDAxIDw8IEdTX0FVVEhfU1RBVFVTX1NI
SUZUKQo+ICsjZGVmaW5lICAgR1NfQVVUSF9TVEFUVVNfR09PRAkJICAoMHgwMiA8PCBHU19BVVRI
X1NUQVRVU19TSElGVCkKPiAgCj4gICNkZWZpbmUgU09GVF9TQ1JBVENIKG4pCQkJX01NSU8oMHhj
MTgwICsgKG4pICogNCkKPiAgI2RlZmluZSBTT0ZUX1NDUkFUQ0hfQ09VTlQJCTE2Cj4gZGlmZiAt
LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYyBiL2RyaXZlcnMv
Z3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYwo+IGluZGV4IGQ4NGM1NjAuLjg3NmU1ZGEg
MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvYWRlci5jCj4g
KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvYWRlci5jCj4gQEAgLTM4Nyw3
ICszODcsNyBAQCBpbnQgaW50ZWxfZ3VjX3Vjb2RlX2xvYWQoc3RydWN0IGRybV9kZXZpY2UgKmRl
dikKPiAgewo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZf
cHJpdmF0ZTsKPiAgCXN0cnVjdCBpbnRlbF9ndWNfZncgKmd1Y19mdyA9ICZkZXZfcHJpdi0+Z3Vj
Lmd1Y19mdzsKPiAtCWludCBlcnIgPSAwOwo+ICsJaW50IHJldHJpZXMsIGVyciA9IDA7Cj4gIAo+
ICAJaWYgKCFpOTE1LmVuYWJsZV9ndWNfc3VibWlzc2lvbikKPiAgCQlyZXR1cm4gMDsKPiBAQCAt
NDQxLDI5ICs0NDEsMjYgQEAgaW50IGludGVsX2d1Y191Y29kZV9sb2FkKHN0cnVjdCBkcm1fZGV2
aWNlICpkZXYpCj4gIAkgKiBzdGVwcGluZ3MgYWxzbyBzbyB0aGlzIGlzIGV4dGVuZGVkIGFzIHdl
bGwuCj4gIAkgKi8KPiAgCS8qIFdhRW5hYmxlR3VDQm9vdEhhc2hDaGVja05vdFNldDpza2wsYnh0
ICovCj4gLQllcnIgPSBndWNfdWNvZGVfeGZlcihkZXZfcHJpdik7Cj4gLQlpZiAoZXJyKSB7Cj4g
LQkJaW50IHJldHJpZXMgPSAzOwo+IC0KPiAtCQlEUk1fRVJST1IoIkd1QyBmdyBsb2FkIGZhaWxl
ZCwgZXJyPSVkLCBhdHRlbXB0aW5nIHJlc2V0IGFuZCByZXRyeVxuIiwgZXJyKTsKPiAtCj4gLQkJ
d2hpbGUgKHJldHJpZXMtLSkgewo+IC0JCQllcnIgPSBpOTE1X3Jlc2V0X2d1YyhkZXZfcHJpdik7
Cj4gLQkJCWlmIChlcnIpCj4gLQkJCQlicmVhazsKPiAtCj4gLQkJCWVyciA9IGd1Y191Y29kZV94
ZmVyKGRldl9wcml2KTsKPiAtCQkJaWYgKCFlcnIpIHsKPiAtCQkJCURSTV9ERUJVR19EUklWRVIo
Ikd1QyBmdyByZWxvYWQgc3VjY2VlZGVkIGFmdGVyIHJlc2V0XG4iKTsKPiAtCQkJCWJyZWFrOwo+
IC0JCQl9Cj4gLQkJCURSTV9ERUJVR19EUklWRVIoIkd1QyBmdyByZWxvYWQgcmV0cmllcyBsZWZ0
OiAlZFxuIiwgcmV0cmllcyk7Cj4gLQkJfQo+IC0KPiArCWZvciAocmV0cmllcyA9IDM7IDsgKSB7
Cj4gKwkJLyoKPiArCQkgKiBBbHdheXMgcmVzZXQgdGhlIEd1QyBqdXN0IGJlZm9yZSAocmUpbG9h
ZGluZywgc28KPiArCQkgKiB0aGF0IHRoZSBzdGF0ZSBhbmQgdGltaW5nIGFyZSBmYWlybHkgcHJl
ZGljdGFibGUKPiArCQkgKi8KPiArCQllcnIgPSBpOTE1X3Jlc2V0X2d1YyhkZXZfcHJpdik7Cj4g
IAkJaWYgKGVycikgewo+IC0JCQlEUk1fRVJST1IoIkd1QyBmdyByZWxvYWQgYXR0ZW1wdCBmYWls
ZWQsIHJldD0lZFxuIiwgZXJyKTsKPiArCQkJRFJNX0VSUk9SKCJHdUMgcmVzZXQgZmFpbGVkLCBl
cnIgJWRcbiIsIGVycik7Cj4gIAkJCWdvdG8gZmFpbDsKPiAgCQl9Cj4gKwo+ICsJCWVyciA9IGd1
Y191Y29kZV94ZmVyKGRldl9wcml2KTsKPiArCQlpZiAoIWVycikKPiArCQkJYnJlYWs7Cj4gKwo+
ICsJCWlmICgtLXJldHJpZXMgPT0gMCkKPiArCQkJZ290byBmYWlsOwo+ICsKPiArCQlEUk1fSU5G
TygiR3VDIGZ3IGxvYWQgZmFpbGVkLCBlcnIgJWQ7IHdpbGwgcmVzZXQgYW5kICIKPiArCQkJInJl
dHJ5ICVkIG1vcmUgdGltZShzKVxuIiwgZXJyLCByZXRyaWVzKTsKPiAgCX0KPiAgCj4gIAlndWNf
ZnctPmd1Y19md19sb2FkX3N0YXR1cyA9IEdVQ19GSVJNV0FSRV9TVUNDRVNTOwo+IEBAIC00ODUs
NiArNDgyLDcgQEAgaW50IGludGVsX2d1Y191Y29kZV9sb2FkKHN0cnVjdCBkcm1fZGV2aWNlICpk
ZXYpCj4gIAlyZXR1cm4gMDsKPiAgCj4gIGZhaWw6Cj4gKwlEUk1fRVJST1IoIkd1QyBmaXJtd2Fy
ZSBsb2FkIGZhaWxlZCwgZXJyICVkXG4iLCBlcnIpOwo+ICAJaWYgKGd1Y19mdy0+Z3VjX2Z3X2xv
YWRfc3RhdHVzID09IEdVQ19GSVJNV0FSRV9QRU5ESU5HKQo+ICAJCWd1Y19mdy0+Z3VjX2Z3X2xv
YWRfc3RhdHVzID0gR1VDX0ZJUk1XQVJFX0ZBSUw7Cj4gIAo+IC0tIAo+IDEuOS4xCj4gCj4gX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZngg
bWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8v
bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKRGFu
aWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Js
b2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn
Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4
Cg==