Re: [PATCH] drm/ttm: Remove TTM_HAS_AGP

Emil Velikov
2016-03-30T12:53:38Z

On 30 March 2016 at 12:24, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> It tries to do fancy things with excluding agp support if ttm is
> built-in, but agp isn't. Instead just express this depency like drm
> does and use CONFIG_AGP everywhere.
>
> Also use the neat Makefile magic to make the entire ttm_agp_backend
> file optional.
>
> v2: Use IS_ENABLED(CONFIG_AGP) as suggested by Ville
>
> v3: Review from Emil.
>
> v4: Actually get it right as spotted by 0-day.
>
Nice one. I didn't even spot the typo/thinko in v3 ;-)

> Cc: Emil Velikov <emil.l.velikov@gmail.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>

-Emil