Re: [Intel-gfx] [PATCH 01/10] drm/ttm: Remove TTM_HAS_AGP

kbuild test robot
2016-03-30T11:00:37Z

[-- Attachment #1: Type: text/plain, Size: 8586 bytes --]

Hi Daniel,

[auto build test ERROR on drm/drm-next]
[also build test ERROR on v4.6-rc1 next-20160330]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/Another-shot-at-cruft-removal/20160330-174803
base: git://people.freedesktop.org/~airlied/linux.git drm-next
config: i386-allmodconfig (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

All error/warnings (new ones prefixed by >>):

drivers/gpu/drm/nouveau/nouveau_bo.c: In function 'nouveau_ttm_tt_create':
>> drivers/gpu/drm/nouveau/nouveau_bo.c:581:10: error: implicit declaration of function 'ttm_agp_tt_create' [-Werror=implicit-function-declaration]
return ttm_agp_tt_create(bdev, drm->agp.bridge, size,
^
>> drivers/gpu/drm/nouveau/nouveau_bo.c:581:10: warning: return makes pointer from integer without a cast [-Wint-conversion]
drivers/gpu/drm/nouveau/nouveau_bo.c: In function 'nouveau_ttm_tt_populate':
>> drivers/gpu/drm/nouveau/nouveau_bo.c:1501:10: error: implicit declaration of function 'ttm_agp_tt_populate' [-Werror=implicit-function-declaration]
return ttm_agp_tt_populate(ttm);
^
drivers/gpu/drm/nouveau/nouveau_bo.c: In function 'nouveau_ttm_tt_unpopulate':
>> drivers/gpu/drm/nouveau/nouveau_bo.c:1568:3: error: implicit declaration of function 'ttm_agp_tt_unpopulate' [-Werror=implicit-function-declaration]
ttm_agp_tt_unpopulate(ttm);
^
cc1: some warnings being treated as errors
--
drivers/gpu/drm/radeon/radeon_ttm.c: In function 'radeon_ttm_tt_create':
>> drivers/gpu/drm/radeon/radeon_ttm.c:685:10: error: implicit declaration of function 'ttm_agp_tt_create' [-Werror=implicit-function-declaration]
return ttm_agp_tt_create(bdev, rdev->ddev->agp->bridge,
^
>> drivers/gpu/drm/radeon/radeon_ttm.c:685:10: warning: return makes pointer from integer without a cast [-Wint-conversion]
drivers/gpu/drm/radeon/radeon_ttm.c: In function 'radeon_ttm_tt_populate':
>> drivers/gpu/drm/radeon/radeon_ttm.c:741:10: error: implicit declaration of function 'ttm_agp_tt_populate' [-Werror=implicit-function-declaration]
return ttm_agp_tt_populate(ttm);
^
drivers/gpu/drm/radeon/radeon_ttm.c: In function 'radeon_ttm_tt_unpopulate':
>> drivers/gpu/drm/radeon/radeon_ttm.c:792:3: error: implicit declaration of function 'ttm_agp_tt_unpopulate' [-Werror=implicit-function-declaration]
ttm_agp_tt_unpopulate(ttm);
^
cc1: some warnings being treated as errors

vim +/ttm_agp_tt_unpopulate +1568 drivers/gpu/drm/nouveau/nouveau_bo.c

26c9e8eff Ben Skeggs 2015-08-20 1495 if (!nvxx_device(&drm->device)->func->cpu_coherent &&
c3a0c771e Alexandre Courbot 2014-10-27 1496 ttm->caching_state == tt_uncached)
c3a0c771e Alexandre Courbot 2014-10-27 1497 return ttm_dma_populate(ttm_dma, dev->dev);
c3a0c771e Alexandre Courbot 2014-10-27 1498
a7fb8a23c Daniel Vetter 2015-09-09 1499 #if IS_ENABLED(CONFIG_AGP)
340b0e7c5 Ben Skeggs 2015-08-20 1500 if (drm->agp.bridge) {
dea7e0ac4 Jerome Glisse 2012-01-03 @1501 return ttm_agp_tt_populate(ttm);
dea7e0ac4 Jerome Glisse 2012-01-03 1502 }
dea7e0ac4 Jerome Glisse 2012-01-03 1503 #endif
dea7e0ac4 Jerome Glisse 2012-01-03 1504
9bcd38de5 Alexandre Courbot 2016-03-02 1505 #if IS_ENABLED(CONFIG_SWIOTLB) && IS_ENABLED(CONFIG_X86)
3230cfc34 Konrad Rzeszutek Wilk 2011-10-17 1506 if (swiotlb_nr_tbl()) {
8e7e70522 Jerome Glisse 2011-11-09 1507 return ttm_dma_populate((void *)ttm, dev->dev);
3230cfc34 Konrad Rzeszutek Wilk 2011-10-17 1508 }
3230cfc34 Konrad Rzeszutek Wilk 2011-10-17 1509 #endif
3230cfc34 Konrad Rzeszutek Wilk 2011-10-17 1510
3230cfc34 Konrad Rzeszutek Wilk 2011-10-17 1511 r = ttm_pool_populate(ttm);
3230cfc34 Konrad Rzeszutek Wilk 2011-10-17 1512 if (r) {
3230cfc34 Konrad Rzeszutek Wilk 2011-10-17 1513 return r;
3230cfc34 Konrad Rzeszutek Wilk 2011-10-17 1514 }
3230cfc34 Konrad Rzeszutek Wilk 2011-10-17 1515
3230cfc34 Konrad Rzeszutek Wilk 2011-10-17 1516 for (i = 0; i < ttm->num_pages; i++) {
fd1496a0f Alexandre Courbot 2014-07-31 1517 dma_addr_t addr;
fd1496a0f Alexandre Courbot 2014-07-31 1518
fd1496a0f Alexandre Courbot 2014-07-31 1519 addr = dma_map_page(pdev, ttm->pages[i], 0, PAGE_SIZE,
fd1496a0f Alexandre Courbot 2014-07-31 1520 DMA_BIDIRECTIONAL);
fd1496a0f Alexandre Courbot 2014-07-31 1521
fd1496a0f Alexandre Courbot 2014-07-31 1522 if (dma_mapping_error(pdev, addr)) {
4fbbed46d Rasmus Villemoes 2016-02-15 1523 while (i--) {
fd1496a0f Alexandre Courbot 2014-07-31 1524 dma_unmap_page(pdev, ttm_dma->dma_address[i],
fd1496a0f Alexandre Courbot 2014-07-31 1525 PAGE_SIZE, DMA_BIDIRECTIONAL);
8e7e70522 Jerome Glisse 2011-11-09 1526 ttm_dma->dma_address[i] = 0;
3230cfc34 Konrad Rzeszutek Wilk 2011-10-17 1527 }
3230cfc34 Konrad Rzeszutek Wilk 2011-10-17 1528 ttm_pool_unpopulate(ttm);
3230cfc34 Konrad Rzeszutek Wilk 2011-10-17 1529 return -EFAULT;
3230cfc34 Konrad Rzeszutek Wilk 2011-10-17 1530 }
fd1496a0f Alexandre Courbot 2014-07-31 1531
fd1496a0f Alexandre Courbot 2014-07-31 1532 ttm_dma->dma_address[i] = addr;
3230cfc34 Konrad Rzeszutek Wilk 2011-10-17 1533 }
3230cfc34 Konrad Rzeszutek Wilk 2011-10-17 1534 return 0;
3230cfc34 Konrad Rzeszutek Wilk 2011-10-17 1535 }
3230cfc34 Konrad Rzeszutek Wilk 2011-10-17 1536
3230cfc34 Konrad Rzeszutek Wilk 2011-10-17 1537 static void
3230cfc34 Konrad Rzeszutek Wilk 2011-10-17 1538 nouveau_ttm_tt_unpopulate(struct ttm_tt *ttm)
3230cfc34 Konrad Rzeszutek Wilk 2011-10-17 1539 {
8e7e70522 Jerome Glisse 2011-11-09 1540 struct ttm_dma_tt *ttm_dma = (void *)ttm;
ebb945a94 Ben Skeggs 2012-07-20 1541 struct nouveau_drm *drm;
be83cd4ef Ben Skeggs 2015-01-14 1542 struct nvkm_device *device;
3230cfc34 Konrad Rzeszutek Wilk 2011-10-17 1543 struct drm_device *dev;
fd1496a0f Alexandre Courbot 2014-07-31 1544 struct device *pdev;
3230cfc34 Konrad Rzeszutek Wilk 2011-10-17 1545 unsigned i;
22b33e8ed Dave Airlie 2012-04-02 1546 bool slave = !!(ttm->page_flags & TTM_PAGE_FLAG_SG);
22b33e8ed Dave Airlie 2012-04-02 1547
22b33e8ed Dave Airlie 2012-04-02 1548 if (slave)
22b33e8ed Dave Airlie 2012-04-02 1549 return;
3230cfc34 Konrad Rzeszutek Wilk 2011-10-17 1550
ebb945a94 Ben Skeggs 2012-07-20 1551 drm = nouveau_bdev(ttm->bdev);
989aa5b76 Ben Skeggs 2015-01-12 1552 device = nvxx_device(&drm->device);
ebb945a94 Ben Skeggs 2012-07-20 1553 dev = drm->dev;
26c9e8eff Ben Skeggs 2015-08-20 1554 pdev = device->dev;
3230cfc34 Konrad Rzeszutek Wilk 2011-10-17 1555
c3a0c771e Alexandre Courbot 2014-10-27 1556 /*
c3a0c771e Alexandre Courbot 2014-10-27 1557 * Objects matching this condition have been marked as force_coherent,
c3a0c771e Alexandre Courbot 2014-10-27 1558 * so use the DMA API for them.
c3a0c771e Alexandre Courbot 2014-10-27 1559 */
26c9e8eff Ben Skeggs 2015-08-20 1560 if (!nvxx_device(&drm->device)->func->cpu_coherent &&
dcccdc143 Alexandre Courbot 2014-12-11 1561 ttm->caching_state == tt_uncached) {
c3a0c771e Alexandre Courbot 2014-10-27 1562 ttm_dma_unpopulate(ttm_dma, dev->dev);
dcccdc143 Alexandre Courbot 2014-12-11 1563 return;
dcccdc143 Alexandre Courbot 2014-12-11 1564 }
c3a0c771e Alexandre Courbot 2014-10-27 1565
a7fb8a23c Daniel Vetter 2015-09-09 1566 #if IS_ENABLED(CONFIG_AGP)
340b0e7c5 Ben Skeggs 2015-08-20 1567 if (drm->agp.bridge) {
dea7e0ac4 Jerome Glisse 2012-01-03 @1568 ttm_agp_tt_unpopulate(ttm);
dea7e0ac4 Jerome Glisse 2012-01-03 1569 return;
dea7e0ac4 Jerome Glisse 2012-01-03 1570 }
dea7e0ac4 Jerome Glisse 2012-01-03 1571 #endif

:::::: The code at line 1568 was first introduced by commit
:::::: dea7e0ac45fd28f90bbc38ff226d36a9f788efbf ttm: fix agp since ttm tt rework

:::::: TO: Jerome Glisse <jglisse@redhat.com>
:::::: CC: Dave Airlie <airlied@redhat.com>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 53506 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org