Re: [Intel-gfx] [PATCH 05/10] drm: Give drm_agp_clear drm_legacy_ prefix

Thierry Reding
2016-03-30T12:59:47Z

[-- Attachment #1.1: Type: text/plain, Size: 2105 bytes --]

On Wed, Mar 30, 2016 at 06:09:04PM +0800, kbuild test robot wrote:
> Hi Daniel,
>
> [auto build test ERROR on drm/drm-next]
> [also build test ERROR on v4.6-rc1 next-20160330]
> [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
>
> url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/Another-shot-at-cruft-removal/20160330-174803
> base: git://people.freedesktop.org/~airlied/linux.git drm-next
> config: sparc64-allmodconfig (attached as .config)
> reproduce:
> wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> make.cross ARCH=sparc64
>
> Note: the linux-review/Daniel-Vetter/Another-shot-at-cruft-removal/20160330-174803 HEAD 0ef75daff5d81f77ebd5796d853c534749223b2e builds fine.
> It only hurts bisectibility.
>
> All errors (new ones prefixed by >>):
>
> drivers/gpu/drm/drm_fops.c: In function 'drm_lastclose':
> >> drivers/gpu/drm/drm_fops.c:416:2: error: implicit declaration of function 'drm_legacy_agp_clear' [-Werror=implicit-function-declaration]
> drm_legacy_agp_clear(dev);
> ^
> cc1: some warnings being treated as errors
> --
> drivers/gpu/drm/drm_pci.c: In function 'drm_pci_agp_destroy':
> >> drivers/gpu/drm/drm_pci.c:253:3: error: implicit declaration of function 'drm_legacy_agp_clear' [-Werror=implicit-function-declaration]
> drm_legacy_agp_clear(dev);
> ^
> cc1: some warnings being treated as errors
>
> vim +/drm_legacy_agp_clear +416 drivers/gpu/drm/drm_fops.c
>
> 410
> 411 if (dev->irq_enabled && !drm_core_check_feature(dev, DRIVER_MODESET))
> 412 drm_irq_uninstall(dev);
> 413
> 414 mutex_lock(&dev->struct_mutex);
> 415
> > 416 drm_legacy_agp_clear(dev);
> 417
> 418 drm_legacy_sg_cleanup(dev);
> 419 drm_legacy_vma_flush(dev);

FWIW, this is because the dummy implementation wasn't renamed.

Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org