Re: [PATCH v2 1/3] drm/i915/shrinker: Account for unshrinkable unbound pages

Joonas Lahtinen
2016-04-05T07:56:35Z

On ma, 2016-04-04 at 14:46 +0100, Chris Wilson wrote:
> Since we only attempt to purge an object if can_release_pages() report
> true, we should also only add it to the count of potential recoverable
> pages when can_release_pages() is true.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Akash Goel <akash.goel@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_gem_shrinker.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_shrinker.c b/drivers/gpu/drm/i915/i915_gem_shrinker.c
> index d3c473ffb90a..e391ee3ec486 100644
> --- a/drivers/gpu/drm/i915/i915_gem_shrinker.c
> +++ b/drivers/gpu/drm/i915/i915_gem_shrinker.c
> @@ -246,7 +246,7 @@ i915_gem_shrinker_count(struct shrinker *shrinker, struct shrink_control *sc)
>
>   count = 0;
>   list_for_each_entry(obj, &dev_priv->mm.unbound_list, global_list)
> - if (obj->pages_pin_count == 0)
> + if (can_release_pages(obj))
>   count += obj->base.size >> PAGE_SHIFT;
>
>   list_for_each_entry(obj, &dev_priv->mm.bound_list, global_list) {
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation