From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v3 2/6] drm/i915/dsi: abstract VLV gpio element execution to a separate function Date: Thu, 7 Apr 2016 16:00:51 +0300 Message-ID: <20160407130051.GG4329@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 82C806E997 for ; Thu, 7 Apr 2016 13:01:02 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBBcHIgMDUsIDIwMTYgYXQgMTA6MzA6NTBQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gUHJlcGFyZSBmb3IgZnV0dXJlLiBObyBmdW5jdGlvbmFsIGNoYW5nZXMuCj4gCj4gdjI6 IE1vdmUgZWFybGllciBpbiB0aGUgc2VyaWVzLiBVc2UgYm9vbCBmb3IgZ3BpbyB2YWx1ZS4KPiAK PiBTaWduZWQtb2ZmLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+IC0t LQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kc2lfcGFuZWxfdmJ0LmMgfCA2OCArKysr KysrKysrKysrKystLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDM1IGluc2VydGlv bnMoKyksIDMzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kc2lfcGFuZWxfdmJ0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k c2lfcGFuZWxfdmJ0LmMKPiBpbmRleCAyMTk2NGJhMGJmMzQuLjZjMjc3NGNlYjY5ZiAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kc2lfcGFuZWxfdmJ0LmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kc2lfcGFuZWxfdmJ0LmMKPiBAQCAtMTg3LDQx ICsxODcsMjEgQEAgc3RhdGljIGNvbnN0IHU4ICptaXBpX2V4ZWNfZGVsYXkoc3RydWN0IGludGVs X2RzaSAqaW50ZWxfZHNpLCBjb25zdCB1OCAqZGF0YSkKPiAgCXJldHVybiBkYXRhOwo+ICB9Cj4g IAo+IC1zdGF0aWMgY29uc3QgdTggKm1pcGlfZXhlY19ncGlvKHN0cnVjdCBpbnRlbF9kc2kgKmlu dGVsX2RzaSwgY29uc3QgdTggKmRhdGEpCj4gK3N0YXRpYyB2b2lkIHZsdl9leGVjX2dwaW8oc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICsJCQkgIHU4IGdwaW9fc291cmNlLCB1 OCBncGlvX2luZGV4LCBib29sIHZhbHVlKQo+ICB7Cj4gLQl1OCBncGlvX3NvdXJjZSwgZ3Bpb19p bmRleCwgYWN0aW9uLCBwb3J0Owo+ICAJdTE2IHBjb25mMCwgcGFkdmFsOwo+IC0JdTMyIHZhbDsK PiAtCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBpbnRlbF9kc2ktPmJhc2UuYmFzZS5kZXY7Cj4g LQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2YXRlOwo+ IC0KPiAtCWlmIChkZXZfcHJpdi0+dmJ0LmRzaS5zZXFfdmVyc2lvbiA+PSAzKQo+IC0JCWRhdGEr KzsKPiAtCj4gLQlncGlvX2luZGV4ID0gKmRhdGErKzsKPiAtCj4gLQkvKiBncGlvIHNvdXJjZSBp biBzZXF1ZW5jZSB2MiBvbmx5ICovCj4gLQlpZiAoZGV2X3ByaXYtPnZidC5kc2kuc2VxX3ZlcnNp b24gPT0gMikKPiAtCQlncGlvX3NvdXJjZSA9ICgqZGF0YSA+PiAxKSAmIDM7Cj4gLQllbHNlCj4g LQkJZ3Bpb19zb3VyY2UgPSAwOwo+IC0KPiAtCS8qIHB1bGwgdXAvZG93biAqLwo+IC0JYWN0aW9u ID0gKmRhdGErKyAmIDE7Cj4gKwl1MzIgdG1wOwo+ICsJdTggcG9ydDsKPiAgCj4gIAlpZiAoZ3Bp b19pbmRleCA+PSBBUlJBWV9TSVpFKHZsdl9ncGlvX3RhYmxlKSkgewo+ICAJCURSTV9ERUJVR19L TVMoInVua25vd24gZ3BpbyBpbmRleCAldVxuIiwgZ3Bpb19pbmRleCk7Cj4gLQkJZ290byBvdXQ7 Cj4gLQl9Cj4gLQo+IC0JaWYgKCFJU19WQUxMRVlWSUVXKGRldl9wcml2KSkgewo+IC0JCURSTV9E RUJVR19LTVMoIkdQSU8gZWxlbWVudCBub3Qgc3VwcG9ydGVkIG9uIHRoaXMgcGxhdGZvcm1cbiIp Owo+IC0JCWdvdG8gb3V0Owo+ICsJCXJldHVybjsKPiAgCX0KPiAgCj4gIAlpZiAoZGV2X3ByaXYt PnZidC5kc2kuc2VxX3ZlcnNpb24gPj0gMykgewo+ICAJCURSTV9ERUJVR19LTVMoIkdQSU8gZWxl bWVudCB2MyBub3Qgc3VwcG9ydGVkXG4iKTsKPiAtCQlnb3RvIG91dDsKPiArCQlyZXR1cm47Cj4g IAl9IGVsc2Ugewo+ICAJCWlmIChncGlvX3NvdXJjZSA9PSAwKSB7Cj4gIAkJCXBvcnQgPSBJT1NG X1BPUlRfR1BJT19OQzsKPiBAQCAtMjI5LDcgKzIwOSw3IEBAIHN0YXRpYyBjb25zdCB1OCAqbWlw aV9leGVjX2dwaW8oc3RydWN0IGludGVsX2RzaSAqaW50ZWxfZHNpLCBjb25zdCB1OCAqZGF0YSkK PiAgCQkJcG9ydCA9IElPU0ZfUE9SVF9HUElPX1NDOwo+ICAJCX0gZWxzZSB7Cj4gIAkJCURSTV9E RUJVR19LTVMoInVua25vd24gZ3BpbyBzb3VyY2UgJXVcbiIsIGdwaW9fc291cmNlKTsKPiAtCQkJ Z290byBvdXQ7Cj4gKwkJCXJldHVybjsKPiAgCQl9Cj4gIAl9Cj4gIAo+IEBAIC0yMzgsMTkgKzIx OCw0MSBAQCBzdGF0aWMgY29uc3QgdTggKm1pcGlfZXhlY19ncGlvKHN0cnVjdCBpbnRlbF9kc2kg KmludGVsX2RzaSwgY29uc3QgdTggKmRhdGEpCj4gIAo+ICAJbXV0ZXhfbG9jaygmZGV2X3ByaXYt PnNiX2xvY2spOwo+ICAJaWYgKCF2bHZfZ3Bpb190YWJsZVtncGlvX2luZGV4XS5pbml0KSB7Cj4g LQkJLyogcHJvZ3JhbSB0aGUgZnVuY3Rpb24gKi8KPiAtCQkvKiBGSVhNRTogcmVtb3ZlIGNvbnN0 YW50IGJlbG93ICovCgpGSVhNRSBzdGlsbCBzZWVtcyB2YWxpZC4KCk90aGVyd2lzZSBsZ3RtClJl dmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29t PgoKPiAgCQl2bHZfaW9zZl9zYl93cml0ZShkZXZfcHJpdiwgcG9ydCwgcGNvbmYwLCAweDIwMDBD QzAwKTsKPiAgCQl2bHZfZ3Bpb190YWJsZVtncGlvX2luZGV4XS5pbml0ID0gdHJ1ZTsKPiAgCX0K PiAgCj4gLQl2YWwgPSAweDQgfCBhY3Rpb247Cj4gKwl0bXAgPSAweDQgfCB2YWx1ZTsKPiArCXZs dl9pb3NmX3NiX3dyaXRlKGRldl9wcml2LCBwb3J0LCBwYWR2YWwsIHRtcCk7Cj4gKwltdXRleF91 bmxvY2soJmRldl9wcml2LT5zYl9sb2NrKTsKPiArfQo+ICsKPiArc3RhdGljIGNvbnN0IHU4ICpt aXBpX2V4ZWNfZ3BpbyhzdHJ1Y3QgaW50ZWxfZHNpICppbnRlbF9kc2ksIGNvbnN0IHU4ICpkYXRh KQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gaW50ZWxfZHNpLT5iYXNlLmJhc2Uu ZGV2Owo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJp dmF0ZTsKPiArCXU4IGdwaW9fc291cmNlLCBncGlvX2luZGV4Owo+ICsJYm9vbCB2YWx1ZTsKPiAr Cj4gKwlpZiAoZGV2X3ByaXYtPnZidC5kc2kuc2VxX3ZlcnNpb24gPj0gMykKPiArCQlkYXRhKys7 Cj4gKwo+ICsJZ3Bpb19pbmRleCA9ICpkYXRhKys7Cj4gKwo+ICsJLyogZ3BpbyBzb3VyY2UgaW4g c2VxdWVuY2UgdjIgb25seSAqLwo+ICsJaWYgKGRldl9wcml2LT52YnQuZHNpLnNlcV92ZXJzaW9u ID09IDIpCj4gKwkJZ3Bpb19zb3VyY2UgPSAoKmRhdGEgPj4gMSkgJiAzOwo+ICsJZWxzZQo+ICsJ CWdwaW9fc291cmNlID0gMDsKPiAgCj4gIAkvKiBwdWxsIHVwL2Rvd24gKi8KPiAtCXZsdl9pb3Nm X3NiX3dyaXRlKGRldl9wcml2LCBwb3J0LCBwYWR2YWwsIHZhbCk7Cj4gLQltdXRleF91bmxvY2so JmRldl9wcml2LT5zYl9sb2NrKTsKPiArCXZhbHVlID0gKmRhdGErKyAmIDE7Cj4gKwo+ICsJaWYg KElTX1ZBTExFWVZJRVcoZGV2X3ByaXYpKQo+ICsJCXZsdl9leGVjX2dwaW8oZGV2X3ByaXYsIGdw aW9fc291cmNlLCBncGlvX2luZGV4LCB2YWx1ZSk7Cj4gKwllbHNlCj4gKwkJRFJNX0RFQlVHX0tN UygiR1BJTyBlbGVtZW50IG5vdCBzdXBwb3J0ZWQgb24gdGhpcyBwbGF0Zm9ybVxuIik7Cj4gIAo+ IC1vdXQ6Cj4gIAlyZXR1cm4gZGF0YTsKPiAgfQo+ICAKPiAtLSAKPiAyLjEuNAoKLS0gClZpbGxl IFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg==