Re: [PATCH v2 3/5] drm/i915/bxt: Corrected the guid for bxt.

David Weinehall
2016-04-08T12:55:36Z

On Fri, Apr 08, 2016 at 12:00:22PM +0300, Jani Nikula wrote:
> On Thu, 07 Apr 2016, Animesh Manna <animesh.manna@intel.com> wrote:
> > Guid is changed for bxt platform, so corrected the guid for bxt.
> >
> > Signed-off-by: Ananth Krishna R <ananth.krishna.r@intel.com>
> > Signed-off-by: Bharath K Veera <bharath.k.veera@intel.com>
> > Signed-off-by: Animesh Manna <animesh.manna@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_acpi.c | 8 +++++++-
> > 1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_acpi.c b/drivers/gpu/drm/i915/intel_acpi.c
> > index 8f3d672..8ba30b3 100644
> > --- a/drivers/gpu/drm/i915/intel_acpi.c
> > +++ b/drivers/gpu/drm/i915/intel_acpi.c
> > @@ -17,7 +17,7 @@ static struct intel_dsm_priv {
> > acpi_handle dhandle;
> > } intel_dsm_priv;
> >
> > -static const u8 intel_dsm_guid[] = {
> > +static u8 intel_dsm_guid[] = {
> > 0xd3, 0x73, 0xd8, 0x7e,
> > 0xd0, 0xc2,
> > 0x4f, 0x4e,
> > @@ -25,6 +25,9 @@ static const u8 intel_dsm_guid[] = {
> > 0x0f, 0x13, 0x17, 0xb0, 0x1c, 0x2c
> > };
> >
> > +static u8 intel_bxt_dsm_guid[] =
> > + "3E5B41C6-EB1D-4260-9D15-C71FBADAE414";
> > +
>
> So I want both of these to be either in string form or in binary uuid
> form, not a mixture. Having them in binary makes the code simpler, so
> I'd go for that.

I was just gonna suggest the same. Also, isn't this a fix we want
merged independently from the HPD-related changes? If so this
should submitted separately (or at least be modified so it can be
the first patch in the series).

Kind regards, David