From: Ben Widawsky <ben@bwidawsk.net>
To: Dave Gordon <david.s.gordon@intel.com>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>,
Mika Kuoppala <mika.kuoppala@intel.com>
Subject: Re: [PATCH] drm/i915: Provide a modparam to disable firmware loading
Date: Wed, 13 Apr 2016 10:48:40 -0700 [thread overview]
Message-ID: <20160413174839.GA29751@mail.bwidawsk.net> (raw)
In-Reply-To: <570E85BC.6010108@intel.com>
On Wed, Apr 13, 2016 at 06:45:32PM +0100, Dave Gordon wrote:
> On 13/04/16 17:57, Ben Widawsky wrote:
> > For debug and development purposes only.
> >
> > Cc: Mika Kuoppala <mika.kuoppala@intel.com>
> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> > ---
> > drivers/gpu/drm/i915/i915_debugfs.c | 13 +++++++++++++
> > drivers/gpu/drm/i915/i915_gpu_error.c | 3 +++
> > drivers/gpu/drm/i915/i915_params.c | 6 ++++++
> > drivers/gpu/drm/i915/i915_params.h | 1 +
> > drivers/gpu/drm/i915/intel_csr.c | 11 +++++++++++
> > drivers/gpu/drm/i915/intel_guc_loader.c | 11 +++++++++++
> > 6 files changed, 45 insertions(+)
>
> You can already disable GuC loading in the existing driver by turning off
> GuC submission,
I saw this. I believe that behavior is incorrect but I didn't bother to fix it.
GuC submission and GuC loading are separate.
> or if you have the previously-posted "add enable_guc_loading" patch, then you
> can separately control the loading of the GuC firmware and the use of the GuC
> for batch submission.
Sounds to me like that patch should be merged, and we could roll that into this
and give me what I want.
>
> .Dave.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-04-13 17:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 16:57 [PATCH] drm/i915: Provide a modparam to disable firmware loading Ben Widawsky
2016-04-13 17:45 ` Dave Gordon
2016-04-13 17:48 ` Ben Widawsky [this message]
2016-04-14 8:27 ` Jani Nikula
2016-04-14 15:07 ` Ben Widawsky
2016-04-14 11:53 ` ✗ Fi.CI.BAT: warning for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160413174839.GA29751@mail.bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=david.s.gordon@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox