Re: [PATCH v5 13/24] input: misc: max8997: explicitly apply PWM config extracted from pwm_args

Dmitry Torokhov
2016-04-17T12:45:48Z

On Thu, Apr 14, 2016 at 09:17:33PM +0200, Boris Brezillon wrote:
> Call pwm_apply_args() just after requesting the PWM device so that the
> polarity and period are initialized according to the information provided
> in pwm_args.
>
> This is an intermediate state, and pwm_apply_args() should be dropped as
> soon as the atomic PWM infrastructure is in place and the driver makes
> use of it.
>
> Signed-off-by: Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> ---
> drivers/input/misc/max8997_haptic.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/input/misc/max8997_haptic.c b/drivers/input/misc/max8997_haptic.c
> index a806ba3..bf17f65 100644
> --- a/drivers/input/misc/max8997_haptic.c
> +++ b/drivers/input/misc/max8997_haptic.c
> @@ -304,6 +304,12 @@ static int max8997_haptic_probe(struct platform_device *pdev)
> error);
> goto err_free_mem;
> }
> +
> + /*
> + * FIXME: pwm_apply_args() should be removed when switching to
> + * the atomic PWM API.
> + */
> + pwm_apply_args(chip->pwm);

I do not understand. We did not fetch/modify any args, what are we
applying and why? Especially since we saying we want to remove this
later.

Thanks.

--
Dmitry