From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 4/4] drm/i915/gen9: Fix runtime PM refcounting in case DMC firmware isn't loaded Date: Wed, 20 Apr 2016 15:02:24 +0200 Message-ID: <20160420130224.GA2510@phenom.ffwll.local> References: <1460963062-13211-5-git-send-email-imre.deak@intel.com> <1460980101-14713-1-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x233.google.com (mail-wm0-x233.google.com [IPv6:2a00:1450:400c:c09::233]) by gabe.freedesktop.org (Postfix) with ESMTPS id 346E66E9BD for ; Wed, 20 Apr 2016 13:02:29 +0000 (UTC) Received: by mail-wm0-x233.google.com with SMTP id n3so80666865wmn.0 for ; Wed, 20 Apr 2016 06:02:29 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1460980101-14713-1-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBBcHIgMTgsIDIwMTYgYXQgMDI6NDg6MjFQTSArMDMwMCwgSW1yZSBEZWFrIHdyb3Rl Ogo+IFdoaWxlIHdlIGRpc2FibGUgcnVudGltZSBQTSBhbmQgd2l0aCB0aGF0IGRpc3BsYXkgcG93 ZXIgd2VsbCBzdXBwb3J0IGlmCj4gdGhlIERNQyBmaXJtd2FyZSBpc24ndCBsb2FkZWQsIHdlIHN0 aWxsIHdhbnQgdG8gZGlzYWJsZSBwb3dlciB3ZWxscwo+IGR1cmluZyBzeXN0ZW0gc3VzcGVuZCBh bmQgZHJpdmVyIHVubG9hZC4gU28gZHJvcC9yZWFjcXVpcmUgdGhlCj4gY29ycmVzcG9uZGluZyBw b3dlciByZWZjb3VudCBkdXJpbmcgc3VzcGVuZC9yZXN1bWUgYW5kIGRyaXZlciB1bmxvYWRpbmcu Cj4gVGhpcyBhbHNvIG1lYW5zIHdlIGhhdmUgdG8gY2hlY2sgaWYgRE1DIGlzIG5vdCBsb2FkZWQg YW5kIHNraXAgZW5hYmxpbmcKPiBEQyBzdGF0ZXMgaW4gdGhlIHBvd2VyIHdlbGwgY29kZS4KPiAK PiB2MjoKPiAtIFJldXNlIGludGVsX2Nzcl91Y29kZV9zdXNwZW5kKCkgaW4gaW50ZWxfY3NyX3Vj b2RlX2ZpbmkoKSBpbnN0ZWFkIG9mCj4gICBvcGVuY29kaW5nIHRoZSBmb3JtZXIuIChDaHJpcykK PiAtIEFkZCBkb2Nib29rIGNvbW1lbnQgdG8gdGhlIHB1YmxpYyByZXN1bWUgYW5kIHN1c3BlbmQg ZnVuY3Rpb25zLgo+IAo+IENDOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51 az4KPiBTaWduZWQtb2ZmLWJ5OiBJbXJlIERlYWsgPGltcmUuZGVha0BpbnRlbC5jb20+Cj4gCj4g LS0tCj4gCj4gQXMgdGhpcyBmaXhlcyB0aGUgc3BlY2lhbCBjYXNlIHdoZW4gZmlybXdhcmUgbG9h ZGluZyBmYWlsZWQgd2l0aCB0aGUKPiByZXN1bHQgb2YgcG9zc2libHkgbGVhdmluZyBwb3dlciB3 ZWxscyBlbmFibGVkIGR1cmluZyBzdXNwZW5kL3Jlc3VtZSBhbmQKPiBkcml2ZXIgdW5sb2FkaW5n IGl0J3Mgbm90IGZvciAtZml4ZXMgb3Igc3RhYmxlLgoKRG8gd2UgZXZlbiBjYXJlIGFib3V0IHRo aXMgdG8gYm90aGVyIGZpeGluZyBpdD8gV2UgcHJldHR5IG11Y2ggYWdyZWVkIHRoYXQKd2UgbmVl ZCBkbWMgdG8gbWFrZSBwb3dlciBtYW5hZ2VtZW50IHdvcmsgb24gc2tsLCBzbyBpZiBpdCBkb2Vz bid0IHdvcmsKdG9vIHdlbGwgb3ZlciBzdXNwZW5kL3Jlc3VtZSAoc29peCksIG1laC4KCkFuZCB5 b3VyIHBhdGNoIGhlcmUgZG9lcyBtYWtlIHRoZSBzdXNwZW5kL3Jlc3VtZSBjb2RlIGV2ZW4gbW9y ZSBmcmFnaWxlCmFuZCBmaWxsZWQgd2l0aCBzcGVjaWFsIGNhc2VzLCBzbyBub3QgdG9vIHN1cmUg d2Ugc2hvdWxkIGFwcGx5IHRoaXMgb25lLgotRGFuaWVsCgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2Rydi5jICAgICAgICAgfCAgNSArKy0tCj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Nzci5jICAgICAgICB8IDQ0ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysr KystLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCAgICAgICAgfCAgMiArKwo+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMgfCAgMyArKysKPiAgNCBm aWxlcyBjaGFuZ2VkLCA1MCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9kcnYuYwo+IGluZGV4IDNiNzllOTcuLjlhMDE2ZjEgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZHJ2LmMKPiBAQCAtNjQwLDggKzY0MCw3IEBAIHN0YXRpYyBpbnQgaTkxNV9kcm1f c3VzcGVuZChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAKPiAgCWludGVsX2Rpc3BsYXlfc2V0 X2luaXRfcG93ZXIoZGV2X3ByaXYsIGZhbHNlKTsKPiAgCj4gLQlpZiAoSEFTX0NTUihkZXZfcHJp dikpCj4gLQkJZmx1c2hfd29yaygmZGV2X3ByaXYtPmNzci53b3JrKTsKPiArCWludGVsX2Nzcl91 Y29kZV9zdXNwZW5kKGRldl9wcml2KTsKPiAgCj4gIG91dDoKPiAgCWVuYWJsZV9ycG1fd2FrZXJl Zl9hc3NlcnRzKGRldl9wcml2KTsKPiBAQCAtNzMzLDYgKzczMiw4IEBAIHN0YXRpYyBpbnQgaTkx NV9kcm1fcmVzdW1lKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gIAo+ICAJZGlzYWJsZV9ycG1f d2FrZXJlZl9hc3NlcnRzKGRldl9wcml2KTsKPiAgCj4gKwlpbnRlbF9jc3JfdWNvZGVfcmVzdW1l KGRldl9wcml2KTsKPiArCj4gIAltdXRleF9sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4gIAlp OTE1X2dlbV9yZXN0b3JlX2d0dF9tYXBwaW5ncyhkZXYpOwo+ICAJbXV0ZXhfdW5sb2NrKCZkZXYt PnN0cnVjdF9tdXRleCk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Nzci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY3NyLmMKPiBpbmRleCBkNTdiMDBl Li5hMzRjMjNlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Nzci5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY3NyLmMKPiBAQCAtNDY3LDEwICs0 NjcsNTAgQEAgdm9pZCBpbnRlbF9jc3JfdWNvZGVfaW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYpCj4gIH0KPiAgCj4gIC8qKgo+ICsgKiBpbnRlbF9jc3JfdWNvZGVfc3VzcGVu ZCgpIC0gcHJlcGFyZSBDU1IgZmlybXdhcmUgYmVmb3JlIHN5c3RlbSBzdXNwZW5kCj4gKyAqIEBk ZXZfcHJpdjogaTkxNSBkcm0gZGV2aWNlCj4gKyAqCj4gKyAqIFByZXBhcmUgdGhlIERNQyBmaXJt d2FyZSBiZWZvcmUgZW50ZXJpbmcgc3lzdGVtIHN1c3BlbmQuIFRoaXMgaW5jbHVkZXMKPiArICog Zmx1c2hpbmcgcGVuZGluZyB3b3JrIGl0ZW1zIGFuZCByZWxlYXNpbmcgYW55IHJlc291cmNlcyBh Y3F1aXJlZCBkdXJpbmcKPiArICogaW5pdC4KPiArICovCj4gK3ZvaWQgaW50ZWxfY3NyX3Vjb2Rl X3N1c3BlbmQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICt7Cj4gKwlpZiAo IUhBU19DU1IoZGV2X3ByaXYpKQo+ICsJCXJldHVybjsKPiArCj4gKwlmbHVzaF93b3JrKCZkZXZf cHJpdi0+Y3NyLndvcmspOwo+ICsKPiArCS8qIERyb3AgdGhlIHJlZmVyZW5jZSBoZWxkIGluIGNh c2UgRE1DIGlzbid0IGxvYWRlZC4gKi8KPiArCWlmICghZGV2X3ByaXYtPmNzci5kbWNfcGF5bG9h ZCkKPiArCQlpbnRlbF9kaXNwbGF5X3Bvd2VyX3B1dChkZXZfcHJpdiwgUE9XRVJfRE9NQUlOX0lO SVQpOwo+ICt9Cj4gKwo+ICsvKioKPiArICogaW50ZWxfY3NyX3Vjb2RlX3Jlc3VtZSgpIC0gaW5p dCBDU1IgZmlybXdhcmUgZHVyaW5nIHN5c3RlbSByZXN1bWUKPiArICogQGRldl9wcml2OiBpOTE1 IGRybSBkZXZpY2UKPiArICoKPiArICogUmVpbml0aWFsaXplIHRoZSBETUMgZmlybXdhcmUgZHVy aW5nIHN5c3RlbSByZXN1bWUsIHJlYWNxdWlyaW5nIGFueQo+ICsgKiByZXNvdXJjZXMgcmVsZWFz ZWQgaW4gaW50ZWxfY3NyX3Vjb2RlX3N1c3BlbmQoKS4KPiArICovCj4gK3ZvaWQgaW50ZWxfY3Ny X3Vjb2RlX3Jlc3VtZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gK3sKPiAr CWlmICghSEFTX0NTUihkZXZfcHJpdikpCj4gKwkJcmV0dXJuOwo+ICsKPiArCS8qCj4gKwkgKiBS ZWFjcXVpcmUgdGhlIHJlZmVyZW5jZSB0byBrZWVwIFJQTSBkaXNhYmxlZCBpbiBjYXNlIERNQyBp c24ndAo+ICsJICogbG9hZGVkLgo+ICsJICovCj4gKwlpZiAoIWRldl9wcml2LT5jc3IuZG1jX3Bh eWxvYWQpCj4gKwkJaW50ZWxfZGlzcGxheV9wb3dlcl9nZXQoZGV2X3ByaXYsIFBPV0VSX0RPTUFJ Tl9JTklUKTsKPiArfQo+ICsKPiArLyoqCj4gICAqIGludGVsX2Nzcl91Y29kZV9maW5pKCkgLSB1 bmxvYWQgdGhlIENTUiBmaXJtd2FyZS4KPiAgICogQGRldl9wcml2OiBpOTE1IGRybSBkZXZpY2Uu Cj4gICAqCj4gLSAqIEZpcm1td2FyZSB1bmxvYWRpbmcgaW5jbHVkZXMgZnJlZWluZyB0aGUgaW50 ZXJuYWwgbW9tb3J5IGFuZCByZXNldCB0aGUKPiArICogRmlybW13YXJlIHVubG9hZGluZyBpbmNs dWRlcyBmcmVlaW5nIHRoZSBpbnRlcm5hbCBtZW1vcnkgYW5kIHJlc2V0IHRoZQo+ICAgKiBmaXJt d2FyZSBsb2FkaW5nIHN0YXR1cy4KPiAgICovCj4gIHZvaWQgaW50ZWxfY3NyX3Vjb2RlX2Zpbmko c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+IEBAIC00NzgsNyArNTE4LDcgQEAg dm9pZCBpbnRlbF9jc3JfdWNvZGVfZmluaShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYpCj4gIAlpZiAoIUhBU19DU1IoZGV2X3ByaXYpKQo+ICAJCXJldHVybjsKPiAgCj4gLQlmbHVz aF93b3JrKCZkZXZfcHJpdi0+Y3NyLndvcmspOwo+ICsJaW50ZWxfY3NyX3Vjb2RlX3N1c3BlbmQo ZGV2X3ByaXYpOwo+ICAKPiAgCWtmcmVlKGRldl9wcml2LT5jc3IuZG1jX3BheWxvYWQpOwo+ICB9 Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBpbmRleCAxMGRmZTcyLi5iZWVkOWU4IDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBAQCAtMTI3NSw2ICsxMjc1LDggQEAgdTMyIHNr bF9wbGFuZV9jdGxfcm90YXRpb24odW5zaWduZWQgaW50IHJvdGF0aW9uKTsKPiAgdm9pZCBpbnRl bF9jc3JfdWNvZGVfaW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqKTsKPiAgdm9pZCBpbnRl bF9jc3JfbG9hZF9wcm9ncmFtKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICopOwo+ICB2b2lkIGlu dGVsX2Nzcl91Y29kZV9maW5pKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICopOwo+ICt2b2lkIGlu dGVsX2Nzcl91Y29kZV9zdXNwZW5kKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICopOwo+ICt2b2lk IGludGVsX2Nzcl91Y29kZV9yZXN1bWUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKik7Cj4gIAo+ ICAvKiBpbnRlbF9kcC5jICovCj4gIHZvaWQgaW50ZWxfZHBfaW5pdChzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2LCBpOTE1X3JlZ190IG91dHB1dF9yZWcsIGVudW0gcG9ydCBwb3J0KTsKPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcnVudGltZV9wbS5jIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfcnVudGltZV9wbS5jCj4gaW5kZXggMjU5ZjY2Zi4uYmZhODU0OCAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMKPiBAQCAtODA5LDYg KzgwOSw5IEBAIHN0YXRpYyB2b2lkIGdlbjlfZGNfb2ZmX3Bvd2VyX3dlbGxfZW5hYmxlKHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgc3RhdGljIHZvaWQgZ2VuOV9kY19vZmZf cG93ZXJfd2VsbF9kaXNhYmxlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAg CQkJCQkgICBzdHJ1Y3QgaTkxNV9wb3dlcl93ZWxsICpwb3dlcl93ZWxsKQo+ICB7Cj4gKwlpZiAo IWRldl9wcml2LT5jc3IuZG1jX3BheWxvYWQpCj4gKwkJcmV0dXJuOwo+ICsKPiAgCWlmIChkZXZf cHJpdi0+Y3NyLmFsbG93ZWRfZGNfbWFzayAmIERDX1NUQVRFX0VOX1VQVE9fREM2KQo+ICAJCXNr bF9lbmFibGVfZGM2KGRldl9wcml2KTsKPiAgCWVsc2UgaWYgKGRldl9wcml2LT5jc3IuYWxsb3dl ZF9kY19tYXNrICYgRENfU1RBVEVfRU5fVVBUT19EQzUpCj4gLS0gCj4gMi41LjAKPiAKPiBfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBt YWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApEYW5p ZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxv Zy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK