From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Bride Subject: Re: [PATCH v2 06/18] drm/i915: Unduplicate CHV encoders' post pll disable code Date: Wed, 20 Apr 2016 10:20:35 -0700 Message-ID: <20160420172035.GA13777@shiv> References: <1460569673-13694-1-git-send-email-ander.conselvan.de.oliveira@intel.com> <1461129648-9981-1-git-send-email-ander.conselvan.de.oliveira@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 8F8C26EAA3 for ; Wed, 20 Apr 2016 17:20:46 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1461129648-9981-1-git-send-email-ander.conselvan.de.oliveira@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ander Conselvan de Oliveira Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBBcHIgMjAsIDIwMTYgYXQgMDg6MjA6NDhBTSArMDMwMCwgQW5kZXIgQ29uc2VsdmFu IGRlIE9saXZlaXJhIHdyb3RlOgo+IFRoZSBleGFjdCBzYW1lIGNvZGUgd2FzIHVzZWQgYnkgSERN SSBhbmQgRFAgZW5jb2RlcnMsIHNvIG1vdmUgaXQgdG8KPiBpbnRlbF9kcGlvX3BoeS5jLgo+IAo+ IHYyOiBGaXggdHlwbyBpbiB0aGUgY29tbWl0IG1lc3NhZ2UuIChKaW0gQnJpZGUpCj4gQ2M6IEpp bSBCcmlkZSA8amltLmJyaWRlQGxpbnV4LmludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBBbmRl ciBDb25zZWx2YW4gZGUgT2xpdmVpcmEgPGFuZGVyLmNvbnNlbHZhbi5kZS5vbGl2ZWlyYUBpbnRl bC5jb20+CgpSZXZpZXdlZC1ieTogSmltIEJyaWRlIDxqaW0uYnJpZGVAbGludXguaW50ZWwuY29t PgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCAgICAgICB8ICAxICsK PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyAgICAgICB8IDMwICstLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGlvX3Bo eS5jIHwgMzMgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2hkbWkuYyAgICAgfCAzMCArLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0KPiAgNCBmaWxlcyBjaGFuZ2VkLCAzNiBpbnNlcnRpb25zKCspLCA1OCBkZWxldGlvbnMo LSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBpbmRleCAzYWNhNjNmLi45NjI1YjA2IDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gQEAgLTM1OTIsNiArMzU5Miw3IEBAIHZvaWQg Y2h2X2RhdGFfbGFuZV9zb2Z0X3Jlc2V0KHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ ICB2b2lkIGNodl9waHlfcHJlX3BsbF9lbmFibGUoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29k ZXIpOwo+ICB2b2lkIGNodl9waHlfcHJlX2VuY29kZXJfZW5hYmxlKHN0cnVjdCBpbnRlbF9lbmNv ZGVyICplbmNvZGVyKTsKPiAgdm9pZCBjaHZfcGh5X3JlbGVhc2VfY2wyX292ZXJyaWRlKHN0cnVj dCBpbnRlbF9lbmNvZGVyICplbmNvZGVyKTsKPiArdm9pZCBjaHZfcGh5X3Bvc3RfZGlzYWJsZShz dHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2Rlcik7Cj4gIAo+ICBpbnQgaW50ZWxfZ3B1X2ZyZXEo c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCBpbnQgdmFsKTsKPiAgaW50IGludGVs X2ZyZXFfb3Bjb2RlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgaW50IHZhbCk7 Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gaW5kZXggMTE0NTQ4ZC4uOTkwMmFhNyAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+IEBAIC0yODM4LDM1ICsyODM4LDcgQEAgc3RhdGljIHZv aWQgY2h2X2RwX3ByZV9wbGxfZW5hYmxlKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyKQo+ ICAKPiAgc3RhdGljIHZvaWQgY2h2X2RwX3Bvc3RfcGxsX2Rpc2FibGUoc3RydWN0IGludGVsX2Vu Y29kZXIgKmVuY29kZXIpCj4gIHsKPiAtCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diA9IHRvX2k5MTUoZW5jb2Rlci0+YmFzZS5kZXYpOwo+IC0JZW51bSBwaXBlIHBpcGUgPSB0b19p bnRlbF9jcnRjKGVuY29kZXItPmJhc2UuY3J0YyktPnBpcGU7Cj4gLQl1MzIgdmFsOwo+IC0KPiAt CW11dGV4X2xvY2soJmRldl9wcml2LT5zYl9sb2NrKTsKPiAtCj4gLQkvKiBkaXNhYmxlIGxlZnQv cmlnaHQgY2xvY2sgZGlzdHJpYnV0aW9uICovCj4gLQlpZiAocGlwZSAhPSBQSVBFX0IpIHsKPiAt CQl2YWwgPSB2bHZfZHBpb19yZWFkKGRldl9wcml2LCBwaXBlLCBfQ0hWX0NNTl9EVzVfQ0gwKTsK PiAtCQl2YWwgJj0gfihDSFZfQlVGTEVGVEVOQTFfTUFTSyB8IENIVl9CVUZSSUdIVEVOQTFfTUFT Syk7Cj4gLQkJdmx2X2RwaW9fd3JpdGUoZGV2X3ByaXYsIHBpcGUsIF9DSFZfQ01OX0RXNV9DSDAs IHZhbCk7Cj4gLQl9IGVsc2Ugewo+IC0JCXZhbCA9IHZsdl9kcGlvX3JlYWQoZGV2X3ByaXYsIHBp cGUsIF9DSFZfQ01OX0RXMV9DSDEpOwo+IC0JCXZhbCAmPSB+KENIVl9CVUZMRUZURU5BMl9NQVNL IHwgQ0hWX0JVRlJJR0hURU5BMl9NQVNLKTsKPiAtCQl2bHZfZHBpb193cml0ZShkZXZfcHJpdiwg cGlwZSwgX0NIVl9DTU5fRFcxX0NIMSwgdmFsKTsKPiAtCX0KPiAtCj4gLQltdXRleF91bmxvY2so JmRldl9wcml2LT5zYl9sb2NrKTsKPiAtCj4gLQkvKgo+IC0JICogTGVhdmUgdGhlIHBvd2VyIGRv d24gYml0IGNsZWFyZWQgZm9yIGF0IGxlYXN0IG9uZQo+IC0JICogbGFuZSBzbyB0aGF0IGNodl9w b3dlcmdhdGVfcGh5X2NoKCkgd2lsbCBwb3dlcgo+IC0JICogb24gc29tZXRoaW5nIHdoZW4gdGhl IGNoYW5uZWwgaXMgb3RoZXJ3aXNlIHVudXNlZC4KPiAtCSAqIFdoZW4gdGhlIHBvcnQgaXMgb2Zm IGFuZCB0aGUgb3ZlcnJpZGUgaXMgcmVtb3ZlZAo+IC0JICogdGhlIGxhbmVzIHBvd2VyIGRvd24g YW55d2F5LCBzbyBvdGhlcndpc2UgaXQgZG9lc24ndAo+IC0JICogcmVhbGx5IG1hdHRlciB3aGF0 IHRoZSBzdGF0ZSBvZiBwb3dlciBkb3duIGJpdHMgaXMKPiAtCSAqIGFmdGVyIHRoaXMuCj4gLQkg Ki8KPiAtCWNodl9waHlfcG93ZXJnYXRlX2xhbmVzKGVuY29kZXIsIGZhbHNlLCAweDApOwo+ICsJ Y2h2X3BoeV9wb3N0X2Rpc2FibGUoZW5jb2Rlcik7Cj4gIH0KPiAgCj4gIC8qCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwaW9fcGh5LmMgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kcGlvX3BoeS5jCj4gaW5kZXggYWQwZTdiZS4uMjQwMDU1NCAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGlvX3BoeS5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBpb19waHkuYwo+IEBAIC0zMzYsMyArMzM2LDM2IEBA IHZvaWQgY2h2X3BoeV9yZWxlYXNlX2NsMl9vdmVycmlkZShzdHJ1Y3QgaW50ZWxfZW5jb2RlciAq ZW5jb2RlcikKPiAgCQlkcG9ydC0+cmVsZWFzZV9jbDJfb3ZlcnJpZGUgPSBmYWxzZTsKPiAgCX0K PiAgfQo+ICsKPiArdm9pZCBjaHZfcGh5X3Bvc3RfZGlzYWJsZShzdHJ1Y3QgaW50ZWxfZW5jb2Rl ciAqZW5jb2RlcikKPiArewo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0g dG9faTkxNShlbmNvZGVyLT5iYXNlLmRldik7Cj4gKwllbnVtIHBpcGUgcGlwZSA9IHRvX2ludGVs X2NydGMoZW5jb2Rlci0+YmFzZS5jcnRjKS0+cGlwZTsKPiArCXUzMiB2YWw7Cj4gKwo+ICsJbXV0 ZXhfbG9jaygmZGV2X3ByaXYtPnNiX2xvY2spOwo+ICsKPiArCS8qIGRpc2FibGUgbGVmdC9yaWdo dCBjbG9jayBkaXN0cmlidXRpb24gKi8KPiArCWlmIChwaXBlICE9IFBJUEVfQikgewo+ICsJCXZh bCA9IHZsdl9kcGlvX3JlYWQoZGV2X3ByaXYsIHBpcGUsIF9DSFZfQ01OX0RXNV9DSDApOwo+ICsJ CXZhbCAmPSB+KENIVl9CVUZMRUZURU5BMV9NQVNLIHwgQ0hWX0JVRlJJR0hURU5BMV9NQVNLKTsK PiArCQl2bHZfZHBpb193cml0ZShkZXZfcHJpdiwgcGlwZSwgX0NIVl9DTU5fRFc1X0NIMCwgdmFs KTsKPiArCX0gZWxzZSB7Cj4gKwkJdmFsID0gdmx2X2RwaW9fcmVhZChkZXZfcHJpdiwgcGlwZSwg X0NIVl9DTU5fRFcxX0NIMSk7Cj4gKwkJdmFsICY9IH4oQ0hWX0JVRkxFRlRFTkEyX01BU0sgfCBD SFZfQlVGUklHSFRFTkEyX01BU0spOwo+ICsJCXZsdl9kcGlvX3dyaXRlKGRldl9wcml2LCBwaXBl LCBfQ0hWX0NNTl9EVzFfQ0gxLCB2YWwpOwo+ICsJfQo+ICsKPiArCW11dGV4X3VubG9jaygmZGV2 X3ByaXYtPnNiX2xvY2spOwo+ICsKPiArCS8qCj4gKwkgKiBMZWF2ZSB0aGUgcG93ZXIgZG93biBi aXQgY2xlYXJlZCBmb3IgYXQgbGVhc3Qgb25lCj4gKwkgKiBsYW5lIHNvIHRoYXQgY2h2X3Bvd2Vy Z2F0ZV9waHlfY2goKSB3aWxsIHBvd2VyCj4gKwkgKiBvbiBzb21ldGhpbmcgd2hlbiB0aGUgY2hh bm5lbCBpcyBvdGhlcndpc2UgdW51c2VkLgo+ICsJICogV2hlbiB0aGUgcG9ydCBpcyBvZmYgYW5k IHRoZSBvdmVycmlkZSBpcyByZW1vdmVkCj4gKwkgKiB0aGUgbGFuZXMgcG93ZXIgZG93biBhbnl3 YXksIHNvIG90aGVyd2lzZSBpdCBkb2Vzbid0Cj4gKwkgKiByZWFsbHkgbWF0dGVyIHdoYXQgdGhl IHN0YXRlIG9mIHBvd2VyIGRvd24gYml0cyBpcwo+ICsJICogYWZ0ZXIgdGhpcy4KPiArCSAqLwo+ ICsJY2h2X3BoeV9wb3dlcmdhdGVfbGFuZXMoZW5jb2RlciwgZmFsc2UsIDB4MCk7Cj4gK30KPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaGRtaS5jIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfaGRtaS5jCj4gaW5kZXggYjRkYTdlZS4uZjQyNGFmNSAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9oZG1pLmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9oZG1pLmMKPiBAQCAtMTY2NywzNSArMTY2Nyw3IEBAIHN0YXRp YyB2b2lkIGNodl9oZG1pX3ByZV9wbGxfZW5hYmxlKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNv ZGVyKQo+ICAKPiAgc3RhdGljIHZvaWQgY2h2X2hkbWlfcG9zdF9wbGxfZGlzYWJsZShzdHJ1Y3Qg aW50ZWxfZW5jb2RlciAqZW5jb2RlcikKPiAgewo+IC0Jc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2ID0gdG9faTkxNShlbmNvZGVyLT5iYXNlLmRldik7Cj4gLQllbnVtIHBpcGUgcGlw ZSA9IHRvX2ludGVsX2NydGMoZW5jb2Rlci0+YmFzZS5jcnRjKS0+cGlwZTsKPiAtCXUzMiB2YWw7 Cj4gLQo+IC0JbXV0ZXhfbG9jaygmZGV2X3ByaXYtPnNiX2xvY2spOwo+IC0KPiAtCS8qIGRpc2Fi bGUgbGVmdC9yaWdodCBjbG9jayBkaXN0cmlidXRpb24gKi8KPiAtCWlmIChwaXBlICE9IFBJUEVf Qikgewo+IC0JCXZhbCA9IHZsdl9kcGlvX3JlYWQoZGV2X3ByaXYsIHBpcGUsIF9DSFZfQ01OX0RX NV9DSDApOwo+IC0JCXZhbCAmPSB+KENIVl9CVUZMRUZURU5BMV9NQVNLIHwgQ0hWX0JVRlJJR0hU RU5BMV9NQVNLKTsKPiAtCQl2bHZfZHBpb193cml0ZShkZXZfcHJpdiwgcGlwZSwgX0NIVl9DTU5f RFc1X0NIMCwgdmFsKTsKPiAtCX0gZWxzZSB7Cj4gLQkJdmFsID0gdmx2X2RwaW9fcmVhZChkZXZf cHJpdiwgcGlwZSwgX0NIVl9DTU5fRFcxX0NIMSk7Cj4gLQkJdmFsICY9IH4oQ0hWX0JVRkxFRlRF TkEyX01BU0sgfCBDSFZfQlVGUklHSFRFTkEyX01BU0spOwo+IC0JCXZsdl9kcGlvX3dyaXRlKGRl dl9wcml2LCBwaXBlLCBfQ0hWX0NNTl9EVzFfQ0gxLCB2YWwpOwo+IC0JfQo+IC0KPiAtCW11dGV4 X3VubG9jaygmZGV2X3ByaXYtPnNiX2xvY2spOwo+IC0KPiAtCS8qCj4gLQkgKiBMZWF2ZSB0aGUg cG93ZXIgZG93biBiaXQgY2xlYXJlZCBmb3IgYXQgbGVhc3Qgb25lCj4gLQkgKiBsYW5lIHNvIHRo YXQgY2h2X3Bvd2VyZ2F0ZV9waHlfY2goKSB3aWxsIHBvd2VyCj4gLQkgKiBvbiBzb21ldGhpbmcg d2hlbiB0aGUgY2hhbm5lbCBpcyBvdGhlcndpc2UgdW51c2VkLgo+IC0JICogV2hlbiB0aGUgcG9y dCBpcyBvZmYgYW5kIHRoZSBvdmVycmlkZSBpcyByZW1vdmVkCj4gLQkgKiB0aGUgbGFuZXMgcG93 ZXIgZG93biBhbnl3YXksIHNvIG90aGVyd2lzZSBpdCBkb2Vzbid0Cj4gLQkgKiByZWFsbHkgbWF0 dGVyIHdoYXQgdGhlIHN0YXRlIG9mIHBvd2VyIGRvd24gYml0cyBpcwo+IC0JICogYWZ0ZXIgdGhp cy4KPiAtCSAqLwo+IC0JY2h2X3BoeV9wb3dlcmdhdGVfbGFuZXMoZW5jb2RlciwgZmFsc2UsIDB4 MCk7Cj4gKwljaHZfcGh5X3Bvc3RfZGlzYWJsZShlbmNvZGVyKTsKPiAgfQo+ICAKPiAgc3RhdGlj IHZvaWQgdmx2X2hkbWlfcG9zdF9kaXNhYmxlKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVy KQo+IC0tIAo+IDIuNC4xMQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl bC1nZngK