From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Bride Subject: Re: [PATCH v2 08/10] drm/i915: Unduplicate VLV phy pre pll enabling code Date: Wed, 20 Apr 2016 12:50:37 -0700 Message-ID: <20160420195037.GG13777@shiv> References: <1460569673-13694-1-git-send-email-ander.conselvan.de.oliveira@intel.com> <1460569673-13694-9-git-send-email-ander.conselvan.de.oliveira@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 6CD2C6EAFF for ; Wed, 20 Apr 2016 19:50:37 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1460569673-13694-9-git-send-email-ander.conselvan.de.oliveira@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ander Conselvan de Oliveira Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBBcHIgMTMsIDIwMTYgYXQgMDg6NDc6NTFQTSArMDMwMCwgQW5kZXIgQ29uc2VsdmFu IGRlIE9saXZlaXJhIHdyb3RlOgo+IFRoZSBjb2RlIHVzZWQgYnkgdGhlIERQIGFuZCBIRE1JIHBh dGhzIHdhcyB2ZXJ5IHNpbWlsYXIsIHNvIG1ha2UgdGhlbQo+IHNoYXJlIGl0LiBOb3RlIHRoYXQg dGhpcyByZW1vdmVzIHRoZSB3cml0ZSB0byBzaWduYWwgbGV2ZWwgcmVnaXN0ZXJzCj4gZnJvbSB0 aGUgSERNSSBwcmUgcGxsIGVuYWJsZSBwYXRoLCBidXQgdGhhdCdzIE9LIHNpbmNlIHRob3NlIGFy ZSBzZXQKPiBpbiB2bHZfaGRtaV9wcmVfZW5hYmxlKCkgZnVuY3Rpb24uCj4gCj4gU2lnbmVkLW9m Zi1ieTogQW5kZXIgQ29uc2VsdmFuIGRlIE9saXZlaXJhIDxhbmRlci5jb25zZWx2YW4uZGUub2xp dmVpcmFAaW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IEppbSBCcmlkZSA8amltLmJyaWRlQGxpbnV4 LmludGVsLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggICAg ICAgfCAgMSArCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgICAgICAgfCAyNSAr LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rw aW9fcGh5LmMgfCAyOCArKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2hkbWkuYyAgICAgfCAyOCArLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tCj4gIDQgZmlsZXMgY2hhbmdlZCwgMzEgaW5zZXJ0aW9ucygrKSwgNTEgZGVsZXRpb25zKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gaW5kZXggZjI0ODFhMi4uYTAwMjg3MCAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+IEBAIC0zNTY4LDYgKzM1NjgsNyBAQCB2b2lkIGNo dl9waHlfcG9zdF9kaXNhYmxlKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyKTsKPiAgdm9p ZCB2bHZfc2V0X3BoeV9zaWduYWxfbGV2ZWwoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIs Cj4gIAkJCSAgICAgIHUzMiBkZW1waF9yZWdfdmFsdWUsIHUzMiBwcmVlbXBoX3JlZ192YWx1ZSwK PiAgCQkJICAgICAgdTMyIHVuaXF0cmFuc2NhbGVfcmVnX3ZhbHVlLCB1MzIgdHgzX2RlbXBoKTsK PiArdm9pZCB2bHZfcGh5X3ByZV9wbGxfZW5hYmxlKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNv ZGVyKTsKPiAgCj4gIGludCBpbnRlbF9ncHVfZnJlcShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYsIGludCB2YWwpOwo+ICBpbnQgaW50ZWxfZnJlcV9vcGNvZGUoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LCBpbnQgdmFsKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZHAuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMK PiBpbmRleCAzZTQyMzU1Li40ODI5YmE5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2RwLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4g QEAgLTI4MjEsMzIgKzI4MjEsOSBAQCBzdGF0aWMgdm9pZCB2bHZfcHJlX2VuYWJsZV9kcChzdHJ1 Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlcikKPiAgCj4gIHN0YXRpYyB2b2lkIHZsdl9kcF9wcmVf cGxsX2VuYWJsZShzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlcikKPiAgewo+IC0Jc3RydWN0 IGludGVsX2RpZ2l0YWxfcG9ydCAqZHBvcnQgPSBlbmNfdG9fZGlnX3BvcnQoJmVuY29kZXItPmJh c2UpOwo+IC0Jc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGVuY29kZXItPmJhc2UuZGV2Owo+IC0J c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiAt CXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjID0KPiAtCQl0b19pbnRlbF9jcnRjKGVuY29k ZXItPmJhc2UuY3J0Yyk7Cj4gLQllbnVtIGRwaW9fY2hhbm5lbCBwb3J0ID0gdmx2X2Rwb3J0X3Rv X2NoYW5uZWwoZHBvcnQpOwo+IC0JaW50IHBpcGUgPSBpbnRlbF9jcnRjLT5waXBlOwo+IC0KPiAg CWludGVsX2RwX3ByZXBhcmUoZW5jb2Rlcik7Cj4gIAo+IC0JLyogUHJvZ3JhbSBUeCBsYW5lIHJl c2V0cyB0byBkZWZhdWx0ICovCj4gLQltdXRleF9sb2NrKCZkZXZfcHJpdi0+c2JfbG9jayk7Cj4g LQl2bHZfZHBpb193cml0ZShkZXZfcHJpdiwgcGlwZSwgVkxWX1BDU19EVzAocG9ydCksCj4gLQkJ CSBEUElPX1BDU19UWF9MQU5FMl9SRVNFVCB8Cj4gLQkJCSBEUElPX1BDU19UWF9MQU5FMV9SRVNF VCk7Cj4gLQl2bHZfZHBpb193cml0ZShkZXZfcHJpdiwgcGlwZSwgVkxWX1BDU19EVzEocG9ydCks Cj4gLQkJCSBEUElPX1BDU19DTEtfQ1JJX1JYRUJfRUlPU19FTiB8Cj4gLQkJCSBEUElPX1BDU19D TEtfQ1JJX1JYRElHRklMVFNHX0VOIHwKPiAtCQkJICgxPDxEUElPX1BDU19DTEtfREFUQVdJRFRI X1NISUZUKSB8Cj4gLQkJCQkgRFBJT19QQ1NfQ0xLX1NPRlRfUkVTRVQpOwo+IC0KPiAtCS8qIEZp eCB1cCBpbnRlci1wYWlyIHNrZXcgZmFpbHVyZSAqLwo+IC0Jdmx2X2RwaW9fd3JpdGUoZGV2X3By aXYsIHBpcGUsIFZMVl9QQ1NfRFcxMihwb3J0KSwgMHgwMDc1MGYwMCk7Cj4gLQl2bHZfZHBpb193 cml0ZShkZXZfcHJpdiwgcGlwZSwgVkxWX1RYX0RXMTEocG9ydCksIDB4MDAwMDE1MDApOwo+IC0J dmx2X2RwaW9fd3JpdGUoZGV2X3ByaXYsIHBpcGUsIFZMVl9UWF9EVzE0KHBvcnQpLCAweDQwNDAw MDAwKTsKPiAtCW11dGV4X3VubG9jaygmZGV2X3ByaXYtPnNiX2xvY2spOwo+ICsJdmx2X3BoeV9w cmVfcGxsX2VuYWJsZShlbmNvZGVyKTsKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgY2h2X3ByZV9l bmFibGVfZHAoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIpCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwaW9fcGh5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kcGlvX3BoeS5jCj4gaW5kZXggZDllNjQ4Mi4uODQ2ZjM1ZiAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGlvX3BoeS5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZHBpb19waHkuYwo+IEBAIC0zOTUsMyArMzk1LDMxIEBAIHZvaWQg dmx2X3NldF9waHlfc2lnbmFsX2xldmVsKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ ICAJdmx2X2RwaW9fd3JpdGUoZGV2X3ByaXYsIHBpcGUsIFZMVl9UWF9EVzUocG9ydCksIERQSU9f VFhfT0NBTElOSVRfRU4pOwo+ICAJbXV0ZXhfdW5sb2NrKCZkZXZfcHJpdi0+c2JfbG9jayk7Cj4g IH0KPiArCj4gK3ZvaWQgdmx2X3BoeV9wcmVfcGxsX2VuYWJsZShzdHJ1Y3QgaW50ZWxfZW5jb2Rl ciAqZW5jb2RlcikKPiArewo+ICsJc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqZHBvcnQgPSBl bmNfdG9fZGlnX3BvcnQoJmVuY29kZXItPmJhc2UpOwo+ICsJc3RydWN0IGRybV9kZXZpY2UgKmRl diA9IGVuY29kZXItPmJhc2UuZGV2Owo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiArCXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRj ID0KPiArCQl0b19pbnRlbF9jcnRjKGVuY29kZXItPmJhc2UuY3J0Yyk7Cj4gKwllbnVtIGRwaW9f Y2hhbm5lbCBwb3J0ID0gdmx2X2Rwb3J0X3RvX2NoYW5uZWwoZHBvcnQpOwo+ICsJaW50IHBpcGUg PSBpbnRlbF9jcnRjLT5waXBlOwo+ICsKPiArCS8qIFByb2dyYW0gVHggbGFuZSByZXNldHMgdG8g ZGVmYXVsdCAqLwo+ICsJbXV0ZXhfbG9jaygmZGV2X3ByaXYtPnNiX2xvY2spOwo+ICsJdmx2X2Rw aW9fd3JpdGUoZGV2X3ByaXYsIHBpcGUsIFZMVl9QQ1NfRFcwKHBvcnQpLAo+ICsJCQkgRFBJT19Q Q1NfVFhfTEFORTJfUkVTRVQgfAo+ICsJCQkgRFBJT19QQ1NfVFhfTEFORTFfUkVTRVQpOwo+ICsJ dmx2X2RwaW9fd3JpdGUoZGV2X3ByaXYsIHBpcGUsIFZMVl9QQ1NfRFcxKHBvcnQpLAo+ICsJCQkg RFBJT19QQ1NfQ0xLX0NSSV9SWEVCX0VJT1NfRU4gfAo+ICsJCQkgRFBJT19QQ1NfQ0xLX0NSSV9S WERJR0ZJTFRTR19FTiB8Cj4gKwkJCSAoMTw8RFBJT19QQ1NfQ0xLX0RBVEFXSURUSF9TSElGVCkg fAo+ICsJCQkJIERQSU9fUENTX0NMS19TT0ZUX1JFU0VUKTsKPiArCj4gKwkvKiBGaXggdXAgaW50 ZXItcGFpciBza2V3IGZhaWx1cmUgKi8KPiArCXZsdl9kcGlvX3dyaXRlKGRldl9wcml2LCBwaXBl LCBWTFZfUENTX0RXMTIocG9ydCksIDB4MDA3NTBmMDApOwo+ICsJdmx2X2RwaW9fd3JpdGUoZGV2 X3ByaXYsIHBpcGUsIFZMVl9UWF9EVzExKHBvcnQpLCAweDAwMDAxNTAwKTsKPiArCXZsdl9kcGlv X3dyaXRlKGRldl9wcml2LCBwaXBlLCBWTFZfVFhfRFcxNChwb3J0KSwgMHg0MDQwMDAwMCk7Cj4g KwltdXRleF91bmxvY2soJmRldl9wcml2LT5zYl9sb2NrKTsKPiArfQo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9oZG1pLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9oZG1pLmMKPiBpbmRleCA5Mzg2NzcyLi5mMGMyMWU0IDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2hkbWkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2hkbWkuYwo+IEBAIC0xNjIxLDM1ICsxNjIxLDkgQEAgc3RhdGljIHZvaWQgdmx2X2hk bWlfcHJlX2VuYWJsZShzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlcikKPiAgCj4gIHN0YXRp YyB2b2lkIHZsdl9oZG1pX3ByZV9wbGxfZW5hYmxlKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNv ZGVyKQo+ICB7Cj4gLQlzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICpkcG9ydCA9IGVuY190b19k aWdfcG9ydCgmZW5jb2Rlci0+YmFzZSk7Cj4gLQlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gZW5j b2Rlci0+YmFzZS5kZXY7Cj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBk ZXYtPmRldl9wcml2YXRlOwo+IC0Jc3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGMgPQo+IC0J CXRvX2ludGVsX2NydGMoZW5jb2Rlci0+YmFzZS5jcnRjKTsKPiAtCWVudW0gZHBpb19jaGFubmVs IHBvcnQgPSB2bHZfZHBvcnRfdG9fY2hhbm5lbChkcG9ydCk7Cj4gLQlpbnQgcGlwZSA9IGludGVs X2NydGMtPnBpcGU7Cj4gLQo+ICAJaW50ZWxfaGRtaV9wcmVwYXJlKGVuY29kZXIpOwo+ICAKPiAt CS8qIFByb2dyYW0gVHggbGFuZSByZXNldHMgdG8gZGVmYXVsdCAqLwo+IC0JbXV0ZXhfbG9jaygm ZGV2X3ByaXYtPnNiX2xvY2spOwo+IC0Jdmx2X2RwaW9fd3JpdGUoZGV2X3ByaXYsIHBpcGUsIFZM Vl9QQ1NfRFcwKHBvcnQpLAo+IC0JCQkgRFBJT19QQ1NfVFhfTEFORTJfUkVTRVQgfAo+IC0JCQkg RFBJT19QQ1NfVFhfTEFORTFfUkVTRVQpOwo+IC0Jdmx2X2RwaW9fd3JpdGUoZGV2X3ByaXYsIHBp cGUsIFZMVl9QQ1NfRFcxKHBvcnQpLAo+IC0JCQkgRFBJT19QQ1NfQ0xLX0NSSV9SWEVCX0VJT1Nf RU4gfAo+IC0JCQkgRFBJT19QQ1NfQ0xLX0NSSV9SWERJR0ZJTFRTR19FTiB8Cj4gLQkJCSAoMTw8 RFBJT19QQ1NfQ0xLX0RBVEFXSURUSF9TSElGVCkgfAo+IC0JCQkgRFBJT19QQ1NfQ0xLX1NPRlRf UkVTRVQpOwo+IC0KPiAtCS8qIEZpeCB1cCBpbnRlci1wYWlyIHNrZXcgZmFpbHVyZSAqLwo+IC0J dmx2X2RwaW9fd3JpdGUoZGV2X3ByaXYsIHBpcGUsIFZMVl9QQ1NfRFcxMihwb3J0KSwgMHgwMDc1 MGYwMCk7Cj4gLQl2bHZfZHBpb193cml0ZShkZXZfcHJpdiwgcGlwZSwgVkxWX1RYX0RXMTEocG9y dCksIDB4MDAwMDE1MDApOwo+IC0Jdmx2X2RwaW9fd3JpdGUoZGV2X3ByaXYsIHBpcGUsIFZMVl9U WF9EVzE0KHBvcnQpLCAweDQwNDAwMDAwKTsKPiAtCj4gLQl2bHZfZHBpb193cml0ZShkZXZfcHJp diwgcGlwZSwgVkxWX1BDU19EVzkocG9ydCksIDB4MDAwMDIwMDApOwo+IC0Jdmx2X2RwaW9fd3Jp dGUoZGV2X3ByaXYsIHBpcGUsIFZMVl9UWF9EVzUocG9ydCksIERQSU9fVFhfT0NBTElOSVRfRU4p Owo+IC0JbXV0ZXhfdW5sb2NrKCZkZXZfcHJpdi0+c2JfbG9jayk7Cj4gKwl2bHZfcGh5X3ByZV9w bGxfZW5hYmxlKGVuY29kZXIpOwo+ICB9Cj4gIAo+ICBzdGF0aWMgdm9pZCBjaHZfaGRtaV9wcmVf cGxsX2VuYWJsZShzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlcikKPiAtLSAKPiAyLjQuMTEK PiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IElu dGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4g aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==