From: Daniel Vetter <daniel@ffwll.ch>
To: Marius Vlad <marius.c.vlad@intel.com>
Cc: tomi.p.sarvela@intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 2/2] tests/kms_flip: Half the duration time for basic-*vs-modeset/flip tests.
Date: Thu, 21 Apr 2016 11:23:26 +0200 [thread overview]
Message-ID: <20160421092326.GU2510@phenom.ffwll.local> (raw)
In-Reply-To: <1461174597-7722-2-git-send-email-marius.c.vlad@intel.com>
On Wed, Apr 20, 2016 at 08:49:57PM +0300, Marius Vlad wrote:
> basic-flip-vs-dpms and basic-flip-vs-modeset together take roughly 2m
> to run. Adjust the duration time to a maximum of 500ms.
Can we have a notch more please? Ime it takes generally a few modesets for
this thing to fall over (2-3 modesets), are you sure the test still does
something useful in half a second? Mostly a modeset takes a lot longer
than that.
Also you just half the duration, but claim it goes from 2minutes to 500 ms
...
I'm confused.
-Daniel
>
> Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
> ---
> tests/kms_flip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> index 3d44544..fd8206f 100644
> --- a/tests/kms_flip.c
> +++ b/tests/kms_flip.c
> @@ -1458,7 +1458,7 @@ static int run_test(int duration, int flags)
> }
>
> igt_require(modes);
> - duration = duration * 1000 / modes;
> + duration = duration * 500 / modes;
> duration = max(500, duration);
>
> /* Find any connected displays */
> --
> 2.5.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-04-21 9:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 17:49 [PATCH i-g-t 1/2] lib/igt_aux: Half the timeout for suspend to RAM and a third for suspend to disk Marius Vlad
2016-04-20 17:49 ` [PATCH i-g-t 2/2] tests/kms_flip: Half the duration time for basic-*vs-modeset/flip tests Marius Vlad
2016-04-21 9:23 ` Daniel Vetter [this message]
2016-04-21 10:08 ` Marius Vlad
2016-04-21 7:54 ` [PATCH i-g-t 1/2] lib/igt_aux: Half the timeout for suspend to RAM and a third for suspend to disk Tomi Sarvela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160421092326.GU2510@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=marius.c.vlad@intel.com \
--cc=tomi.p.sarvela@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox