From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/4] drm/i915/fbc: sanitize i915.enable_fbc during FBC init Date: Mon, 25 Apr 2016 10:10:55 +0200 Message-ID: <20160425081055.GF2510@phenom.ffwll.local> References: <20160406141953.GK18736@nuc-i3427.alporthouse.com> <1460574069-14005-1-git-send-email-paulo.r.zanoni@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x22f.google.com (mail-wm0-x22f.google.com [IPv6:2a00:1450:400c:c09::22f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3EC3E6E4DE for ; Mon, 25 Apr 2016 08:11:00 +0000 (UTC) Received: by mail-wm0-x22f.google.com with SMTP id v188so87762732wme.1 for ; Mon, 25 Apr 2016 01:11:00 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1460574069-14005-1-git-send-email-paulo.r.zanoni@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBBcHIgMTMsIDIwMTYgYXQgMDQ6MDE6MDlQTSAtMDMwMCwgUGF1bG8gWmFub25pIHdy b3RlOgo+IFRoZSBERFggZHJpdmVyIGNoYW5nZXMgaXRzIGJlaGF2aW9yIGRlcGVuZGluZyBvbiB0 aGUgdmFsdWUgaXQgcmVhZHMKPiBmcm9tIGk5MTUuZW5hYmxlX2ZiYywgc28gc2FuaXRpemUgdGhl IHZhbHVlIGluIG9yZGVyIHRvIGFsbG93IGl0IHRvCj4ga25vdyB3aGF0J3MgZ29pbmcgb24uIEl0 IHVzZXMgdGhpcyBpbiBvcmRlciB0byBjaG9vc2UgdGhlIGRlZmF1bHRzIGZvcgo+IHRoZSBUZWFy RnJlZSBvcHRpb24uIEJlZm9yZSB0aGlzIHBhdGNoLCBpdCB3b3VsZCByZWFkIC0xIGFuZCBhbHdh eXMKPiBhc3N1bWUgdGhhdCBGQkMgd2FzIGRpc2FibGVkLCBzbyBpdCB3b3VsZG4ndCBmb3JjZSBU ZWFyRnJlZS4KPiAKPiB2MjogRXh0cmFjdCBpbnRlbF9zYW5pdGl6ZV9mYmNfb3B0aW9uKCkgKENo cmlzKS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBQYXVsbyBaYW5vbmkgPHBhdWxvLnIuemFub25pQGlu dGVsLmNvbT4KClJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xs LmNoPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJjLmMgfCAzMiArKysr KysrKysrKysrKysrKysrKysrKystLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjQgaW5zZXJ0 aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZmJjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmMuYwo+IGlu ZGV4IGZjM2MwOTQuLmMzZGZmYmEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZmJjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmMuYwo+IEBA IC04MjQsMjEgKzgyNCwxNCBAQCBzdGF0aWMgYm9vbCBpbnRlbF9mYmNfY2FuX2Nob29zZShzdHJ1 Y3QgaW50ZWxfY3J0YyAqY3J0YykKPiAgewo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2ID0gY3J0Yy0+YmFzZS5kZXYtPmRldl9wcml2YXRlOwo+ICAJc3RydWN0IGludGVsX2Zi YyAqZmJjID0gJmRldl9wcml2LT5mYmM7Cj4gLQlib29sIGVuYWJsZV9ieV9kZWZhdWx0ID0gSVNf SEFTV0VMTChkZXZfcHJpdikgfHwKPiAtCQkJCSBJU19CUk9BRFdFTEwoZGV2X3ByaXYpOwo+ICAK PiAgCWlmIChpbnRlbF92Z3B1X2FjdGl2ZShkZXZfcHJpdi0+ZGV2KSkgewo+ICAJCWZiYy0+bm9f ZmJjX3JlYXNvbiA9ICJWR1BVIGlzIGFjdGl2ZSI7Cj4gIAkJcmV0dXJuIGZhbHNlOwo+ICAJfQo+ ICAKPiAtCWlmIChpOTE1LmVuYWJsZV9mYmMgPCAwICYmICFlbmFibGVfYnlfZGVmYXVsdCkgewo+ IC0JCWZiYy0+bm9fZmJjX3JlYXNvbiA9ICJkaXNhYmxlZCBwZXIgY2hpcCBkZWZhdWx0IjsKPiAt CQlyZXR1cm4gZmFsc2U7Cj4gLQl9Cj4gLQo+ICAJaWYgKCFpOTE1LmVuYWJsZV9mYmMpIHsKPiAt CQlmYmMtPm5vX2ZiY19yZWFzb24gPSAiZGlzYWJsZWQgcGVyIG1vZHVsZSBwYXJhbSI7Cj4gKwkJ ZmJjLT5ub19mYmNfcmVhc29uID0gImRpc2FibGVkIHBlciBtb2R1bGUgcGFyYW0gb3IgYnkgZGVm YXVsdCI7Cj4gIAkJcmV0dXJuIGZhbHNlOwo+ICAJfQo+ICAKPiBAQCAtMTIyMyw2ICsxMjE2LDI2 IEBAIHZvaWQgaW50ZWxfZmJjX2luaXRfcGlwZV9zdGF0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYpCj4gIAkJCWRldl9wcml2LT5mYmMudmlzaWJsZV9waXBlc19tYXNrIHw9ICgx IDw8IGNydGMtPnBpcGUpOwo+ICB9Cj4gIAo+ICsvKgo+ICsgKiBUaGUgRERYIGRyaXZlciBjaGFu Z2VzIGl0cyBiZWhhdmlvciBkZXBlbmRpbmcgb24gdGhlIHZhbHVlIGl0IHJlYWRzIGZyb20KPiAr ICogaTkxNS5lbmFibGVfZmJjLCBzbyBzYW5pdGl6ZSBpdCBieSB0cmFuc2xhdGluZyB0aGUgZGVm YXVsdCB2YWx1ZSBpbnRvIGVpdGhlcgo+ICsgKiAwIG9yIDEgaW4gb3JkZXIgdG8gYWxsb3cgaXQg dG8ga25vdyB3aGF0J3MgZ29pbmcgb24uCj4gKyAqCj4gKyAqIE5vdGljZSB0aGF0IHRoaXMgaXMg ZG9uZSBhdCBkcml2ZXIgaW5pdGlhbGl6YXRpb24gYW5kIHdlIHN0aWxsIGFsbG93IHVzZXIKPiAr ICogc3BhY2UgdG8gY2hhbmdlIHRoZSB2YWx1ZSBkdXJpbmcgcnVudGltZSB3aXRob3V0IHNhbml0 aXppbmcgaXQgYWdhaW4uIElHVAo+ICsgKiByZWxpZXMgb24gYmVpbmcgYWJsZSB0byBjaGFuZ2Ug aTkxNS5lbmFibGVfZmJjIGF0IHJ1bnRpbWUuCj4gKyAqLwo+ICtzdGF0aWMgaW50IGludGVsX3Nh bml0aXplX2ZiY19vcHRpb24oc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICt7 Cj4gKwlpZiAoaTkxNS5lbmFibGVfZmJjID49IDApCj4gKwkJcmV0dXJuICEhaTkxNS5lbmFibGVf ZmJjOwo+ICsKPiArCWlmIChJU19IQVNXRUxMKGRldl9wcml2KSB8fCBJU19CUk9BRFdFTEwoZGV2 X3ByaXYpKQo+ICsJCXJldHVybiAxOwo+ICsKPiArCXJldHVybiAwOwo+ICt9Cj4gKwo+ICAvKioK PiAgICogaW50ZWxfZmJjX2luaXQgLSBJbml0aWFsaXplIEZCQwo+ICAgKiBAZGV2X3ByaXY6IHRo ZSBpOTE1IGRldmljZQo+IEBAIC0xMjQwLDYgKzEyNTMsOSBAQCB2b2lkIGludGVsX2ZiY19pbml0 KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCWZiYy0+YWN0aXZlID0gZmFs c2U7Cj4gIAlmYmMtPndvcmsuc2NoZWR1bGVkID0gZmFsc2U7Cj4gIAo+ICsJaTkxNS5lbmFibGVf ZmJjID0gaW50ZWxfc2FuaXRpemVfZmJjX29wdGlvbihkZXZfcHJpdik7Cj4gKwlEUk1fREVCVUdf S01TKCJTYW5pdGl6ZWQgZW5hYmxlX2ZiYyB2YWx1ZTogJWRcbiIsIGk5MTUuZW5hYmxlX2ZiYyk7 Cj4gKwo+ICAJaWYgKCFIQVNfRkJDKGRldl9wcml2KSkgewo+ICAJCWZiYy0+bm9fZmJjX3JlYXNv biA9ICJ1bnN1cHBvcnRlZCBieSB0aGlzIGNoaXBzZXQiOwo+ICAJCXJldHVybjsKPiAtLSAKPiAy LjguMC5yYzMKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jw b3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngK