Re: [PATCH 1/4] CI_ONLY: add enable_guc_loading parameter

From: Daniel Vetter <daniel@ffwll.ch>
To: Dave Gordon <david.s.gordon@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/4] CI_ONLY: add enable_guc_loading parameter
Date: Thu, 28 Apr 2016 10:04:56 +0200	[thread overview]
Message-ID: <20160428080456.GN2558@phenom.ffwll.local> (raw)
In-Reply-To: <572089DF.7080705@intel.com>

On Wed, Apr 27, 2016 at 10:43:59AM +0100, Dave Gordon wrote:
> On 26/04/16 15:18, Daniel Vetter wrote:
> >On Mon, Apr 25, 2016 at 03:37:11PM +0100, Dave Gordon wrote:
> >>Split the function of "enable_guc_submission" into two separate
> >>options.  The new one ("enable_guc_loading") controls only the
> >>*fetching and loading* of the GuC firmware image. The existing
> >>one is redefined to control only the *use* of the GuC for batch
> >>submission once the firmware is loaded.
> >>
> >>In addition, the degree of control has been refined from a simple
> >>bool to an integer key, allowing several options:
> >>-1 (default)     whatever the platform default is
> >>0  DISABLE      don't load/use the GuC
> >>1  BEST EFFORT  try to load/use the GuC, fallback if not available
> >>2  REQUIRE      must load/use the GuC, else leave the GPU wedged
> >>
> >>The new platform default (as coded here) will be to attempt to
> >>load the GuC iff the device has a GuC that requires firmware,
> >>but not yet to use it for submission. A later patch will change
> >>to enable it if appropriate.
> >>
> >>Signed-off-by: Dave Gordon <david.s.gordon@intel.com>
> >
> >intel-gfx-trybot@fd.o is your CI_only patchwork and CI instance:
> >
> >https://patchwork.freedesktop.org/project/intel-gfx-trybot/series/?ordering=-last_updated
> >
> >Cheers, Daniel
> 
> Yes, I tried sending this to trybot several times before this, but it wasn't
> working well, with many tests giving spurious "INCOMPLETE" results,
> especially on the Romanian machines. So this was still the only was to get a
> good test run.
> 
> Hopefully trybot will be back in working order soon, but that link shows
> there has not been a single successful submission by anybody since 1st
> April!

You need to escalate this all over the place. CI is meant as a service for
developers, if it doesn't work that's pretty critical (and imo much more
important than getting the next feature in).
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx