* Re: [Mesa-dev] [PATCH v2 mesa] vk/intel: use negative VK_NO_PROTOTYPES scheme [not found] ` <CACvgo50DC8MV9hQbo2rnZfmKe0WdwKNPwnBPoyEPKsrVAjJW8w@mail.gmail.com> @ 2016-04-28 18:13 ` Eric Engestrom 2016-05-01 8:51 ` Emil Velikov 0 siblings, 1 reply; 7+ messages in thread From: Eric Engestrom @ 2016-04-28 18:13 UTC (permalink / raw) To: Emil Velikov; +Cc: mesa-dev, intel-gfx On Mon, Apr 25, 2016 at 05:08:18PM +0100, Emil Velikov wrote: > On 21 April 2016 at 11:24, Eric Engestrom <eric.engestrom@imgtec.com> wrote: > > Commit 3d0fac7aca237bbe8ed8e2a362d3b42d0ef8c46c changed all the > > VK_PROTOTYPES to VK_NO_PROTOTYPES > > This brings the Intel header in line with the rest of the Vulkan code. > > > > Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com> > Reviewed-by: Emil Velikov <emil.velikov@collabora.com> > > > --- > > > > This might break code that was using the old guard scheme (not sure how > > that could've worked anyway). > > What the policy on this? > > > > v2: rebase on top of 3caf2e89aa1711e80db80d2056e0a44663d9c7d2 > > ("anv: fix build without Wayland platform"). Should've done that the > > first time around, sorry :] > > > > include/vulkan/vulkan_intel.h | 2 +- > > src/intel/vulkan/anv_private.h | 1 - > > 2 files changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/include/vulkan/vulkan_intel.h b/include/vulkan/vulkan_intel.h > > index 1f77128..8ede61b 100644 > > --- a/include/vulkan/vulkan_intel.h > > +++ b/include/vulkan/vulkan_intel.h > > @@ -44,7 +44,7 @@ typedef struct VkDmaBufImageCreateInfo_ > > > > typedef VkResult (VKAPI_PTR *PFN_vkCreateDmaBufImageINTEL)(VkDevice device, const VkDmaBufImageCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkDeviceMemory* pMem, VkImage* pImage); > > > > -#ifdef VK_PROTOTYPES > > +#ifndef VK_NO_PROTOTYPES > > > Would be great to hear from the Intel guys, if there is a another > Cannonical repo where this change should land first ? CC'ing intel-gfx even though this isn't X-related, because I don't know of any other way to contact you guys :] > > Thanks > Emil _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 mesa] vk/intel: use negative VK_NO_PROTOTYPES scheme 2016-04-28 18:13 ` [Mesa-dev] [PATCH v2 mesa] vk/intel: use negative VK_NO_PROTOTYPES scheme Eric Engestrom @ 2016-05-01 8:51 ` Emil Velikov 2016-05-02 1:04 ` Kenneth Graunke 0 siblings, 1 reply; 7+ messages in thread From: Emil Velikov @ 2016-05-01 8:51 UTC (permalink / raw) To: Eric Engestrom, Jason Ekstrand, Chad Versace Cc: ML mesa-dev, intel-gfx@lists.freedesktop.org On 28 April 2016 at 19:13, Eric Engestrom <eric.engestrom@imgtec.com> wrote: > On Mon, Apr 25, 2016 at 05:08:18PM +0100, Emil Velikov wrote: >> On 21 April 2016 at 11:24, Eric Engestrom <eric.engestrom@imgtec.com> wrote: >> > Commit 3d0fac7aca237bbe8ed8e2a362d3b42d0ef8c46c changed all the >> > VK_PROTOTYPES to VK_NO_PROTOTYPES >> > This brings the Intel header in line with the rest of the Vulkan code. >> > >> > Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com> >> Reviewed-by: Emil Velikov <emil.velikov@collabora.com> >> >> > --- >> > >> > This might break code that was using the old guard scheme (not sure how >> > that could've worked anyway). >> > What the policy on this? >> > >> > v2: rebase on top of 3caf2e89aa1711e80db80d2056e0a44663d9c7d2 >> > ("anv: fix build without Wayland platform"). Should've done that the >> > first time around, sorry :] >> > >> > include/vulkan/vulkan_intel.h | 2 +- >> > src/intel/vulkan/anv_private.h | 1 - >> > 2 files changed, 1 insertion(+), 2 deletions(-) >> > >> > diff --git a/include/vulkan/vulkan_intel.h b/include/vulkan/vulkan_intel.h >> > index 1f77128..8ede61b 100644 >> > --- a/include/vulkan/vulkan_intel.h >> > +++ b/include/vulkan/vulkan_intel.h >> > @@ -44,7 +44,7 @@ typedef struct VkDmaBufImageCreateInfo_ >> > >> > typedef VkResult (VKAPI_PTR *PFN_vkCreateDmaBufImageINTEL)(VkDevice device, const VkDmaBufImageCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkDeviceMemory* pMem, VkImage* pImage); >> > >> > -#ifdef VK_PROTOTYPES >> > +#ifndef VK_NO_PROTOTYPES >> > >> Would be great to hear from the Intel guys, if there is a another >> Cannonical repo where this change should land first ? > > CC'ing intel-gfx even though this isn't X-related, because I don't know > of any other way to contact you guys :] > Adding the anv authors. Jason, Chad, is there a canonical place where changes to vulkan_intel.h should land first ? Eric has a nice fix which we want in mesa. Thanks Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 mesa] vk/intel: use negative VK_NO_PROTOTYPES scheme 2016-05-01 8:51 ` Emil Velikov @ 2016-05-02 1:04 ` Kenneth Graunke 2016-05-02 4:39 ` Jason Ekstrand 0 siblings, 1 reply; 7+ messages in thread From: Kenneth Graunke @ 2016-05-02 1:04 UTC (permalink / raw) To: mesa-dev; +Cc: intel-gfx@lists.freedesktop.org, Emil Velikov [-- Attachment #1.1: Type: text/plain, Size: 2211 bytes --] On Sunday, May 1, 2016 9:51:00 AM PDT Emil Velikov wrote: > On 28 April 2016 at 19:13, Eric Engestrom <eric.engestrom@imgtec.com> wrote: > > On Mon, Apr 25, 2016 at 05:08:18PM +0100, Emil Velikov wrote: > >> On 21 April 2016 at 11:24, Eric Engestrom <eric.engestrom@imgtec.com> wrote: > >> > Commit 3d0fac7aca237bbe8ed8e2a362d3b42d0ef8c46c changed all the > >> > VK_PROTOTYPES to VK_NO_PROTOTYPES > >> > This brings the Intel header in line with the rest of the Vulkan code. > >> > > >> > Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com> > >> Reviewed-by: Emil Velikov <emil.velikov@collabora.com> > >> > >> > --- > >> > > >> > This might break code that was using the old guard scheme (not sure how > >> > that could've worked anyway). > >> > What the policy on this? > >> > > >> > v2: rebase on top of 3caf2e89aa1711e80db80d2056e0a44663d9c7d2 > >> > ("anv: fix build without Wayland platform"). Should've done that the > >> > first time around, sorry :] > >> > > >> > include/vulkan/vulkan_intel.h | 2 +- > >> > src/intel/vulkan/anv_private.h | 1 - > >> > 2 files changed, 1 insertion(+), 2 deletions(-) > >> > > >> > diff --git a/include/vulkan/vulkan_intel.h b/include/vulkan/ vulkan_intel.h > >> > index 1f77128..8ede61b 100644 > >> > --- a/include/vulkan/vulkan_intel.h > >> > +++ b/include/vulkan/vulkan_intel.h > >> > @@ -44,7 +44,7 @@ typedef struct VkDmaBufImageCreateInfo_ > >> > > >> > typedef VkResult (VKAPI_PTR *PFN_vkCreateDmaBufImageINTEL)(VkDevice device, const VkDmaBufImageCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkDeviceMemory* pMem, VkImage* pImage); > >> > > >> > -#ifdef VK_PROTOTYPES > >> > +#ifndef VK_NO_PROTOTYPES > >> > > >> Would be great to hear from the Intel guys, if there is a another > >> Cannonical repo where this change should land first ? > > > > CC'ing intel-gfx even though this isn't X-related, because I don't know > > of any other way to contact you guys :] > > > Adding the anv authors. > > Jason, Chad, is there a canonical place where changes to > vulkan_intel.h should land first ? Eric has a nice fix which we want > in mesa. > > Thanks > Emil I'm pretty sure Mesa is the only repository where this lives. [-- Attachment #1.2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 819 bytes --] [-- Attachment #2: Type: text/plain, Size: 157 bytes --] _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 mesa] vk/intel: use negative VK_NO_PROTOTYPES scheme 2016-05-02 1:04 ` Kenneth Graunke @ 2016-05-02 4:39 ` Jason Ekstrand 2016-05-09 15:50 ` Eric Engestrom 0 siblings, 1 reply; 7+ messages in thread From: Jason Ekstrand @ 2016-05-02 4:39 UTC (permalink / raw) To: Kenneth Graunke; +Cc: mesa-dev, intel-gfx@lists.freedesktop.org, Emil Velikov [-- Attachment #1.1: Type: text/plain, Size: 2398 bytes --] On May 1, 2016 6:04 PM, "Kenneth Graunke" <kenneth@whitecape.org> wrote: > > On Sunday, May 1, 2016 9:51:00 AM PDT Emil Velikov wrote: > > On 28 April 2016 at 19:13, Eric Engestrom <eric.engestrom@imgtec.com> wrote: > > > On Mon, Apr 25, 2016 at 05:08:18PM +0100, Emil Velikov wrote: > > >> On 21 April 2016 at 11:24, Eric Engestrom <eric.engestrom@imgtec.com> > wrote: > > >> > Commit 3d0fac7aca237bbe8ed8e2a362d3b42d0ef8c46c changed all the > > >> > VK_PROTOTYPES to VK_NO_PROTOTYPES > > >> > This brings the Intel header in line with the rest of the Vulkan code. > > >> > > > >> > Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com> > > >> Reviewed-by: Emil Velikov <emil.velikov@collabora.com> > > >> > > >> > --- > > >> > > > >> > This might break code that was using the old guard scheme (not sure how > > >> > that could've worked anyway). > > >> > What the policy on this? > > >> > > > >> > v2: rebase on top of 3caf2e89aa1711e80db80d2056e0a44663d9c7d2 > > >> > ("anv: fix build without Wayland platform"). Should've done that > the > > >> > first time around, sorry :] > > >> > > > >> > include/vulkan/vulkan_intel.h | 2 +- > > >> > src/intel/vulkan/anv_private.h | 1 - > > >> > 2 files changed, 1 insertion(+), 2 deletions(-) > > >> > > > >> > diff --git a/include/vulkan/vulkan_intel.h b/include/vulkan/ > vulkan_intel.h > > >> > index 1f77128..8ede61b 100644 > > >> > --- a/include/vulkan/vulkan_intel.h > > >> > +++ b/include/vulkan/vulkan_intel.h > > >> > @@ -44,7 +44,7 @@ typedef struct VkDmaBufImageCreateInfo_ > > >> > > > >> > typedef VkResult (VKAPI_PTR *PFN_vkCreateDmaBufImageINTEL)(VkDevice > device, const VkDmaBufImageCreateInfo* pCreateInfo, const > VkAllocationCallbacks* pAllocator, VkDeviceMemory* pMem, VkImage* pImage); > > >> > > > >> > -#ifdef VK_PROTOTYPES > > >> > +#ifndef VK_NO_PROTOTYPES > > >> > > > >> Would be great to hear from the Intel guys, if there is a another > > >> Cannonical repo where this change should land first ? > > > > > > CC'ing intel-gfx even though this isn't X-related, because I don't know > > > of any other way to contact you guys :] > > > > > Adding the anv authors. > > > > Jason, Chad, is there a canonical place where changes to > > vulkan_intel.h should land first ? Eric has a nice fix which we want > > in mesa. > > > > Thanks > > Emil > > I'm pretty sure Mesa is the only repository where this lives. Yup [-- Attachment #1.2: Type: text/html, Size: 3682 bytes --] [-- Attachment #2: Type: text/plain, Size: 157 bytes --] _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 mesa] vk/intel: use negative VK_NO_PROTOTYPES scheme 2016-05-02 4:39 ` Jason Ekstrand @ 2016-05-09 15:50 ` Eric Engestrom 2016-05-09 22:13 ` [Mesa-dev] " Chad Versace 0 siblings, 1 reply; 7+ messages in thread From: Eric Engestrom @ 2016-05-09 15:50 UTC (permalink / raw) To: Emil Velikov; +Cc: mesa-dev, Kenneth Graunke, intel-gfx@lists.freedesktop.org On Sun, May 01, 2016 at 09:39:58PM -0700, Jason Ekstrand wrote: > On May 1, 2016 6:04 PM, "Kenneth Graunke" <kenneth@whitecape.org> wrote: > > On Sunday, May 1, 2016 9:51:00 AM PDT Emil Velikov wrote: > > > Adding the anv authors. > > > > > > Jason, Chad, is there a canonical place where changes to > > > vulkan_intel.h should land first ? Eric has a nice fix which we want > > > in mesa. > > > > > > Thanks > > > Emil > > > > I'm pretty sure Mesa is the only repository where this lives. > > Yup Ping? I'm not sure why this didn't get at least an ACK from Intel, but I don't see any reason not to apply this fix. I don't have commit access; Emil, can you do it? Cheers, Eric _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Mesa-dev] [PATCH v2 mesa] vk/intel: use negative VK_NO_PROTOTYPES scheme 2016-05-09 15:50 ` Eric Engestrom @ 2016-05-09 22:13 ` Chad Versace 2016-05-09 23:13 ` Jason Ekstrand 0 siblings, 1 reply; 7+ messages in thread From: Chad Versace @ 2016-05-09 22:13 UTC (permalink / raw) To: Eric Engestrom Cc: mesa-dev, Kenneth Graunke, Emil Velikov, intel-gfx@lists.freedesktop.org, Jason Ekstrand On Mon 09 May 2016, Eric Engestrom wrote: > On Sun, May 01, 2016 at 09:39:58PM -0700, Jason Ekstrand wrote: > > On May 1, 2016 6:04 PM, "Kenneth Graunke" <kenneth@whitecape.org> wrote: > > > On Sunday, May 1, 2016 9:51:00 AM PDT Emil Velikov wrote: > > > > Adding the anv authors. > > > > > > > > Jason, Chad, is there a canonical place where changes to > > > > vulkan_intel.h should land first ? Eric has a nice fix which we want > > > > in mesa. > > > > > > > > Thanks > > > > Emil > > > > > > I'm pretty sure Mesa is the only repository where this lives. > > > > Yup > > Ping? > > I'm not sure why this didn't get at least an ACK from Intel, but I don't > see any reason not to apply this fix. > I don't have commit access; Emil, can you do it? Bump. Jason, does this patch look good to you? Reviewed-by: Chad Versace <chad.versace@intel.com> _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 mesa] vk/intel: use negative VK_NO_PROTOTYPES scheme 2016-05-09 22:13 ` [Mesa-dev] " Chad Versace @ 2016-05-09 23:13 ` Jason Ekstrand 0 siblings, 0 replies; 7+ messages in thread From: Jason Ekstrand @ 2016-05-09 23:13 UTC (permalink / raw) To: Chad Versace, Eric Engestrom, Emil Velikov, Kenneth Graunke, intel-gfx@lists.freedesktop.org, Jason Ekstrand, mesa-dev@lists.freedesktop.org [-- Attachment #1.1: Type: text/plain, Size: 998 bytes --] On Mon, May 9, 2016 at 3:13 PM, Chad Versace <chad.versace@intel.com> wrote: > On Mon 09 May 2016, Eric Engestrom wrote: > > On Sun, May 01, 2016 at 09:39:58PM -0700, Jason Ekstrand wrote: > > > On May 1, 2016 6:04 PM, "Kenneth Graunke" <kenneth@whitecape.org> > wrote: > > > > On Sunday, May 1, 2016 9:51:00 AM PDT Emil Velikov wrote: > > > > > Adding the anv authors. > > > > > > > > > > Jason, Chad, is there a canonical place where changes to > > > > > vulkan_intel.h should land first ? Eric has a nice fix which we > want > > > > > in mesa. > > > > > > > > > > Thanks > > > > > Emil > > > > > > > > I'm pretty sure Mesa is the only repository where this lives. > > > > > > Yup > > > > Ping? > > > > I'm not sure why this didn't get at least an ACK from Intel, but I don't > > see any reason not to apply this fix. > > I don't have commit access; Emil, can you do it? > > Bump. Jason, does this patch look good to you? > Fine by me > Reviewed-by: Chad Versace <chad.versace@intel.com> > > [-- Attachment #1.2: Type: text/html, Size: 1840 bytes --] [-- Attachment #2: Type: text/plain, Size: 157 bytes --] _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-05-09 23:13 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1461232428-17482-1-git-send-email-eric.engestrom@imgtec.com>
[not found] ` <1461234265-27828-1-git-send-email-eric.engestrom@imgtec.com>
[not found] ` <CACvgo50DC8MV9hQbo2rnZfmKe0WdwKNPwnBPoyEPKsrVAjJW8w@mail.gmail.com>
2016-04-28 18:13 ` [Mesa-dev] [PATCH v2 mesa] vk/intel: use negative VK_NO_PROTOTYPES scheme Eric Engestrom
2016-05-01 8:51 ` Emil Velikov
2016-05-02 1:04 ` Kenneth Graunke
2016-05-02 4:39 ` Jason Ekstrand
2016-05-09 15:50 ` Eric Engestrom
2016-05-09 22:13 ` [Mesa-dev] " Chad Versace
2016-05-09 23:13 ` Jason Ekstrand
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox