From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [Intel-gfx] [PATCH] drm/atomic: Add WARN_ON when state->acquire_ctx is not set. Date: Tue, 3 May 2016 14:36:37 +0200 Message-ID: <20160503123637.GF14148@phenom.ffwll.local> References: <1462266751-29123-1-git-send-email-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1462266751-29123-1-git-send-email-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBNYXkgMDMsIDIwMTYgYXQgMTE6MTI6MzFBTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gV2hlbiBJIHdhcyB3cml0aW5nIGFuIGF0b21pYyB3cmFwcGVyIGZvciBybWZi LCBJIHJhbiBpbnRvIHRoZQo+IGZvbGxvd2luZyBiYWNrdHJhY2UgZnJvbSBsb2NrZGVwOgo+IAo+ ID09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQo+IFsgSU5GTzog cG9zc2libGUgcmVjdXJzaXZlIGxvY2tpbmcgZGV0ZWN0ZWQgXQo+IDQuNS4wLXBhdHNlcisgIzQ2 OTYgVGFpbnRlZDogRyAgICAgVQo+IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLQo+IGt3b3JrZXIvMjoyLzI2MDggaXMgdHJ5aW5nIHRvIGFjcXVpcmUgbG9jazoK PiAgKGNydGNfd3dfY2xhc3NfbXV0ZXgpeysuKy4rLn0sIGF0OiBbPGZmZmZmZmZmYzAwYzlkZGM+ XSBkcm1fbW9kZXNldF9sb2NrKzB4N2MvMHgxMjAgW2RybV0KPiAKPiBidXQgdGFzayBpcyBhbHJl YWR5IGhvbGRpbmcgbG9jazoKPiAgKGNydGNfd3dfY2xhc3NfbXV0ZXgpeysuKy4rLn0sIGF0OiBb PGZmZmZmZmZmYzAwYzk4Y2Q+XSBtb2Rlc2V0X2JhY2tvZmYrMHg4ZC8weDIyMCBbZHJtXQo+IAo+ IG90aGVyIGluZm8gdGhhdCBtaWdodCBoZWxwIHVzIGRlYnVnIHRoaXM6Cj4gIFBvc3NpYmxlIHVu c2FmZSBsb2NraW5nIHNjZW5hcmlvOgo+IAo+ICAgICAgICBDUFUwCj4gICAgICAgIC0tLS0KPiAg IGxvY2soY3J0Y193d19jbGFzc19tdXRleCk7Cj4gICBsb2NrKGNydGNfd3dfY2xhc3NfbXV0ZXgp Owo+IAo+ICAqKiogREVBRExPQ0sgKioqCj4gCj4gIE1heSBiZSBkdWUgdG8gbWlzc2luZyBsb2Nr IG5lc3Rpbmcgbm90YXRpb24KPiAKPiA0IGxvY2tzIGhlbGQgYnkga3dvcmtlci8yOjIvMjYwODoK PiAgIzA6ICAoImV2ZW50cyIpey4rLisuK30sIGF0OiBbPGZmZmZmZmZmODEwYTVlZWE+XSBwcm9j ZXNzX29uZV93b3JrKzB4MTVhLzB4NmMwCj4gICMxOiAgKCgmYXJnLndvcmspKXsrLisuKy59LCBh dDogWzxmZmZmZmZmZjgxMGE1ZWVhPl0gcHJvY2Vzc19vbmVfd29yaysweDE1YS8weDZjMAo+ICAj MjogIChjcnRjX3d3X2NsYXNzX2FjcXVpcmUpeysuKy4rLn0sIGF0OiBbPGZmZmZmZmZmYzAwNDUz MmE+XSBkcm1fYXRvbWljX2hlbHBlcl9yZW1vdmVfZmIrMHg0YS8weDFkMCBbZHJtX2ttc19oZWxw ZXJdCj4gICMzOiAgKGNydGNfd3dfY2xhc3NfbXV0ZXgpeysuKy4rLn0sIGF0OiBbPGZmZmZmZmZm YzAwYzk4Y2Q+XSBtb2Rlc2V0X2JhY2tvZmYrMHg4ZC8weDIyMCBbZHJtXQo+IAo+IFdoaWxlIGxv Y2tkZXAgcHJvYmFibHkgY2F0Y2hlcyB0aGlzIGJ1ZyB3aGVuIGl0IGhhcHBlbnMsIGl0J3MgYmV0 dGVyCj4gdG8gZXhwbGljaXRseSB3YXJuIHdoZW4gc3RhdGUtPmFjcXVpcmVfY3R4IGlzIG5vdCBz ZXQuCj4gCj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hv cnN0QGxpbnV4LmludGVsLmNvbT4KClllYWgsIGJlY2F1c2Ugb2YgdGhlIGF1dG9tYWdpYyBmYWxs YmFjayB0byBub3JtYWwgbXV0ZXggc2VtYW50aWNzIHdoZW4KYWNxdWlyZV9jdHggPT0gTlVMTCBp biB3d19tdXRleF9sb2NrIHRoaXMgY2FuIGdvIGJvb20sIGFuZCB0aGUgbG9ja2RlcApzcGxhdCBp cyBwcmV0dHkgaGFyZCB0byByZWFkLiBNYWtlcyBzZW5zZSB0byBoYXZlIGFuIGV4cGxpY2l0IFdB Uk5fT04KYWJvdXQgaXQuCgpBcHBsaWVkIHRvIGRybS1taXNjLCB0aGFua3MuCi1EYW5pZWwKCj4g LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMgfCA2ICsrKysrKwo+ICAxIGZpbGUg Y2hhbmdlZCwgNiBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9kcm1fYXRvbWljLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jCj4gaW5kZXggMGI1 MjY0MjNmMTlmLi42OWFkY2YzOTQ0Y2MgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2Ry bV9hdG9taWMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMKPiBAQCAtMjYz LDYgKzI2Myw4IEBAIGRybV9hdG9taWNfZ2V0X2NydGNfc3RhdGUoc3RydWN0IGRybV9hdG9taWNf c3RhdGUgKnN0YXRlLAo+ICAJaW50IHJldCwgaW5kZXggPSBkcm1fY3J0Y19pbmRleChjcnRjKTsK PiAgCXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsKPiAgCj4gKwlXQVJOX09OKCFz dGF0ZS0+YWNxdWlyZV9jdHgpOwo+ICsKPiAgCWNydGNfc3RhdGUgPSBkcm1fYXRvbWljX2dldF9l eGlzdGluZ19jcnRjX3N0YXRlKHN0YXRlLCBjcnRjKTsKPiAgCWlmIChjcnRjX3N0YXRlKQo+ICAJ CXJldHVybiBjcnRjX3N0YXRlOwo+IEBAIC02MjIsNiArNjI0LDggQEAgZHJtX2F0b21pY19nZXRf cGxhbmVfc3RhdGUoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLAo+ICAJaW50IHJldCwg aW5kZXggPSBkcm1fcGxhbmVfaW5kZXgocGxhbmUpOwo+ICAJc3RydWN0IGRybV9wbGFuZV9zdGF0 ZSAqcGxhbmVfc3RhdGU7Cj4gIAo+ICsJV0FSTl9PTighc3RhdGUtPmFjcXVpcmVfY3R4KTsKPiAr Cj4gIAlwbGFuZV9zdGF0ZSA9IGRybV9hdG9taWNfZ2V0X2V4aXN0aW5nX3BsYW5lX3N0YXRlKHN0 YXRlLCBwbGFuZSk7Cj4gIAlpZiAocGxhbmVfc3RhdGUpCj4gIAkJcmV0dXJuIHBsYW5lX3N0YXRl Owo+IEBAIC04OTAsNiArODk0LDggQEAgZHJtX2F0b21pY19nZXRfY29ubmVjdG9yX3N0YXRlKHN0 cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwKPiAgCXN0cnVjdCBkcm1fbW9kZV9jb25maWcg KmNvbmZpZyA9ICZjb25uZWN0b3ItPmRldi0+bW9kZV9jb25maWc7Cj4gIAlzdHJ1Y3QgZHJtX2Nv bm5lY3Rvcl9zdGF0ZSAqY29ubmVjdG9yX3N0YXRlOwo+ICAKPiArCVdBUk5fT04oIXN0YXRlLT5h Y3F1aXJlX2N0eCk7Cj4gKwo+ICAJcmV0ID0gZHJtX21vZGVzZXRfbG9jaygmY29uZmlnLT5jb25u ZWN0aW9uX211dGV4LCBzdGF0ZS0+YWNxdWlyZV9jdHgpOwo+ICAJaWYgKHJldCkKPiAgCQlyZXR1 cm4gRVJSX1BUUihyZXQpOwo+IC0tIAo+IDIuNS41Cj4gCj4gX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50 ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2Fy ZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==