From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: add missing condition for committing planes on crtc Date: Mon, 9 May 2016 09:37:23 +0200 Message-ID: <20160509073723.GQ27098@phenom.ffwll.local> References: <1462360419-24072-1-git-send-email-lionel.g.landwerlin@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1BCFA89F82 for ; Mon, 9 May 2016 07:37:25 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id e201so19265092wme.2 for ; Mon, 09 May 2016 00:37:25 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1462360419-24072-1-git-send-email-lionel.g.landwerlin@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lionel Landwerlin Cc: Jani Nikula , Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBNYXkgMDQsIDIwMTYgYXQgMTI6MTM6MzlQTSArMDEwMCwgTGlvbmVsIExhbmR3ZXJs aW4gd3JvdGU6Cj4gV2UgYXJlIGN1cnJlbnRseSBtaXNzaW5nIHRoZSBjb2xvciBtYW5hZ2VtZW50 IHVwZGF0ZSBjb25kaXRpb24gdG8KPiBjb21taXQgcGxhbmVzIG9uIGNydGMuCj4gCj4gdjI6IGFk ZCBjb21tZW50IGFib3V0IG1vdmluZyB0aGUgY29tbWl0IG9mIGNvbG9yIG1hbmFnZW1lbnQgcmVn aXN0ZXJzCj4gICAgIHRvIGFuIGFzeW5jIHdvcmtlcgo+IAo+IEZpeGVzOiAyMGEzNGU3OGYwZDcg KGRybS9pOTE1OiBVcGRhdGUgY29sb3IgbWFuYWdlbWVudCBkdXJpbmcgdmJsYW5rIGV2YXNpb24u KQo+IENjOiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwu Y29tPgo+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+IENjOiBEYW5p ZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+IFNpZ25lZC1vZmYtYnk6IExpb25l bCBMYW5kd2VybGluIDxsaW9uZWwuZy5sYW5kd2VybGluQGludGVsLmNvbT4KPiAtLS0KPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgMTYgKysrKysrKysrKysrKy0tLQo+ ICAxIGZpbGUgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiAKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggNDVjMjE4ZC4uNDkzNjc0MyAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBAQCAtMTM1NDQsNiArMTM1 NDQsMTUgQEAgc3RhdGljIGJvb2wgbmVlZHNfdmJsYW5rX3dhaXQoc3RydWN0IGludGVsX2NydGNf c3RhdGUgKmNydGNfc3RhdGUpCj4gIAlyZXR1cm4gZmFsc2U7Cj4gIH0KPiAgCj4gK3N0YXRpYyBi b29sIG5lZWRzX2NvbW1pdF9wbGFuZXNfb25fY3J0YyhzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNy dGNfc3RhdGUpCj4gK3sKPiArCS8qIFRPRE86IGRyb3AgdGhlIGNvbG9yIG1hbmFnZW1lbnQgY29u ZGl0aW9uIG9uY2UgY29tbWl0dGluZwo+ICsJICogdGhvc2UgcmVnaXN0ZXJzIGhhcyBiZWVuIG1v dmVkIHRvIGFuIGFzeW5jIHdvcmtlci4gKi8KPiArCXJldHVybiAoY3J0Y19zdGF0ZS0+cGxhbmVz X2NoYW5nZWQgfHwKPiArCQljcnRjX3N0YXRlLT5jb2xvcl9tZ210X2NoYW5nZWQgfHwKPiArCQl0 b19pbnRlbF9jcnRjX3N0YXRlKGNydGNfc3RhdGUpLT51cGRhdGVfcGlwZSk7Cj4gK30KCkkgdGhp bmsgaXQnZCBiZSBjbGVhbmVyIChhcyBpbiByZWxhdGVkIGxvZ2ljIHB1bGxlZCB0b2dldGhlcikg YW5kIG1vcmUgaW4Kc3Bpcml0IG9mIHRoZSBhdG9taWMgZnJhbWV3b3JrIGlmIHlvdSBzZXQgcGxh bmVzX2NoYW5nZWQgd2hlbiB5b3Ugbm90aWNlCnRoYXQgY29sb3IgbWdtIHN0YXRlIG5lZWRzIGFu IHVwZGF0ZS4gVGhhdCBtYWtlcyBpdCBjbGVhciB0aGF0IG9uIGludGVsIGh3CndlIGRvIHN1Y2gg Y2hhbmdlcyB3aXRoIGEgcGxhaW4gZmxpcCAod2VsbCBsYXRlciBvbiBtYXliZSB3ZSBuZWVkIGEg Ym9vbApmb3IgdGhlIHZibGFuayB3b3JrZXIpLiBPdGhlciBodyBtaWdodCBuZWVkIGEgZnVsbCBt b2Rlc2V0LgoKQWRkaW5nIG1vcmUgY29uZGl0aW9ucyBsaWtlIHRoaXMgdG8gdGhlIGNvbW1pdCBj b2RlIG1ha2VzIGl0IGltbyByZWFsbHkKZnJhZ2lsZSBhbmQgaGFyZCB0byB1bmRlcnN0YW5kLiBB dCBsZWFzdCBpbW8gY29tcHV0aW5nIGhvdyB0byBjb21taXQgc3RhdGUKaXMgYmVzdCBwbGFjZWQg bmV4dCB0byB3aGVuIHdlIGNvbXB1dGUgd2hhdCBjaGFuZ2VkLgoKQWxsIHRoZSAqX2NoYW5nZWQg dmFyaWFibGVzIGNvbXB1dGVkIGJ5IHRoZSBoZWxwZXJzL2NvcmUgYXJlIG1lYW50IHRvIGJlCmNo YW5nZWFibGUgYnkgdGhlIGRyaXZlciAoYXNzdW1pbmcgaXQga25vd3Mgd2hhdCBpdCdzIGRvaW5n KSwgYW5kIGluCmdlbmVyYWwgY2FuIGJlIHVwZ3JhZGVkIHRvIHRydWUgd2l0aG91dCBjYXVzaW5n IGFueSB0cm91YmxlIChleGNlcHQgbWF5YmUKcnVubmluZyBzb21lIGNvZGUgdGhhdCBkb2Vzbid0 IG5lY2Vzc2FyaWx5IG5lZWQgdG8gYmUgcnVuKS4KLURhbmllbAoKPiArCj4gIC8qKgo+ICAgKiBp bnRlbF9hdG9taWNfY29tbWl0IC0gY29tbWl0IHZhbGlkYXRlZCBzdGF0ZSBvYmplY3QKPiAgICog QGRldjogRFJNIGRldmljZQo+IEBAIC0xMzY0OSw3ICsxMzY1OCw2IEBAIHN0YXRpYyBpbnQgaW50 ZWxfYXRvbWljX2NvbW1pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJCWJvb2wgbW9kZXNl dCA9IG5lZWRzX21vZGVzZXQoY3J0Yy0+c3RhdGUpOwo+ICAJCXN0cnVjdCBpbnRlbF9jcnRjX3N0 YXRlICpwaXBlX2NvbmZpZyA9Cj4gIAkJCXRvX2ludGVsX2NydGNfc3RhdGUoY3J0Yy0+c3RhdGUp Owo+IC0JCWJvb2wgdXBkYXRlX3BpcGUgPSAhbW9kZXNldCAmJiBwaXBlX2NvbmZpZy0+dXBkYXRl X3BpcGU7Cj4gIAo+ICAJCWlmIChtb2Rlc2V0ICYmIGNydGMtPnN0YXRlLT5hY3RpdmUpIHsKPiAg CQkJdXBkYXRlX3NjYW5saW5lX29mZnNldCh0b19pbnRlbF9jcnRjKGNydGMpKTsKPiBAQCAtMTM2 NjMsOCArMTM2NzEsOCBAQCBzdGF0aWMgaW50IGludGVsX2F0b21pY19jb21taXQoc3RydWN0IGRy bV9kZXZpY2UgKmRldiwKPiAgCQkgICAgZHJtX2F0b21pY19nZXRfZXhpc3RpbmdfcGxhbmVfc3Rh dGUoc3RhdGUsIGNydGMtPnByaW1hcnkpKQo+ICAJCQlpbnRlbF9mYmNfZW5hYmxlKGludGVsX2Ny dGMpOwo+ICAKPiAtCQlpZiAoY3J0Yy0+c3RhdGUtPmFjdGl2ZSAmJgo+IC0JCSAgICAoY3J0Yy0+ c3RhdGUtPnBsYW5lc19jaGFuZ2VkIHx8IHVwZGF0ZV9waXBlKSkKPiArCQlpZiAoY3J0Yy0+c3Rh dGUtPmFjdGl2ZSAmJiAhbW9kZXNldCAmJgo+ICsJCSAgICBuZWVkc19jb21taXRfcGxhbmVzX29u X2NydGMoY3J0Yy0+c3RhdGUpKQo+ICAJCQlkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfcGxhbmVz X29uX2NydGMob2xkX2NydGNfc3RhdGUpOwo+ICAKPiAgCQlpZiAocGlwZV9jb25maWctPmJhc2Uu YWN0aXZlICYmIG5lZWRzX3ZibGFua193YWl0KHBpcGVfY29uZmlnKSkKPiBAQCAtMTM5NzQsNiAr MTM5ODIsOCBAQCBzdGF0aWMgdm9pZCBpbnRlbF9iZWdpbl9jcnRjX2NvbW1pdChzdHJ1Y3QgZHJt X2NydGMgKmNydGMsCj4gIAlpZiAobW9kZXNldCkKPiAgCQlyZXR1cm47Cj4gIAo+ICsJLyogVE9E TzogQ29sb3IgbWFuYWdlbWVudCByZWdpc3RlcnMgY29tbWl0IHNob3VsZCBiZSBtb3ZlZCB0bwo+ ICsJICogYW4gYXN5bmMgd29ya2VyIHdoZW4gd2UgaGF2ZSB0aGVtLiAqLwo+ICAJaWYgKGNydGMt PnN0YXRlLT5jb2xvcl9tZ210X2NoYW5nZWQgfHwgdG9faW50ZWxfY3J0Y19zdGF0ZShjcnRjLT5z dGF0ZSktPnVwZGF0ZV9waXBlKSB7Cj4gIAkJaW50ZWxfY29sb3Jfc2V0X2NzYyhjcnRjLT5zdGF0 ZSk7Cj4gIAkJaW50ZWxfY29sb3JfbG9hZF9sdXRzKGNydGMtPnN0YXRlKTsKPiAtLSAKPiAyLjgu MC5yYzMuMjI2LmczOWQ0MDIwCj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVl ciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==