From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/2] drm/i915: Ignore stale wm register values on resume on ilk-bdw Date: Fri, 13 May 2016 20:18:18 +0300 Message-ID: <20160513171818.GF4329@intel.com> References: <1463151318-14719-1-git-send-email-ville.syrjala@linux.intel.com> <1463151318-14719-3-git-send-email-ville.syrjala@linux.intel.com> <20160513165855.GE22371@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTP id 8158C6EAD6 for ; Fri, 13 May 2016 17:18:22 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20160513165855.GE22371@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBNYXkgMTMsIDIwMTYgYXQgMDk6NTg6NTVBTSAtMDcwMCwgTWF0dCBSb3BlciB3cm90 ZToKPiBPbiBGcmksIE1heSAxMywgMjAxNiBhdCAwNTo1NToxOFBNICswMzAwLCB2aWxsZS5zeXJq YWxhQGxpbnV4LmludGVsLmNvbSB3cm90ZToKPiA+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmls bGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiAKPiA+IFdoZW4gd2UgcmVzdW1lIHRoZSB3 YXRlcm1hcmsgcmVnaXN0ZXIgbWF5IGNvbnRhaW4gc29tZSBCSU9TIGxlZnRvdmVycywKPiA+IG9y IGp1c3QgdGhlIGhhcmR3YXJlIHJlc2V0IHZhbHVlcy4gV2Ugc2hvdWxkIGlnbm9yZSB0aG9zZSBh cyB0aGUKPiA+IHBpcGVzIHdpbGwgYmUgb2ZmIGFueXdheSwgYW5kIHNvIGZyb2JiaW5nIGFyb3Vu ZCB3aXRoIGludGVybWVkaWF0ZQo+ID4gd2F0ZXJtYXJrcyBkb2Vzbid0IG1ha2UgbXVjaCBzZW5z ZS4KPiA+IAo+ID4gSW4gZmFjdCBJIHRoaW5rIHdlIHNob3VsZCBqdXN0IHRocm93IHRoZSBza2lw X2ludGVybWVkaWF0ZV93bSBmbGFnCj4gPiBvdXQsIGFuZCBpbnN0ZWFkIHByb3Blcmx5IHNhbml0 aXplIHRoZSAiYWN0aXZlIiB3YXRlcm1hcmtzIHRvIG1hdGNoCj4gPiB0aGUgY3VycmVudCBwbGFu ZSBhbmQgcGlwZSBzdGF0ZXMuCj4gCj4gVGhhdCdzIHdoYXQgdGhlIGZsYWcgd2FzIG9yaWdpbmFs bHkgYWRkZWQgZm9yLiAgVGhlIGVhc2llc3Qgd2F5IHRvCj4gc2FuaXRpemUgdGhlIGFjdGl2ZSB3 YXRlcm1hcmtzIGlzIHRvIHJ1biB0aGUgY3VycmVudCBhdG9taWMgc3RhdGUKPiB0aHJvdWdoIG91 ciB3aG9sZSBhdG9taWMgY2hlY2sgcHJvY2VzcyB0byBjYWxjdWxhdGUgYWxsIGRlcml2ZWQgc3Rh dGUKPiBwbHVzIHRoZSB3YXRlcm1hcmsgdmFsdWVzLCBhbmQgdGhlbiBqdXN0IHB1c2ggdGhlIG9w dGltYWwgdmFsdWVzIGludG8KPiB0aGUgaGFyZHdhcmUuICBUaGUgZmxhZyB0ZWxscyB1cyB0byBq dXN0IHNraXAgY2FsY3VsYXRpbmcgdGhlCj4gaW50ZXJtZWRpYXRlIHZhbHVlcyAod2hpY2ggbWln aHQgYmUgYm9ndXMgYW5kL29yIGZhaWwgYW55d2F5KSBzaW5jZSBhbGwKPiB3ZSBjYXJlIGFib3V0 IGFyZSB0aGUgZmluYWwvb3B0aW1hbCB2YWx1ZXMuCgpXZSBzaG91bGQgc3RpbGwgY2FyZSBhYm91 dCB0aGUgdHJhbnNpdGlvbiB0byBhdm9pZCBhbnkgdW5kZXJydW5zLApzbyB3ZSBzaG91bGQgcmF0 aGVyIGhhdmUgcHJvcGVyIGludGVybWVkaWF0ZSB3YXRlcm1hcmtzIGhlcmUuIEkKdGhpbmsgdGhl IHByb2JsZW0gd2UncmUgd29ya2luZyBhcm91bmQgaGVyZSBpcyBiYXNpY2FsbHkgcG9vciBodyBz dGF0ZQpyZWFkb3V0LiBUaGF0IGlzLCB3ZSBzaG91bGQgbW9yZSBvciBsZXNzIGp1c3QgZGlzY2Fy ZCB0aGUgcmVzdWx0cyBvZgp0aGUgaHcgcmVhZG91dCBmb3IgYW55IHBsYW5lL3BpcGUgdGhhdCBp cyBkaXNhYmxlZC4KClRoZSBlbmQgcmVzdWx0IHNob3VsZCBiZSBvbmUgbGVzcyBzcGVjaWFsIGNh c2UgdG8gd29ycnkgYWJvdXQuIFRoZSBsZXNzCndlIGhhdmUgb2YgdGhvc2UgdGhlIGJldHRlci4K CklmIHdlIHdvdWxkIGV2ZXIgcnVuIGludG8gYSBnZW51aW5lIGNhc2Ugd2hlcmUgd2UgY291bGRu J3QgZG8gdGhlCmludGVybWVkaWF0ZSB3YXRlcm1hcmtzIHByb3Blcmx5LCB0aGVuIHdlIGNvdWxk IGFsd2F5cyBqdXN0IHNodXQKZXZlcnl0aGluZyBkb3duIGZpcnN0LCBhbmQgdGhlbiBicmluZyBp dCBiYWNrIHVwIGZyb20gc2NyYXRjaC4KCj4gCj4gQW55d2F5LCB0aGlzIGxvb2tzIHByZXR0eSBz aW1pbGFyIHRvIHRoZSBmaXggSSB3cm90ZSByaWdodCBiZWZvcmUgSSB3ZW50Cj4gT09PLCBidXQg bmV2ZXIgZ290IGEgY2hhbmNlIHRvIHNlbmQgb3V0OyBJIHNldCB0aGUgc2tpcCBmbGFnIHdoZW4g dGhlCj4gYXRvbWljIHN0YXRlIHdhcyBjcmVhdGVkIGluIHRoZSBzdXNwZW5kIGZ1bmN0aW9uIGFu ZCB5b3UgZG8gaXQgaW4gdGhlCj4gcmVzdW1lIGZ1bmN0aW9uLCBidXQgSSB0aGluayB0aGUgcmVz dWx0IHNob3VsZCBiZSB0aGUgc2FtZSBlaXRoZXIgd2F5LAo+IHNvIG92ZXJhbGwgbGd0bS4KPiAK PiBGb3IgYm90aCBwYXRjaGVzOgo+IFJldmlld2VkLWJ5OiBNYXR0IFJvcGVyIDxtYXR0aGV3LmQu cm9wZXJAaW50ZWwuY29tPgo+IAo+IAo+ID4gVGhlIGFjdHVhbCB3bSBzdGF0ZSByZWFkb3V0IG1p Z2h0Cj4gPiBhbHNvIG5lZWQgYSBiaXQgb2Ygd29yay4gQnV0IGZvciBub3csIGxldCdzIGNvbnRp bnVlIHdpdGggdGhlCj4gPiBza2lwX2ludGVybWVkaWF0ZV93bSB0byBrZWVwIHRoZSBmaXggbW9y ZSBtaW5pbWFsLgo+ID4gCj4gPiBGaXhlcyB0aGlzIHNvcnQgb2YgZXJyb3JzIG9uIHJlc3VtZQo+ ID4gW2RybTppbGtfdmFsaWRhdGVfcGlwZV93bV0gTFAwIHdhdGVybWFyayBpbnZhbGlkCj4gPiBb ZHJtOmludGVsX2NydGNfYXRvbWljX2NoZWNrXSBObyB2YWxpZCBpbnRlcm1lZGlhdGUgcGlwZSB3 YXRlcm1hcmtzIGFyZSBwb3NzaWJsZQo+ID4gW2RybTppbnRlbF9kaXNwbGF5X3Jlc3VtZSBbaTkx NV1dICpFUlJPUiogUmVzdG9yaW5nIG9sZCBzdGF0ZSBmYWlsZWQgd2l0aCAtMjIKPiA+IGFuZCBh IGJvYXRsb2FkIG9mIHN1YnNlcXVlbnQgbW9kZXNldCBCQVQgZmFpbHMgb24gbXkgSUxLLgo+ID4g Cj4gPiBDYzogTWF0dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNvbT4KPiA+IENjOiBN YWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+ID4g Rml4ZXM6IGVkNGE2YTdjYTg1MyAoImRybS9pOTE1OiBBZGQgdHdvLXN0YWdlIElMSy1zdHlsZSB3 YXRlcm1hcmsgcHJvZ3JhbW1pbmcgKHYxMSkiKQo+ID4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3ly asOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDYgKysrKysrCj4gPiAgMSBmaWxlIGNo YW5nZWQsIDYgaW5zZXJ0aW9ucygrKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jCj4gPiBpbmRleCBhMDhjNGE0NWI4ZDMuLjkzODY1MzA2M2YxNSAxMDA2NDQKPiA+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBAQCAtMTIwMDMsNiArMTIwMDMsOSBA QCBzdGF0aWMgaW50IGludGVsX2NydGNfYXRvbWljX2NoZWNrKHN0cnVjdCBkcm1fY3J0YyAqY3J0 YywKPiA+ICAJCQlEUk1fREVCVUdfS01TKCJObyB2YWxpZCBpbnRlcm1lZGlhdGUgcGlwZSB3YXRl cm1hcmtzIGFyZSBwb3NzaWJsZVxuIik7Cj4gPiAgCQkJcmV0dXJuIHJldDsKPiA+ICAJCX0KPiA+ ICsJfSBlbHNlIGlmIChkZXZfcHJpdi0+ZGlzcGxheS5jb21wdXRlX2ludGVybWVkaWF0ZV93bSkg ewo+ID4gKwkJaWYgKEhBU19QQ0hfU1BMSVQoZGV2X3ByaXYpICYmIElOVEVMX0dFTihkZXZfcHJp dikgPCA5KQo+ID4gKwkJCXBpcGVfY29uZmlnLT53bS5pbnRlcm1lZGlhdGUgPSBwaXBlX2NvbmZp Zy0+d20ub3B0aW1hbC5pbGs7Cj4gPiAgCX0KPiA+ICAKPiA+ICAJaWYgKElOVEVMX0lORk8oZGV2 KS0+Z2VuID49IDkpIHsKPiA+IEBAIC0xNTk5MSw2ICsxNTk5NCw5IEBAIHJldHJ5Ogo+ID4gIAo+ ID4gIAkJc3RhdGUtPmFjcXVpcmVfY3R4ID0gJmN0eDsKPiA+ICAKPiA+ICsJCS8qIGlnbm9yZSBh bnkgcmVzZXQgdmFsdWVzL0JJT1MgbGVmdG92ZXJzIGluIHRoZSBXTSByZWdpc3RlcnMgKi8KPiA+ ICsJCXRvX2ludGVsX2F0b21pY19zdGF0ZShzdGF0ZSktPnNraXBfaW50ZXJtZWRpYXRlX3dtID0g dHJ1ZTsKPiA+ICsKPiA+ICAJCWZvcl9lYWNoX2NydGNfaW5fc3RhdGUoc3RhdGUsIGNydGMsIGNy dGNfc3RhdGUsIGkpIHsKPiA+ICAJCQkvKgo+ID4gIAkJCSAqIEZvcmNlIHJlY2FsY3VsYXRpb24g ZXZlbiBpZiB3ZSByZXN0b3JlCj4gPiAtLSAKPiA+IDIuNy40Cj4gPiAKPiAKPiAtLSAKPiBNYXR0 IFJvcGVyCj4gR3JhcGhpY3MgU29mdHdhcmUgRW5naW5lZXIKPiBJb1RHIFBsYXRmb3JtIEVuYWJs aW5nICYgRGV2ZWxvcG1lbnQKPiBJbnRlbCBDb3Jwb3JhdGlvbgo+ICg5MTYpIDM1Ni0yNzk1Cgot LSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngK