From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Roper Subject: Re: [PATCH 2/2] drm/i915: Ignore stale wm register values on resume on ilk-bdw Date: Fri, 13 May 2016 10:35:16 -0700 Message-ID: <20160513173516.GF22371@intel.com> References: <1463151318-14719-1-git-send-email-ville.syrjala@linux.intel.com> <1463151318-14719-3-git-send-email-ville.syrjala@linux.intel.com> <20160513165855.GE22371@intel.com> <20160513171818.GF4329@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 1D6496E2AC for ; Fri, 13 May 2016 17:35:17 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20160513171818.GF4329@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBNYXkgMTMsIDIwMTYgYXQgMDg6MTg6MThQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIEZyaSwgTWF5IDEzLCAyMDE2IGF0IDA5OjU4OjU1QU0gLTA3MDAsIE1hdHQg Um9wZXIgd3JvdGU6Cj4gPiBPbiBGcmksIE1heSAxMywgMjAxNiBhdCAwNTo1NToxOFBNICswMzAw LCB2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbSB3cm90ZToKPiA+ID4gRnJvbTogVmlsbGUg U3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+ID4gCj4gPiA+IFdo ZW4gd2UgcmVzdW1lIHRoZSB3YXRlcm1hcmsgcmVnaXN0ZXIgbWF5IGNvbnRhaW4gc29tZSBCSU9T IGxlZnRvdmVycywKPiA+ID4gb3IganVzdCB0aGUgaGFyZHdhcmUgcmVzZXQgdmFsdWVzLiBXZSBz aG91bGQgaWdub3JlIHRob3NlIGFzIHRoZQo+ID4gPiBwaXBlcyB3aWxsIGJlIG9mZiBhbnl3YXks IGFuZCBzbyBmcm9iYmluZyBhcm91bmQgd2l0aCBpbnRlcm1lZGlhdGUKPiA+ID4gd2F0ZXJtYXJr cyBkb2Vzbid0IG1ha2UgbXVjaCBzZW5zZS4KPiA+ID4gCj4gPiA+IEluIGZhY3QgSSB0aGluayB3 ZSBzaG91bGQganVzdCB0aHJvdyB0aGUgc2tpcF9pbnRlcm1lZGlhdGVfd20gZmxhZwo+ID4gPiBv dXQsIGFuZCBpbnN0ZWFkIHByb3Blcmx5IHNhbml0aXplIHRoZSAiYWN0aXZlIiB3YXRlcm1hcmtz IHRvIG1hdGNoCj4gPiA+IHRoZSBjdXJyZW50IHBsYW5lIGFuZCBwaXBlIHN0YXRlcy4KPiA+IAo+ ID4gVGhhdCdzIHdoYXQgdGhlIGZsYWcgd2FzIG9yaWdpbmFsbHkgYWRkZWQgZm9yLiAgVGhlIGVh c2llc3Qgd2F5IHRvCj4gPiBzYW5pdGl6ZSB0aGUgYWN0aXZlIHdhdGVybWFya3MgaXMgdG8gcnVu IHRoZSBjdXJyZW50IGF0b21pYyBzdGF0ZQo+ID4gdGhyb3VnaCBvdXIgd2hvbGUgYXRvbWljIGNo ZWNrIHByb2Nlc3MgdG8gY2FsY3VsYXRlIGFsbCBkZXJpdmVkIHN0YXRlCj4gPiBwbHVzIHRoZSB3 YXRlcm1hcmsgdmFsdWVzLCBhbmQgdGhlbiBqdXN0IHB1c2ggdGhlIG9wdGltYWwgdmFsdWVzIGlu dG8KPiA+IHRoZSBoYXJkd2FyZS4gIFRoZSBmbGFnIHRlbGxzIHVzIHRvIGp1c3Qgc2tpcCBjYWxj dWxhdGluZyB0aGUKPiA+IGludGVybWVkaWF0ZSB2YWx1ZXMgKHdoaWNoIG1pZ2h0IGJlIGJvZ3Vz IGFuZC9vciBmYWlsIGFueXdheSkgc2luY2UgYWxsCj4gPiB3ZSBjYXJlIGFib3V0IGFyZSB0aGUg ZmluYWwvb3B0aW1hbCB2YWx1ZXMuCj4gCj4gV2Ugc2hvdWxkIHN0aWxsIGNhcmUgYWJvdXQgdGhl IHRyYW5zaXRpb24gdG8gYXZvaWQgYW55IHVuZGVycnVucywKPiBzbyB3ZSBzaG91bGQgcmF0aGVy IGhhdmUgcHJvcGVyIGludGVybWVkaWF0ZSB3YXRlcm1hcmtzIGhlcmUuIEkKPiB0aGluayB0aGUg cHJvYmxlbSB3ZSdyZSB3b3JraW5nIGFyb3VuZCBoZXJlIGlzIGJhc2ljYWxseSBwb29yIGh3IHN0 YXRlCj4gcmVhZG91dC4gVGhhdCBpcywgd2Ugc2hvdWxkIG1vcmUgb3IgbGVzcyBqdXN0IGRpc2Nh cmQgdGhlIHJlc3VsdHMgb2YKPiB0aGUgaHcgcmVhZG91dCBmb3IgYW55IHBsYW5lL3BpcGUgdGhh dCBpcyBkaXNhYmxlZC4KCldoYXQgSSBtZWFuIGlzIHRoYXQgZHVyaW5nIGluaXRpYWwgYm9vdCwg dGhlIHNhbml0aXphdGlvbiB3ZSBkbyBpcyBvbmx5CnByb2dyYW1taW5nIHRoZSB3YXRlcm1hcmtz IGFuZCBub3QgY2hhbmdpbmcgdGhlIGNvbmZpZ3VyYXRpb24gYXQgYWxsLgoKRm9yIHJlc3VtZSB0 aGF0J3MgYSBiaXQgZGlmZmVyZW50IGF0IHRoZSBtb21lbnQgc2luY2Ugd2UgcmVhZCBvdXQgdGhl CmhhcmR3YXJlIHN0YXRlIGFuZCB0aGVuIGltbWVkaWF0ZWx5IHBlcmZvcm0gYW4gYXRvbWljIGNv bW1pdCAod2l0aCB0aGUKc2F2ZWQgc3RhdGUpIHdpdGhvdXQgaGF2aW5nIHNhbml0aXplZCB0aGUg d2F0ZXJtYXJrcyBmaXJzdC4gIFNvIEkgdGhpbmsKYW5vdGhlciBwb3RlbnRpYWwgZml4IG1pZ2h0 IGJlIHRvIGp1c3QgY2FsbCBzYW5pdGl6ZV93YXRlcm1hcmtzKCkgYWZ0ZXIKcmVhZGluZyBvdXQg dGhlIGhhcmR3YXJlIHN0YXRlLCBidXQgYmVmb3JlIGNvbW1pdHRpbmcgdGhlIHNhdmVkIHN0YXRl LgpJIHRoaW5rIHRoYXQgYXBwcm9hY2ggaXMgd2hhdCB5b3Ugd2VyZSByZWZlcnJpbmcgdG8gYWJv dmUgYnkgInNhbml0aXplCnRoZSAnYWN0aXZlJyB3YXRlcm1hcmtzIHRvIG1hdGNoIHRoZSBjdXJy ZW50IHBsYW5lIGFuZCBwaXBlIHN0YXRlcywiIGJ1dAp1bmxlc3Mgd2UgYWxzbyBjaGFuZ2VkIG91 ciBzYW5pdGl6YXRpb24gbG9naWMsIHdlJ2Qgc3RpbGwgaGF2ZSB0aGUKc2tpcF9pbnRlcm1lZGlh dGVfd20gZmxhZyBzaW5jZSBpdCBnZXRzIHVzZWQgaW5zaWRlIHRoZSBzYW5pdGl6YXRpb24KY29k ZS4KCj4gCj4gVGhlIGVuZCByZXN1bHQgc2hvdWxkIGJlIG9uZSBsZXNzIHNwZWNpYWwgY2FzZSB0 byB3b3JyeSBhYm91dC4gVGhlIGxlc3MKPiB3ZSBoYXZlIG9mIHRob3NlIHRoZSBiZXR0ZXIuCj4g Cj4gSWYgd2Ugd291bGQgZXZlciBydW4gaW50byBhIGdlbnVpbmUgY2FzZSB3aGVyZSB3ZSBjb3Vs ZG4ndCBkbyB0aGUKPiBpbnRlcm1lZGlhdGUgd2F0ZXJtYXJrcyBwcm9wZXJseSwgdGhlbiB3ZSBj b3VsZCBhbHdheXMganVzdCBzaHV0Cj4gZXZlcnl0aGluZyBkb3duIGZpcnN0LCBhbmQgdGhlbiBi cmluZyBpdCBiYWNrIHVwIGZyb20gc2NyYXRjaC4KClllYWgsIHRoYXQncyBhIGdvb2QgcG9pbnQu CgoKTWF0dAoKPiAKPiA+IAo+ID4gQW55d2F5LCB0aGlzIGxvb2tzIHByZXR0eSBzaW1pbGFyIHRv IHRoZSBmaXggSSB3cm90ZSByaWdodCBiZWZvcmUgSSB3ZW50Cj4gPiBPT08sIGJ1dCBuZXZlciBn b3QgYSBjaGFuY2UgdG8gc2VuZCBvdXQ7IEkgc2V0IHRoZSBza2lwIGZsYWcgd2hlbiB0aGUKPiA+ IGF0b21pYyBzdGF0ZSB3YXMgY3JlYXRlZCBpbiB0aGUgc3VzcGVuZCBmdW5jdGlvbiBhbmQgeW91 IGRvIGl0IGluIHRoZQo+ID4gcmVzdW1lIGZ1bmN0aW9uLCBidXQgSSB0aGluayB0aGUgcmVzdWx0 IHNob3VsZCBiZSB0aGUgc2FtZSBlaXRoZXIgd2F5LAo+ID4gc28gb3ZlcmFsbCBsZ3RtLgo+ID4g Cj4gPiBGb3IgYm90aCBwYXRjaGVzOgo+ID4gUmV2aWV3ZWQtYnk6IE1hdHQgUm9wZXIgPG1hdHRo ZXcuZC5yb3BlckBpbnRlbC5jb20+Cj4gPiAKPiA+IAo+ID4gPiBUaGUgYWN0dWFsIHdtIHN0YXRl IHJlYWRvdXQgbWlnaHQKPiA+ID4gYWxzbyBuZWVkIGEgYml0IG9mIHdvcmsuIEJ1dCBmb3Igbm93 LCBsZXQncyBjb250aW51ZSB3aXRoIHRoZQo+ID4gPiBza2lwX2ludGVybWVkaWF0ZV93bSB0byBr ZWVwIHRoZSBmaXggbW9yZSBtaW5pbWFsLgo+ID4gPiAKPiA+ID4gRml4ZXMgdGhpcyBzb3J0IG9m IGVycm9ycyBvbiByZXN1bWUKPiA+ID4gW2RybTppbGtfdmFsaWRhdGVfcGlwZV93bV0gTFAwIHdh dGVybWFyayBpbnZhbGlkCj4gPiA+IFtkcm06aW50ZWxfY3J0Y19hdG9taWNfY2hlY2tdIE5vIHZh bGlkIGludGVybWVkaWF0ZSBwaXBlIHdhdGVybWFya3MgYXJlIHBvc3NpYmxlCj4gPiA+IFtkcm06 aW50ZWxfZGlzcGxheV9yZXN1bWUgW2k5MTVdXSAqRVJST1IqIFJlc3RvcmluZyBvbGQgc3RhdGUg ZmFpbGVkIHdpdGggLTIyCj4gPiA+IGFuZCBhIGJvYXRsb2FkIG9mIHN1YnNlcXVlbnQgbW9kZXNl dCBCQVQgZmFpbHMgb24gbXkgSUxLLgo+ID4gPiAKPiA+ID4gQ2M6IE1hdHQgUm9wZXIgPG1hdHRo ZXcuZC5yb3BlckBpbnRlbC5jb20+Cj4gPiA+IENjOiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRl bi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+ID4gPiBGaXhlczogZWQ0YTZhN2NhODUzICgi ZHJtL2k5MTU6IEFkZCB0d28tc3RhZ2UgSUxLLXN0eWxlIHdhdGVybWFyayBwcm9ncmFtbWluZyAo djExKSIpCj4gPiA+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFs YUBsaW51eC5pbnRlbC5jb20+Cj4gPiA+IC0tLQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGlzcGxheS5jIHwgNiArKysrKysKPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2Vy dGlvbnMoKykKPiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+ ID4gaW5kZXggYTA4YzRhNDViOGQzLi45Mzg2NTMwNjNmMTUgMTAwNjQ0Cj4gPiA+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+ID4gQEAgLTEyMDAzLDYgKzEyMDAzLDkgQEAg c3RhdGljIGludCBpbnRlbF9jcnRjX2F0b21pY19jaGVjayhzdHJ1Y3QgZHJtX2NydGMgKmNydGMs Cj4gPiA+ICAJCQlEUk1fREVCVUdfS01TKCJObyB2YWxpZCBpbnRlcm1lZGlhdGUgcGlwZSB3YXRl cm1hcmtzIGFyZSBwb3NzaWJsZVxuIik7Cj4gPiA+ICAJCQlyZXR1cm4gcmV0Owo+ID4gPiAgCQl9 Cj4gPiA+ICsJfSBlbHNlIGlmIChkZXZfcHJpdi0+ZGlzcGxheS5jb21wdXRlX2ludGVybWVkaWF0 ZV93bSkgewo+ID4gPiArCQlpZiAoSEFTX1BDSF9TUExJVChkZXZfcHJpdikgJiYgSU5URUxfR0VO KGRldl9wcml2KSA8IDkpCj4gPiA+ICsJCQlwaXBlX2NvbmZpZy0+d20uaW50ZXJtZWRpYXRlID0g cGlwZV9jb25maWctPndtLm9wdGltYWwuaWxrOwo+ID4gPiAgCX0KPiA+ID4gIAo+ID4gPiAgCWlm IChJTlRFTF9JTkZPKGRldiktPmdlbiA+PSA5KSB7Cj4gPiA+IEBAIC0xNTk5MSw2ICsxNTk5NCw5 IEBAIHJldHJ5Ogo+ID4gPiAgCj4gPiA+ICAJCXN0YXRlLT5hY3F1aXJlX2N0eCA9ICZjdHg7Cj4g PiA+ICAKPiA+ID4gKwkJLyogaWdub3JlIGFueSByZXNldCB2YWx1ZXMvQklPUyBsZWZ0b3ZlcnMg aW4gdGhlIFdNIHJlZ2lzdGVycyAqLwo+ID4gPiArCQl0b19pbnRlbF9hdG9taWNfc3RhdGUoc3Rh dGUpLT5za2lwX2ludGVybWVkaWF0ZV93bSA9IHRydWU7Cj4gPiA+ICsKPiA+ID4gIAkJZm9yX2Vh Y2hfY3J0Y19pbl9zdGF0ZShzdGF0ZSwgY3J0YywgY3J0Y19zdGF0ZSwgaSkgewo+ID4gPiAgCQkJ LyoKPiA+ID4gIAkJCSAqIEZvcmNlIHJlY2FsY3VsYXRpb24gZXZlbiBpZiB3ZSByZXN0b3JlCj4g PiA+IC0tIAo+ID4gPiAyLjcuNAo+ID4gPiAKPiA+IAo+ID4gLS0gCj4gPiBNYXR0IFJvcGVyCj4g PiBHcmFwaGljcyBTb2Z0d2FyZSBFbmdpbmVlcgo+ID4gSW9URyBQbGF0Zm9ybSBFbmFibGluZyAm IERldmVsb3BtZW50Cj4gPiBJbnRlbCBDb3Jwb3JhdGlvbgo+ID4gKDkxNikgMzU2LTI3OTUKPiAK PiAtLSAKPiBWaWxsZSBTeXJqw6Rsw6QKPiBJbnRlbCBPVEMKCi0tIApNYXR0IFJvcGVyCkdyYXBo aWNzIFNvZnR3YXJlIEVuZ2luZWVyCklvVEcgUGxhdGZvcm0gRW5hYmxpbmcgJiBEZXZlbG9wbWVu dApJbnRlbCBDb3Jwb3JhdGlvbgooOTE2KSAzNTYtMjc5NQpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK