From: Daniel Vetter <daniel@ffwll.ch>
To: intel-gfx@lists.freedesktop.org, jani.nikula@intel.com,
Chris Wilson <chris@chris-wilson.co.uk>,
"Feceoru, Gabriel" <gabriel.feceoru@intel.com>
Subject: Re: [PATCH i-g-t v2] autotools/: Allow building tests/gem_concurrent_{all, blit}
Date: Tue, 17 May 2016 12:02:05 +0200 [thread overview]
Message-ID: <20160517100205.GU27098@phenom.ffwll.local> (raw)
In-Reply-To: <20160516150927.GA5133@mcvlad-wk.rb.intel.com>
On Mon, May 16, 2016 at 06:09:27PM +0300, Marius Vlad wrote:
> Trivial. Pushed.
>
> On Mon, May 16, 2016 at 01:36:48PM +0300, Marius Vlad wrote:
> > Introduced by a633ad03c6 (tests: Separate tests with lots of subtests).
> >
> > v2: Fix commit typo (Jani Nikula).
> >
> > Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
Also review from my side on the offending original commit was ignored -
imo gem_concurrent_all should just be put into EXTRA, and
gem_concurrent_blit should be kept in the normal igt set of testcases.
Dropping gem_concurrent_blit from the list of tests means we have a
massive gap in coverage. If that one still has too many subtests we need
to filter them harder, but that's a different problem.
Also pls run $ make distcheck before pushing stuf ...
-Daniel
> > ---
> > tests/Makefile.am | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/Makefile.am b/tests/Makefile.am
> > index 32b9115..c2c2025 100644
> > --- a/tests/Makefile.am
> > +++ b/tests/Makefile.am
> > @@ -30,6 +30,7 @@ pkglibexec_PROGRAMS = \
> > gem_stress \
> > $(TESTS_progs) \
> > $(TESTS_progs_M) \
> > + $(TESTS_progs_XM) \
> > $(NULL)
> >
> > dist_pkglibexec_SCRIPTS = \
> > --
> > 2.8.0.rc3
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-05-17 10:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 15:16 [PATCH igt] Revert "tests: Separate tests with lots of subtests" Chris Wilson
2016-05-14 12:12 ` [PATCH i-g-t] autotools/: Allow building tests/gem_concurrent_{all, blit} Marius Vlad
2016-05-16 7:50 ` Jani Nikula
2016-05-16 10:36 ` [PATCH i-g-t v2] " Marius Vlad
2016-05-16 15:09 ` Marius Vlad
2016-05-17 10:02 ` Daniel Vetter [this message]
2016-05-17 12:24 ` Gabriel Feceoru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160517100205.GU27098@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=gabriel.feceoru@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox