From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 07/21] drm/i915: Allow enable/disable of DPLL0 around cdclk changes on SKL Date: Thu, 19 May 2016 16:18:26 +0300 Message-ID: <20160519131826.GJ4329@intel.com> References: <1463172100-24715-1-git-send-email-ville.syrjala@linux.intel.com> <1463172100-24715-8-git-send-email-ville.syrjala@linux.intel.com> <1463663080.12342.24.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id D543D6E995 for ; Thu, 19 May 2016 13:20:01 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1463663080.12342.24.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBNYXkgMTksIDIwMTYgYXQgMDQ6MDQ6NDBQTSArMDMwMCwgSW1yZSBEZWFrIHdyb3Rl Ogo+IE9uIHBlLCAyMDE2LTA1LTEzIGF0IDIzOjQxICswMzAwLCB2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbSB3cm90ZToKPiA+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFs YUBsaW51eC5pbnRlbC5jb20+Cj4gPiAKPiA+IEluIGNhc2Ugd2Ugb3JpZ2luYWxseSBndWVzc2Vk IHdyb25nIHdoaWNoIGxjcGxsIHZjbyBmcmVxdWVuY3kgdG8gdXNlLAo+ID4gd2Ugd2lsbCBuZWVk IHRvIHNodXQgZG93biB0aGUgcGxsIGFuZCByZXN0YXJ0IGl0IHdoZW4gcmVwcm9nYW1taW5nIHRo ZQo+ID4gY2RjbGsuCj4gPiAKPiA+IFRoaXMgYWxzbyBhbGxvd3MgdXMgdG8gdHJhY2sgdGhlIGFj dHVhbCB2Y28gZnJlcXVlbmN5IGluIGRldl9wcml2Cj4gPiBpbnN0ZWFkIG9mIGp1c3QgYSBndWVz cy4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxh QGxpbnV4LmludGVsLmNvbT4KPiA+IC0tLQo+ID4gwqBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kaXNwbGF5LmMgfCA1NCArKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0KPiA+ IMKgMSBmaWxlIGNoYW5nZWQsIDI5IGluc2VydGlvbnMoKyksIDI1IGRlbGV0aW9ucygtKQo+ID4g Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBpbmRleCA5NTk5N2VlZDlk ZDYuLmNkMjgwOTE3OTA0MiAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh eS5jCj4gPiBAQCAtNTYyNiw2ICs1NjI2LDggQEAgc2tsX2RwbGwwX2VuYWJsZShzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGludCB2Y28pCj4gPiDCoAo+ID4gwqAJaWYgKHdhaXRf Zm9yKEk5MTVfUkVBRChMQ1BMTDFfQ1RMKSAmIExDUExMX1BMTF9MT0NLLCA1KSkKPiA+IMKgCQlE Uk1fRVJST1IoIkRQTEwwIG5vdCBsb2NrZWRcbiIpOwo+ID4gKwo+ID4gKwlkZXZfcHJpdi0+c2ts X3Zjb19mcmVxID0gdmNvOwo+ID4gwqB9Cj4gPiDCoAo+ID4gwqBzdGF0aWMgdm9pZAo+ID4gQEAg LTU2MzQsNiArNTYzNiw4IEBAIHNrbF9kcGxsMF9kaXNhYmxlKHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdikKPiA+IMKgCUk5MTVfV1JJVEUoTENQTEwxX0NUTCwgSTkxNV9SRUFEKExD UExMMV9DVEwpICYgfkxDUExMX1BMTF9FTkFCTEUpOwo+ID4gwqAJaWYgKHdhaXRfZm9yKCEoSTkx NV9SRUFEKExDUExMMV9DVEwpICYgTENQTExfUExMX0xPQ0spLCAxKSkKPiA+IMKgCQlEUk1fRVJS T1IoIkNvdWxkbid0IGRpc2FibGUgRFBMTDBcbiIpOwo+ID4gKwo+ID4gKwlkZXZfcHJpdi0+c2ts X3Zjb19mcmVxID0gMDsKPiA+IMKgfQo+ID4gwqAKPiA+IMKgc3RhdGljIGJvb2wgc2tsX2NkY2xr X3BjdV9yZWFkeShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiBAQCAtNTY2 MywxMiArNTY2NywxNCBAQCBzdGF0aWMgYm9vbCBza2xfY2RjbGtfd2FpdF9mb3JfcGN1X3JlYWR5 KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+IMKgCXJldHVybiBmYWxzZTsK PiA+IMKgfQo+ID4gwqAKPiA+IC1zdGF0aWMgdm9pZCBza2xfc2V0X2NkY2xrKHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdiwgaW50IGNkY2xrKQo+ID4gK3N0YXRpYyB2b2lkIHNrbF9z ZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCBpbnQgY2RjbGssIGlu dCB2Y28pCj4gPiDCoHsKPiA+IMKgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBkZXZfcHJpdi0+ ZGV2Owo+ID4gwqAJdTMyIGZyZXFfc2VsZWN0LCBwY3VfYWNrOwo+ID4gwqAKPiA+IC0JRFJNX0RF QlVHX0RSSVZFUigiQ2hhbmdpbmcgQ0RDTEsgdG8gJWRLSHpcbiIsIGNkY2xrKTsKPiA+ICsJV0FS Tl9PTigoY2RjbGsgPT0gMjQwMDApICE9ICh2Y28gPT0gMCkpOwo+ID4gKwo+ID4gKwlEUk1fREVC VUdfRFJJVkVSKCJDaGFuZ2luZyBDRENMSyB0byAlZCBrSHogKFZDTyAlZCBNSHopXG4iLCBjZGNs aywgdmNvKTsKPiA+IMKgCj4gPiDCoAlpZiAoIXNrbF9jZGNsa193YWl0X2Zvcl9wY3VfcmVhZHko ZGV2X3ByaXYpKSB7Cj4gPiDCoAkJRFJNX0VSUk9SKCJmYWlsZWQgdG8gaW5mb3JtIFBDVSBhYm91 dCBjZGNsayBjaGFuZ2VcbiIpOwo+ID4gQEAgLTU2OTksNiArNTcwNSwxMyBAQCBzdGF0aWMgdm9p ZCBza2xfc2V0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgaW50IGNk Y2xrKQo+ID4gwqAJCWJyZWFrOwo+ID4gwqAJfQo+ID4gwqAKPiA+ICsJaWYgKGRldl9wcml2LT5z a2xfdmNvX2ZyZXEgIT0gMCAmJgo+ID4gKwnCoMKgwqDCoGRldl9wcml2LT5za2xfdmNvX2ZyZXEg IT0gdmNvKQo+ID4gKwkJc2tsX2RwbGwwX2Rpc2FibGUoZGV2X3ByaXYpOwo+ID4gKwo+ID4gKwlp ZiAoZGV2X3ByaXYtPnNrbF92Y29fZnJlcSAhPSB2Y28pCj4gPiArCQlza2xfZHBsbDBfZW5hYmxl KGRldl9wcml2LCB2Y28pOwo+ID4gKwo+ID4gwqAJSTkxNV9XUklURShDRENMS19DVEwsIGZyZXFf c2VsZWN0IHwgc2tsX2NkY2xrX2RlY2ltYWwoY2RjbGspKTsKPiA+IMKgCVBPU1RJTkdfUkVBRChD RENMS19DVEwpOwo+ID4gwqAKPiA+IEBAIC01NzIxLDI2ICs1NzM0LDIxIEBAIHZvaWQgc2tsX3Vu aW5pdF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiDCoAlpZiAo STkxNV9SRUFEKERCVUZfQ1RMKSAmIERCVUZfUE9XRVJfU1RBVEUpCj4gPiDCoAkJRFJNX0VSUk9S KCJEQnVmIHBvd2VyIGRpc2FibGUgdGltZW91dFxuIik7Cj4gPiDCoAo+ID4gLQlza2xfZHBsbDBf ZGlzYWJsZShkZXZfcHJpdik7Cj4gPiArCXNrbF9zZXRfY2RjbGsoZGV2X3ByaXYsIDI0MDAwLCAw KTsKPiAKPiBUaGUgc3BlYyBkb2Vzbid0IHNheSBob3cgdG8gcHJvZ3JhbSBDRENMSyBmb3IgdGhl IGJ5cGFzcyBjYXNlIGFuZCB3ZSdsbAo+IHByb2dyYW0gdGhlICdmcmVxdWVuY3kgZGVjaW1hbCcg ZmllbGQgdG8gc29tZXRoaW5nIGlzbid0IGxpc3RlZCBhcyBhCj4gdmFsaWQgdmFsdWUgKGFuZCBu b3QgbWF0Y2hpbmcgdGhlIENEIGZyZXF1ZW5jeSBzZWxlY3QgdmFsdWUpLiBCdXQgSQo+IHRoaW5r IENEQ0xLIGlzIGRvbid0LWNhcmUgaW4gdGhhdCBjYXNlLCBzbyBpdCdzIGZpbmUuCj4gCj4gPiDC oH0KPiA+IMKgCj4gPiDCoHZvaWQgc2tsX2luaXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2KQo+ID4gwqB7Cj4gPiAtCXVuc2lnbmVkIGludCBjZGNsazsKPiA+IC0KPiA+ IMKgCS8qIERQTEwwIG5vdCBlbmFibGVkIChoYXBwZW5zIG9uIGVhcmx5IEJJT1MgdmVyc2lvbnMp ICovCj4gPiAtCWlmICghKEk5MTVfUkVBRChMQ1BMTDFfQ1RMKSAmIExDUExMX1BMTF9FTkFCTEUp KSB7Cj4gPiAtCQkvKiBlbmFibGUgRFBMTDAgKi8KPiA+IC0JCWlmIChkZXZfcHJpdi0+c2tsX3Zj b19mcmVxICE9IDg2NDApCj4gPiAtCQkJZGV2X3ByaXYtPnNrbF92Y29fZnJlcSA9IDgxMDA7Cj4g PiAtCQlza2xfZHBsbDBfZW5hYmxlKGRldl9wcml2LCBkZXZfcHJpdi0+c2tsX3Zjb19mcmVxKTsK PiA+IC0JCWNkY2xrID0gc2tsX2NhbGNfY2RjbGsoMCwgZGV2X3ByaXYtPnNrbF92Y29fZnJlcSk7 Cj4gPiAtCX0gZWxzZSB7Cj4gPiAtCQljZGNsayA9IGRldl9wcml2LT5jZGNsa19mcmVxOwo+ID4g LQl9Cj4gPiArCWlmIChkZXZfcHJpdi0+c2tsX3Zjb19mcmVxID09IDApIHsKPiA+ICsJCWludCBj ZGNsaywgdmNvOwo+ID4gwqAKPiA+IC0JLyogc2V0IENEQ0xLIHRvIHRoZSBsb3dlc3QgZnJlcXVl bmN5LCBNb2Rlc2V0IGZvbGxvd3MgKi8KPiA+IC0Jc2tsX3NldF9jZGNsayhkZXZfcHJpdiwgY2Rj bGspOwo+ID4gKwkJLyogc2V0IENEQ0xLIHRvIHRoZSBsb3dlc3QgZnJlcXVlbmN5LCBNb2Rlc2V0 IGZvbGxvd3MgKi8KPiA+ICsJCXZjbyA9IDgxMDA7Cj4gPiArCQljZGNsayA9IHNrbF9jYWxjX2Nk Y2xrKDAsIHZjbyk7Cj4gPiArCj4gPiArCQlza2xfc2V0X2NkY2xrKGRldl9wcml2LCBjZGNsaywg dmNvKTsKPiA+ICsJfQo+ID4gwqAKPiA+IMKgCS8qIGVuYWJsZSBEQlVGIHBvd2VyICovCj4gPiDC oAlJOTE1X1dSSVRFKERCVUZfQ1RMLCBJOTE1X1JFQUQoREJVRl9DVEwpIHwgREJVRl9QT1dFUl9S RVFVRVNUKTsKPiA+IEBAIC05Nzc3LDE2ICs5Nzg1LDEyIEBAIHN0YXRpYyBpbnQgc2tsX21vZGVz ZXRfY2FsY19jZGNsayhzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4gPiDCoAo+ID4g wqBzdGF0aWMgdm9pZCBza2xfbW9kZXNldF9jb21taXRfY2RjbGsoc3RydWN0IGRybV9hdG9taWNf c3RhdGUgKm9sZF9zdGF0ZSkKPiAKPiBXaHkgaXMgdGhlIGFib3ZlIGNhbGxlZCBvbGRfc3RhdGU/ CgpCZWNhdXNlIGF0b21pYyBpcyBzdHVwaWQuIFRoZXJlJ3MganVzdCBvbmUgdG9wIGxldmVsIHN0 YXRlIHdoaWNoIHN0YXJ0cwpvdXQgYXMgdGhlIG5ldyBzdGF0ZSwgYnV0IGxhdGVyIHdlIHN3YXAg dGhlIGNvbm5lY3Rvci9jcnRjL3BsYW5lIHN0YXRlCnBvaW50ZXJzIGFyb3VuZCBzbyB0aGF0IHRo ZSB0b3AgbGV2ZWwgc3RhdGUgcG9pbnRzIHRvIHRoZSBvbGQgc3RhdGUKZm9yIHRob3NlIHRoaW5n cy4gVGhhdCdzIHdoeSBpdCdzIGNhbGxlZCBvbGRfc3RhdGUgaGVyZS4gRXZlcnl0aGluZwplbHNl IHN0b3JlZCBpbiB0aGF0IHRvcCBsZXZlbCBzdGF0ZSBpcyBub3Qgc3dhcHBlZCB0aG91Z2ggc28g aXQncwphY3R1YWxseSBhbiBleHRyZW1lbHkgY29uZnVzaW5nIG1peCBvZiBvbGQgYW5kIG5ldyBz dGF0ZS4KCkkgdGhpbmsgd2hhdCB3ZSBzaG91bGQgZG8gaXMgcHVsbCBhbGwgdGhlIHN0YXRlIHN0 b3JlZCBpbiB0aGUgdG9wIGxldmVsCmF0b21pYyBzdGF0ZSBzdHJ1Y3R1cmUgaW50byBhIHNlcGFy YXRlIHN0cnVjdHVyZSBhbmQgc3RvcmUgYSBwb2ludGVyIHRvCnRoYXQgaW4gdGhlIHRvcCBsZXZl bCBhdG9taWMgc3RhdGUganVzdCBsaWtlIGZvciBldmVyeXRoaW5nIGVsc2UuIFdlCmNhbiB0aGVu IHN3YXAgdGhhdCBwb2ludGVyIGFzIHdlbGwuIFRoYXQgd2F5IGFsbCB0aGUgb2xkIHZzLiBuZXcg c3R1ZmYKd291bGQgYmUgY29uc2lzdGVudC4gSXQgbWlndGggYWxzbyBjbGVhbiB1cCB0aGUgaG9y cmlibGUgbWVzcyB3aXRoIHRoZQphdG9taWNfY2RjbGsgc3R1ZmYgYW5kIHdoYXRub3QuCgo+IAo+ IFRoZSBwYXRjaCBsb29rcyBvazoKPiBSZXZpZXdlZC1ieTogSW1yZSBEZWFrIDxpbXJlLmRlYWtA aW50ZWwuY29tPgo+IAo+ID4gwqB7Cj4gPiAtCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBvbGRf c3RhdGUtPmRldjsKPiA+IC0Jc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2 LT5kZXZfcHJpdmF0ZTsKPiA+IC0JdW5zaWduZWQgaW50IHJlcV9jZGNsayA9IHRvX2ludGVsX2F0 b21pY19zdGF0ZShvbGRfc3RhdGUpLT5kZXZfY2RjbGs7Cj4gPiAtCj4gPiAtCS8qCj4gPiAtCcKg KiBGSVhNRSBkaXNhYmxlL2VuYWJsZSBQTEwgc2hvdWxkIHdyYXAgc2V0X2NkY2xrKCkKPiA+IC0J wqAqLwo+ID4gLQlza2xfc2V0X2NkY2xrKGRldl9wcml2LCByZXFfY2RjbGspOwo+ID4gKwlzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KG9sZF9zdGF0ZS0+ZGV2KTsK PiA+ICsJc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqaW50ZWxfc3RhdGUgPSB0b19pbnRlbF9h dG9taWNfc3RhdGUob2xkX3N0YXRlKTsKPiA+ICsJdW5zaWduZWQgaW50IHJlcV9jZGNsayA9IGlu dGVsX3N0YXRlLT5kZXZfY2RjbGs7Cj4gPiArCXVuc2lnbmVkIGludCByZXFfdmNvID0gaW50ZWxf c3RhdGUtPmNkY2xrX3BsbF92Y287Cj4gPiDCoAo+ID4gLQlkZXZfcHJpdi0+c2tsX3Zjb19mcmVx ID0gdG9faW50ZWxfYXRvbWljX3N0YXRlKG9sZF9zdGF0ZSktPmNkY2xrX3BsbF92Y287Cj4gPiAr CXNrbF9zZXRfY2RjbGsoZGV2X3ByaXYsIHJlcV9jZGNsaywgcmVxX3Zjbyk7Cj4gPiDCoH0KPiA+ IMKgCj4gPiDCoHN0YXRpYyBpbnQgaGFzd2VsbF9jcnRjX2NvbXB1dGVfY2xvY2soc3RydWN0IGlu dGVsX2NydGMgKmNydGMsCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK