From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Fix NULL pointer deference when out of PLLs in IVB Date: Fri, 20 May 2016 20:13:35 +0300 Message-ID: <20160520171335.GO4329@intel.com> References: <1463748426-5956-1-git-send-email-ander.conselvan.de.oliveira@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 617926EB07 for ; Fri, 20 May 2016 17:13:53 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1463748426-5956-1-git-send-email-ander.conselvan.de.oliveira@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ander Conselvan de Oliveira Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBNYXkgMjAsIDIwMTYgYXQgMDM6NDc6MDZQTSArMDMwMCwgQW5kZXIgQ29uc2VsdmFu IGRlIE9saXZlaXJhIHdyb3RlOgo+IEluIGNvbW1pdCBmOTQ3NmE2YzZkMGMgKCJkcm0vaTkxNTog UmVmYWN0b3IgcGxhdGZvcm0gc3BlY2lmaWNzIG91dCBvZgo+IGludGVsX2dldF9zaGFyZWRfZHBs bCgpIiksIHRoZSBpYnhfZ2V0X2RwbGwoKSBmdW5jdGlvbiBsYWNrZWQgYW4gZXJyb3IKPiBjaGVj aywgdGhhdCBjYW4gbGVhZCB0byBhIE5VTEwgcG9pbnRlciBkZXJlZmVyZW5jZSB3aGVuIHRyeWlu ZyB0byBlbmFibGUKPiBwaXBlIEMuCgpzL3BpcGUgQy90aHJlZSBwaXBlcy8KCj4gCj4gQlVHOiB1 bmFibGUgdG8gaGFuZGxlIGtlcm5lbCBOVUxMIHBvaW50ZXIgZGVyZWZlcmVuY2UgYXQgMDAwMDAw MDAwMDAwMDA2OAo+IElQOiBbPGZmZmZmZmZmYTA0ODIyNzU+XSBpbnRlbF9yZWZlcmVuY2Vfc2hh cmVkX2RwbGwrMHgxNS8weDEwMCBbaTkxNV0KPiBQR0QgY2VjODcwNjcgUFVEIGQzMGNlMDY3IFBN RCAwCj4gT29wczogMDAwMCBbIzFdIFBSRUVNUFQgU01QCj4gTW9kdWxlcyBsaW5rZWQgaW46IHNu ZF9oZGFfaW50ZWwgaTkxNSBkcm1fa21zX2hlbHBlciBkcm0gaW50ZWxfZ3R0IHNjaF9mcV9jb2Rl bCBjZmc4MDIxMSBiaW5mbXRfbWlzYyBpMmNfYWxnb19iaXQgY2ZiZmlsbHJlY3Qgc3lzY29weWFy ZWEgY2ZiaW1nYmx0IHN5c2ZpbGxyZWN0IHN5c2ltZ2JsdCBmYl9zeXNfZm9wcyBjZmJjb3B5YXJl YSBpbnRlbF9yYXBsIGlvc2ZfbWJpIHg4Nl9wa2dfdGVtcF90aGVybWFsIGNvcmV0ZW1wIGFncGdh cnQga3ZtX2ludGVsIHNuZF9oZGFfY29kZWNfaGRtaSBrdm0gaVRDT193ZHQgc25kX2hkYV9jb2Rl Y19yZWFsdGVrIHNuZF9oZGFfY29kZWNfZ2VuZXJpYyBpcnFieXBhc3MgYWVzbmlfaW50ZWwgYWVz X3g4Nl82NCBnbHVlX2hlbHBlciBscncgZ2YxMjhtdWwgYWJsa19oZWxwZXIgY3J5cHRkIHBzbW91 c2UgcGNzcGtyIHNuZF9oZGFfY29kZWMgaTJjX2k4MDEgc25kX2h3ZGVwIHNuZF9oZGFfY29yZSBz bmRfcGNtIHNuZF90aW1lciBscGNfaWNoIG1mZF9jb3JlIHNuZCBzb3VuZGNvcmUgd21pIGV2ZGV2 IHRwbV90aXMgdHBtIFtsYXN0IHVubG9hZGVkOiBkcm1dCj4gQ1BVOiAzIFBJRDogNTgxMCBDb21t OiBrbXNfZmxpcCBUYWludGVkOiBHICAgICBVICBXICAgICAgIDQuNi4wLXRlc3QrICMzCj4gSGFy ZHdhcmUgbmFtZTogICAgICAgICAgICAgICAgICAvRFo3N0JILTU1SywgQklPUyBCSFo3NzEwSC44 NkEuMDEwMC4yMDEzLjA1MTcuMDk0MiAwNS8xNy8yMDEzCj4gdGFzazogZmZmZjg4MDBkMzkwODA0 MCB0aTogZmZmZjg4MDExNjZjODAwMCB0YXNrLnRpOiBmZmZmODgwMTE2NmM4MDAwCj4gUklQOiAw MDEwOls8ZmZmZmZmZmZhMDQ4MjI3NT5dICBbPGZmZmZmZmZmYTA0ODIyNzU+XSBpbnRlbF9yZWZl cmVuY2Vfc2hhcmVkX2RwbGwrMHgxNS8weDEwMCBbaTkxNV0KPiBSU1A6IDAwMTg6ZmZmZjg4MDEx NjZjYmE2MCAgRUZMQUdTOiAwMDAxMDI0Ngo+IFJBWDogMDAwMDAwMDAwMDAwMDAwMCBSQlg6IDAw MDAwMDAwMDAwMDAwMDAgUkNYOiAwMDAwMDAwMDAwMDAwMDAyCj4gUkRYOiAwMDAwMDAwMDAwMDAw MDAxIFJTSTogZmZmZjg4MDBkMDdmMWJmOCBSREk6IDAwMDAwMDAwMDAwMDAwMDAKPiBSQlA6IGZm ZmY4ODAxMTY2Y2JhODggUjA4OiAwMDAwMDAwMDAwMDAwMDAyIFIwOTogZmZmZjg4MDBkMzJlNTY5 OAo+IFIxMDogMDAwMDAwMDAwMDAwMDAwMSBSMTE6IGZmZmY4ODAwY2M4OWFjODggUjEyOiBmZmZm ODgwMGQwN2YxYmY4Cj4gUjEzOiAwMDAwMDAwMDAwMDAwMDAwIFIxNDogMDAwMDAwMDAwMDAwMDAw MCBSMTU6IDAwMDAwMDAwMDAwMDAwMDAKPiBGUzogIDAwMDA3ZjRjM2ZjOGQ4YzAoMDAwMCkgR1M6 ZmZmZjg4MDExYmNjMDAwMCgwMDAwKSBrbmxHUzowMDAwMDAwMDAwMDAwMDAwCj4gQ1M6ICAwMDEw IERTOiAwMDAwIEVTOiAwMDAwIENSMDogMDAwMDAwMDA4MDA1MDAzMwo+IENSMjogMDAwMDAwMDAw MDAwMDA2OCBDUjM6IDAwMDAwMDAwZDNiNGMwMDAgQ1I0OiAwMDAwMDAwMDAwMTQwNmUwCj4gU3Rh Y2s6Cj4gIDAwMDAwMDAwMDAwMDAwMDAgZmZmZjg4MDBkMDdmMWJmOCAwMDAwMDAwMDAwMDAwMDAw IGZmZmY4ODAwZDA0YzAwMDAKPiAgMDAwMDAwMDAwMDAwMDAwMCBmZmZmODgwMTE2NmNiYWE4IGZm ZmZmZmZmYTA0ODIzYTcgZmZmZjg4MDBkMDdmMWJmOAo+ICBmZmZmODgwMGQzMmU1Njk4IGZmZmY4 ODAxMTY2Y2JhYjggZmZmZmZmZmZhMDQ4NDBjZiBmZmZmODgwMTE2NmNiYWYwCj4gQ2FsbCBUcmFj ZToKPiAgWzxmZmZmZmZmZmEwNDgyM2E3Pl0gaWJ4X2dldF9kcGxsKzB4NDcvMHhhMCBbaTkxNV0K PiAgWzxmZmZmZmZmZmEwNDg0MGNmPl0gaW50ZWxfZ2V0X3NoYXJlZF9kcGxsKzB4MWYvMHg1MCBb aTkxNV0KPiAgWzxmZmZmZmZmZmEwNDZkMDgwPl0gaXJvbmxha2VfY3J0Y19jb21wdXRlX2Nsb2Nr KzB4MjgwLzB4NDMwIFtpOTE1XQo+ICBbPGZmZmZmZmZmYTA0NzJhYzA+XSBpbnRlbF9jcnRjX2F0 b21pY19jaGVjaysweDI0MC8weDMyMCBbaTkxNV0KPiAgWzxmZmZmZmZmZmEwM2RhMThlPl0gZHJt X2F0b21pY19oZWxwZXJfY2hlY2tfcGxhbmVzKzB4MTRlLzB4MWQwIFtkcm1fa21zX2hlbHBlcl0K PiAgWzxmZmZmZmZmZmEwNDc0YTBjPl0gaW50ZWxfYXRvbWljX2NoZWNrKzB4NWRjLzB4MTExMCBb aTkxNV0KPiAgWzxmZmZmZmZmZmEwMjlkM2FhPl0gZHJtX2F0b21pY19jaGVja19vbmx5KzB4MTRh LzB4NjYwIFtkcm1dCj4gIFs8ZmZmZmZmZmZhMDI5ZDA4Nj5dID8gZHJtX2F0b21pY19zZXRfY3J0 Y19mb3JfY29ubmVjdG9yKzB4OTYvMHgxMDAgW2RybV0KPiAgWzxmZmZmZmZmZmEwMjlkOGQ3Pl0g ZHJtX2F0b21pY19jb21taXQrMHgxNy8weDYwIFtkcm1dCj4gIFs8ZmZmZmZmZmZhMDNkYzNiNz5d IHJlc3RvcmVfZmJkZXZfbW9kZSsweDIzNy8weDI2MCBbZHJtX2ttc19oZWxwZXJdCj4gIFs8ZmZm ZmZmZmZhMDI5YzY1YT5dID8gZHJtX21vZGVzZXRfbG9ja19hbGxfY3R4KzB4OWEvMHhiMCBbZHJt XQo+ICBbPGZmZmZmZmZmYTAzZGU5YjM+XSBkcm1fZmJfaGVscGVyX3Jlc3RvcmVfZmJkZXZfbW9k ZV91bmxvY2tlZCsweDMzLzB4ODAgW2RybV9rbXNfaGVscGVyXQo+ICBbPGZmZmZmZmZmYTAzZGVh MmQ+XSBkcm1fZmJfaGVscGVyX3NldF9wYXIrMHgyZC8weDUwIFtkcm1fa21zX2hlbHBlcl0KPiAg WzxmZmZmZmZmZmEwM2RlOTNhPl0gZHJtX2ZiX2hlbHBlcl9ob3RwbHVnX2V2ZW50KzB4YWEvMHhm MCBbZHJtX2ttc19oZWxwZXJdCj4gIFs8ZmZmZmZmZmZhMDNkZTlkNj5dIGRybV9mYl9oZWxwZXJf cmVzdG9yZV9mYmRldl9tb2RlX3VubG9ja2VkKzB4NTYvMHg4MCBbZHJtX2ttc19oZWxwZXJdCj4g IFs8ZmZmZmZmZmZhMDQ5MGY3Mj5dIGludGVsX2ZiZGV2X3Jlc3RvcmVfbW9kZSsweDIyLzB4ODAg W2k5MTVdCj4gIFs8ZmZmZmZmZmZhMDRiYTQ1ZT5dIGk5MTVfZHJpdmVyX2xhc3RjbG9zZSsweGUv MHgyMCBbaTkxNV0KPiAgWzxmZmZmZmZmZmEwMjgxMGRlPl0gZHJtX2xhc3RjbG9zZSsweDJlLzB4 MTMwIFtkcm1dCj4gIFs8ZmZmZmZmZmZhMDI4MTQ4Yz5dIGRybV9yZWxlYXNlKzB4MmFjLzB4NGIw IFtkcm1dCj4gIFs8ZmZmZmZmZmY4MTFhNmIyZD5dIF9fZnB1dCsweGVkLzB4MWYwCj4gIFs8ZmZm ZmZmZmY4MTFhNmM2ZT5dIF9fX19mcHV0KzB4ZS8weDEwCj4gIFs8ZmZmZmZmZmY4MTA3OTE1Nj5d IHRhc2tfd29ya19ydW4rMHg3Ni8weGIwCj4gIFs8ZmZmZmZmZmY4MTA1YWFhYj5dIGRvX2V4aXQr MHgzYWIvMHhjNjAKPiAgWzxmZmZmZmZmZjgxMGExNDVmPl0gPyB0cmFjZV9oYXJkaXJxc19vbl9j YWxsZXIrMHgxMmYvMHgxYzAKPiAgWzxmZmZmZmZmZjgxMDVjNjdlPl0gZG9fZ3JvdXBfZXhpdCsw eDRlLzB4YzAKPiAgWzxmZmZmZmZmZjgxMDVjNzA0Pl0gU3lTX2V4aXRfZ3JvdXArMHgxNC8weDIw Cj4gIFs8ZmZmZmZmZmY4MTU4YmIyNT5dIGVudHJ5X1NZU0NBTExfNjRfZmFzdHBhdGgrMHgxOC8w eGE4Cj4gQ29kZTogMTQgODAgNDggOGQgMzQgOTAgYjggMDEgMDAgMDAgMDAgZDMgZTAgMDkgMDQg YjMgNWIgNDEgNWMgNWQgYzMgOTAgMGYgMWYgNDQgMDAgMDAgNTUgNDggODkgZTUgNDEgNTcgNDEg NTYgNDkgODkgZmUgNDEgNTUgNDEgNTQgNTMgPDQ0PiA4YiA2NyA2OCA0OCA4OSBmMyA0OCA4YiBi ZSAwOCAwMiAwMCAwMCA0YyA4YiAyZSBlOCAxNSA5ZCBmZAo+IFJJUCAgWzxmZmZmZmZmZmEwNDgy Mjc1Pl0gaW50ZWxfcmVmZXJlbmNlX3NoYXJlZF9kcGxsKzB4MTUvMHgxMDAgW2k5MTVdCj4gIFJT UCA8ZmZmZjg4MDExNjZjYmE2MD4KPiBDUjI6IDAwMDAwMDAwMDAwMDAwNjgKPiAKPiBDYzogVmls bGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiBSZXBvcnRlZC1i eTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiBGaXhl czogZjk0NzZhNmM2ZDBjICgiZHJtL2k5MTU6IFJlZmFjdG9yIHBsYXRmb3JtIHNwZWNpZmljcyBv dXQgb2YgaW50ZWxfZ2V0X3NoYXJlZF9kcGxsKCkiKQo+IFNpZ25lZC1vZmYtYnk6IEFuZGVyIENv bnNlbHZhbiBkZSBPbGl2ZWlyYSA8YW5kZXIuY29uc2VsdmFuLmRlLm9saXZlaXJhQGludGVsLmNv bT4KClJldmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50 ZWwuY29tPgpUZXN0ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5p bnRlbC5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5j IHwgMyArKysKPiAgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYwo+IGluZGV4IGY5ODhhZGIuLjFlM2QwOTEgMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMKPiBAQCAtMzY2LDYgKzM2Niw5IEBA IGlieF9nZXRfZHBsbChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0Yywgc3RydWN0IGludGVsX2NydGNf c3RhdGUgKmNydGNfc3RhdGUsCj4gIAkJCQkJICAgICBEUExMX0lEX1BDSF9QTExfQik7Cj4gIAl9 Cj4gIAo+ICsJaWYgKCFwbGwpCj4gKwkJcmV0dXJuIE5VTEw7Cj4gKwo+ICAJLyogcmVmZXJlbmNl IHRoZSBwbGwgKi8KPiAgCWludGVsX3JlZmVyZW5jZV9zaGFyZWRfZHBsbChwbGwsIGNydGNfc3Rh dGUpOwo+ICAKPiAtLSAKPiAyLjUuNQoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==