Re: [PATCH v2] drm/i915: Enable GSE interrupt on BDW+

From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, Mark Kettenis <mark.kettenis@xs4all.nl>
Subject: Re: [PATCH v2] drm/i915: Enable GSE interrupt on BDW+
Date: Mon, 23 May 2016 18:38:34 +0300	[thread overview]
Message-ID: <20160523153834.GR4329@intel.com> (raw)
In-Reply-To: <87shx8deb7.fsf@intel.com>

On Mon, May 23, 2016 at 05:44:28PM +0300, Jani Nikula wrote:
> On Mon, 23 May 2016, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
> >> From: Jani Nikula <jani.nikula@linux.intel.com>
> >> Date: Mon, 23 May 2016 17:04:48 +0300
> >> 
> >> On Thu, 19 May 2016, ville.syrjala@linux.intel.com wrote:
> >> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >> >
> >> > We've never actually enabled or unmasked the GSE interrupt on BDW+,
> >> > even though the interrupt handler was always prepared for it.
> >> > Let's enable it and see what happens.
> >> >
> >> > Credit to Mark Kettenis who fixed this in the OpenBSD fork of the
> >> > driver. He reports that it fixed the "ACPI _BCM/_BCQ-based
> >> > brightness mechanism on a MacBookPro12,1 and a 3rd gen Lenovo X1
> >> > Carbon" for them.
> >> >
> >> > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> >> > References: http://lists.freedesktop.org/archives/intel-gfx/2015-December/081799.html
> >> > Reported-by: Mark Kettenis <mark.kettenis@xs4all.nl>
> >> > Cc: Mark Kettenis <mark.kettenis@xs4all.nl>
> >> > Cc: Jani Nikula <jani.nikula@linux.intel.com>
> >> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >> > ---
> >> > Nothing changed, just reposted for CI.
> >> 
> >> As I noted previously, I don't think we need this, but if you insist on
> >> having it, please add a note about it in the commit message. With that,
> >
> > FWIW, this *is* needed if you want ACPI-based backlight control to
> > work.  On Linux you probably don't notice, since "hardware" backlight
> > control is preferred over "firmware" or "platform" backlight control.
> >
> > It would help me if this did land in the Linux tree though, as it will
> > make future imports of the i915 driver into OpenBSD easier.
> 
> Ville, there's your copy-paste for the logs. ;)

Copy-pasted and pushed to dinq. Thanks everyone.

> 
> BR,
> Jani.
> 
> 
> >
> >> >  drivers/gpu/drm/i915/i915_irq.c | 2 ++
> >> >  1 file changed, 2 insertions(+)
> >> >
> >> > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> >> > index f0d941455bed..4c271ea267bb 100644
> >> > --- a/drivers/gpu/drm/i915/i915_irq.c
> >> > +++ b/drivers/gpu/drm/i915/i915_irq.c
> >> > @@ -3799,6 +3799,7 @@ static void gen8_de_irq_postinstall(struct drm_i915_private *dev_priv)
> >> >  	uint32_t de_pipe_enables;
> >> >  	u32 de_port_masked = GEN8_AUX_CHANNEL_A;
> >> >  	u32 de_port_enables;
> >> > +	u32 de_misc_masked = GEN8_DE_MISC_GSE;
> >> >  	enum pipe pipe;
> >> >  
> >> >  	if (INTEL_INFO(dev_priv)->gen >= 9) {
> >> > @@ -3834,6 +3835,7 @@ static void gen8_de_irq_postinstall(struct drm_i915_private *dev_priv)
> >> >  					  de_pipe_enables);
> >> >  
> >> >  	GEN5_IRQ_INIT(GEN8_DE_PORT_, ~de_port_masked, de_port_enables);
> >> > +	GEN5_IRQ_INIT(GEN8_DE_MISC_, ~de_misc_masked, de_misc_masked);
> >> >  }
> >> >  
> >> >  static int gen8_irq_postinstall(struct drm_device *dev)
> >> 
> >> -- 
> >> Jani Nikula, Intel Open Source Technology Center
> >> 
> >> 
> 
> -- 
> Jani Nikula, Intel Open Source Technology Center

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx