From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 2/2] drm/i915/bxt: Sanitize CDCLK to fix breakage during S4 resume Date: Tue, 24 May 2016 17:45:59 +0300 Message-ID: <20160524144559.GH4329@intel.com> References: <1464093513-16258-1-git-send-email-imre.deak@intel.com> <1464093513-16258-2-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTP id 3F5B16E7E2 for ; Tue, 24 May 2016 14:46:02 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1464093513-16258-2-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBNYXkgMjQsIDIwMTYgYXQgMDM6Mzg6MzNQTSArMDMwMCwgSW1yZSBEZWFrIHdyb3Rl Ogo+IEkgbm90aWNlZCB0aGF0IGR1cmluZyBTNCByZXN1bWUgQklPUyBpbmNvcnJlY3RseSBzZXRz IGJpdHMgMTgsIDE5IHdoaWNoCj4gYXJlIHJlc2VydmVkL01CWiBhbmQgc2V0cyB0aGUgZGVjaW1h bCBmcmVxdWVuY3kgZmllbGRzIHRvIGFsbCAweGZmIGluCj4gdGhlIENEQ0xLIHJlZ2lzdGVyLiBU aGUgcmVzdWx0IGlzIGEgaGFyZCBsb2NrdXAgYXMgZGlzcGxheSByZWdpc3Rlcgo+IGFjY2Vzc2Vz IGFyZSBhdHRlbXB0ZWQgbGF0ZXIuIFdvcmsgYXJvdW5kIHRoaXMgYnkgc2FuaXRpemluZyB0aGUg Q0RDTEsKPiBQTEwvZGl2aWRlcnMgdGhlIHNhbWUgd2F5IGl0J3MgZG9uZSBvbiBTS0wuCj4gCj4g V2hpbGUgdGhpcyBpcyBjbGVhcmx5IGEgQklPUyBidWcgd2hpY2ggc2hvdWxkIGJlIGZpeGVkIHNl cGFyYXRlbHksIGl0Cj4gZG9lc24ndCBodXJ0IHRvIGNoZWNrL3Nhbml0aXplIHRoaXMgcmVnYXJk bGVzcy4KPiAKPiB2MjoKPiAtIFVzZSB0aGUgc2FtZSBjb25kaXRpb24gZm9yIFZDTyBhbmQgQ0RD TEsgaW4gYnJveHRvbl9pbml0X2NkY2xrIGFzIGlzCj4gICB1c2VkIGluIHNrbF9pbml0X2NkY2xr IGZvciB0aGUgc2FtZSBwdXJwb3NlLgo+IAo+IENDOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5 cmphbGFAbGludXguaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEltcmUgRGVhayA8aW1yZS5k ZWFrQGludGVsLmNvbT4KClJldmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmph bGFAbGludXguaW50ZWwuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZGlzcGxheS5jIHwgNTEgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tCj4gIDEg ZmlsZSBjaGFuZ2VkLCA0OSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRleCA0N2IyNDY2Li4xOWY5NDdmIDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC01NDEyLDExICs1NDEyLDU4 IEBAIHN0YXRpYyB2b2lkIGJyb3h0b25fc2V0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiwgaW50IGNkY2xrKQo+ICAJaW50ZWxfdXBkYXRlX2NkY2xrKGRldl9wcml2LT5k ZXYpOwo+ICB9Cj4gIAo+ICtzdGF0aWMgdm9pZCBieHRfc2FuaXRpemVfY2RjbGsoc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICt7Cj4gKwl1MzIgY2RjdGwsIGV4cGVjdGVkOwo+ ICsKPiArCWludGVsX3VwZGF0ZV9jZGNsayhkZXZfcHJpdi0+ZGV2KTsKPiArCj4gKwlpZiAoZGV2 X3ByaXYtPmNkY2xrX3BsbC52Y28gPT0gMCB8fAo+ICsJICAgIGRldl9wcml2LT5jZGNsa19mcmVx ID09IGRldl9wcml2LT5jZGNsa19wbGwucmVmKQo+ICsJCWdvdG8gc2FuaXRpemU7Cj4gKwo+ICsJ LyogRFBMTCBva2F5OyB2ZXJpZnkgdGhlIGNkY2xvY2sKPiArCSAqCj4gKwkgKiBTb21lIEJJT1Mg dmVyc2lvbnMgbGVhdmUgYW4gaW5jb3JyZWN0IGRlY2ltYWwgZnJlcXVlbmN5IHZhbHVlIGFuZAo+ ICsJICogc2V0IHJlc2VydmVkIE1CWiBiaXRzIGluIENEQ0xLX0NUTCBhdCBsZWFzdCBkdXJpbmcg ZXhpdGluZyBmcm9tIFM0LAo+ICsJICogc28gc2FuaXRpemUgdGhpcyByZWdpc3Rlci4KPiArCSAq Lwo+ICsJY2RjdGwgPSBJOTE1X1JFQUQoQ0RDTEtfQ1RMKTsKPiArCS8qCj4gKwkgKiBMZXQncyBp Z25vcmUgdGhlIHBpcGUgZmllbGQsIHNpbmNlIEJJT1MgY291bGQgaGF2ZSBjb25maWd1cmVkIHRo ZQo+ICsJICogZGl2aWRlcnMgYm90aCBzeW5jaGluZyB0byBhbiBhY3RpdmUgcGlwZSwgb3IgYXN5 bmNocm9ub3VzbHkKPiArCSAqIChQSVBFX05PTkUpLgo+ICsJICovCj4gKwljZGN0bCAmPSB+QlhU X0NEQ0xLX0NEMlhfUElQRV9OT05FOwo+ICsKPiArCWV4cGVjdGVkID0gKGNkY3RsICYgQlhUX0NE Q0xLX0NEMlhfRElWX1NFTF9NQVNLKSB8Cj4gKwkJICAgc2tsX2NkY2xrX2RlY2ltYWwoZGV2X3By aXYtPmNkY2xrX2ZyZXEpOwo+ICsJLyoKPiArCSAqIERpc2FibGUgU1NBIFByZWNoYXJnZSB3aGVu IENEIGNsb2NrIGZyZXF1ZW5jeSA8IDUwMCBNSHosCj4gKwkgKiBlbmFibGUgb3RoZXJ3aXNlLgo+ ICsJICovCj4gKwlpZiAoZGV2X3ByaXYtPmNkY2xrX2ZyZXEgPj0gNTAwMDAwKQo+ICsJCWV4cGVj dGVkIHw9IEJYVF9DRENMS19TU0FfUFJFQ0hBUkdFX0VOQUJMRTsKPiArCj4gKwlpZiAoY2RjdGwg PT0gZXhwZWN0ZWQpCj4gKwkJLyogQWxsIHdlbGw7IG5vdGhpbmcgdG8gc2FuaXRpemUgKi8KPiAr CQlyZXR1cm47Cj4gKwo+ICtzYW5pdGl6ZToKPiArCURSTV9ERUJVR19LTVMoIlNhbml0aXppbmcg Y2RjbGsgcHJvZ3JhbW1lZCBieSBwcmUtb3NcbiIpOwo+ICsKPiArCS8qIGZvcmNlIGNkY2xrIHBy b2dyYW1taW5nICovCj4gKwlkZXZfcHJpdi0+Y2RjbGtfZnJlcSA9IDA7Cj4gKwo+ICsJLyogZm9y Y2UgZnVsbCBQTEwgZGlzYWJsZSArIGVuYWJsZSAqLwo+ICsJZGV2X3ByaXYtPmNkY2xrX3BsbC52 Y28gPSAtMTsKPiArfQo+ICsKPiAgdm9pZCBicm94dG9uX2luaXRfY2RjbGsoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICB7Cj4gLQlpbnRlbF91cGRhdGVfY2RjbGsoZGV2X3By aXYtPmRldik7Cj4gKwlieHRfc2FuaXRpemVfY2RjbGsoZGV2X3ByaXYpOwo+ICAKPiAtCWlmIChk ZXZfcHJpdi0+Y2RjbGtfcGxsLnZjbyAhPSAwKQo+ICsJaWYgKGRldl9wcml2LT5jZGNsa19mcmVx ICE9IDAgJiYgZGV2X3ByaXYtPmNkY2xrX3BsbC52Y28gIT0gMCkKPiAgCQlyZXR1cm47Cj4gIAo+ ICAJLyoKPiAtLSAKPiAyLjUuMAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==